150334 2015-10-19 11:25:31 -0700 Mac Debug EWS never finishes when there are failures 2015-10-20 10:20:08 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue dbates glenn lforschler oldest_to_newest 1134637 0 ap 2015-10-19 11:25:31 -0700 webkitpy always tries to load results from WebKitBuild/Release/layout-test-results/full_results.json - but the queue tests debug! 1134762 1 263534 ap 2015-10-19 17:24:19 -0700 Created attachment 263534 proposed fix 1134901 2 263534 dbates 2015-10-20 09:25:11 -0700 Comment on attachment 263534 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=263534&action=review Looks sane to me. > Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:48 > + _build_style = None How did you come to the decision to assign None to _build_style as opposed to choosing a specific build style? 1134903 3 263534 ap 2015-10-20 09:34:21 -0700 Comment on attachment 263534 proposed fix > How did you come to the decision to assign None to _build_style as opposed to choosing a specific build style? For EWS queues, it's the common case to not specify the build style in ews.json. 1134914 4 263534 commit-queue 2015-10-20 10:20:03 -0700 Comment on attachment 263534 proposed fix Clearing flags on attachment: 263534 Committed r191345: <http://trac.webkit.org/changeset/191345> 1134915 5 commit-queue 2015-10-20 10:20:08 -0700 All reviewed patches have been landed. Closing bug. 263534 2015-10-19 17:24:19 -0700 2015-10-20 10:20:03 -0700 proposed fix debugews.txt text/plain 3750 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5MTMyMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE1LTEwLTE5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIE1hYyBEZWJ1ZyBFV1MgbmV2ZXIgZmluaXNoZXMgd2hlbiB0aGVyZSBhcmUg ZmFpbHVyZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE1MDMzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbV91bml0 dGVzdC5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVz LnB5OgorCiAyMDE1LTEwLTE5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgog CiAgICAgICAgIEFkZCBuZXcgRVdTIHF1ZXVlcyB0byBib3Qgd2F0Y2hlcidzIGRhc2hib2FyZApJ bmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5 c3RlbV91bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rv b2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAxOTEz MTYpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5n c3lzdGVtX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC00NSw2ICs0NSw3IEBAIGNsYXNz IEFic3RyYWN0RWFybHlXYXJuaW5nU3lzdGVtVGVzdChRdWUKICAgICAgICAgIyBOZWVkZWQgdG8g ZGVmaW5lIHBvcnRfbmFtZSwgdXNlZCBpbiBBYnN0cmFjdEVhcmx5V2FybmluZ1N5c3RlbS5fX2lu aXRfXwogICAgICAgICBjbGFzcyBUZXN0RVdTKEFic3RyYWN0RWFybHlXYXJuaW5nU3lzdGVtKToK ICAgICAgICAgICAgIHBvcnRfbmFtZSA9ICJ3aW4iICAjIE5lZWRzIHRvIGJlIGEgcG9ydCB3aGlj aCBwb3J0L2ZhY3RvcnkgdW5kZXJzdGFuZHMuCisgICAgICAgICAgICBfYnVpbGRfc3R5bGUgPSBO b25lCiAKICAgICAgICAgZXdzID0gVGVzdEVXUygpCiAgICAgICAgIGV3cy5iaW5kX3RvX3Rvb2wo TW9ja1Rvb2woKSkKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9x dWV1ZXMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1h bmRzL3F1ZXVlcy5weQkocmV2aXNpb24gMTkxMzE2KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRw eS90b29sL2NvbW1hbmRzL3F1ZXVlcy5weQkod29ya2luZyBjb3B5KQpAQCAtMjUwLDYgKzI1MCw5 IEBAIGNsYXNzIEFic3RyYWN0UGF0Y2hRdWV1ZShBYnN0cmFjdFF1ZXVlKToKICAgICBkZWYgd29y a19pdGVtX2xvZ19wYXRoKHNlbGYsIHBhdGNoKToKICAgICAgICAgcmV0dXJuIG9zLnBhdGguam9p bihzZWxmLl9sb2dfZGlyZWN0b3J5KCksICIlcy5sb2ciICUgcGF0Y2guYnVnX2lkKCkpCiAKKyAg ICBkZWYgYnVpbGRfc3R5bGUoc2VsZik6CisgICAgICAgIHJldHVybiAicmVsZWFzZSIKKwogCiAj IFVzZWQgdG8gc2hhcmUgY29kZSBiZXR3ZWVuIHRoZSBFV1MgYW5kIGNvbW1pdC1xdWV1ZS4KIGNs YXNzIFBhdGNoUHJvY2Vzc2luZ1F1ZXVlKEFic3RyYWN0UGF0Y2hRdWV1ZSk6CkBAIC0yNjksNiAr MjcyLDE1IEBAIGNsYXNzIFBhdGNoUHJvY2Vzc2luZ1F1ZXVlKEFic3RyYWN0UGF0Y2gKICAgICAg ICAgICAgIHJldHVybiAnd2luLWZ1dHVyZScKICAgICAgICAgcmV0dXJuIHBvcnRfbmFtZQogCisg ICAgZGVmIF9jcmVhdGVfcG9ydChzZWxmKToKKyAgICAgICAgc2VsZi5fcG9ydCA9IHNlbGYuX3Rv b2wucG9ydF9mYWN0b3J5LmdldChzZWxmLl9uZXdfcG9ydF9uYW1lX2Zyb21fb2xkKHNlbGYucG9y dF9uYW1lLCBzZWxmLl90b29sLnBsYXRmb3JtKSkKKyAgICAgICAgaWYgc2VsZi5hcmNoaXRlY3R1 cmU6CisgICAgICAgICAgICBzZWxmLl9wb3J0LnNldF9hcmNoaXRlY3R1cmUoc2VsZi5hcmNoaXRl Y3R1cmUpCisgICAgICAgIGlmIHNlbGYuYnVpbGRfc3R5bGUoKSA9PSAiZGVidWciOgorICAgICAg ICAgICAgc2VsZi5fcG9ydC5zZXRfb3B0aW9uKCJjb25maWd1cmF0aW9uIiwgIkRlYnVnIikKKyAg ICAgICAgZWxzZToKKyAgICAgICAgICAgIHNlbGYuX3BvcnQuc2V0X29wdGlvbigiY29uZmlndXJh dGlvbiIsICJSZWxlYXNlIikKKwogICAgIGRlZiBiZWdpbl93b3JrX3F1ZXVlKHNlbGYpOgogICAg ICAgICBBYnN0cmFjdFBhdGNoUXVldWUuYmVnaW5fd29ya19xdWV1ZShzZWxmKQogICAgICAgICBp ZiBub3Qgc2VsZi5wb3J0X25hbWU6CkBAIC0yNzgsMTMgKzI5MCwxMSBAQCBjbGFzcyBQYXRjaFBy b2Nlc3NpbmdRdWV1ZShBYnN0cmFjdFBhdGNoCiAgICAgICAgICMgRklYTUU6IFRoaXMgdmlvbGF0 ZXMgYWJzdHJhY3Rpb24KICAgICAgICAgc2VsZi5fdG9vbC5fZGVwcmVjYXRlZF9wb3J0ID0gc2Vs Zi5fZGVwcmVjYXRlZF9wb3J0CiAKLSAgICAgICAgc2VsZi5fcG9ydCA9IHNlbGYuX3Rvb2wucG9y dF9mYWN0b3J5LmdldChzZWxmLl9uZXdfcG9ydF9uYW1lX2Zyb21fb2xkKHNlbGYucG9ydF9uYW1l LCBzZWxmLl90b29sLnBsYXRmb3JtKSkKLSAgICAgICAgaWYgc2VsZi5hcmNoaXRlY3R1cmU6Ci0g ICAgICAgICAgICBzZWxmLl9wb3J0LnNldF9hcmNoaXRlY3R1cmUoc2VsZi5hcmNoaXRlY3R1cmUp CisgICAgICAgIHNlbGYuX2NyZWF0ZV9wb3J0KCkKIAogICAgIGRlZiBfdXBsb2FkX3Jlc3VsdHNf YXJjaGl2ZV9mb3JfcGF0Y2goc2VsZiwgcGF0Y2gsIHJlc3VsdHNfYXJjaGl2ZV96aXApOgogICAg ICAgICBpZiBub3Qgc2VsZi5fcG9ydDoKLSAgICAgICAgICAgIHNlbGYuX3BvcnQgPSBzZWxmLl90 b29sLnBvcnRfZmFjdG9yeS5nZXQoc2VsZi5fbmV3X3BvcnRfbmFtZV9mcm9tX29sZChzZWxmLnBv cnRfbmFtZSwgc2VsZi5fdG9vbC5wbGF0Zm9ybSkpCisgICAgICAgICAgICBzZWxmLl9jcmVhdGVf cG9ydCgpCiAKICAgICAgICAgYm90X2lkID0gc2VsZi5fdG9vbC5zdGF0dXNfc2VydmVyLmJvdF9p ZCBvciAiYm90IgogICAgICAgICBkZXNjcmlwdGlvbiA9ICJBcmNoaXZlIG9mIGxheW91dC10ZXN0 LXJlc3VsdHMgZnJvbSAlcyBmb3IgJXMiICUgKGJvdF9pZCwgc2VsZi5fcG9ydC5uYW1lKCkpCkBA IC0zODIsOSArMzkyLDYgQEAgY2xhc3MgQ29tbWl0UXVldWUoUGF0Y2hQcm9jZXNzaW5nUXVldWUs IAogICAgIGRlZiBhcmNoaXZlX2xhc3RfdGVzdF9yZXN1bHRzKHNlbGYsIHBhdGNoKToKICAgICAg ICAgcmV0dXJuIHNlbGYuX2xheW91dF90ZXN0X3Jlc3VsdHNfcmVhZGVyLmFyY2hpdmUocGF0Y2gp CiAKLSAgICBkZWYgYnVpbGRfc3R5bGUoc2VsZik6Ci0gICAgICAgIHJldHVybiAicmVsZWFzZSIK LQogICAgIGRlZiByZWZldGNoX3BhdGNoKHNlbGYsIHBhdGNoKToKICAgICAgICAgcmV0dXJuIHNl bGYuX3Rvb2wuYnVncy5mZXRjaF9hdHRhY2htZW50KHBhdGNoLmlkKCkpCiAK