150330 2015-10-19 07:20:54 -0700 Fix the ENABLE(WEBASSEMBLY) build after r190827 2015-10-19 09:20:52 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P1 Blocker --- 149727 1 ossy ossy commit-queue fpizlo ggaren ossy oldest_to_newest 1134571 0 ossy 2015-10-19 07:20:54 -0700 https://trac.webkit.org/changeset/190827 broke the ENABLE(WEBASSEMBLY) build in many places. It's obvious that the changes in ENABLE(WEBASSEMBLY) blocks were speculative changes and nobody tried to build it anytime. Fix is coming. 1134572 1 ossy 2015-10-19 07:27:22 -0700 for example: ------------- CodeBlock::CodeBlock(VM* vm, Structure* structure, WebAssemblyExecutable* ownerExecutable, VM& vm, JSGlobalObject* globalObject) "VM* vm" vs "VM& vm" --- WebAssemblyCodeBlock* codeBlock = WebAssemblyCodeBlock::create(vm, this, exec->lexicalGlobalObject())); extra ")" at the end ... 1134573 2 263481 ossy 2015-10-19 07:34:28 -0700 Created attachment 263481 Patch 1134589 3 263481 ggaren 2015-10-19 09:11:03 -0700 Comment on attachment 263481 Patch r=me 1134593 4 263481 commit-queue 2015-10-19 09:20:48 -0700 Comment on attachment 263481 Patch Clearing flags on attachment: 263481 Committed r191291: <http://trac.webkit.org/changeset/191291> 1134594 5 commit-queue 2015-10-19 09:20:52 -0700 All reviewed patches have been landed. Closing bug. 263481 2015-10-19 07:34:28 -0700 2015-10-19 09:20:48 -0700 Patch bug-150330-20151019073346.patch text/plain 5786 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxMjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 Y2JlOWVkMDZkYTAwNmYxOGU1ODE2YjkyOWQ0NWUzNTQwYmYwN2JkLi4xODJhZDk5MDM5ZGI3YmQ4 ZjBmYzI1YmJiNGViOTdmZjExNjYxNTJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNS0xMC0xOSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIEZpeCB0aGUgRU5BQkxFKFdFQkFTU0VNQkxZKSBidWlsZCBhZnRlciBy MTkwODI3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NTAzMzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGJ5dGVjb2RlL0NvZGVCbG9jay5jcHA6CisgICAgICAgIChKU0M6OkNvZGVCbG9jazo6Q29kZUJs b2NrKTogUmVtb3ZlZCB0aGUgZHVwbGljYXRlZCBWTSBhcmd1bWVudC4KKyAgICAgICAgKiBieXRl Y29kZS9Db2RlQmxvY2suaDoKKyAgICAgICAgKEpTQzo6V2ViQXNzZW1ibHlDb2RlQmxvY2s6OmNy ZWF0ZSk6IEFkZGVkIG5ldyBwYXJhbWV0ZXJzIHRvIGZpbmlzaENyZWF0aW9uKCkgY2FsbHMuCisg ICAgICAgIChKU0M6OldlYkFzc2VtYmx5Q29kZUJsb2NrOjpXZWJBc3NlbWJseUNvZGVCbG9jayk6 IENoYW5nZSBWTSBwYXJhbWV0ZXIgdG8gcG9pbnRlciB0byBtYXRjaCAqQ29kZUJsb2NrIGNsYXNz ZXMuCisgICAgICAgICogcnVudGltZS9FeGVjdXRhYmxlLmNwcDoKKyAgICAgICAgKEpTQzo6V2Vi QXNzZW1ibHlFeGVjdXRhYmxlOjpwcmVwYXJlRm9yRXhlY3V0aW9uKTogUmVtb3ZlZCBleHRyYSAi KSIgYW5kIHBhc3MgcG9pbnRlciBhcyBpdCBpcyBleHBlY3RlZC4KKwogMjAxNS0xMC0xOCAgWXVz dWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBQcm9taXNlIGNv bnN0cnVjdG9yIHNob3VsZCB0aHJvdyB3aGVuIG5vdCBjYWxsZWQgd2l0aCAibmV3IgpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5jcHAgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcAppbmRleCBlMGYyNDAyODMx YTRhYTA3OTZkNGM2OWExMzM3Yzk2ZjZlOTM2OTU0Li4zMDg1NTM1ODE4OTE2ZjFkZWExMTRlOGM5 NjQwZWIwY2M3MDQxMDk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNv ZGUvQ29kZUJsb2NrLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29k ZUJsb2NrLmNwcApAQCAtMjIwMyw4ICsyMjAzLDggQEAgdm9pZCBDb2RlQmxvY2s6OmZpbmlzaENy ZWF0aW9uKFZNJiB2bSwgU2NyaXB0RXhlY3V0YWJsZSogb3duZXJFeGVjdXRhYmxlLCBVbmxpbmsK IH0KIAogI2lmIEVOQUJMRShXRUJBU1NFTUJMWSkKLUNvZGVCbG9jazo6Q29kZUJsb2NrKFZNKiB2 bSwgU3RydWN0dXJlKiBzdHJ1Y3R1cmUsIFdlYkFzc2VtYmx5RXhlY3V0YWJsZSogb3duZXJFeGVj dXRhYmxlLCBWTSYgdm0sIEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QpCi0gICAgOiBKU0Nl bGwodm0sIHN0cnVjdHVyZSkKK0NvZGVCbG9jazo6Q29kZUJsb2NrKFZNKiB2bSwgU3RydWN0dXJl KiBzdHJ1Y3R1cmUsIFdlYkFzc2VtYmx5RXhlY3V0YWJsZSogb3duZXJFeGVjdXRhYmxlLCBKU0ds b2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0KQorICAgIDogSlNDZWxsKCp2bSwgc3RydWN0dXJlKQog ICAgICwgbV9nbG9iYWxPYmplY3QoZ2xvYmFsT2JqZWN0LT52bSgpLCB0aGlzLCBnbG9iYWxPYmpl Y3QpCiAgICAgLCBtX2hlYXAoJm1fZ2xvYmFsT2JqZWN0LT52bSgpLmhlYXApCiAgICAgLCBtX251 bUNhbGxlZVJlZ2lzdGVycygwKQpAQCAtMjIxNyw3ICsyMjE3LDcgQEAgQ29kZUJsb2NrOjpDb2Rl QmxvY2soVk0qIHZtLCBTdHJ1Y3R1cmUqIHN0cnVjdHVyZSwgV2ViQXNzZW1ibHlFeGVjdXRhYmxl KiBvd25lckUKICAgICAsIG1fc3RlcHBpbmdNb2RlKFN0ZXBwaW5nTW9kZURpc2FibGVkKQogICAg ICwgbV9udW1CcmVha3BvaW50cygwKQogICAgICwgbV9vd25lckV4ZWN1dGFibGUobV9nbG9iYWxP YmplY3QtPnZtKCksIHRoaXMsIG93bmVyRXhlY3V0YWJsZSkKLSAgICAsIG1fdm0oJnZtKQorICAg ICwgbV92bSh2bSkKICAgICAsIG1faXNTdHJpY3RNb2RlKGZhbHNlKQogICAgICwgbV9uZWVkc0Fj dGl2YXRpb24oZmFsc2UpCiAgICAgLCBtX2NvZGVUeXBlKEZ1bmN0aW9uQ29kZSkKZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaCBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaAppbmRleCAyM2M3N2MxYzVhY2EzMGNj M2I4Nzk1OTRiNDUyY2I4MDVmYjJmYzM4Li40ODgwNzFkMjUzYjE3ZTNjOTBiYzY2ZDkyMGIxNmE5 NThlZDk4MDk1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29k ZUJsb2NrLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5o CkBAIC0xMTEsNyArMTExLDcgQEAgcHJvdGVjdGVkOgogICAgIENvZGVCbG9jayhWTSosIFN0cnVj dHVyZSosIENvcHlQYXJzZWRCbG9ja1RhZywgQ29kZUJsb2NrJiBvdGhlcik7CiAgICAgQ29kZUJs b2NrKFZNKiwgU3RydWN0dXJlKiwgU2NyaXB0RXhlY3V0YWJsZSogb3duZXJFeGVjdXRhYmxlLCBV bmxpbmtlZENvZGVCbG9jayosIEpTU2NvcGUqLCBQYXNzUmVmUHRyPFNvdXJjZVByb3ZpZGVyPiwg dW5zaWduZWQgc291cmNlT2Zmc2V0LCB1bnNpZ25lZCBmaXJzdExpbmVDb2x1bW5PZmZzZXQpOwog I2lmIEVOQUJMRShXRUJBU1NFTUJMWSkKLSAgICBDb2RlQmxvY2soVk0qLCBTdHJ1Y3R1cmUqLCBX ZWJBc3NlbWJseUV4ZWN1dGFibGUqIG93bmVyRXhlY3V0YWJsZSwgVk0mLCBKU0dsb2JhbE9iamVj dCopOworICAgIENvZGVCbG9jayhWTSosIFN0cnVjdHVyZSosIFdlYkFzc2VtYmx5RXhlY3V0YWJs ZSogb3duZXJFeGVjdXRhYmxlLCBKU0dsb2JhbE9iamVjdCopOwogI2VuZGlmCiAKICAgICB2b2lk IGZpbmlzaENyZWF0aW9uKFZNJiwgQ29weVBhcnNlZEJsb2NrVGFnLCBDb2RlQmxvY2smIG90aGVy KTsKQEAgLTEyODYsMTMgKzEyODYsMTQgQEAgcHJpdmF0ZToKICNpZiBFTkFCTEUoV0VCQVNTRU1C TFkpCiBjbGFzcyBXZWJBc3NlbWJseUNvZGVCbG9jayA6IHB1YmxpYyBDb2RlQmxvY2sgewogcHVi bGljOgorICAgIHR5cGVkZWYgQ29kZUJsb2NrIEJhc2U7CiAgICAgREVDTEFSRV9JTkZPOwogCiAg ICAgc3RhdGljIFdlYkFzc2VtYmx5Q29kZUJsb2NrKiBjcmVhdGUoVk0qIHZtLCBDb3B5UGFyc2Vk QmxvY2tUYWcsIFdlYkFzc2VtYmx5Q29kZUJsb2NrJiBvdGhlcikKICAgICB7CiAgICAgICAgIFdl YkFzc2VtYmx5Q29kZUJsb2NrKiBpbnN0YW5jZSA9IG5ldyAoTm90TnVsbCwgYWxsb2NhdGVDZWxs PFdlYkFzc2VtYmx5Q29kZUJsb2NrPih2bS0+aGVhcCkpCiAgICAgICAgICAgICBXZWJBc3NlbWJs eUNvZGVCbG9jayh2bSwgdm0tPndlYkFzc2VtYmx5Q29kZUJsb2NrU3RydWN0dXJlLmdldCgpLCBD b3B5UGFyc2VkQmxvY2ssIG90aGVyKTsKLSAgICAgICAgaW5zdGFuY2UtPmZpbmlzaENyZWF0aW9u KCp2bSk7CisgICAgICAgIGluc3RhbmNlLT5maW5pc2hDcmVhdGlvbigqdm0sIENvcHlQYXJzZWRC bG9jaywgb3RoZXIpOwogICAgICAgICByZXR1cm4gaW5zdGFuY2U7CiAgICAgfQogCkBAIC0xMzAw LDcgKzEzMDEsNyBAQCBwdWJsaWM6CiAgICAgewogICAgICAgICBXZWJBc3NlbWJseUNvZGVCbG9j ayogaW5zdGFuY2UgPSBuZXcgKE5vdE51bGwsIGFsbG9jYXRlQ2VsbDxXZWJBc3NlbWJseUNvZGVC bG9jaz4odm0tPmhlYXApKQogICAgICAgICAgICAgV2ViQXNzZW1ibHlDb2RlQmxvY2sodm0sIHZt LT53ZWJBc3NlbWJseUNvZGVCbG9ja1N0cnVjdHVyZS5nZXQoKSwgb3duZXJFeGVjdXRhYmxlLCBn bG9iYWxPYmplY3QpOwotICAgICAgICBpbnN0YW5jZS0+ZmluaXNoQ3JlYXRpb24oKnZtKTsKKyAg ICAgICAgaW5zdGFuY2UtPmZpbmlzaENyZWF0aW9uKCp2bSwgb3duZXJFeGVjdXRhYmxlLCBnbG9i YWxPYmplY3QpOwogICAgICAgICByZXR1cm4gaW5zdGFuY2U7CiAgICAgfQogCkBAIC0xMzEwLDEz ICsxMzExLDEzIEBAIHB1YmxpYzoKICAgICB9CiAKIHByaXZhdGU6Ci0gICAgV2ViQXNzZW1ibHlD b2RlQmxvY2soVk0mIHZtLCBTdHJ1Y3R1cmUqIHN0cnVjdHVyZSwgQ29weVBhcnNlZEJsb2NrVGFn LCBXZWJBc3NlbWJseUNvZGVCbG9jayYgb3RoZXIpCisgICAgV2ViQXNzZW1ibHlDb2RlQmxvY2so Vk0qIHZtLCBTdHJ1Y3R1cmUqIHN0cnVjdHVyZSwgQ29weVBhcnNlZEJsb2NrVGFnLCBXZWJBc3Nl bWJseUNvZGVCbG9jayYgb3RoZXIpCiAgICAgICAgIDogQ29kZUJsb2NrKHZtLCBzdHJ1Y3R1cmUs IENvcHlQYXJzZWRCbG9jaywgb3RoZXIpCiAgICAgewogICAgIH0KIAotICAgIFdlYkFzc2VtYmx5 Q29kZUJsb2NrKFZNJiB2bSwgU3RydWN0dXJlKiBzdHJ1Y3R1cmUsIFdlYkFzc2VtYmx5RXhlY3V0 YWJsZSogb3duZXJFeGVjdXRhYmxlLCBKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0KQotICAg ICAgICA6IENvZGVCbG9jayh2bSwgc3RydWN0dXJlLCBvd25lckV4ZWN1dGFibGUsIHZtLCBnbG9i YWxPYmplY3QpCisgICAgV2ViQXNzZW1ibHlDb2RlQmxvY2soVk0qIHZtLCBTdHJ1Y3R1cmUqIHN0 cnVjdHVyZSwgV2ViQXNzZW1ibHlFeGVjdXRhYmxlKiBvd25lckV4ZWN1dGFibGUsIEpTR2xvYmFs T2JqZWN0KiBnbG9iYWxPYmplY3QpCisgICAgICAgIDogQ29kZUJsb2NrKHZtLCBzdHJ1Y3R1cmUs IG93bmVyRXhlY3V0YWJsZSwgZ2xvYmFsT2JqZWN0KQogICAgIHsKICAgICB9CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4ZWN1dGFibGUuY3BwIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXhlY3V0YWJsZS5jcHAKaW5kZXggMDMwYmNjNTE1ODc4 MmJmZmM5ODc2ZTViMDU4NGMwYzhiODY1MTkxYS4uYWFmODVjNDMwMjY5MDBlMDg1ZWVjYzZlNjNh Nzc1MjJmMjNiYzk5ZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv RXhlY3V0YWJsZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXhlY3V0 YWJsZS5jcHAKQEAgLTczOCw4ICs3MzgsOCBAQCB2b2lkIFdlYkFzc2VtYmx5RXhlY3V0YWJsZTo6 cHJlcGFyZUZvckV4ZWN1dGlvbihFeGVjU3RhdGUqIGV4ZWMpCiAgICAgVk0mIHZtID0gZXhlYy0+ dm0oKTsKICAgICBEZWZlckdDIGRlZmVyR0Modm0uaGVhcCk7CiAKLSAgICBXZWJBc3NlbWJseUNv ZGVCbG9jayogY29kZUJsb2NrID0gV2ViQXNzZW1ibHlDb2RlQmxvY2s6OmNyZWF0ZSh2bSwKLSAg ICAgICAgdGhpcywgZXhlYy0+bGV4aWNhbEdsb2JhbE9iamVjdCgpKSk7CisgICAgV2ViQXNzZW1i bHlDb2RlQmxvY2sqIGNvZGVCbG9jayA9IFdlYkFzc2VtYmx5Q29kZUJsb2NrOjpjcmVhdGUoJnZt LAorICAgICAgICB0aGlzLCBleGVjLT5sZXhpY2FsR2xvYmFsT2JqZWN0KCkpOwogCiAgICAgV0FT TUZ1bmN0aW9uUGFyc2VyOjpjb21waWxlKHZtLCBjb2RlQmxvY2ssIG1fbW9kdWxlLmdldCgpLCBt X3NvdXJjZSwgbV9mdW5jdGlvbkluZGV4KTsKIAo=