150327 2015-10-19 05:11:31 -0700 ASSERTION FAILED: m_state == Initialized in SubresourceLoader::didReceiveResponse() 2015-10-19 23:19:19 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 1 cgarcia webkit-unassigned commit-queue darin japhet koivisto oldest_to_newest 1134554 0 cgarcia 2015-10-19 05:11:31 -0700 This happens with printing/print-close-crash.html in the GTK+ port. This is how it happens: 1. print() is called while the document is still loading, so m_shouldPrintWhenFinishedLoading is set to true 2. DataURLDecoder::decode() finishes in the work queue thread, the completion handler is scheduled in the main thread 3. The load is cancelled 3.1 SubresourceLoader::willCancel sets m_state = Finishing 3.2 DOMWindow::finishedLoading() is called, and since m_shouldPrintWhenFinishedLoading is true, it does the print. 3.3 Cancellation finishes and ResourceLoader::releaseResources() si called that sets m_reachedTerminalState = true So, between 3.1 and 3.3, the state is finishing, but m_reachedTerminalState is false. What happens, in the GTK+ port at least, is that the nested main loop used to make print() synchronous, processes the DataURLDecoder::decode() completion handler that was pending. The completion handler returns early if m_reachedTerminalState is true, but it's not yet in this particular case. So, it ends up calling didReceiveResponse (because the decode didn't fail) when the subresource loader state is Finishing. I think there are two things here. One is that we shouldn't start a print that was waiting for the load to finish when it failed. That would fix the problem. But it's probably a good idea to also check for cancellation in the DataURLDecoder::decode() completion handler. 1134555 1 263472 cgarcia 2015-10-19 05:16:45 -0700 Created attachment 263472 Patch 1134814 2 cgarcia 2015-10-19 23:19:19 -0700 Committed r191332: <http://trac.webkit.org/changeset/191332> 263472 2015-10-19 05:16:45 -0700 2015-10-19 05:27:13 -0700 Patch wk2-print-assert.diff text/plain 3632 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhYjFhYzM2Li5mNWQ0OTY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsNDgg QEAKKzIwMTUtMTAtMTkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIEFTU0VSVElPTiBGQUlMRUQ6IG1fc3RhdGUgPT0gSW5pdGlhbGl6ZWQgaW4g dWJyZXNvdXJjZUxvYWRlcjo6ZGlkUmVjZWl2ZVJlc3BvbnNlKCkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDMyNworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgaG93IGl0IGhhcHBlbnM6CisK KyAgICAgICAgMS4gcHJpbnQoKSBpcyBjYWxsZWQgd2hpbGUgdGhlIGRvY3VtZW50IGlzIHN0aWxs IGxvYWRpbmcsIHNvCisgICAgICAgICAgIG1fc2hvdWxkUHJpbnRXaGVuRmluaXNoZWRMb2FkaW5n IGlzIHNldCB0byB0cnVlCisgICAgICAgIDIuIERhdGFVUkxEZWNvZGVyOjpkZWNvZGUoKSBmaW5p c2hlcyBpbiB0aGUgd29yayBxdWV1ZSB0aHJlYWQsCisgICAgICAgICAgIHRoZSBjb21wbGV0aW9u IGhhbmRsZXIgaXMgc2NoZWR1bGVkIGluIHRoZSBtYWluIHRocmVhZAorICAgICAgICAzLiBUaGUg bG9hZCBpcyBjYW5jZWxsZWQKKyAgICAgICAgICAzLjEuIFN1YnJlc291cmNlTG9hZGVyOjp3aWxs Q2FuY2VsIHNldHMgbV9zdGF0ZSA9IEZpbmlzaGluZworICAgICAgICAgIDMuMi4gRE9NV2luZG93 OjpmaW5pc2hlZExvYWRpbmcoKSBpcyBjYWxsZWQsIGFuZCBzaW5jZQorICAgICAgICAgICAgICAg bV9zaG91bGRQcmludFdoZW5GaW5pc2hlZExvYWRpbmcgaXMgdHJ1ZSwgaXQgZG9lcyB0aGUgcHJp bnQuCisgICAgICAgICAgMy4zLiBDYW5jZWxsYXRpb24gZmluaXNoZXMgYW5kIFJlc291cmNlTG9h ZGVyOjpyZWxlYXNlUmVzb3VyY2VzKCkKKyAgICAgICAgICAgICAgIGlzIGNhbGxlZCB0aGF0IHNl dHMgbV9yZWFjaGVkVGVybWluYWxTdGF0ZSA9IHRydWUKKworICAgICAgICBTbywgYmV0d2VlbiAz LjEgYW5kIDMuMywgdGhlIHN0YXRlIGlzIEZpbmlzaGluZywgYnV0CisgICAgICAgIG1fcmVhY2hl ZFRlcm1pbmFsU3RhdGUgaXMgZmFsc2UuIFdoYXQgaGFwcGVucywgaW4gdGhlIEdUSysgcG9ydCBh dAorICAgICAgICBsZWFzdCwgaXMgdGhhdCB0aGUgbmVzdGVkIG1haW4gbG9vcCB1c2VkIHRvIG1h a2UgcHJpbnQoKQorICAgICAgICBzeW5jaHJvbm91cywgcHJvY2Vzc2VzIHRoZSBEYXRhVVJMRGVj b2Rlcjo6ZGVjb2RlKCkgY29tcGxldGlvbgorICAgICAgICBoYW5kbGVyIHRoYXQgd2FzIHBlbmRp bmcuIFRoZSBjb21wbGV0aW9uIGhhbmRsZXIgcmV0dXJucyBlYXJseSBpZgorICAgICAgICBtX3Jl YWNoZWRUZXJtaW5hbFN0YXRlIGlzIHRydWUsIGJ1dCBpdCdzIG5vdCB5ZXQgaW4gdGhpcworICAg ICAgICBwYXJ0aWN1bGFyIGNhc2UuIFNvLCBpdCBlbmRzIHVwIGNhbGxpbmcgZGlkUmVjZWl2ZVJl c3BvbnNlLAorICAgICAgICBiZWNhdXNlIHRoZSBkZWNvZGUgZGlkbid0IGZhaWwsIHdoZW4gdGhl IHN1YnJlc291cmNlIGxvYWRlciBzdGF0ZQorICAgICAgICBpcyBGaW5pc2hpbmcuCisKKyAgICAg ICAgSSB0aGluayB0aGVyZSBhcmUgdHdvIHRoaW5ncyBoZXJlLiBPbmUgaXMgdGhhdCB3ZSBzaG91 bGRuJ3Qgc3RhcnQKKyAgICAgICAgYSBwcmludCB0aGF0IHdhcyB3YWl0aW5nIGZvciB0aGUgbG9h ZCB0byBmaW5pc2ggd2hlbiBpdAorICAgICAgICBmYWlsZWQuIFRoYXQgd291bGQgZml4IHRoZSBw cm9ibGVtLiBCdXQgaXQncyBwcm9iYWJseSBhIGdvb2QgaWRlYQorICAgICAgICB0byBhbHNvIGNo ZWNrIGZvciBjYW5jZWxsYXRpb24gaW4gdGhlIERhdGFVUkxEZWNvZGVyOjpkZWNvZGUoKQorICAg ICAgICBjb21wbGV0aW9uIGhhbmRsZXIuCisKKyAgICAgICAgRml4ZXMgcHJpbnRpbmcvcHJpbnQt Y2xvc2UtY3Jhc2guaHRtbCBpbiBHVEsrIERlYnVnLgorCisgICAgICAgICogbG9hZGVyL1Jlc291 cmNlTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlTG9hZGVyOjpsb2FkRGF0 YVVSTCk6IFJldHVybiBlYXJseSBmcm9tCisgICAgICAgIERhdGFVUkxEZWNvZGVyOjpkZWNvZGUo KSBjb21wbGV0aW9uIGhhbmRsZXIgaWYgdGhlIGxvYWQgd2FzIGNhbmNlbGxlZC4KKyAgICAgICAg KiBwYWdlL0RPTVdpbmRvdy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpET01XaW5kb3c6OmZpbmlz aGVkTG9hZGluZyk6IERvIG5vdCBzdGFydCBhIHByaW50IHRoYXQKKyAgICAgICAgd2FzIHdpdGlu ZyBmb3IgdGhlIGxvYWQgdG8gZmluaXNoIHdoZW4gaXQgZmFpbGVkLgorCiAyMDE1LTEwLTE5ICBY YWJpZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CiAKICAgICAgICAg W1N0cmVhbXMgQVBJXSBBZGQgc2tlbGV0b24gZm9yIGluaXRpYWwgV3JpdGFibGVTdHJlYW0gc3Vw cG9ydApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZGVyLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRlci5jcHAKaW5kZXggYTJmZmI0 NC4uNjU1MWZmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9h ZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwCkBA IC0yNTYsNiArMjU2LDggQEAgdm9pZCBSZXNvdXJjZUxvYWRlcjo6bG9hZERhdGFVUkwoKQogICAg ICAgICAgICAgbG9hZGVyLT5kaWRGYWlsKFJlc291cmNlRXJyb3IoZXJyb3JEb21haW5XZWJLaXRJ bnRlcm5hbCwgMCwgdXJsLnN0cmluZygpLCAiRGF0YSBVUkwgZGVjb2RpbmcgZmFpbGVkIikpOwog ICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CisgICAgICAgIGlmIChsb2FkZXItPndhc0Nh bmNlbGxlZCgpKQorICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICBhdXRvJiByZXN1bHQgPSBk ZWNvZGVSZXN1bHQudmFsdWUoKTsKICAgICAgICAgYXV0byBkYXRhU2l6ZSA9IHJlc3VsdC5kYXRh LT5zaXplKCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAppbmRleCA0MzQyZjEzLi4xMGYy N2NhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCkBAIC0xOTg3LDcgKzE5ODcsOCBAQCB2 b2lkIERPTVdpbmRvdzo6ZmluaXNoZWRMb2FkaW5nKCkKIHsKICAgICBpZiAobV9zaG91bGRQcmlu dFdoZW5GaW5pc2hlZExvYWRpbmcpIHsKICAgICAgICAgbV9zaG91bGRQcmludFdoZW5GaW5pc2hl ZExvYWRpbmcgPSBmYWxzZTsKLSAgICAgICAgcHJpbnQoKTsKKyAgICAgICAgaWYgKG1fZnJhbWUt PmxvYWRlcigpLmFjdGl2ZURvY3VtZW50TG9hZGVyKCktPm1haW5Eb2N1bWVudEVycm9yKCkuaXNO dWxsKCkpCisgICAgICAgICAgICBwcmludCgpOwogICAgIH0KIH0KIAo=