150322 2015-10-19 03:50:12 -0700 Fix the !ENABLE(CSS_GRID_LAYOUT) build after r190840 2015-10-19 09:10:59 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 149698 1 ossy ossy commit-queue esprehn+autocc gyuyoung.kim kling koivisto ossy oldest_to_newest 1134539 0 ossy 2015-10-19 03:50:12 -0700 https://trac.webkit.org/changeset/190840 broke the !ENABLE(CSS_GRID_LAYOUT) build: ../../Source/WebCore/html/HTMLDetailsElement.cpp: In function 'const WTF::AtomicString& WebCore::summarySlotName()': ../../Source/WebCore/html/HTMLDetailsElement.cpp:43:52: error: variable 'WTF::NeverDestroyed<WTF::AtomicString> summarySlot' has initializer but incomplete type ../../Source/WebCore/html/HTMLDetailsElement.cpp:45:1: error: control reaches end of non-void function [-Werror=return-type] cc1plus: all warnings being treated as errors If ENABLE(CSS_GRID_LAYOUT) is true, NeverDestroyed.h is included by one of the header files, that's why we didn't notice this error previously. We shouldn't depend on this include, let's include NeverDestroyed.h explicitly, because this cpp needs it. 1134540 1 263466 ossy 2015-10-19 03:52:26 -0700 Created attachment 263466 Patch 1134587 2 263466 commit-queue 2015-10-19 09:10:55 -0700 Comment on attachment 263466 Patch Clearing flags on attachment: 263466 Committed r191289: <http://trac.webkit.org/changeset/191289> 1134588 3 commit-queue 2015-10-19 09:10:59 -0700 All reviewed patches have been landed. Closing bug. 263466 2015-10-19 03:52:26 -0700 2015-10-19 09:10:55 -0700 Patch bug-150322-20151019035144.patch text/plain 1094 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxMjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjNjMWFhYzhiM2FiMTE1 NDM3NTFlZWY2NWUyOWQ0NGUzMzI3Nzc4ZS4uN2M0NDFiODBiNGQwMzgwMjE4ZjQ0ZDdkNGY4Zjhj NDQ4NmUyOTg3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1LTEwLTE5ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSAhRU5B QkxFKENTU19HUklEX0xBWU9VVCkgYnVpbGQgYWZ0ZXIgcjE5MDg0MAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwMzIyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodG1sL0hUTUxEZXRhaWxzRWxlbWVu dC5jcHA6CisKIDIwMTUtMTAtMTggIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAog ICAgICAgICBTY3JpcHQgZWxlbWVudCB3aXRoIGFuIGVtcHR5IGZvciBvciBldmVudCBhdHRyaWJ1 dGVzIHNob3VsZCBub3QgZXhlY3V0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MRGV0YWlsc0VsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRGV0YWlsc0Vs ZW1lbnQuY3BwCmluZGV4IDAxYmVmNmQxYWQ3ZjhkMjlhZDc0ZWJmZjEzZmY4YWMyZDFiZjhlNWUu LmU4NDk5YThlMDI0NTRjZDdlZjZhMzMxZDI2YzU5ZTZmOTY5Nzc1ZWIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTERldGFpbHNFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxEZXRhaWxzRWxlbWVudC5jcHAKQEAgLTMyLDYgKzMyLDcgQEAKICNpbmNs dWRlICJTaGFkb3dSb290LmgiCiAjaW5jbHVkZSAiU2xvdEFzc2lnbm1lbnQuaCIKICNpbmNsdWRl ICJUZXh0LmgiCisjaW5jbHVkZSA8d3RmL05ldmVyRGVzdHJveWVkLmg+CiAKIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAo=