150320 2015-10-19 02:41:45 -0700 Fix the binding generator after r191176 2015-10-19 14:22:28 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 149952 1 ossy ossy commit-queue darin youennf oldest_to_newest 1134517 0 ossy 2015-10-19 02:41:45 -0700 https://trac.webkit.org/changeset/191176 broke the !ENABLE(FOO) builds because of a mistake in the binding generator. DerivedSources/WebCore/JSCompositionEvent.cpp: In static member function 'static JSC::ConstructType WebCore::JSDOMConstructor<JSClass>::getConstructData(JSC::JSCell*, JSC::ConstructData&) [with JSClass = WebCore::JSCompositionEvent]': DerivedSources/WebCore/JSCompositionEvent.cpp:131:35: error: 'cell' was not declared in this scope DerivedSources/WebCore/JSCompositionEvent.cpp:133:1: error: control reaches end of non-void function [-Werror=return-type] WebKitBuild/Release/DerivedSources/WebCore/JSCompositionEvent.cpp ------------------------------------------------------------------ ... template<> ConstructType JSCompositionEventConstructor::getConstructData(JSCell*, ConstructData& constructData) { #if ENABLE(DOM4_EVENTS_CONSTRUCTOR) constructData.native.function = construct; return ConstructTypeHost; #else return Base::getConstructData(cell, constructData); #endif } ... 1134518 1 263460 ossy 2015-10-19 02:44:46 -0700 Created attachment 263460 Patch 1134526 2 youennf 2015-10-19 02:59:02 -0700 LGTM. Thanks for fixing it again. 1134694 3 263460 commit-queue 2015-10-19 14:22:24 -0700 Comment on attachment 263460 Patch Clearing flags on attachment: 263460 Committed r191316: <http://trac.webkit.org/changeset/191316> 1134695 4 commit-queue 2015-10-19 14:22:28 -0700 All reviewed patches have been landed. Closing bug. 263460 2015-10-19 02:44:46 -0700 2015-10-19 14:22:24 -0700 Patch bug-150320-20151019024404.patch text/plain 2872 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxMjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjNjMWFhYzhiM2FiMTE1 NDM3NTFlZWY2NWUyOWQ0NGUzMzI3Nzc4ZS4uNTA5YTNlN2QyN2ZkZDI1MmNmY2VjYzc4MzE0ZTQ3 YjU2MDMyOTk2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTEwLTE5ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSBiaW5k aW5nIGdlbmVyYXRvciBhZnRlciByMTkxMTc2CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTAzMjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBt OgorICAgICAgICAoR2VuZXJhdGVDb25zdHJ1Y3RvckhlbHBlck1ldGhvZHMpOgorICAgICAgICAq IGJpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RJbnRlcmZhY2UuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SlNUZXN0SW50ZXJmYWNlQ29uc3RydWN0b3I6OmdldENvbnN0cnVjdERhdGEpOgor CiAyMDE1LTEwLTE4ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAg U2NyaXB0IGVsZW1lbnQgd2l0aCBhbiBlbXB0eSBmb3Igb3IgZXZlbnQgYXR0cmlidXRlcyBzaG91 bGQgbm90IGV4ZWN1dGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvQ29kZUdlbmVyYXRvckpTLnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9D b2RlR2VuZXJhdG9ySlMucG0KaW5kZXggMzA1YzRmYTU5Yzk5OWE1MmI0ZTQ2M2JmZGNhZmU5MWE3 YWQ2ZTJkZi4uMWM4OWNkYWJjZjQyYTMxNzNiOTQ3ZmRmNjMxNmRiMGVkYzU1OGVkNyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0K KysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0K QEAgLTQ5MjYsOSArNDkyNiwxMCBAQCBzdWIgR2VuZXJhdGVDb25zdHJ1Y3RvckhlbHBlck1ldGhv ZHMKIAogICAgIG15ICRjb25kaXRpb25hbFN0cmluZyA9ICRjb2RlR2VuZXJhdG9yLT5HZW5lcmF0 ZUNvbnN0cnVjdG9yQ29uZGl0aW9uYWxTdHJpbmcoJGludGVyZmFjZSk7CiAgICAgaWYgKCRjb25k aXRpb25hbFN0cmluZykgewotICAgICAgICBwdXNoKEAkb3V0cHV0QXJyYXksICJ0ZW1wbGF0ZTw+ IENvbnN0cnVjdFR5cGUgJHtjb25zdHJ1Y3RvckNsYXNzTmFtZX06OmdldENvbnN0cnVjdERhdGEo SlNDZWxsKiwgQ29uc3RydWN0RGF0YSYgY29uc3RydWN0RGF0YSlcbiIpOworICAgICAgICBwdXNo KEAkb3V0cHV0QXJyYXksICJ0ZW1wbGF0ZTw+IENvbnN0cnVjdFR5cGUgJHtjb25zdHJ1Y3RvckNs YXNzTmFtZX06OmdldENvbnN0cnVjdERhdGEoSlNDZWxsKiBjZWxsLCBDb25zdHJ1Y3REYXRhJiBj b25zdHJ1Y3REYXRhKVxuIik7CiAgICAgICAgIHB1c2goQCRvdXRwdXRBcnJheSwgIntcbiIpOwog ICAgICAgICBwdXNoKEAkb3V0cHV0QXJyYXksICIjaWYgJGNvbmRpdGlvbmFsU3RyaW5nXG4iKTsK KyAgICAgICAgcHVzaChAJG91dHB1dEFycmF5LCAiICAgIFVOVVNFRF9QQVJBTShjZWxsKTtcbiIp OwogICAgICAgICBwdXNoKEAkb3V0cHV0QXJyYXksICIgICAgY29uc3RydWN0RGF0YS5uYXRpdmUu ZnVuY3Rpb24gPSBjb25zdHJ1Y3Q7XG4iKTsKICAgICAgICAgcHVzaChAJG91dHB1dEFycmF5LCAi ICAgIHJldHVybiBDb25zdHJ1Y3RUeXBlSG9zdDtcbiIpOwogICAgICAgICBwdXNoKEAkb3V0cHV0 QXJyYXksICIjZWxzZVxuIik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL3Rlc3QvSlMvSlNUZXN0SW50ZXJmYWNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RJbnRlcmZhY2UuY3BwCmluZGV4IDFlODc5MmNkMDEw MTdhOTZkM2ZjMzAxYjNlNzdiMWJhMTRjMjVlZWMuLjFkZjhjYzc1MTcwOTFjMWVkZGE2NDhlODUy YmY0YTY1ZDE4NmUyMTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvdGVzdC9KUy9KU1Rlc3RJbnRlcmZhY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RJbnRlcmZhY2UuY3BwCkBAIC0yNzIsOSArMjcyLDEw IEBAIHRlbXBsYXRlPD4gdm9pZCBKU1Rlc3RJbnRlcmZhY2VDb25zdHJ1Y3Rvcjo6aW5pdGlhbGl6 ZVByb3BlcnRpZXMoVk0mIHZtLCBKU0RPTUdsCiAgICAgcmVpZnlTdGF0aWNQcm9wZXJ0aWVzKHZt LCBKU1Rlc3RJbnRlcmZhY2VDb25zdHJ1Y3RvclRhYmxlVmFsdWVzLCAqdGhpcyk7CiB9CiAKLXRl bXBsYXRlPD4gQ29uc3RydWN0VHlwZSBKU1Rlc3RJbnRlcmZhY2VDb25zdHJ1Y3Rvcjo6Z2V0Q29u c3RydWN0RGF0YShKU0NlbGwqLCBDb25zdHJ1Y3REYXRhJiBjb25zdHJ1Y3REYXRhKQordGVtcGxh dGU8PiBDb25zdHJ1Y3RUeXBlIEpTVGVzdEludGVyZmFjZUNvbnN0cnVjdG9yOjpnZXRDb25zdHJ1 Y3REYXRhKEpTQ2VsbCogY2VsbCwgQ29uc3RydWN0RGF0YSYgY29uc3RydWN0RGF0YSkKIHsKICNp ZiBFTkFCTEUoVEVTVF9JTlRFUkZBQ0UpCisgICAgVU5VU0VEX1BBUkFNKGNlbGwpOwogICAgIGNv bnN0cnVjdERhdGEubmF0aXZlLmZ1bmN0aW9uID0gY29uc3RydWN0OwogICAgIHJldHVybiBDb25z dHJ1Y3RUeXBlSG9zdDsKICNlbHNlCg==