150311 2015-10-18 21:55:40 -0700 [EFL] ContextMenu doesn't work correctly on MiniBrowser after r191194. 2015-10-20 18:53:55 -0700 1 1 1 Unclassified WebKit WebKit EFL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 150310 0 hs85.jeong hs85.jeong commit-queue gyuyoung.kim lucas.de.marchi ossy oldest_to_newest 1134449 0 hs85.jeong 2015-10-18 21:55:40 -0700 ContextMenu doesn't work correctly on MiniBrowser and test_ewk2_text_checker API test(https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/25018/steps/API%20tests/logs/stdio) failed after r191194. 1134451 1 hs85.jeong 2015-10-18 22:00:25 -0700 I make the patch to fix the contextMenu(https://bugs.webkit.org/show_bug.cgi?id=150310). 1134551 2 hs85.jeong 2015-10-19 04:14:09 -0700 This bug was fixed at http://trac.webkit.org/changeset/191282. 1134771 3 gyuyoung.kim 2015-10-19 18:04:23 -0700 (In reply to comment #2) > This bug was fixed at http://trac.webkit.org/changeset/191282. I understood that r191282 didn't fix context menu perfectly. That's why I allowed to land it without API test. And this bug is to support API test for showContextMenu(). However you closed this bug as soon as r191282 is closed. If r191282 can fix context menu, we needed to pass or support API test as well. Hmm you didn't understand what I wanted. 1134798 4 263548 hs85.jeong 2015-10-19 21:13:50 -0700 Created attachment 263548 Patch 1134799 5 hs85.jeong 2015-10-19 21:17:09 -0700 I think showContextMenu() test is covered by test_ewk2_context_menu. How about your opinion? test_ewk2_context_menu was suppressed after r168925. 1135094 6 263548 commit-queue 2015-10-20 18:53:51 -0700 Comment on attachment 263548 Patch Clearing flags on attachment: 263548 Committed r191368: <http://trac.webkit.org/changeset/191368> 1135095 7 commit-queue 2015-10-20 18:53:55 -0700 All reviewed patches have been landed. Closing bug. 263548 2015-10-19 21:13:50 -0700 2015-10-20 18:53:51 -0700 Patch bug-150311-20151020131307.patch text/plain 1414 hs85.jeong SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MTMyNikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTEwLTE5ICBIdW5zZW9w IEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBDb250ZXh0 TWVudSBkb2Vzbid0IHdvcmsgY29ycmVjdGx5IG9uIE1pbmlCcm93c2VyIGFmdGVyIHIxOTExOTQu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTAzMTEK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXN0b3Jl IHRoZSB0ZXN0X2V3azJfY29udGV4dF9tZW51IEFQSSB0ZXN0IHRvIGNoZWNrIHRoZSBjb250ZXh0 IG1lbnUgd2hldGhlciBpdCB3b3JrcyBjb3JyZWN0bHkuCisKKyAgICAgICAgKiBQbGF0Zm9ybUVm bC5jbWFrZToKKwogMjAxNS0xMC0xOSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxl LmNvbT4KIAogICAgICAgICBSZW1vdmUgdW51c2VkIHN1cHBvcnQgZm9yIGxvbmcgcHJlc3NlcyBm cm9tIFdlYktpdApJbmRleDogU291cmNlL1dlYktpdDIvUGxhdGZvcm1FZmwuY21ha2UKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdDIvUGxhdGZvcm1FZmwuY21ha2UJKHJldmlzaW9uIDE5MTMy NCkKKysrIFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtRWZsLmNtYWtlCSh3b3JraW5nIGNvcHkpCkBA IC01MzEsNiArNTMxLDcgQEAgc2V0KEVXSzJVbml0VGVzdHNfQklOQVJJRVMKICAgICB0ZXN0X2V3 azJfY29sb3JfcGlja2VyCiAgICAgdGVzdF9ld2syX2NvbnRleHQKICAgICB0ZXN0X2V3azJfY29u dGV4dF9oaXN0b3J5X2NhbGxiYWNrcworICAgIHRlc3RfZXdrMl9jb250ZXh0X21lbnUKICAgICB0 ZXN0X2V3azJfY29va2llX21hbmFnZXIKICAgICB0ZXN0X2V3azJfZGF0YWJhc2VfbWFuYWdlcgog ICAgIHRlc3RfZXdrMl9kb3dubG9hZF9qb2IKQEAgLTU1Myw3ICs1NTQsNiBAQCBzZXQoRVdLMlVu aXRUZXN0c19CSU5BUklFUwogIyBTa2lwcGVkIHVuaXQgdGVzdHMgbGlzdDoKICMKICMgd2Via2l0 Lm9yZy9iLzEwNzQyMjogdGVzdF9ld2syX2F1dGhfcmVxdWVzdAotIyB3ZWJraXQub3JnL2IvMTMy OTgwOiB0ZXN0X2V3azJfY29udGV4dF9tZW51CiAKIGlmIChFTkFCTEVfQVBJX1RFU1RTKQogICAg IGZvcmVhY2ggKHRlc3ROYW1lICR7RVdLMlVuaXRUZXN0c19CSU5BUklFU30pCg==