150307 2015-10-18 18:11:52 -0700 [Win] Can't run MiniBrowser on Visual Studio after webkit.org/b/150124 2015-10-18 19:27:01 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sungmann.cho sungmann.cho bfulgham commit-queue oldest_to_newest 1134428 0 sungmann.cho 2015-10-18 18:11:52 -0700 The DLL build rules have been changed to generate "{Name}Lib.DLL", but these changes have not yet been applied to the Visual Studio builds. 1134429 1 263433 sungmann.cho 2015-10-18 18:23:07 -0700 Created attachment 263433 Patch 1134433 2 bfulgham 2015-10-18 18:41:11 -0700 You might need to take similar action for JSC.exe and DumpRebderTree.exe. Or, switch to CMake, which should work without further action. It generates a Visual Studio Solution. 1134435 3 sungmann.cho 2015-10-18 19:12:12 -0700 Wow! When I switched to CMake, all my issues have been resolved. Thank you for letting me know! 1134436 4 263433 commit-queue 2015-10-18 19:26:58 -0700 Comment on attachment 263433 Patch Clearing flags on attachment: 263433 Committed r191277: <http://trac.webkit.org/changeset/191277> 1134437 5 commit-queue 2015-10-18 19:27:01 -0700 All reviewed patches have been landed. Closing bug. 263433 2015-10-18 18:23:07 -0700 2015-10-18 19:26:58 -0700 Patch bug-150307-20151019102226.patch text/plain 3153 sungmann.cho U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxMjcxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWFkMmRjM2E5MjcwZDhkN2I1ZjE4YzVlYzcyMWI3Yzg3 MDJmYmQ2NS4uNGQwOWFhY2M5NDNjZWFkMGZlZDQ4ZjM2YjQ3MGNhMzMxZmZjMjhlNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE1LTEwLTE4ICBTdW5nbWFubiBDaG8gIDxzdW5nbWFubi5jaG9AbmF2ZXJjb3JwLmNv bT4KKworICAgICAgICBbV2luXSBDaGFuZ2UgdGhlIERMTCBuYW1lIGluIE1pbmlCcm93c2VyTGli LnZjeHByb2ogdG8gbWF0Y2ggd2Via2l0Lm9yZy9iLzE1MDEyNC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDMwNworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBETEwgYnVpbGQgcnVsZXMgaGF2ZSBi ZWVuIGNoYW5nZWQgdG8gZ2VuZXJhdGUgIntOYW1lfUxpYi5ETEwiLAorICAgICAgICBidXQgdGhl c2UgY2hhbmdlcyBoYXZlIG5vdCB5ZXQgYmVlbiBhcHBsaWVkIHRvIHRoZSBWaXN1YWwgU3R1ZGlv IGJ1aWxkcy4KKworICAgICAgICAqIE1pbmlCcm93c2VyL01pbmlCcm93c2VyLnZjeHByb2ovTWlu aUJyb3dzZXJMaWIudmN4cHJvajoKKwogMjAxNS0xMC0xNiAgQW5kcmVhcyBLbGluZyAgPGFrbGlu Z0BhcHBsZS5jb20+CiAKICAgICAgICAgW0VGTCwgQXBwbGVXaW5dIFdURi5Db25jYXRlbmF0ZUNo YXJhY3RlckFycmF5QW5kRW1wdHlTdHJpbmcgQVBJIHRlc3QgZmFpbGVkCmRpZmYgLS1naXQgYS9U b29scy9NaW5pQnJvd3Nlci9NaW5pQnJvd3Nlci52Y3hwcm9qL01pbmlCcm93c2VyTGliLnZjeHBy b2ogYi9Ub29scy9NaW5pQnJvd3Nlci9NaW5pQnJvd3Nlci52Y3hwcm9qL01pbmlCcm93c2VyTGli LnZjeHByb2oKaW5kZXggZDQ1NWUwYTU1MjI5ZWRhOGVhZTdiNzlkNjNlNWVhMDI5MGJkZjk2Yy4u YjMyZjFkNWEwYWQ0ZjI1ZTI2OWI5ODc5YTM4MjZiZTJmMDRhODM2YSAxMDA2NDQKLS0tIGEvVG9v bHMvTWluaUJyb3dzZXIvTWluaUJyb3dzZXIudmN4cHJvai9NaW5pQnJvd3NlckxpYi52Y3hwcm9q CisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL01pbmlCcm93c2VyLnZjeHByb2ovTWluaUJyb3dzZXJM aWIudmN4cHJvagpAQCAtMTk0LDYgKzE5NCw0MiBAQAogICA8UHJvcGVydHlHcm91cD4KICAgICA8 X1Byb2plY3RGaWxlVmVyc2lvbj4xMC4wLjQwMjE5LjE8L19Qcm9qZWN0RmlsZVZlcnNpb24+CiAg IDwvUHJvcGVydHlHcm91cD4KKyAgPFByb3BlcnR5R3JvdXAgQ29uZGl0aW9uPSInJChDb25maWd1 cmF0aW9uKXwkKFBsYXRmb3JtKSc9PSdSZWxlYXNlX1dpbkNhaXJvfHg2NCciPgorICAgIDxUYXJn ZXROYW1lPk1pbmlCcm93c2VyTGliPC9UYXJnZXROYW1lPgorICA8L1Byb3BlcnR5R3JvdXA+Cisg IDxQcm9wZXJ0eUdyb3VwIENvbmRpdGlvbj0iJyQoQ29uZmlndXJhdGlvbil8JChQbGF0Zm9ybSkn PT0nRGVidWdfV2luQ2Fpcm98eDY0JyI+CisgICAgPFRhcmdldE5hbWU+TWluaUJyb3dzZXJMaWI8 L1RhcmdldE5hbWU+CisgIDwvUHJvcGVydHlHcm91cD4KKyAgPFByb3BlcnR5R3JvdXAgQ29uZGl0 aW9uPSInJChDb25maWd1cmF0aW9uKXwkKFBsYXRmb3JtKSc9PSdQcm9kdWN0aW9ufHg2NCciPgor ICAgIDxUYXJnZXROYW1lPk1pbmlCcm93c2VyTGliPC9UYXJnZXROYW1lPgorICA8L1Byb3BlcnR5 R3JvdXA+CisgIDxQcm9wZXJ0eUdyb3VwIENvbmRpdGlvbj0iJyQoQ29uZmlndXJhdGlvbil8JChQ bGF0Zm9ybSknPT0nRGVidWd8eDY0JyI+CisgICAgPFRhcmdldE5hbWU+TWluaUJyb3dzZXJMaWI8 L1RhcmdldE5hbWU+CisgIDwvUHJvcGVydHlHcm91cD4KKyAgPFByb3BlcnR5R3JvdXAgQ29uZGl0 aW9uPSInJChDb25maWd1cmF0aW9uKXwkKFBsYXRmb3JtKSc9PSdSZWxlYXNlfHg2NCciPgorICAg IDxUYXJnZXROYW1lPk1pbmlCcm93c2VyTGliPC9UYXJnZXROYW1lPgorICA8L1Byb3BlcnR5R3Jv dXA+CisgIDxQcm9wZXJ0eUdyb3VwIENvbmRpdGlvbj0iJyQoQ29uZmlndXJhdGlvbil8JChQbGF0 Zm9ybSknPT0nRGVidWdTdWZmaXh8eDY0JyI+CisgICAgPFRhcmdldE5hbWU+TWluaUJyb3dzZXJM aWI8L1RhcmdldE5hbWU+CisgIDwvUHJvcGVydHlHcm91cD4KKyAgPFByb3BlcnR5R3JvdXAgQ29u ZGl0aW9uPSInJChDb25maWd1cmF0aW9uKXwkKFBsYXRmb3JtKSc9PSdSZWxlYXNlX1dpbkNhaXJv fFdpbjMyJyI+CisgICAgPFRhcmdldE5hbWU+TWluaUJyb3dzZXJMaWI8L1RhcmdldE5hbWU+Cisg IDwvUHJvcGVydHlHcm91cD4KKyAgPFByb3BlcnR5R3JvdXAgQ29uZGl0aW9uPSInJChDb25maWd1 cmF0aW9uKXwkKFBsYXRmb3JtKSc9PSdEZWJ1Z19XaW5DYWlyb3xXaW4zMiciPgorICAgIDxUYXJn ZXROYW1lPk1pbmlCcm93c2VyTGliPC9UYXJnZXROYW1lPgorICA8L1Byb3BlcnR5R3JvdXA+Cisg IDxQcm9wZXJ0eUdyb3VwIENvbmRpdGlvbj0iJyQoQ29uZmlndXJhdGlvbil8JChQbGF0Zm9ybSkn PT0nUHJvZHVjdGlvbnxXaW4zMiciPgorICAgIDxUYXJnZXROYW1lPk1pbmlCcm93c2VyTGliPC9U YXJnZXROYW1lPgorICA8L1Byb3BlcnR5R3JvdXA+CisgIDxQcm9wZXJ0eUdyb3VwIENvbmRpdGlv bj0iJyQoQ29uZmlndXJhdGlvbil8JChQbGF0Zm9ybSknPT0nRGVidWd8V2luMzInIj4KKyAgICA8 VGFyZ2V0TmFtZT5NaW5pQnJvd3NlckxpYjwvVGFyZ2V0TmFtZT4KKyAgPC9Qcm9wZXJ0eUdyb3Vw PgorICA8UHJvcGVydHlHcm91cCBDb25kaXRpb249IickKENvbmZpZ3VyYXRpb24pfCQoUGxhdGZv cm0pJz09J1JlbGVhc2V8V2luMzInIj4KKyAgICA8VGFyZ2V0TmFtZT5NaW5pQnJvd3NlckxpYjwv VGFyZ2V0TmFtZT4KKyAgPC9Qcm9wZXJ0eUdyb3VwPgorICA8UHJvcGVydHlHcm91cCBDb25kaXRp b249IickKENvbmZpZ3VyYXRpb24pfCQoUGxhdGZvcm0pJz09J0RlYnVnU3VmZml4fFdpbjMyJyI+ CisgICAgPFRhcmdldE5hbWU+TWluaUJyb3dzZXJMaWI8L1RhcmdldE5hbWU+CisgIDwvUHJvcGVy dHlHcm91cD4KICAgPEl0ZW1EZWZpbml0aW9uR3JvdXA+CiAgIDwvSXRlbURlZmluaXRpb25Hcm91 cD4KICAgPEl0ZW1Hcm91cD4K