150303 2015-10-18 09:24:25 -0700 [GTK] Accessing default web context before gtk_init results in drawing failure (Gtk-WARNING **: drawing failure for widget 'WebKitWebView': invalid value for an input Visual*) 2018-11-26 06:18:44 -0800 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Linux RESOLVED FIXED P2 Normal --- 1 steefhegeman webkit-unassigned aperez bugs-noreply cgarcia dustin mcatanzaro oldest_to_newest 1134346 0 steefhegeman 2015-10-18 09:24:25 -0700 On WebKit2GTK+ version 2.10.2, drawing failures occur when (in this order): 1. webkit_web_context_get_default() gets called 2. gtk_init() gets called 3. a window with a WebKitWebView gets shown In this order, however, no errors occur: 1. gtk_init() gets called 2. webkit_web_context_get_default() gets called 3. a window with a WebKitWebView gets shown I have attached a minimal example showing this behavior. When running this, the following warnings are printed from time to time: Gtk-WARNING **: drawing failure for widget 'WebKitWebView': invalid value for an input Visual* This behavior only started to appear recently, my guess would be from version 2.10.1 onward. 1134347 1 263423 steefhegeman 2015-10-18 09:25:12 -0700 Created attachment 263423 Minimal example for reproduction 1462912 2 aperez 2018-09-24 15:01:52 -0700 Interestingly enough, the same kind of warnings are logged when building Cog (https://github.com/Igalia/cog) with “-DCOG_USE_WEBKITGTK=ON”, and after I have updated to WebKitGTK+ 2.22.x While it might be possible to workaround this issue in many cases, it is very annoying for programs which, for example, fetch the default context, then its associated WebKitSettings, and change the initial settings based on CLI flags *before* GTK+ has been initialized (in Cog GTK+ is initialized by GtkApplication, and the default context has been retrieved at least once precisely to setup CLI parsing). A workaround has been to call gtk_init() early anyway, but it feels dirty to do that: https://github.com/Igalia/cog/pull/63 IMHO it would be great if we could fix this regression, as we don't know how many applications out there in the wild depend on this behaviour, and it would be better to not break them if possible. 1476464 3 cgarcia 2018-11-08 01:32:54 -0800 I can't reproduce this in current trunk 1476487 4 cgarcia 2018-11-08 03:18:39 -0800 I still don't get the error message, but I'm getting a black screen in pages using AC. The problem is that PlatformDisplay::sharedDisplay() is called before gtk_init(), creating a new display instead of reusing the one opened by GTK+ in gtk_init(). This approach doesn't seem to work anymore when using AC, neither in X11 nor in wayland. The display is created by HardwareAccelerationManager, called when settings are initialized to check if the x server support xdamange and xcomposite in case of x11 and whether the wayland nested compositor failed in case of wayland. Both things are unlikely to happen, and they are already handled by AcceleratedBackingStoreX11 and AcceleratedBackingStoreWayland in their create() method. So, we could probably remove those checks and not change the settings based on system capabilities. 1481087 5 cgarcia 2018-11-23 01:27:53 -0800 I've changed my mind here, we should ensure that gtk init has been initialized before creating the default display. Application that want to handle gtk command line arguments either call gtk_init earlier or use GtkApplication. 1481088 6 355504 cgarcia 2018-11-23 01:31:27 -0800 Created attachment 355504 Patch 1481141 7 mcatanzaro 2018-11-23 09:06:59 -0800 GTK+ command line args are deprecated anyway. 1481511 8 cgarcia 2018-11-26 06:18:44 -0800 Committed r238492: <https://trac.webkit.org/changeset/238492> 263423 2015-10-18 09:25:12 -0700 2015-10-18 09:25:12 -0700 Minimal example for reproduction wc-before-init.c text/x-csrc 371 steefhegeman I2luY2x1ZGUgPGd0ay9ndGsuaD4KI2luY2x1ZGUgPHdlYmtpdDIvd2Via2l0Mi5oPgoKaW50IG1h aW4oaW50IGFyZ2MsIGNoYXIqKiBhcmd2KQp7CglHdGtXaWRnZXQqIHdpbjsKCUd0a1dpZGdldCog dmlldzsKCgl3ZWJraXRfd2ViX2NvbnRleHRfZ2V0X2RlZmF1bHQoKTsKCglndGtfaW5pdCgmYXJn YywgJmFyZ3YpOwoKCXdpbiA9IGd0a193aW5kb3dfbmV3KEdUS19XSU5ET1dfVE9QTEVWRUwpOwoJ dmlldyA9IHdlYmtpdF93ZWJfdmlld19uZXcoKTsKCglndGtfY29udGFpbmVyX2FkZChHVEtfQ09O VEFJTkVSKHdpbiksIHZpZXcpOwoJZ3RrX3dpZGdldF9zaG93X2FsbChHVEtfV0lER0VUKHdpbikp OwoKCWd0a19tYWluKCk7CglyZXR1cm4gMDsKfQo= 355504 2018-11-23 01:31:27 -0800 2018-11-23 09:06:44 -0800 Patch wkgtk-display.diff text/plain 2312 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0OWNjMTIzMWVhZS4uN2M4MjVmNTMxNGUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxOC0xMS0yMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gQWNjZXNzaW5nIGRlZmF1bHQgd2ViIGNvbnRleHQg YmVmb3JlIGd0a19pbml0IHJlc3VsdHMgaW4gZHJhd2luZyBmYWlsdXJlIChHdGstV0FSTklORyAq KjogZHJhd2luZyBmYWlsdXJlIGZvciB3aWRnZXQgJ1dlYktpdFdlYlZpZXcnOiBpbnZhbGlkIHZh bHVlIGZvciBhbiBpbnB1dCBWaXN1YWwqKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTUwMzAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRW5zdXJlIGd0ayBoYXMgYmVlbiBpbml0aWFsaXplZCBiZWZvcmUg dHJ5aW5nIHRvIGdldCB0aGUgZGVmYXVsdCBkaXNwbGF5LgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvUGxhdGZvcm1EaXNwbGF5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsYXRmb3Jt RGlzcGxheTo6Y3JlYXRlUGxhdGZvcm1EaXNwbGF5KToKKwogMjAxOC0xMS0yMiAgV2Vuc29uIEhz aWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGRyZXNzIHBvc3QtcmV2 aWV3IGZlZWRiYWNrIGFmdGVyIHIyMzg0MzgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL1BsYXRmb3JtRGlzcGxheS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9QbGF0Zm9ybURpc3BsYXkuY3BwCmluZGV4IGIxYWM0MGNiOGM3Li5kMjNj NjA3OTJlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvUGxh dGZvcm1EaXNwbGF5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Q bGF0Zm9ybURpc3BsYXkuY3BwCkBAIC00Nyw3ICs0Nyw3IEBACiAjZW5kaWYKIAogI2lmIFBMQVRG T1JNKEdUSykKLSNpbmNsdWRlIDxnZGsvZ2RrLmg+CisjaW5jbHVkZSA8Z3RrL2d0ay5oPgogI2Vu ZGlmCiAKICNpZiBQTEFURk9STShHVEspICYmIFBMQVRGT1JNKFgxMSkKQEAgLTc3LDE1ICs3Nywx NyBAQCBzdGQ6OnVuaXF1ZV9wdHI8UGxhdGZvcm1EaXNwbGF5PiBQbGF0Zm9ybURpc3BsYXk6OmNy ZWF0ZVBsYXRmb3JtRGlzcGxheSgpCiAjaWYgZGVmaW5lZChHVEtfQVBJX1ZFUlNJT05fMikKICAg ICByZXR1cm4gUGxhdGZvcm1EaXNwbGF5WDExOjpjcmVhdGUoR0RLX0RJU1BMQVlfWERJU1BMQVko Z2RrX2Rpc3BsYXlfZ2V0X2RlZmF1bHQoKSkpOwogI2Vsc2UKLSAgICBHZGtEaXNwbGF5KiBkaXNw bGF5ID0gZ2RrX2Rpc3BsYXlfbWFuYWdlcl9nZXRfZGVmYXVsdF9kaXNwbGF5KGdka19kaXNwbGF5 X21hbmFnZXJfZ2V0KCkpOworICAgIGlmIChndGtfaW5pdF9jaGVjayhudWxscHRyLCBudWxscHRy KSkgeworICAgICAgICBHZGtEaXNwbGF5KiBkaXNwbGF5ID0gZ2RrX2Rpc3BsYXlfbWFuYWdlcl9n ZXRfZGVmYXVsdF9kaXNwbGF5KGdka19kaXNwbGF5X21hbmFnZXJfZ2V0KCkpOwogI2lmIFBMQVRG T1JNKFgxMSkKLSAgICBpZiAoR0RLX0lTX1gxMV9ESVNQTEFZKGRpc3BsYXkpKQotICAgICAgICBy ZXR1cm4gUGxhdGZvcm1EaXNwbGF5WDExOjpjcmVhdGUoR0RLX0RJU1BMQVlfWERJU1BMQVkoZGlz cGxheSkpOworICAgICAgICBpZiAoR0RLX0lTX1gxMV9ESVNQTEFZKGRpc3BsYXkpKQorICAgICAg ICAgICAgcmV0dXJuIFBsYXRmb3JtRGlzcGxheVgxMTo6Y3JlYXRlKEdES19ESVNQTEFZX1hESVNQ TEFZKGRpc3BsYXkpKTsKICNlbmRpZgogI2lmIFBMQVRGT1JNKFdBWUxBTkQpCi0gICAgaWYgKEdE S19JU19XQVlMQU5EX0RJU1BMQVkoZGlzcGxheSkpCi0gICAgICAgIHJldHVybiBQbGF0Zm9ybURp c3BsYXlXYXlsYW5kOjpjcmVhdGUoZ2RrX3dheWxhbmRfZGlzcGxheV9nZXRfd2xfZGlzcGxheShk aXNwbGF5KSk7CisgICAgICAgIGlmIChHREtfSVNfV0FZTEFORF9ESVNQTEFZKGRpc3BsYXkpKQor ICAgICAgICAgICAgcmV0dXJuIFBsYXRmb3JtRGlzcGxheVdheWxhbmQ6OmNyZWF0ZShnZGtfd2F5 bGFuZF9kaXNwbGF5X2dldF93bF9kaXNwbGF5KGRpc3BsYXkpKTsKICNlbmRpZgorICAgIH0KICNl bmRpZgogI2VuZGlmIC8vIFBMQVRGT1JNKEdUSykKIAo=