150302 2015-10-18 07:05:46 -0700 Add missing #if ENABLE(CONTENT_EXTENSIONS) for successful builds with ENABLE_CONTENT_EXTENSIONS=OFF 2015-10-19 06:34:30 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sungmann.cho sungmann.cho commit-queue darin ossy oldest_to_newest 1134341 0 sungmann.cho 2015-10-18 07:05:46 -0700 Add missing #if ENABLE(CONTENT_EXTENSIONS) for successful builds with CONTENT_EXTENSIONS=OFF. 1134342 1 263420 sungmann.cho 2015-10-18 07:09:28 -0700 Created attachment 263420 Patch 1134343 2 263421 sungmann.cho 2015-10-18 07:58:32 -0700 Created attachment 263421 Patch 1134397 3 263421 commit-queue 2015-10-18 16:37:20 -0700 Comment on attachment 263421 Patch Clearing flags on attachment: 263421 Committed r191266: <http://trac.webkit.org/changeset/191266> 1134398 4 commit-queue 2015-10-18 16:37:24 -0700 All reviewed patches have been landed. Closing bug. 1134496 5 ossy 2015-10-19 00:49:11 -0700 (In reply to comment #3) > Comment on attachment 263421 [details] > Patch > > Clearing flags on attachment: 263421 > > Committed r191266: <http://trac.webkit.org/changeset/191266> Why did you need this change? ContentExtensionActions.h is properly guarded with ENABLE(CONTENT_EXTENSIONS. https://trac.webkit.org/browser/trunk/Source/WebCore/contentextensions/ContentExtensionActions.h It's not common to use guards for include statements. 1134565 6 sungmann.cho 2015-10-19 06:34:30 -0700 > Why did you need this change? ContentExtensionActions.h > is properly guarded with ENABLE(CONTENT_EXTENSIONS. Because I got errors "cannot include ContentExtensionActions.h" while building on Visual Studio with ENABLE_CONTENT_EXTENSION=OFF (this is the default value in the AppleWin target). Honestly, I don't know exactly why the errors occur. I just simply followed other cases like ContentExtensionRule.h. But today I realized through webkit.org/b/150300 that our Visual Studio projects are not being managed well, so I think the root cause of the problem might be elsewhere. > It's not common to use guards for include statements. I agree with your point, but I can find so many cases like this in our codebase. How do I understand this? 263420 2015-10-18 07:09:28 -0700 2015-10-18 07:58:27 -0700 Patch bug-150302-20151018230844.patch text/plain 1779 sungmann.cho U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxMjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDllMGQ3OTM3N2U5Yzhi MjdhYzljYjJjNmU1ODU5ODk4ZDliZTJjZi4uYmNhMTdjNjg0OGM4ZTQzOTljMDViMGJmY2Y1N2Iy OTllYmJjYzU3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTEwLTE4ICBTdW5n bWFubiBDaG8gIDxzdW5nbWFubi5jaG9AbmF2ZXJjb3JwLmNvbT4KKworICAgICAgICBGaXggdGhl IGJ1aWxkcyB3aXRoIEVOQUJMRV9DT05URU5UX0VYVEVOU0lPTlM9T0ZGLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwMzAyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG1pc3NpbmcgI2lmIEVOQUJM RShDT05URU5UX0VYVEVOU0lPTlMpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZp b3IgY2hhbmdlLgorCisgICAgICAgICogcGFnZS9Vc2VyQ29udGVudENvbnRyb2xsZXIuaDoKKwog MjAxNS0xMC0xOCAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE5MTI1MCBhbmQgcjE5MTI1My4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvVXNlckNvbnRlbnRDb250cm9sbGVyLmggYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL1VzZXJDb250ZW50Q29udHJvbGxlci5oCmluZGV4IDkyMmRiOTI4Yzg4 NTc3NjIwZmY0YWM5OTJmYWIwMzZkYmE2MmVmZWYuLjBhMDdkMGRiMjZlNDFkYzAxNzdlZWUzOTg1 OGE1NTkxNzkxZDZlYTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvVXNlckNvbnRl bnRDb250cm9sbGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9Vc2VyQ29udGVudENvbnRy b2xsZXIuaApAQCAtMjYsNyArMjYsNiBAQAogI2lmbmRlZiBVc2VyQ29udGVudENvbnRyb2xsZXJf aAogI2RlZmluZSBVc2VyQ29udGVudENvbnRyb2xsZXJfaAogCi0jaW5jbHVkZSAiQ29udGVudEV4 dGVuc2lvbkFjdGlvbnMuaCIKICNpbmNsdWRlICJVc2VyU2NyaXB0VHlwZXMuaCIKICNpbmNsdWRl ICJVc2VyU3R5bGVTaGVldFR5cGVzLmgiCiAjaW5jbHVkZSA8d3RmL0hhc2hTZXQuaD4KQEAgLTM3 LDYgKzM2LDEwIEBACiAjaW5jbHVkZSAiVXNlck1lc3NhZ2VIYW5kbGVyRGVzY3JpcHRvclR5cGVz LmgiCiAjZW5kaWYKIAorI2lmIEVOQUJMRShDT05URU5UX0VYVEVOU0lPTlMpCisjaW5jbHVkZSAi Q29udGVudEV4dGVuc2lvbkFjdGlvbnMuaCIKKyNlbmRpZgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKIGNsYXNzIERPTVdyYXBwZXJXb3JsZDsKQEAgLTUzLDExICs1NiwxMyBAQCBlbnVtIGNsYXNz IFJlc291cmNlVHlwZSA6IHVpbnQxNl90OwogCiBzdHJ1Y3QgUmVzb3VyY2VMb2FkSW5mbzsKIAor I2lmIEVOQUJMRShDT05URU5UX0VYVEVOU0lPTlMpCiBuYW1lc3BhY2UgQ29udGVudEV4dGVuc2lv bnMgewogY2xhc3MgQ29tcGlsZWRDb250ZW50RXh0ZW5zaW9uOwogY2xhc3MgQ29udGVudEV4dGVu c2lvbnNCYWNrZW5kOwogc3RydWN0IEFjdGlvbjsKIH0KKyNlbmRpZgogCiBjbGFzcyBVc2VyQ29u dGVudENvbnRyb2xsZXIgOiBwdWJsaWMgUmVmQ291bnRlZDxVc2VyQ29udGVudENvbnRyb2xsZXI+ IHsKIHB1YmxpYzoK 263421 2015-10-18 07:58:32 -0700 2015-10-18 16:37:20 -0700 Patch bug-150302-20151018235751.patch text/plain 1452 sungmann.cho U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxMjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDllMGQ3OTM3N2U5Yzhi MjdhYzljYjJjNmU1ODU5ODk4ZDliZTJjZi4uYmNhMTdjNjg0OGM4ZTQzOTljMDViMGJmY2Y1N2Iy OTllYmJjYzU3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTEwLTE4ICBTdW5n bWFubiBDaG8gIDxzdW5nbWFubi5jaG9AbmF2ZXJjb3JwLmNvbT4KKworICAgICAgICBGaXggdGhl IGJ1aWxkcyB3aXRoIEVOQUJMRV9DT05URU5UX0VYVEVOU0lPTlM9T0ZGLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwMzAyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG1pc3NpbmcgI2lmIEVOQUJM RShDT05URU5UX0VYVEVOU0lPTlMpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZp b3IgY2hhbmdlLgorCisgICAgICAgICogcGFnZS9Vc2VyQ29udGVudENvbnRyb2xsZXIuaDoKKwog MjAxNS0xMC0xOCAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE5MTI1MCBhbmQgcjE5MTI1My4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvVXNlckNvbnRlbnRDb250cm9sbGVyLmggYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL1VzZXJDb250ZW50Q29udHJvbGxlci5oCmluZGV4IDkyMmRiOTI4Yzg4 NTc3NjIwZmY0YWM5OTJmYWIwMzZkYmE2MmVmZWYuLjNiMjE1OGJhOGRiZDdmOTE4MzY1YmI2ZGNj Nzk4MzdhYzlkNzEyN2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvVXNlckNvbnRl bnRDb250cm9sbGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9Vc2VyQ29udGVudENvbnRy b2xsZXIuaApAQCAtMjYsNyArMjYsNiBAQAogI2lmbmRlZiBVc2VyQ29udGVudENvbnRyb2xsZXJf aAogI2RlZmluZSBVc2VyQ29udGVudENvbnRyb2xsZXJfaAogCi0jaW5jbHVkZSAiQ29udGVudEV4 dGVuc2lvbkFjdGlvbnMuaCIKICNpbmNsdWRlICJVc2VyU2NyaXB0VHlwZXMuaCIKICNpbmNsdWRl ICJVc2VyU3R5bGVTaGVldFR5cGVzLmgiCiAjaW5jbHVkZSA8d3RmL0hhc2hTZXQuaD4KQEAgLTM3 LDYgKzM2LDEwIEBACiAjaW5jbHVkZSAiVXNlck1lc3NhZ2VIYW5kbGVyRGVzY3JpcHRvclR5cGVz LmgiCiAjZW5kaWYKIAorI2lmIEVOQUJMRShDT05URU5UX0VYVEVOU0lPTlMpCisjaW5jbHVkZSAi Q29udGVudEV4dGVuc2lvbkFjdGlvbnMuaCIKKyNlbmRpZgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKIGNsYXNzIERPTVdyYXBwZXJXb3JsZDsK