150299 2015-10-18 05:01:14 -0700 [GTK] Remove WebKitContextMenu related missing annotation warnings 2015-10-24 12:50:34 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jh718.park jh718.park bugs-noreply cgarcia commit-queue gyuyoung.kim mcatanzaro ossy oldest_to_newest 1134333 0 jh718.park 2015-10-18 05:01:14 -0700 The warnings below occurs currently, because when executing g-ir-scanner, it doesn't consider WebKitContextMenu related cpp files, but only h files. Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuItem.h:81: Warning: WebKit2WebExtension: webkit_context_menu_item_get_action: return value: Missing (transfer) annotation Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuItem.h:94: Warning: WebKit2WebExtension: webkit_context_menu_item_get_submenu: return value: Missing (transfer) annotation Source/WebKit2/UIProcess/API/gtk/WebKitContextMenu.h:86: Warning: WebKit2WebExtension: webkit_context_menu_get_items: return value: Missing (element-type) annotation Source/WebKit2/UIProcess/API/gtk/WebKitContextMenu.h:92: Warning: WebKit2WebExtension: webkit_context_menu_first: return value: Missing (transfer) annotation Source/WebKit2/UIProcess/API/gtk/WebKitContextMenu.h:95: Warning: WebKit2WebExtension: webkit_context_menu_last: return value: Missing (transfer) annotation Source/WebKit2/UIProcess/API/gtk/WebKitContextMenu.h:98: Warning: WebKit2WebExtension: webkit_context_menu_get_item_at_position: return value: Missing (transfer) annotation Source/WebKit2/UIProcess/API/gtk/WebKitContextMenu.h:66: Warning: WebKit2WebExtension: webkit_context_menu_new_with_items: argument items: Missing (element-type) annotation 1134335 1 263417 jh718.park 2015-10-18 05:12:37 -0700 Created attachment 263417 Patch 1134413 2 263417 commit-queue 2015-10-18 16:48:18 -0700 Comment on attachment 263417 Patch Clearing flags on attachment: 263417 Committed r191272: <http://trac.webkit.org/changeset/191272> 1134414 3 commit-queue 2015-10-18 16:48:22 -0700 All reviewed patches have been landed. Closing bug. 1134464 4 cgarcia 2015-10-18 22:51:48 -0700 I always wondered why those warnings happened only when building the extensions gir, thanks! 1134465 5 jh718.park 2015-10-18 23:06:20 -0700 (In reply to comment #4) > I always wondered why those warnings happened only when building the > extensions gir, thanks! It was my pleasure :) 1136275 6 mcatanzaro 2015-10-24 12:50:34 -0700 (In reply to comment #4) > I always wondered why those warnings happened only when building the > extensions gir, thanks! Yeah, this one had stumped me too; thanks Joonghun! 263417 2015-10-18 05:12:37 -0700 2015-10-18 16:48:18 -0700 Patch bug-150299-20151018211145.patch text/plain 1779 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxMjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTgyODMwNmMyZGYzYzk5 OTZlYTY5NzI2ZmRjN2FlODFmY2Y2ZTQyMi4uYjFkMzhlMTU1MGIxZDRmYzE4NzIxZmNiNGFiYzNi ZGUzMmFiZTdmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTEwLTE4ICBKb29u Z2h1biBQYXJrICA8amg3MTgucGFya0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbR1RLXSBSZW1v dmUgV2ViS2l0Q29udGV4dE1lbnUgcmVsYXRlZCBtaXNzaW5nIGFubm90YXRpb24gd2FybmluZ3MK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDI5OQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSB3YXJu aW5ncyBvY2N1ciBjdXJyZW50bHkgYmVjYXVzZSB3aGVuIGV4ZWN1dGluZyBnLWlyLXNjYW5uZXIs CisgICAgICAgIGl0IGRvZXNuJ3QgY29uc2lkZXIgV2ViS2l0Q29udGV4dE1lbnUgcmVsYXRlZCAu Y3BwIGZpbGVzLAorICAgICAgICBidXQgb25seSAuaCBmaWxlcy4KKworICAgICAgICAqIFBsYXRm b3JtR1RLLmNtYWtlOiBBZGQgV2ViS2l0Q29udGV4dE1lbnUgcmVsYXRlZCBjcHAgZmlsZXMuCisK IDIwMTUtMTAtMTggIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAg ICAgICAgW0dUS10gSW1wbGVtZW50IFdlYkNvbnRleHRNZW51UHJveHlHdGs6OnNob3dDb250ZXh0 TWVudSBhZnRlciByMTkxMTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybUdU Sy5jbWFrZSBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtR1RLLmNtYWtlCmluZGV4IDQ4ZjAwYWQx YzYxNzk4ZTI4ZTRmMDcwNDRlNWViYzZhYTkzYTZhMzAuLjQ4Y2JkODI0ZTE5OTE2M2Y5YzI0ZjFk YmE5MzcxYmE0MzI5NDk2NjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtR1RLLmNtYWtlCkBAIC05NzMsOCAr OTczLDEwIEBAIGFkZF9jdXN0b21fY29tbWFuZCgKICAgICAgICAgJHtHT2JqZWN0RE9NQmluZGlu Z3NfR0lSX0hFQURFUlN9CiAgICAgICAgICR7V2ViS2l0MldlYkV4dGVuc2lvbl9JTlNUQUxMRURf SEVBREVSU30KICAgICAgICAgJHtXRUJLSVQyX0RJUn0vVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0 Q29udGV4dE1lbnUuaAorICAgICAgICAke1dFQktJVDJfRElSfS9VSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRDb250ZXh0TWVudS5jcHAKICAgICAgICAgJHtXRUJLSVQyX0RJUn0vVUlQcm9jZXNzL0FQ SS9ndGsvV2ViS2l0Q29udGV4dE1lbnVBY3Rpb25zLmgKICAgICAgICAgJHtXRUJLSVQyX0RJUn0v VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0Q29udGV4dE1lbnVJdGVtLmgKKyAgICAgICAgJHtXRUJL SVQyX0RJUn0vVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0Q29udGV4dE1lbnVJdGVtLmNwcAogICAg ICAgICAke1dFQktJVDJfRElSfS9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRIaXRUZXN0UmVzdWx0 LmgKICAgICAgICAgJHtXRUJLSVQyX0RJUn0vVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0VVJJUmVx dWVzdC5oCiAgICAgICAgICR7V0VCS0lUMl9ESVJ9L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFVS SVJlc3BvbnNlLmgK