150278 2015-10-17 08:49:13 -0700 [Win] Fix the Windows build 2015-10-17 11:05:39 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sungmann.cho sungmann.cho bfulgham commit-queue oldest_to_newest 1134187 0 sungmann.cho 2015-10-17 08:49:13 -0700 Currently, ToT breaks at: 5>PolymorphicAccess.obj : error LNK2019: unresolved external symbol "private: void __thiscall JSC::AccessCase::emitIntrinsicGetter(struct JSC::AccessGenerationState &)" (?emitIntrinsicGetter@AccessCase@JSC@@AAEXAAUAccessGenerationState@2@@Z) referenced in function "private: void __thiscall JSC::AccessCase::generate(struct JSC::AccessGenerationState &)" (?generate@AccessCase@JSC@@AAEXAAUAccessGenerationState@2@@Z) 5>Repatch.obj : error LNK2019: unresolved external symbol "public: static bool __cdecl JSC::AccessCase::canEmitIntrinsicGetter(class JSC::JSFunction *,class JSC::Structure *)" (?canEmitIntrinsicGetter@AccessCase@JSC@@SA_NPAVJSFunction@2@PAVStructure@2@@Z) referenced in function "enum JSC::InlineCacheAction __cdecl JSC::tryCacheGetByID(class JSC::ExecState *,class JSC::JSValue,class JSC::Identifier const &,class JSC::PropertySlot const &,class JSC::StructureStubInfo &)" (?tryCacheGetByID@JSC@@YA?AW4InlineCacheAction@1@PAVExecState@1@VJSValue@1@ABVIdentifier@1@ABVPropertySlot@1@AAVStructureStubInfo@1@@Z) 5>JSGlobalObject.obj : error LNK2019: unresolved external symbol "public: static class JSC::JSTypedArrayViewConstructor * __cdecl JSC::JSTypedArrayViewConstructor::create(class JSC::VM &,class JSC::JSGlobalObject *,class JSC::Structure *,class JSC::JSObject *)" (?create@JSTypedArrayViewConstructor@JSC@@SAPAV12@AAVVM@2@PAVJSGlobalObject@2@PAVStructure@2@PAVJSObject@2@@Z) referenced in function "private: void __thiscall JSC::JSGlobalObject::init(class JSC::VM &)" (?init@JSGlobalObject@JSC@@AAEXAAVVM@2@@Z) 5>JSGlobalObject.obj : error LNK2019: unresolved external symbol "public: static class JSC::Structure * __cdecl JSC::JSTypedArrayViewConstructor::createStructure(class JSC::VM &,class JSC::JSGlobalObject *,class JSC::JSValue)" (?createStructure@JSTypedArrayViewConstructor@JSC@@SAPAVStructure@2@AAVVM@2@PAVJSGlobalObject@2@VJSValue@2@@Z) referenced in function "private: void __thiscall JSC::JSGlobalObject::init(class JSC::VM &)" (?init@JSGlobalObject@JSC@@AAEXAAVVM@2@@Z) 5>Z:\Developer\OSS\WebKit\WebKitBuild\Debug\bin32\JavaScriptCore.dll : fatal error LNK1120: 4 unresolved externals 1134188 1 263374 sungmann.cho 2015-10-17 08:51:33 -0700 Created attachment 263374 Patch 1134198 2 263374 commit-queue 2015-10-17 11:05:36 -0700 Comment on attachment 263374 Patch Clearing flags on attachment: 263374 Committed r191242: <http://trac.webkit.org/changeset/191242> 1134199 3 commit-queue 2015-10-17 11:05:39 -0700 All reviewed patches have been landed. Closing bug. 263374 2015-10-17 08:51:33 -0700 2015-10-17 11:05:36 -0700 Patch bug-150278-20151018005053.patch text/plain 3633 sungmann.cho U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxMjM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm M2YzMzA0NzhhMTljY2M2ZDM4ZTFhZTA5ZDdkNjE0NWExOTQ5NWEzLi40ZGMxZDk4ODcwZjA3Y2Nj ZDM0ZWZmZmQ5Y2NmZTU4NDZhMjUzOTFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNS0xMC0xNyAgU3VuZ21hbm4gQ2hvICA8c3VuZ21hbm4uY2hvQG5hdmVy Y29ycC5jb20+CisKKyAgICAgICAgW1dpbl0gRml4IHRoZSBXaW5kb3dzIGJ1aWxkLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwMjc4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBKYXZhU2NyaXB0Q29y ZS52Y3hwcm9qL0phdmFTY3JpcHRDb3JlLnZjeHByb2o6CisgICAgICAgICogSmF2YVNjcmlwdENv cmUudmN4cHJvai9KYXZhU2NyaXB0Q29yZS52Y3hwcm9qLmZpbHRlcnM6CisKIDIwMTUtMTAtMTYg IFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgW0VTNl0g SW1wbGVtZW50IFN0cmluZy5wcm90b3R5cGUubm9ybWFsaXplCmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUudmN4cHJvai9KYXZhU2NyaXB0Q29yZS52Y3hw cm9qIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnZjeHByb2ovSmF2YVNj cmlwdENvcmUudmN4cHJvagppbmRleCAzZDhhYjEzYmYwZGRmM2QyZDViMWFiYTBkZTZiMjdhNDll ODM4YjI3Li4wOTUwMTg5YjYwMTllNWRiNmU2YzU1OTk3NDc1NGQ0YWYzZTliMmYwIDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUudmN4cHJvai9KYXZhU2Ny aXB0Q29yZS52Y3hwcm9qCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29y ZS52Y3hwcm9qL0phdmFTY3JpcHRDb3JlLnZjeHByb2oKQEAgLTYzNCw2ICs2MzQsNyBAQAogICAg IDxDbENvbXBpbGUgSW5jbHVkZT0iLi5caml0XEV4ZWN1dGFibGVBbGxvY2F0b3JGaXhlZFZNUG9v bC5jcHAiIC8+CiAgICAgPENsQ29tcGlsZSBJbmNsdWRlPSIuLlxqaXRcR0NBd2FyZUpJVFN0dWJS b3V0aW5lLmNwcCIgLz4KICAgICA8Q2xDb21waWxlIEluY2x1ZGU9Ii4uXGppdFxIb3N0Q2FsbFJl dHVyblZhbHVlLmNwcCIgLz4KKyAgICA8Q2xDb21waWxlIEluY2x1ZGU9Ii4uXGppdFxJbnRyaW5z aWNFbWl0dGVyLmNwcCIgLz4KICAgICA8Q2xDb21waWxlIEluY2x1ZGU9Ii4uXGppdFxKSVQuY3Bw IiAvPgogICAgIDxDbENvbXBpbGUgSW5jbHVkZT0iLi5caml0XEpJVEFyaXRobWV0aWMuY3BwIiAv PgogICAgIDxDbENvbXBpbGUgSW5jbHVkZT0iLi5caml0XEpJVEFyaXRobWV0aWMzMl82NC5jcHAi IC8+CkBAIC04MjQsNiArODI1LDcgQEAKICAgICA8Q2xDb21waWxlIEluY2x1ZGU9Ii4uXHJ1bnRp bWVcSlNUeXBlZEFycmF5Q29uc3RydWN0b3JzLmNwcCIgLz4KICAgICA8Q2xDb21waWxlIEluY2x1 ZGU9Ii4uXHJ1bnRpbWVcSlNUeXBlZEFycmF5UHJvdG90eXBlcy5jcHAiIC8+CiAgICAgPENsQ29t cGlsZSBJbmNsdWRlPSIuLlxydW50aW1lXEpTVHlwZWRBcnJheXMuY3BwIiAvPgorICAgIDxDbENv bXBpbGUgSW5jbHVkZT0iLi5ccnVudGltZVxKU1R5cGVkQXJyYXlWaWV3Q29uc3RydWN0b3IuY3Bw IiAvPgogICAgIDxDbENvbXBpbGUgSW5jbHVkZT0iLi5ccnVudGltZVxKU1R5cGVkQXJyYXlWaWV3 UHJvdG90eXBlLmNwcCIgLz4KICAgICA8Q2xDb21waWxlIEluY2x1ZGU9Ii4uXHJ1bnRpbWVcSlNF bnZpcm9ubWVudFJlY29yZC5jcHAiIC8+CiAgICAgPENsQ29tcGlsZSBJbmNsdWRlPSIuLlxydW50 aW1lXEpTV2Vha01hcC5jcHAiIC8+CkBAIC0xNjk1LDYgKzE2OTcsNyBAQAogICAgIDxDbEluY2x1 ZGUgSW5jbHVkZT0iLi5ccnVudGltZVxKU1R5cGVkQXJyYXlDb25zdHJ1Y3RvcnMuaCIgLz4KICAg ICA8Q2xJbmNsdWRlIEluY2x1ZGU9Ii4uXHJ1bnRpbWVcSlNUeXBlZEFycmF5UHJvdG90eXBlcy5o IiAvPgogICAgIDxDbEluY2x1ZGUgSW5jbHVkZT0iLi5ccnVudGltZVxKU1R5cGVkQXJyYXlzLmgi IC8+CisgICAgPENsSW5jbHVkZSBJbmNsdWRlPSIuLlxydW50aW1lXEpTVHlwZWRBcnJheVZpZXdD b25zdHJ1Y3Rvci5oIiAvPgogICAgIDxDbEluY2x1ZGUgSW5jbHVkZT0iLi5ccnVudGltZVxKU1R5 cGVkQXJyYXlWaWV3UHJvdG90eXBlLmgiIC8+CiAgICAgPENsSW5jbHVkZSBJbmNsdWRlPSIuLlxy dW50aW1lXEpTVWludDE2QXJyYXkuaCIgLz4KICAgICA8Q2xJbmNsdWRlIEluY2x1ZGU9Ii4uXHJ1 bnRpbWVcSlNVaW50MzJBcnJheS5oIiAvPgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD b3JlL0phdmFTY3JpcHRDb3JlLnZjeHByb2ovSmF2YVNjcmlwdENvcmUudmN4cHJvai5maWx0ZXJz IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnZjeHByb2ovSmF2YVNjcmlw dENvcmUudmN4cHJvai5maWx0ZXJzCmluZGV4IDRlZDIxMGU5MTgwOTJmNWM4YjY3YmEwMGM0NjVm MjZjY2E0ODY3NTguLjk2MzRlOTE1NGRjMGM3MWY1MTY2MTk3ZTczNzhiNWMyMzI1MzUwZGYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS52Y3hwcm9qL0ph dmFTY3JpcHRDb3JlLnZjeHByb2ouZmlsdGVycworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv SmF2YVNjcmlwdENvcmUudmN4cHJvai9KYXZhU2NyaXB0Q29yZS52Y3hwcm9qLmZpbHRlcnMKQEAg LTQwOCw2ICs0MDgsOSBAQAogICAgIDxDbENvbXBpbGUgSW5jbHVkZT0iLi5caml0XENhbGxGcmFt ZVNodWZmbGVyNjQuY3BwIj4KICAgICAgIDxGaWx0ZXI+aml0PC9GaWx0ZXI+CiAgICAgPC9DbENv bXBpbGU+CisgICAgPENsQ29tcGlsZSBJbmNsdWRlPSIuLlxqaXRcSW50cmluc2ljRW1pdHRlci5j cHAiPgorICAgICAgPEZpbHRlcj5qaXQ8L0ZpbHRlcj4KKyAgICA8L0NsQ29tcGlsZT4KICAgICA8 Q2xDb21waWxlIEluY2x1ZGU9Ii4uXGppdFxKSVQuY3BwIj4KICAgICAgIDxGaWx0ZXI+aml0PC9G aWx0ZXI+CiAgICAgPC9DbENvbXBpbGU+CkBAIC0zNDQzLDEwICszNDQ2LDEwIEBACiAgICAgPC9D bEluY2x1ZGU+CiAgICAgPENsSW5jbHVkZSBJbmNsdWRlPSIuLlxydW50aW1lXEpTVHlwZWRBcnJh eVZpZXdDb25zdHJ1Y3Rvci5oIj4KICAgICAgIDxGaWx0ZXI+cnVudGltZTwvRmlsdGVyPgotICAg IDwvQ2xDb21waWxlPgorICAgIDwvQ2xJbmNsdWRlPgogICAgIDxDbEluY2x1ZGUgSW5jbHVkZT0i Li5ccnVudGltZVxKU1R5cGVkQXJyYXlWaWV3UHJvdG90eXBlLmgiPgogICAgICAgPEZpbHRlcj5y dW50aW1lPC9GaWx0ZXI+Ci0gICAgPC9DbENvbXBpbGU+CisgICAgPC9DbEluY2x1ZGU+CiAgICAg PENsSW5jbHVkZSBJbmNsdWRlPSIuLlxydW50aW1lXEpTVWludDE2QXJyYXkuaCI+CiAgICAgICA8 RmlsdGVyPnJ1bnRpbWU8L0ZpbHRlcj4KICAgICA8L0NsSW5jbHVkZT4K