150238 2015-10-16 10:17:21 -0700 Finalize bug 149952 patch 2015-10-17 00:10:52 -0700 1 1 1 Unclassified WebKit WebCore JavaScript WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf commit-queue darin oldest_to_newest 1133898 0 youennf 2015-10-16 10:17:21 -0700 Following on bug 149952, we should fix what Darin mentionned: > Source/WebCore/bindings/js/JSDOMConstructor.h:32 > + static JSC::Structure* createStructure(JSC::VM&, JSC::JSGlobalObject&, JSC::JSValue); I noticed one tiny mistake that we should return and fix. I don’t think the meaning of JSC::JSValue is clear here without the argument name, prototype. > Source/WebCore/bindings/js/JSDOMConstructor.h:137 > +template<typename JSClass> void JSDOMConstructor<JSClass>::finishCreation(JSC::VM& vm, JSDOMGlobalObject& globalObject) In the final patch you landed this was one of the only function templates without “inline”. Was that intentional? If not, I suggest adding the inline. > Source/WebCore/bindings/js/JSDOMConstructor.h:144 > +template<typename JSClass> JSC::ConstructType JSDOMConstructor<JSClass>::getConstructData(JSC::JSCell*, JSC::ConstructData& constructData) In the final patch you landed this was one of the only function templates without “inline”. Was that intentional? If not, I suggest adding the inline. 1133902 1 263283 youennf 2015-10-16 10:24:15 -0700 Created attachment 263283 Patch 1134166 2 263283 commit-queue 2015-10-17 00:10:48 -0700 Comment on attachment 263283 Patch Clearing flags on attachment: 263283 Committed r191238: <http://trac.webkit.org/changeset/191238> 1134167 3 commit-queue 2015-10-17 00:10:52 -0700 All reviewed patches have been landed. Closing bug. 263283 2015-10-16 10:24:15 -0700 2015-10-17 00:10:48 -0700 Patch bug-150238-20151016142335.patch text/plain 3587 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxMTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjlkYTU5NGQwZDk2OWU3 NWMwMzc1OGU5NGRjZWZmNTk0MTkzMTc5OS4uYTBlN2ZjMzEyNjViNTEwN2U5MTkwNzE1OTgyZWUw N2U3NzFlNGRmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTEwLTE2ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CisKKyAgICAgICAgRmluYWxp emUgYnVnIDE0OTk1MiBwYXRjaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTUwMjM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3Mv anMvSlNET01Db25zdHJ1Y3Rvci5oOgorICAgICAgICAoV2ViQ29yZTo6SlNET01Db25zdHJ1Y3Rv cjxKU0NsYXNzPjo6ZmluaXNoQ3JlYXRpb24pOiBNYXJrZWQgYXMgaW5saW5lLgorICAgICAgICAo V2ViQ29yZTo6SlNET01Db25zdHJ1Y3RvcjxKU0NsYXNzPjo6Z2V0Q29uc3RydWN0RGF0YSk6IE1h cmtlZCBhcyBpbmxpbmUuCisKIDIwMTUtMTAtMTYgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxl LmNvbT4KIAogICAgICAgICBIVE1MUHJlbG9hZFNjYW5uZXIgc2hvdWxkIHByZWxvYWQgaWZyYW1l cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01Db25zdHJ1Y3Rv ci5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01Db25zdHJ1Y3Rvci5oCmluZGV4 IDhkZWQ0YmUyMjJmMmRmODc2Yzg0NjE5ZjcwZWM3MmFjYmI0ZjIxOWIuLmI4MDc2Y2ViMzNjZmM3 YWJjYmNhMGQ5OWM3YTJiMmNhMGI3OWQ5ZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2pzL0pTRE9NQ29uc3RydWN0b3IuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9KU0RPTUNvbnN0cnVjdG9yLmgKQEAgLTI5LDcgKzI5LDcgQEAgcHVibGljOgogICAgIHR5 cGVkZWYgRE9NQ29uc3RydWN0b3JPYmplY3QgQmFzZTsKIAogICAgIHN0YXRpYyBKU0RPTUNvbnN0 cnVjdG9yTm90Q29uc3RydWN0YWJsZSogY3JlYXRlKEpTQzo6Vk0mLCBKU0M6OlN0cnVjdHVyZSos IEpTRE9NR2xvYmFsT2JqZWN0Jik7Ci0gICAgc3RhdGljIEpTQzo6U3RydWN0dXJlKiBjcmVhdGVT dHJ1Y3R1cmUoSlNDOjpWTSYsIEpTQzo6SlNHbG9iYWxPYmplY3QmLCBKU0M6OkpTVmFsdWUpOwor ICAgIHN0YXRpYyBKU0M6OlN0cnVjdHVyZSogY3JlYXRlU3RydWN0dXJlKEpTQzo6Vk0mLCBKU0M6 OkpTR2xvYmFsT2JqZWN0JiwgSlNDOjpKU1ZhbHVlIHByb3RvdHlwZSk7CiAKICAgICBERUNMQVJF X0lORk87CiAKQEAgLTQ2LDcgKzQ2LDcgQEAgcHVibGljOgogICAgIHR5cGVkZWYgRE9NQ29uc3Ry dWN0b3JPYmplY3QgQmFzZTsKIAogICAgIHN0YXRpYyBKU0RPTUNvbnN0cnVjdG9yKiBjcmVhdGUo SlNDOjpWTSYsIEpTQzo6U3RydWN0dXJlKiwgSlNET01HbG9iYWxPYmplY3QmKTsKLSAgICBzdGF0 aWMgSlNDOjpTdHJ1Y3R1cmUqIGNyZWF0ZVN0cnVjdHVyZShKU0M6OlZNJiwgSlNDOjpKU0dsb2Jh bE9iamVjdCYsIEpTQzo6SlNWYWx1ZSk7CisgICAgc3RhdGljIEpTQzo6U3RydWN0dXJlKiBjcmVh dGVTdHJ1Y3R1cmUoSlNDOjpWTSYsIEpTQzo6SlNHbG9iYWxPYmplY3QmLCBKU0M6OkpTVmFsdWUg cHJvdG90eXBlKTsKIAogICAgIERFQ0xBUkVfSU5GTzsKIApAQCAtNjYsNyArNjYsNyBAQCBwdWJs aWM6CiAgICAgdHlwZWRlZiBET01Db25zdHJ1Y3RvcldpdGhEb2N1bWVudCBCYXNlOwogCiAgICAg c3RhdGljIEpTRE9NTmFtZWRDb25zdHJ1Y3RvciogY3JlYXRlKEpTQzo6Vk0mLCBKU0M6OlN0cnVj dHVyZSosIEpTRE9NR2xvYmFsT2JqZWN0Jik7Ci0gICAgc3RhdGljIEpTQzo6U3RydWN0dXJlKiBj cmVhdGVTdHJ1Y3R1cmUoSlNDOjpWTSYsIEpTQzo6SlNHbG9iYWxPYmplY3QmLCBKU0M6OkpTVmFs dWUpOworICAgIHN0YXRpYyBKU0M6OlN0cnVjdHVyZSogY3JlYXRlU3RydWN0dXJlKEpTQzo6Vk0m LCBKU0M6OkpTR2xvYmFsT2JqZWN0JiwgSlNDOjpKU1ZhbHVlIHByb3RvdHlwZSk7CiAKICAgICBE RUNMQVJFX0lORk87CiAKQEAgLTg2LDcgKzg2LDcgQEAgcHVibGljOgogICAgIHR5cGVkZWYgRE9N Q29uc3RydWN0b3JKU0J1aWx0aW5PYmplY3QgQmFzZTsKIAogICAgIHN0YXRpYyBKU0J1aWx0aW5D b25zdHJ1Y3RvciogY3JlYXRlKEpTQzo6Vk0mLCBKU0M6OlN0cnVjdHVyZSosIEpTRE9NR2xvYmFs T2JqZWN0Jik7Ci0gICAgc3RhdGljIEpTQzo6U3RydWN0dXJlKiBjcmVhdGVTdHJ1Y3R1cmUoSlND OjpWTSYsIEpTQzo6SlNHbG9iYWxPYmplY3QmLCBKU0M6OkpTVmFsdWUpOworICAgIHN0YXRpYyBK U0M6OlN0cnVjdHVyZSogY3JlYXRlU3RydWN0dXJlKEpTQzo6Vk0mLCBKU0M6OkpTR2xvYmFsT2Jq ZWN0JiwgSlNDOjpKU1ZhbHVlIHByb3RvdHlwZSk7CiAKICAgICBERUNMQVJFX0lORk87CiAKQEAg LTEzNCwxNCArMTM0LDE0IEBAIHRlbXBsYXRlPHR5cGVuYW1lIEpTQ2xhc3M+IGlubGluZSBKU0M6 OlN0cnVjdHVyZSogSlNET01Db25zdHJ1Y3RvcjxKU0NsYXNzPjo6Y3JlCiAgICAgcmV0dXJuIEpT Qzo6U3RydWN0dXJlOjpjcmVhdGUodm0sICZnbG9iYWxPYmplY3QsIHByb3RvdHlwZSwgSlNDOjpU eXBlSW5mbyhKU0M6Ok9iamVjdFR5cGUsIFN0cnVjdHVyZUZsYWdzKSwgaW5mbygpKTsKIH0KIAot dGVtcGxhdGU8dHlwZW5hbWUgSlNDbGFzcz4gdm9pZCBKU0RPTUNvbnN0cnVjdG9yPEpTQ2xhc3M+ OjpmaW5pc2hDcmVhdGlvbihKU0M6OlZNJiB2bSwgSlNET01HbG9iYWxPYmplY3QmIGdsb2JhbE9i amVjdCkKK3RlbXBsYXRlPHR5cGVuYW1lIEpTQ2xhc3M+IGlubGluZSB2b2lkIEpTRE9NQ29uc3Ry dWN0b3I8SlNDbGFzcz46OmZpbmlzaENyZWF0aW9uKEpTQzo6Vk0mIHZtLCBKU0RPTUdsb2JhbE9i amVjdCYgZ2xvYmFsT2JqZWN0KQogewogICAgIEJhc2U6OmZpbmlzaENyZWF0aW9uKHZtKTsKICAg ICBBU1NFUlQoaW5oZXJpdHMoaW5mbygpKSk7CiAgICAgaW5pdGlhbGl6ZVByb3BlcnRpZXModm0s IGdsb2JhbE9iamVjdCk7CiB9CiAKLXRlbXBsYXRlPHR5cGVuYW1lIEpTQ2xhc3M+IEpTQzo6Q29u c3RydWN0VHlwZSBKU0RPTUNvbnN0cnVjdG9yPEpTQ2xhc3M+OjpnZXRDb25zdHJ1Y3REYXRhKEpT Qzo6SlNDZWxsKiwgSlNDOjpDb25zdHJ1Y3REYXRhJiBjb25zdHJ1Y3REYXRhKQordGVtcGxhdGU8 dHlwZW5hbWUgSlNDbGFzcz4gaW5saW5lIEpTQzo6Q29uc3RydWN0VHlwZSBKU0RPTUNvbnN0cnVj dG9yPEpTQ2xhc3M+OjpnZXRDb25zdHJ1Y3REYXRhKEpTQzo6SlNDZWxsKiwgSlNDOjpDb25zdHJ1 Y3REYXRhJiBjb25zdHJ1Y3REYXRhKQogewogICAgIGNvbnN0cnVjdERhdGEubmF0aXZlLmZ1bmN0 aW9uID0gY29uc3RydWN0OwogICAgIHJldHVybiBKU0M6OkNvbnN0cnVjdFR5cGVIb3N0Owo=