150229 2015-10-16 03:19:18 -0700 [GStreamer] ASSERTION FAILED: !m_adoptionIsRequired in MediaSourceGStreamer::addSourceBuffer 2015-10-16 03:48:16 -0700 1 1 1 Unclassified WebKit Media WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 1 cgarcia webkit-unassigned pnormand zan oldest_to_newest 1133808 0 cgarcia 2015-10-16 03:19:18 -0700 This happens in the debug bot in all media source tests that run that code. The problem is that we are creating a RefPtr without adopting the reference. The ownerships there are not very clear anyway. 1133811 1 263256 cgarcia 2015-10-16 03:25:28 -0700 Created attachment 263256 Patch 1133815 2 cgarcia 2015-10-16 03:48:16 -0700 Committed r191174: <http://trac.webkit.org/changeset/191174> 263256 2015-10-16 03:25:28 -0700 2015-10-16 03:44:46 -0700 Patch wcore-gst-refcount.diff text/plain 4571 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4YmRkNWY2Li5mMDI0ZDM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTUtMTAtMTYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHU3RyZWFtZXJdIEFTU0VSVElPTiBGQUlMRUQ6ICFtX2Fkb3B0aW9uSXNS ZXF1aXJlZCBpbiBNZWRpYVNvdXJjZUdTdHJlYW1lcjo6YWRkU291cmNlQnVmZmVyCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTAyMjkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGhhcHBlbnMgaW4g dGhlIGRlYnVnIGJvdCBpbiBhbGwgbWVkaWEgc291cmNlIHRlc3RzIHRoYXQgcnVuCisgICAgICAg IHRoYXQgY29kZS4gVGhlIHByb2JsZW0gaXMgdGhhdCB3ZSBhcmUgY3JlYXRpbmcgYSBSZWZQdHIg d2l0aG91dAorICAgICAgICBhZG9wdGluZyB0aGUgcmVmZXJlbmNlLgorCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhU291cmNlR1N0cmVhbWVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6Ok1lZGlhU291cmNlR1N0cmVhbWVyOjphZGRTb3VyY2VCdWZmZXIpOiBVc2UK KyAgICAgICAgU291cmNlQnVmZmVyUHJpdmF0ZUdTdHJlYW1lcjo6Y3JlYXRlKCkuCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1NvdXJjZUJ1ZmZlclByaXZhdGVHU3RyZWFt ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U291cmNlQnVmZmVyUHJpdmF0ZUdTdHJlYW1lcjo6 Y3JlYXRlKTogQWRkZWQgdG8gbWFrZQorICAgICAgICBzdXJlIHlvdSBjYW4ndCBjcmVhdGUgYSBT b3VyY2VCdWZmZXJQcml2YXRlR1N0cmVhbWVyIHdpdGhvdXQKKyAgICAgICAgYWRvcHRpbmcgdGhl IHJlZmVyZW5jZS4KKyAgICAgICAgKFdlYkNvcmU6OlNvdXJjZUJ1ZmZlclByaXZhdGVHU3RyZWFt ZXI6OlNvdXJjZUJ1ZmZlclByaXZhdGVHU3RyZWFtZXIpOgorICAgICAgICBUYWtlcyBhIHJlZmVy ZW5jZSB0byB0aGUgY2xpZW50IGluc3RlYWQgb2YgYSBQYXNzUmVmUHRyLgorICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9Tb3VyY2VCdWZmZXJQcml2YXRlR1N0cmVhbWVyLmg6 CisKIDIwMTUtMTAtMTUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCiAgICAgICAgIFtHVEtdIEFTU0VSVElPTiBGQUlMRUQ6IG1hcmtGb250RGF0YSBpbiBGb250 Q2FzY2FkZTo6ZW1waGFzaXNNYXJrSGVpZ2h0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFTb3VyY2VHU3RyZWFtZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhU291cmNlR1N0cmVh bWVyLmNwcAppbmRleCAzYTJmODU5Yy4uNDkxM2ZlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhU291cmNlR1N0cmVhbWVyLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFTb3Vy Y2VHU3RyZWFtZXIuY3BwCkBAIC02Myw5ICs2Myw4IEBAIE1lZGlhU291cmNlR1N0cmVhbWVyOjp+ TWVkaWFTb3VyY2VHU3RyZWFtZXIoKQogCiBNZWRpYVNvdXJjZUdTdHJlYW1lcjo6QWRkU3RhdHVz IE1lZGlhU291cmNlR1N0cmVhbWVyOjphZGRTb3VyY2VCdWZmZXIoY29uc3QgQ29udGVudFR5cGUm IGNvbnRlbnRUeXBlLCBSZWZQdHI8U291cmNlQnVmZmVyUHJpdmF0ZT4mIHNvdXJjZUJ1ZmZlclBy aXZhdGUpCiB7Ci0gICAgUmVmUHRyPFNvdXJjZUJ1ZmZlclByaXZhdGVHU3RyZWFtZXI+IHNvdXJj ZUJ1ZmZlclByaXZhdGVHU3RyZWFtZXIgPSBuZXcgU291cmNlQnVmZmVyUHJpdmF0ZUdTdHJlYW1l cihtX2NsaWVudC5nZXQoKSwgY29udGVudFR5cGUpOwotCi0gICAgc291cmNlQnVmZmVyUHJpdmF0 ZSA9IGFkb3B0UmVmKHNvdXJjZUJ1ZmZlclByaXZhdGVHU3RyZWFtZXIuZ2V0KCkpOworICAgIFJl ZlB0cjxTb3VyY2VCdWZmZXJQcml2YXRlR1N0cmVhbWVyPiBzb3VyY2VCdWZmZXJQcml2YXRlR1N0 cmVhbWVyID0gU291cmNlQnVmZmVyUHJpdmF0ZUdTdHJlYW1lcjo6Y3JlYXRlKCptX2NsaWVudCwg Y29udGVudFR5cGUpOworICAgIHNvdXJjZUJ1ZmZlclByaXZhdGUgPSBzb3VyY2VCdWZmZXJQcml2 YXRlR1N0cmVhbWVyOwogICAgIHJldHVybiBtX2NsaWVudC0+YWRkU291cmNlQnVmZmVyKHNvdXJj ZUJ1ZmZlclByaXZhdGVHU3RyZWFtZXIsIGNvbnRlbnRUeXBlKTsKIH0KIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1NvdXJjZUJ1ZmZlclBy aXZhdGVHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL1NvdXJjZUJ1ZmZlclByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IGJiNTA4NDAuLmVk MDA0YTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9Tb3VyY2VCdWZmZXJQcml2YXRlR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvU291cmNlQnVmZmVyUHJpdmF0ZUdTdHJlYW1l ci5jcHAKQEAgLTQwLDkgKzQwLDE0IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotU291cmNl QnVmZmVyUHJpdmF0ZUdTdHJlYW1lcjo6U291cmNlQnVmZmVyUHJpdmF0ZUdTdHJlYW1lcihQYXNz UmVmUHRyPE1lZGlhU291cmNlQ2xpZW50R1N0cmVhbWVyPiBjbGllbnQsIGNvbnN0IENvbnRlbnRU eXBlJiBjb250ZW50VHlwZSkKK1JlZjxTb3VyY2VCdWZmZXJQcml2YXRlR1N0cmVhbWVyPiBTb3Vy Y2VCdWZmZXJQcml2YXRlR1N0cmVhbWVyOjpjcmVhdGUoTWVkaWFTb3VyY2VDbGllbnRHU3RyZWFt ZXImIGNsaWVudCwgY29uc3QgQ29udGVudFR5cGUmIGNvbnRlbnRUeXBlKQoreworICAgIHJldHVy biBhZG9wdFJlZigqbmV3IFNvdXJjZUJ1ZmZlclByaXZhdGVHU3RyZWFtZXIoY2xpZW50LCBjb250 ZW50VHlwZSkpOworfQorCitTb3VyY2VCdWZmZXJQcml2YXRlR1N0cmVhbWVyOjpTb3VyY2VCdWZm ZXJQcml2YXRlR1N0cmVhbWVyKE1lZGlhU291cmNlQ2xpZW50R1N0cmVhbWVyJiBjbGllbnQsIGNv bnN0IENvbnRlbnRUeXBlJiBjb250ZW50VHlwZSkKICAgICA6IG1fdHlwZShjb250ZW50VHlwZSkK LSAgICAsIG1fY2xpZW50KGNsaWVudCkKKyAgICAsIG1fY2xpZW50KCZjbGllbnQpCiAgICAgLCBt X3JlYWR5U3RhdGUoTWVkaWFQbGF5ZXI6OkhhdmVOb3RoaW5nKQogewogfQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1NvdXJjZUJ1ZmZlclBy aXZhdGVHU3RyZWFtZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9Tb3VyY2VCdWZmZXJQcml2YXRlR1N0cmVhbWVyLmgKaW5kZXggOTYwZjg3Ni4uZDRlY2Vk ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L1NvdXJjZUJ1ZmZlclByaXZhdGVHU3RyZWFtZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvU291cmNlQnVmZmVyUHJpdmF0ZUdTdHJlYW1lci5oCkBA IC00Myw3ICs0Myw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgU291cmNlQnVmZmVy UHJpdmF0ZUdTdHJlYW1lciBmaW5hbCA6IHB1YmxpYyBTb3VyY2VCdWZmZXJQcml2YXRlIHsKIHB1 YmxpYzoKLSAgICBTb3VyY2VCdWZmZXJQcml2YXRlR1N0cmVhbWVyKFBhc3NSZWZQdHI8TWVkaWFT b3VyY2VDbGllbnRHU3RyZWFtZXI+LCBjb25zdCBDb250ZW50VHlwZSYpOworICAgIHN0YXRpYyBS ZWY8U291cmNlQnVmZmVyUHJpdmF0ZUdTdHJlYW1lcj4gY3JlYXRlKE1lZGlhU291cmNlQ2xpZW50 R1N0cmVhbWVyJiwgY29uc3QgQ29udGVudFR5cGUmKTsKICAgICB2aXJ0dWFsIH5Tb3VyY2VCdWZm ZXJQcml2YXRlR1N0cmVhbWVyKCk7CiAKICAgICB2aXJ0dWFsIHZvaWQgc2V0Q2xpZW50KFNvdXJj ZUJ1ZmZlclByaXZhdGVDbGllbnQqKTsKQEAgLTYzLDYgKzYzLDggQEAgcHVibGljOgogICAgIHZp cnR1YWwgdm9pZCBub3RpZnlDbGllbnRXaGVuUmVhZHlGb3JNb3JlU2FtcGxlcyhBdG9taWNTdHJp bmcpOwogCiBwcml2YXRlOgorICAgIFNvdXJjZUJ1ZmZlclByaXZhdGVHU3RyZWFtZXIoTWVkaWFT b3VyY2VDbGllbnRHU3RyZWFtZXImLCBjb25zdCBDb250ZW50VHlwZSYpOworCiAgICAgQ29udGVu dFR5cGUgbV90eXBlOwogICAgIFJlZlB0cjxNZWRpYVNvdXJjZUNsaWVudEdTdHJlYW1lcj4gbV9j bGllbnQ7CiAgICAgU291cmNlQnVmZmVyUHJpdmF0ZUNsaWVudCogbV9zb3VyY2VCdWZmZXJQcml2 YXRlQ2xpZW50Owo=