150190 2015-10-15 14:58:54 -0700 Always enable MASM_PROBE for debug builds. 2015-10-17 17:28:02 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam benjamin cmarcelo commit-queue fpizlo ggaren joepeck keith_miller msaboff saam ysuzuki oldest_to_newest 1133610 0 mark.lam 2015-10-15 14:58:54 -0700 Enabling it only costs some code space, and incurs no performance cost until put to use. Enabling it for debug builds saves us from having to rebuild the world in order to enable it for debugging. 1133612 1 263193 mark.lam 2015-10-15 15:00:51 -0700 Created attachment 263193 the patch. 1133657 2 263193 ggaren 2015-10-15 16:06:42 -0700 Comment on attachment 263193 the patch. Please resolve the namespacing for MASM_PROBE #defines in headers before landing. All macros should have a prefix -- and it looks like you've chosen "PROBE_". 1133972 3 mark.lam 2015-10-16 12:15:24 -0700 Per our discussion yesterday, the namespacing of MASM_PROBE #defines will not be an issue if they are only local to a .cpp file. In https://bugs.webkit.org/show_bug.cgi?id=150239, I've moved all the of probe implementations from the JITStubs<CPU>.h files to their corresponding MacroAssembler<CPU>.cpp files. Hence, this patch is good for landing now. Thanks. 1133989 4 263193 commit-queue 2015-10-16 13:02:59 -0700 Comment on attachment 263193 the patch. Clearing flags on attachment: 263193 Committed r191197: <http://trac.webkit.org/changeset/191197> 1133990 5 commit-queue 2015-10-16 13:03:08 -0700 All reviewed patches have been landed. Closing bug. 1134273 6 mark.lam 2015-10-17 17:28:02 -0700 Follow up landed in r191254: <http://trac.webkit.org/r191254>. This adds CPU(X86) (which was accidentally left out) to the supported list of MASM_PROBE CPUs. 263193 2015-10-15 15:00:51 -0700 2015-10-16 13:02:59 -0700 the patch. bug-150190.patch text/plain 1116 mark.lam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxOTExMzkpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE1LTEwLTE1ICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KKworICAgICAgICBBbHdheXMgZW5hYmxlIE1BU01fUFJPQkUgZm9yIGRlYnVn IGJ1aWxkcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE1MDE5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMTUtMTAtMTQgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdA YXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjE5MDg4Mik6IENvbmNhdGVuYXRpbmcg YSBjaGFyYWN0ZXIgYXJyYXkgYW5kIGFuIGVtcHR5IHN0cmluZyBpcyBicm9rZW4uCkluZGV4OiBT b3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL1Bs YXRmb3JtLmgJKHJldmlzaW9uIDE5MTEzMCkKKysrIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgJ KHdvcmtpbmcgY29weSkKQEAgLTg2MSw5ICs4NjEsMTEgQEAKICNlbmRpZgogI2VuZGlmCiAKLSNp ZiBFTkFCTEUoSklUKQogLyogRW5hYmxlIHRoZSBmb2xsb3dpbmcgaWYgeW91IHdhbnQgdG8gdXNl IHRoZSBNYWNyb0Fzc2VtYmxlcjo6cHJvYmUoKSBmYWNpbGl0eQogICAgdG8gZG8gSklUIGRlYnVn Z2luZy4gKi8KKyNpZiAoQ1BVKFg4Nl82NCkgfHwgQ1BVKEFSTTY0KSB8fCAoQ1BVKEFSTV9USFVN QjIpICYmIFBMQVRGT1JNKElPUykpKSAmJiBFTkFCTEUoSklUKSAmJiBPUyhEQVJXSU4pICYmICFk ZWZpbmVkKE5ERUJVRykKKyNkZWZpbmUgRU5BQkxFX01BU01fUFJPQkUgMQorI2Vsc2UKICNkZWZp bmUgRU5BQkxFX01BU01fUFJPQkUgMAogI2VuZGlmCiAK