150177 2015-10-15 10:30:11 -0700 Refactoring: give probe CPUState methods shorter names. 2015-10-15 11:38:19 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue oldest_to_newest 1133517 0 mark.lam 2015-10-15 10:30:11 -0700 The current names are longer than they need to be. 1133522 1 263171 mark.lam 2015-10-15 10:41:13 -0700 Created attachment 263171 the patch. 1133527 2 263171 msaboff 2015-10-15 10:50:05 -0700 Comment on attachment 263171 the patch. r=me 1133528 3 263171 mark.lam 2015-10-15 10:50:38 -0700 Comment on attachment 263171 the patch. Thanks for the review. 1133535 4 263171 commit-queue 2015-10-15 11:38:15 -0700 Comment on attachment 263171 the patch. Clearing flags on attachment: 263171 Committed r191123: <http://trac.webkit.org/changeset/191123> 1133536 5 commit-queue 2015-10-15 11:38:19 -0700 All reviewed patches have been landed. Closing bug. 263171 2015-10-15 10:41:13 -0700 2015-10-15 11:38:15 -0700 the patch. bug-150177.patch text/plain 4449 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkxMTE4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBA CisyMDE1LTEwLTE1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZWZhY3RvcmluZzogZ2l2ZSB0aGUgTUFTTSBwcm9iZSBDUFVTdGF0ZSBtZXRob2RzIHNob3J0ZXIg bmFtZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NTAxNzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGUgZXhpc3RpbmcgbmFtZXMgYXJlIGxvbmdlciB0aGFuIHRoZXkgbmVlZCB0byBiZS4gIFJlbmFt aW5nIHRoZW0gYXMgZm9sbG93czoKKyAgICAgICAgICAgIEZvciBHUFIsIHJlZ2lzdGVyTmFtZSA9 PT4gZ3ByTmFtZQorICAgICAgICAgICAgRm9yIEdQUiwgcmVnaXN0ZXJWYWx1ZSA9PT4gZ3ByCisg ICAgICAgICAgICBGb3IgRlBSLCByZWdpc3Rlck5hbWUgPT0+IGZwck5hbWUKKyAgICAgICAgICAg IEZvciBGUFIsIHJlZ2lzdGVyVmFsdWUgPT0+IGZwcgorCisgICAgICAgICogYXNzZW1ibGVyL0Fi c3RyYWN0TWFjcm9Bc3NlbWJsZXIuaDoKKyAgICAgICAgKEpTQzo6QWJzdHJhY3RNYWNyb0Fzc2Vt Ymxlcjo6Q1BVU3RhdGU6Omdwck5hbWUpOgorICAgICAgICAoSlNDOjpBYnN0cmFjdE1hY3JvQXNz ZW1ibGVyOjpDUFVTdGF0ZTo6ZnByTmFtZSk6CisgICAgICAgIChKU0M6OkFic3RyYWN0TWFjcm9B c3NlbWJsZXI6OkNQVVN0YXRlOjpncHIpOgorICAgICAgICAoSlNDOjpBYnN0cmFjdE1hY3JvQXNz ZW1ibGVyOjpDUFVTdGF0ZTo6ZnByKToKKyAgICAgICAgKEpTQzo6QWJzdHJhY3RNYWNyb0Fzc2Vt Ymxlcjo6Q1BVU3RhdGU6OnJlZ2lzdGVyTmFtZSk6IERlbGV0ZWQuCisgICAgICAgIChKU0M6OkFi c3RyYWN0TWFjcm9Bc3NlbWJsZXI6OkNQVVN0YXRlOjpyZWdpc3RlclZhbHVlKTogRGVsZXRlZC4K KworICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclByaW50ZXIuY3BwOgorICAgICAg ICAoSlNDOjpwcmludFJlZ2lzdGVyKToKKyAgICAgICAgKEpTQzo6cHJpbnRNZW1vcnkpOgorICAg ICAgICAtIFVwZGF0ZWQgdG8gdXNlIHRoZSBuZXcgbmFtZXMuCisKIDIwMTUtMTAtMTUgIFl1c3Vr ZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgW0VTNl0gQ2xhc3Mg ZXhwcmVzc2lvbiBzaG91bGQgaGF2ZSBsZXhpY2FsIGVudmlyb25tZW50IHRoYXQgaGFzIGl0c2Vs ZiBhcyBhbiBpbXV0YWJsZSBiaW5kaW5nCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNz ZW1ibGVyL0Fic3RyYWN0TWFjcm9Bc3NlbWJsZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvYXNzZW1ibGVyL0Fic3RyYWN0TWFjcm9Bc3NlbWJsZXIuaAkocmV2aXNpb24g MTkxMTE2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BYnN0cmFjdE1hY3Jv QXNzZW1ibGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTg1Miw3ICs4NTIsNyBAQCBwdWJsaWM6CiAg ICAgICAgIEZPUl9FQUNIX0NQVV9SRUdJU1RFUihERUNMQVJFX1JFR0lTVEVSKQogICAgICAgICAj dW5kZWYgREVDTEFSRV9SRUdJU1RFUgogCi0gICAgICAgIHN0YXRpYyBjb25zdCBjaGFyKiByZWdp c3Rlck5hbWUoUmVnaXN0ZXJJRCByZWdJRCkKKyAgICAgICAgc3RhdGljIGNvbnN0IGNoYXIqIGdw ck5hbWUoUmVnaXN0ZXJJRCByZWdJRCkKICAgICAgICAgewogICAgICAgICAgICAgc3dpdGNoIChy ZWdJRCkgewogICAgICAgICAgICAgICAgICNkZWZpbmUgREVDTEFSRV9SRUdJU1RFUihfdHlwZSwg X3JlZ05hbWUpIFwKQEAgLTg2NCw3ICs4NjQsNyBAQCBwdWJsaWM6CiAgICAgICAgICAgICBSRUxF QVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgICAgICB9CiAKLSAgICAgICAgc3RhdGljIGNv bnN0IGNoYXIqIHJlZ2lzdGVyTmFtZShGUFJlZ2lzdGVySUQgcmVnSUQpCisgICAgICAgIHN0YXRp YyBjb25zdCBjaGFyKiBmcHJOYW1lKEZQUmVnaXN0ZXJJRCByZWdJRCkKICAgICAgICAgewogICAg ICAgICAgICAgc3dpdGNoIChyZWdJRCkgewogICAgICAgICAgICAgICAgICNkZWZpbmUgREVDTEFS RV9SRUdJU1RFUihfdHlwZSwgX3JlZ05hbWUpIFwKQEAgLTg3Niw3ICs4NzYsNyBAQCBwdWJsaWM6 CiAgICAgICAgICAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgICAgICB9CiAK LSAgICAgICAgdm9pZCogcmVnaXN0ZXJWYWx1ZShSZWdpc3RlcklEIHJlZ0lEKQorICAgICAgICB2 b2lkKiBncHIoUmVnaXN0ZXJJRCByZWdJRCkKICAgICAgICAgewogICAgICAgICAgICAgc3dpdGNo IChyZWdJRCkgewogICAgICAgICAgICAgICAgICNkZWZpbmUgREVDTEFSRV9SRUdJU1RFUihfdHlw ZSwgX3JlZ05hbWUpIFwKQEAgLTg4OCw3ICs4ODgsNyBAQCBwdWJsaWM6CiAgICAgICAgICAgICBS RUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgICAgICB9CiAKLSAgICAgICAgZG91Ymxl IHJlZ2lzdGVyVmFsdWUoRlBSZWdpc3RlcklEIHJlZ0lEKQorICAgICAgICBkb3VibGUgZnByKEZQ UmVnaXN0ZXJJRCByZWdJRCkKICAgICAgICAgewogICAgICAgICAgICAgc3dpdGNoIChyZWdJRCkg ewogICAgICAgICAgICAgICAgICNkZWZpbmUgREVDTEFSRV9SRUdJU1RFUihfdHlwZSwgX3JlZ05h bWUpIFwKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJs ZXJQcmludGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1i bGVyL01hY3JvQXNzZW1ibGVyUHJpbnRlci5jcHAJKHJldmlzaW9uIDE5MTExNikKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJQcmludGVyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtOTEsMjMgKzkxLDIzIEBAIHZvaWQgcHJpbnRDUFVSZWdpc3RlcnMoQ1BV U3RhdGUmIGNwdSwgaW4KIAogdm9pZCBwcmludFJlZ2lzdGVyKENQVVN0YXRlJiBjcHUsIFJlZ2lz dGVySUQgcmVnSUQpCiB7Ci0gICAgY29uc3QgY2hhciogbmFtZSA9IENQVVN0YXRlOjpyZWdpc3Rl ck5hbWUocmVnSUQpOworICAgIGNvbnN0IGNoYXIqIG5hbWUgPSBDUFVTdGF0ZTo6Z3ByTmFtZShy ZWdJRCk7CiAgICAgdW5pb24gewogICAgICAgICB2b2lkKiB2b2lkUHRyOwogICAgICAgICBpbnRw dHJfdCBpbnRwdHJWYWx1ZTsKICAgICB9IHU7Ci0gICAgdS52b2lkUHRyID0gY3B1LnJlZ2lzdGVy VmFsdWUocmVnSUQpOworICAgIHUudm9pZFB0ciA9IGNwdS5ncHIocmVnSUQpOwogICAgIGRhdGFM b2dGKCIlczo8JXAgJWxkPiIsIG5hbWUsIHUudm9pZFB0ciwgdS5pbnRwdHJWYWx1ZSk7CiB9CiAK IHZvaWQgcHJpbnRSZWdpc3RlcihDUFVTdGF0ZSYgY3B1LCBGUFJlZ2lzdGVySUQgcmVnSUQpCiB7 Ci0gICAgY29uc3QgY2hhciogbmFtZSA9IENQVVN0YXRlOjpyZWdpc3Rlck5hbWUocmVnSUQpOwor ICAgIGNvbnN0IGNoYXIqIG5hbWUgPSBDUFVTdGF0ZTo6ZnByTmFtZShyZWdJRCk7CiAgICAgdW5p b24gewogICAgICAgICBkb3VibGUgZG91YmxlVmFsdWU7CiAgICAgICAgIHVpbnQ2NF90IHVpbnQ2 NFZhbHVlOwogICAgIH0gdTsKLSAgICB1LmRvdWJsZVZhbHVlID0gY3B1LnJlZ2lzdGVyVmFsdWUo cmVnSUQpOworICAgIHUuZG91YmxlVmFsdWUgPSBjcHUuZnByKHJlZ0lEKTsKICAgICBkYXRhTG9n RigiJXM6PDB4JTAxNmxseCAlLjEzZz4iLCBuYW1lLCB1LnVpbnQ2NFZhbHVlLCB1LmRvdWJsZVZh bHVlKTsKIH0KIApAQCAtMTE2LDcgKzExNiw3IEBAIHZvaWQgcHJpbnRNZW1vcnkoQ1BVU3RhdGUm IGNwdSwgY29uc3QgTWUKICAgICB1aW50OF90KiBwdHIgPSBudWxscHRyOwogICAgIHN3aXRjaCAo bWVtb3J5LmFkZHJlc3NUeXBlKSB7CiAgICAgY2FzZSBNZW1vcnk6OkFkZHJlc3NUeXBlOjpBZGRy ZXNzOiB7Ci0gICAgICAgIHB0ciA9IHJlaW50ZXJwcmV0X2Nhc3Q8dWludDhfdCo+KGNwdS5yZWdp c3RlclZhbHVlKG1lbW9yeS51LmFkZHJlc3MuYmFzZSkpOworICAgICAgICBwdHIgPSByZWludGVy cHJldF9jYXN0PHVpbnQ4X3QqPihjcHUuZ3ByKG1lbW9yeS51LmFkZHJlc3MuYmFzZSkpOwogICAg ICAgICBwdHIgKz0gbWVtb3J5LnUuYWRkcmVzcy5vZmZzZXQ7CiAgICAgICAgIGJyZWFrOwogICAg IH0K