150175 2015-10-15 09:54:26 -0700 Fix the !(ENABLE(SHADOW_DOM) || ENABLE(DETAILS_ELEMENT)) build after r191112 2015-10-15 12:47:05 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy cmarcelo commit-queue esprehn+autocc kangil.han kling koivisto oldest_to_newest 1133498 0 ossy 2015-10-15 09:54:26 -0700 http://trac.webkit.org/changeset/191112 broke the build: ../../Source/WebCore/dom/ComposedTreeAncestorIterator.h: In member function 'WebCore::ComposedTreeAncestorIterator& WebCore::ComposedTreeAncestorIterator::traverseParent()': ../../Source/WebCore/dom/ComposedTreeAncestorIterator.h:91:15: error: unused variable 'shadowRoot' [-Werror=unused-variable] ../../Source/WebCore/dom/ComposedTreeIterator.cpp: In member function 'void WebCore::ComposedTreeIterator::initializeShadowStack()': ../../Source/WebCore/dom/ComposedTreeIterator.cpp:51:19: error: unused variable 'shadowRoot' [-Werror=unused-variable] ../../Source/WebCore/dom/Element.cpp: In member function 'virtual void WebCore::Element::childrenChanged(const WebCore::ContainerNode::ChildChange&)': ../../Source/WebCore/dom/Element.cpp:1848:21: error: unused variable 'shadowRoot' [-Werror=unused-variable] 1133500 1 263165 ossy 2015-10-15 09:55:57 -0700 Created attachment 263165 Patch 1133563 2 263165 commit-queue 2015-10-15 12:47:01 -0700 Comment on attachment 263165 Patch Clearing flags on attachment: 263165 Committed r191127: <http://trac.webkit.org/changeset/191127> 1133564 3 commit-queue 2015-10-15 12:47:05 -0700 All reviewed patches have been landed. Closing bug. 263165 2015-10-15 09:55:57 -0700 2015-10-15 12:47:01 -0700 Patch bug-150175-20151015185519.patch text/plain 3068 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxMTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODBlYjQzMzk0MGZhODI5 NzE0MDYzMDlkZDI2ZjRmOGZmNGY3M2YwMy4uZTE0YmU2Nzc4NGI1ODc5OGI5MjM3NzVmZmQ0NzM1 MjNhZDdiMjU3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE1LTEwLTE1ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSAhKEVO QUJMRShTSEFET1dfRE9NKSB8fCBFTkFCTEUoREVUQUlMU19FTEVNRU5UKSkgYnVpbGQgYWZ0ZXIg cjE5MTExMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTUwMTc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBkb20vQ29tcG9zZWRUcmVlQW5jZXN0b3JJdGVyYXRvci5oOgorICAgICAgICAoV2ViQ29yZTo6 Q29tcG9zZWRUcmVlQW5jZXN0b3JJdGVyYXRvcjo6dHJhdmVyc2VQYXJlbnQpOgorICAgICAgICAq IGRvbS9Db21wb3NlZFRyZWVJdGVyYXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb21wb3Nl ZFRyZWVJdGVyYXRvcjo6aW5pdGlhbGl6ZVNoYWRvd1N0YWNrKToKKyAgICAgICAgKiBkb20vRWxl bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50OjpjaGlsZHJlbkNoYW5nZWQpOgor CiAyMDE1LTEwLTE1ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAg ICBbaU9TXSBET00gY2xpY2sgZXZlbnQgbWF5IG5vdCBiZSBkaXNwYXRjaGVkIHdoZW4gcGFnZSBo YXMgOmFjdGl2ZSBzdHlsZSBhbmQgPGlucHV0IHR5cGU9InNlYXJjaCI+CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9kb20vQ29tcG9zZWRUcmVlQW5jZXN0b3JJdGVyYXRvci5oIGIvU291cmNl L1dlYkNvcmUvZG9tL0NvbXBvc2VkVHJlZUFuY2VzdG9ySXRlcmF0b3IuaAppbmRleCBkNjNhYjll N2Y3ZDk5NDNlMmViOTkxMzE4Y2Y5NzEyMTBkMDllYmU5Li5iMDBmZmI5YWMzYzc0OTZlOTAzZGRm YWRkZTYxYWJiZDM4MDFkOGFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ29tcG9z ZWRUcmVlQW5jZXN0b3JJdGVyYXRvci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Db21wb3Nl ZFRyZWVBbmNlc3Rvckl0ZXJhdG9yLmgKQEAgLTkyLDYgKzkyLDcgQEAgaW5saW5lIENvbXBvc2Vk VHJlZUFuY2VzdG9ySXRlcmF0b3ImIENvbXBvc2VkVHJlZUFuY2VzdG9ySXRlcmF0b3I6OnRyYXZl cnNlUGFyZW4KICNpZiBFTkFCTEUoU0hBRE9XX0RPTSkgfHwgRU5BQkxFKERFVEFJTFNfRUxFTUVO VCkKICAgICAgICAgbV9jdXJyZW50ID0gc2hhZG93Um9vdC0+ZmluZEFzc2lnbmVkU2xvdCgqbV9j dXJyZW50KTsKICNlbHNlCisgICAgICAgIFVOVVNFRF9QQVJBTShzaGFkb3dSb290KTsKICAgICAg ICAgbV9jdXJyZW50ID0gbnVsbHB0cjsKICNlbmRpZgogICAgICAgICByZXR1cm4gKnRoaXM7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ29tcG9zZWRUcmVlSXRlcmF0b3IuY3BwIGIv U291cmNlL1dlYkNvcmUvZG9tL0NvbXBvc2VkVHJlZUl0ZXJhdG9yLmNwcAppbmRleCA3OGNlNjVm OGZmZmFjZWY1YWYwMzE1ZGRhNTJhZDAwMjhhMDYxMThlLi40MTQzNzUwM2U3ZmRkOWMyM2E0NGYy MzA2ZWMyNGU1MTkzNTk0OTAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ29tcG9z ZWRUcmVlSXRlcmF0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Db21wb3NlZFRyZWVJ dGVyYXRvci5jcHAKQEAgLTYzLDYgKzYzLDcgQEAgdm9pZCBDb21wb3NlZFRyZWVJdGVyYXRvcjo6 aW5pdGlhbGl6ZVNoYWRvd1N0YWNrKCkKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIC8vIFRo ZSBub2RlIGlzIG5vdCBwYXJ0IG9mIHRoZSBjb21wb3NlZCB0cmVlLgogI2Vsc2UKKyAgICAgICAg ICAgIFVOVVNFRF9QQVJBTShzaGFkb3dSb290KTsKICAgICAgICAgICAgIG1fY3VycmVudCA9IG51 bGxwdHI7CiAgICAgICAgICAgICByZXR1cm47CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2RvbS9FbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcApp bmRleCA3ZWM1NmE2YjM3YmVmNTg2ODQyNjQwMGI0ZjliMmY4OWRiMWU1YWYwLi4xMmU3NjhiMjRh OGYzODZmZjI0N2I1OGU0OWJiNTg3NzY4YjhhYmI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9kb20vRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCkBA IC0xODQ1LDggKzE4NDUsOCBAQCB2b2lkIEVsZW1lbnQ6OmNoaWxkcmVuQ2hhbmdlZChjb25zdCBD aGlsZENoYW5nZSYgY2hhbmdlKQogICAgICAgICBjaGVja0ZvclNpYmxpbmdTdHlsZUNoYW5nZXMo KnRoaXMsIGNoZWNrVHlwZSwgY2hhbmdlLnByZXZpb3VzU2libGluZ0VsZW1lbnQsIGNoYW5nZS5u ZXh0U2libGluZ0VsZW1lbnQpOwogICAgIH0KIAotICAgIGlmIChTaGFkb3dSb290KiBzaGFkb3dS b290ID0gdGhpcy0+c2hhZG93Um9vdCgpKSB7CiAjaWYgRU5BQkxFKFNIQURPV19ET00pIHx8IEVO QUJMRShERVRBSUxTX0VMRU1FTlQpCisgICAgaWYgKFNoYWRvd1Jvb3QqIHNoYWRvd1Jvb3QgPSB0 aGlzLT5zaGFkb3dSb290KCkpIHsKICAgICAgICAgc3dpdGNoIChjaGFuZ2UudHlwZSkgewogICAg ICAgICBjYXNlIEVsZW1lbnRJbnNlcnRlZDoKICAgICAgICAgY2FzZSBFbGVtZW50UmVtb3ZlZDoK QEAgLTE4NjEsOCArMTg2MSw4IEBAIHZvaWQgRWxlbWVudDo6Y2hpbGRyZW5DaGFuZ2VkKGNvbnN0 IENoaWxkQ2hhbmdlJiBjaGFuZ2UpCiAgICAgICAgIGNhc2UgTm9uQ29udGVudHNDaGlsZENoYW5n ZWQ6CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQotI2VuZGlmCiAgICAgfQorI2VuZGlm CiB9CiAKIHZvaWQgRWxlbWVudDo6cmVtb3ZlQWxsRXZlbnRMaXN0ZW5lcnMoKQo=