150173 2015-10-15 09:02:04 -0700 [WK2] Simplify unused return warning in WKRetainPtr.h 2015-10-19 00:08:54 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy andersca mitz ossy oldest_to_newest 1133482 0 ossy 2015-10-15 09:02:04 -0700 http://trac.webkit.org/changeset/159788/trunk/Source/WebKit2/UIProcess/API/cpp/WKRetainPtr.h added (copy/pasted) a complex definition to do it without including Compiler.h from WTF. But now WARN_UNUSED is defined to __attribute__((__warn_unused_result__)) if the compiler is GCC or Clang. But it is a WebKit2 file, I don't know if any other compiler is supported. http://trac.webkit.org/browser/trunk/Source/WTF/wtf/Compiler.h#L308 I think we can simply use __attribute__((__warn_unused_result__)) unconditionally. 1133483 1 263163 ossy 2015-10-15 09:04:22 -0700 Created attachment 263163 Patch 1133485 2 263164 ossy 2015-10-15 09:11:17 -0700 Created attachment 263164 Patch 1134489 3 263164 ossy 2015-10-19 00:08:47 -0700 Comment on attachment 263164 Patch Clearing flags on attachment: 263164 Committed r191279: <http://trac.webkit.org/changeset/191279> 1134490 4 ossy 2015-10-19 00:08:54 -0700 All reviewed patches have been landed. Closing bug. 263163 2015-10-15 09:04:22 -0700 2015-10-15 09:11:11 -0700 Patch bug-150173-20151015180343.patch text/plain 1666 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxMTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmE4OTNkMDZmNDNhNDkz NWU1ZmU2Y2ZkNzA0N2QzN2ZmMmIxODEzYS4uY2NjNDYxZGU2ODE3YjNiMTRkMjdmZTgxNjBkNTY2 ZjI5YmEwMDY3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTEwLTE1ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1dLMl0gU2ltcGxp ZnkgdW51c2VkIHJldHVybiB3YXJuaW5nIGluIFdLUmV0YWluUHRyLmgKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDE3MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9jcHAvV0tS ZXRhaW5QdHIuaDoKKyAgICAgICAgKFdlYktpdDo6X19hdHRyaWJ1dGVfXyk6CisgICAgICAgIChX ZWJLaXQ6OmFkb3B0V0spOiBEZWxldGVkLgorCiAyMDE1LTEwLTE1ICBDYXJsb3MgR2FyY2lhIENh bXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBUZXN0IFdlYktpdDIu UmVzdG9yZVNlc3Npb25TdGF0ZUNvbnRhaW5pbmdGb3JtRGF0YSBmYWlscwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9jcHAvV0tSZXRhaW5QdHIuaCBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvY3BwL1dLUmV0YWluUHRyLmgKaW5kZXggZjUxYjcyMjBjYWQ3 YmJiZTEzY2FiZmEwNTk1MzUxNDNiMjBiODNlZS4uNWI1ZjU5MDA0MzA4M2E2NjZkODJiODY5YjE1 NzdkYTBmZjQzNDQ2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9j cHAvV0tSZXRhaW5QdHIuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2NwcC9X S1JldGFpblB0ci5oCkBAIC0yNDIsMTcgKzI0Miw3IEBAIHRlbXBsYXRlPHR5cGVuYW1lIFQsIHR5 cGVuYW1lIFU+IGlubGluZSBib29sIG9wZXJhdG9yIT0oVCogYSwgY29uc3QgV0tSZXRhaW5QdHI8 CiAgICAgcmV0dXJuIGEgIT0gYi5nZXQoKTsgCiB9CiAKLSNpZiBkZWZpbmVkKF9fR05VQ19fKSAm JiAhKGRlZmluZWQoX19DQ19BUk0pIHx8IGRlZmluZWQoX19BUk1DQ19fKSkKLSNkZWZpbmUgV0tf V0FSTl9VTlVTRURfUkVUVVJOIF9fYXR0cmlidXRlX18oKHdhcm5fdW51c2VkX3Jlc3VsdCkpCi0j ZWxzZQotI2RlZmluZSBXS19XQVJOX1VOVVNFRF9SRVRVUk4KLSNlbmRpZgotCi10ZW1wbGF0ZTx0 eXBlbmFtZSBUPiBpbmxpbmUgV0tSZXRhaW5QdHI8VD4gYWRvcHRXSyhUKSBXS19XQVJOX1VOVVNF RF9SRVRVUk47Ci0KLSN1bmRlZiBXS19XQVJOX1VOVVNFRF9SRVRVUk4KLQotdGVtcGxhdGU8dHlw ZW5hbWUgVD4gaW5saW5lIFdLUmV0YWluUHRyPFQ+IGFkb3B0V0soVCBvKSAKK3RlbXBsYXRlPHR5 cGVuYW1lIFQ+IGlubGluZSBXS1JldGFpblB0cjxUPiBhZG9wdFdLKFQgbykgX19hdHRyaWJ1dGVf Xygod2Fybl91bnVzZWRfcmVzdWx0KSkKIHsKICAgICByZXR1cm4gV0tSZXRhaW5QdHI8VD4oQWRv cHRXSywgbyk7CiB9Cg== 263164 2015-10-15 09:11:17 -0700 2015-10-19 00:08:47 -0700 Patch bug-150173-20151015181038.patch text/plain 1722 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxMTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmE4OTNkMDZmNDNhNDkz NWU1ZmU2Y2ZkNzA0N2QzN2ZmMmIxODEzYS4uY2NjNDYxZGU2ODE3YjNiMTRkMjdmZTgxNjBkNTY2 ZjI5YmEwMDY3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTEwLTE1ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1dLMl0gU2ltcGxp ZnkgdW51c2VkIHJldHVybiB3YXJuaW5nIGluIFdLUmV0YWluUHRyLmgKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDE3MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9jcHAvV0tS ZXRhaW5QdHIuaDoKKyAgICAgICAgKFdlYktpdDo6X19hdHRyaWJ1dGVfXyk6CisgICAgICAgIChX ZWJLaXQ6OmFkb3B0V0spOiBEZWxldGVkLgorCiAyMDE1LTEwLTE1ICBDYXJsb3MgR2FyY2lhIENh bXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBUZXN0IFdlYktpdDIu UmVzdG9yZVNlc3Npb25TdGF0ZUNvbnRhaW5pbmdGb3JtRGF0YSBmYWlscwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9jcHAvV0tSZXRhaW5QdHIuaCBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvY3BwL1dLUmV0YWluUHRyLmgKaW5kZXggZjUxYjcyMjBjYWQ3 YmJiZTEzY2FiZmEwNTk1MzUxNDNiMjBiODNlZS4uMjRhNDVhZmQ0YWI5N2Q4OWQwZmM3NDYwZjc2 ZGY5ODk2MTE1NTQ1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9j cHAvV0tSZXRhaW5QdHIuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2NwcC9X S1JldGFpblB0ci5oCkBAIC0yNDIsMTcgKzI0Miw4IEBAIHRlbXBsYXRlPHR5cGVuYW1lIFQsIHR5 cGVuYW1lIFU+IGlubGluZSBib29sIG9wZXJhdG9yIT0oVCogYSwgY29uc3QgV0tSZXRhaW5QdHI8 CiAgICAgcmV0dXJuIGEgIT0gYi5nZXQoKTsgCiB9CiAKLSNpZiBkZWZpbmVkKF9fR05VQ19fKSAm JiAhKGRlZmluZWQoX19DQ19BUk0pIHx8IGRlZmluZWQoX19BUk1DQ19fKSkKLSNkZWZpbmUgV0tf V0FSTl9VTlVTRURfUkVUVVJOIF9fYXR0cmlidXRlX18oKHdhcm5fdW51c2VkX3Jlc3VsdCkpCi0j ZWxzZQotI2RlZmluZSBXS19XQVJOX1VOVVNFRF9SRVRVUk4KLSNlbmRpZgotCi10ZW1wbGF0ZTx0 eXBlbmFtZSBUPiBpbmxpbmUgV0tSZXRhaW5QdHI8VD4gYWRvcHRXSyhUKSBXS19XQVJOX1VOVVNF RF9SRVRVUk47Ci0KLSN1bmRlZiBXS19XQVJOX1VOVVNFRF9SRVRVUk4KLQotdGVtcGxhdGU8dHlw ZW5hbWUgVD4gaW5saW5lIFdLUmV0YWluUHRyPFQ+IGFkb3B0V0soVCBvKSAKK3RlbXBsYXRlPHR5 cGVuYW1lIFQ+IGlubGluZSBXS1JldGFpblB0cjxUPiBhZG9wdFdLKFQpIF9fYXR0cmlidXRlX18o KHdhcm5fdW51c2VkX3Jlc3VsdCkpOwordGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIFdLUmV0 YWluUHRyPFQ+IGFkb3B0V0soVCBvKQogewogICAgIHJldHVybiBXS1JldGFpblB0cjxUPihBZG9w dFdLLCBvKTsKIH0K