150152 2015-10-14 17:46:10 -0700 [iOS] build-dumprendertree does not build ImageDiff 2015-10-14 20:57:25 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build iPhone / iPad All RESOLVED FIXED P2 Normal --- 1 aestes aestes ap dbates ddkilzer lforschler simon.fraser thorton oldest_to_newest 1133327 0 aestes 2015-10-14 17:46:10 -0700 [iOS] build-dumprendertree does not build ImageDiff 1133333 1 263125 aestes 2015-10-14 17:53:33 -0700 Created attachment 263125 Patch 1133334 2 aestes 2015-10-14 17:58:16 -0700 Committed r191078: <http://trac.webkit.org/changeset/191078> 1133364 3 ap 2015-10-14 20:26:13 -0700 Does this mean that we will be building ImageDiff for iOS (simulator) instead of the host OS? I do not fully understand the setup yet, but this sounds wrong. One thing that's built for the host is LayoutTestRelay. 1133369 4 aestes 2015-10-14 20:57:25 -0700 We have always(In reply to comment #3) > Does this mean that we will be building ImageDiff for iOS (simulator) > instead of the host OS? I do not fully understand the setup yet, but this > sounds wrong. I don't know if it's right, but we do build ImageDiff for iOS Simulator and run it in the sim bootstrap (see http://trac.webkit.org/changeset/172118). This just brings build-dumprendertree in line with what is built by make and the 'All Tools' scheme. 263125 2015-10-14 17:53:33 -0700 2015-10-14 17:56:38 -0700 Patch bug-150152-20151014175255.patch text/plain 2021 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxMDc2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWFiNmMyZGUxM2MyZDljMmEzNDRiM2VlMGY3MzBmYjli MjlkYWVmYi4uZGIwMzU1NWVmN2M5MGE4ZjFjNWQwNjNiN2IxNTQ2ZTNiMDdlZjYxYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDE1LTEwLTE0ICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAg ICBbaU9TXSBidWlsZC1kdW1wcmVuZGVydHJlZSBkb2VzIG5vdCBidWlsZCBJbWFnZURpZmYKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDE1MgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHJ1bi13ZWJraXQt dGVzdHMgYXR0ZW1wdHMgdG8gYnVpbGQgdGhlIHRvb2xzIGl0IHJlcXVpcmVzIGJ5IGNhbGxpbmcg YnVpbGQtZHVtcHJlbmRlcnRyZWUgYW5kIGJ1aWxkLXdlYmtpdHRlc3RydW5uZXIuCisgICAgICAg IE9uIGlPUywgYnVpbGQtZHVtcHJlbmRlcnRyZWUgYnVpbGRzIHRoZSBEdW1wUmVuZGVyVHJlZS5h cHAgdGFyZ2V0LCB3aGljaCBkb2VzIG5vdCBjb250YWluIHRoZSBJbWFnZURpZmYgdGFyZ2V0Cisg ICAgICAgIGFzIGEgZGVwZW5kZW50LiBJZiB5b3UgaGF2ZW4ndCBidWlsdCBJbWFnZURpZmYgYnkg b3RoZXIgbWVhbnMgKHNheSwgYmVjYXVzZSB5b3UgYnVpbHQgdGhlICdBbGwgU291cmNlJyBzY2hl bWUgaW4KKyAgICAgICAgV2ViS2l0Lnhjd29ya3NwYWNlKSwgdGVzdHMgdGhhdCByZWx5IG9uIGlt YWdlIGRpZmZpbmcgd29uJ3Qgd29yayBwcm9wZXJseS4KKworICAgICAgICBUaGVyZSdzIGFjdHVh bGx5IG5vIHJlYXNvbiB0byBidWlsZCB0aGUgRHVtcFJlbmRlclRyZWUuYXBwIHRhcmdldCBvbiBp T1M7IHRoZSBkZWZhdWx0IGFnZ3JlZ2F0ZSB0YXJnZXQgd29ya3MKKyAgICAgICAgZmluZSBvbiB0 aGF0IHBsYXRmb3JtLCBhbmQgcmVzdWx0cyBpbiBJbWFnZURpZmYgYmVpbmcgYnVpbHQuCisKKyAg ICAgICAgKiBTY3JpcHRzL2J1aWxkLWR1bXByZW5kZXJ0cmVlOgorCiAyMDE1LTEwLTE0ICBCcmVu dCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtXaW5dIEVuZm9yY2Ug bGF1bmNoZXIvbGlicmFyeSBuYW1pbmcgc2NoZW1lCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L2J1aWxkLWR1bXByZW5kZXJ0cmVlIGIvVG9vbHMvU2NyaXB0cy9idWlsZC1kdW1wcmVuZGVydHJl ZQppbmRleCAzZTQxNjg3NjkwYTA4NDE4ODczZTMxYmEyOTg0YzkyZjJlMWQ5ZmIyLi5hMTQ0MDU1 YWRhNzI5YjdhZTU0NDgwMzc2NzBjODk2ZTRkODYyODc2IDEwMDc1NQotLS0gYS9Ub29scy9TY3Jp cHRzL2J1aWxkLWR1bXByZW5kZXJ0cmVlCisrKyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtZHVtcHJl bmRlcnRyZWUKQEAgLTY1LDggKzY1LDcgQEAgY2hkaXIgRmlsZTo6U3BlYy0+Y2F0ZGlyKCJUb29s cyIsICJEdW1wUmVuZGVyVHJlZSIpIG9yIGRpZTsKIAogbXkgJHJlc3VsdDsKIGlmIChpc0FwcGxl TWFjV2ViS2l0KCkpIHsKLSAgICBteSBAdGFyZ2V0ID0gaXNJT1NXZWJLaXQoKSA/ICgiLXRhcmdl dCIsICJEdW1wUmVuZGVyVHJlZS5hcHAiKSA6ICgpOwotICAgICRyZXN1bHQgPSBidWlsZFhDb2Rl UHJvamVjdCgiRHVtcFJlbmRlclRyZWUiLCAkY2xlYW4sIFhjb2RlT3B0aW9ucygpLCAoQEFSR1Ys IEB0YXJnZXQpKTsKKyAgICAkcmVzdWx0ID0gYnVpbGRYQ29kZVByb2plY3QoIkR1bXBSZW5kZXJU cmVlIiwgJGNsZWFuLCBYY29kZU9wdGlvbnMoKSwgQEFSR1YpOwogfSBlbHNpZiAoaXNHdGsoKSB8 fCBpc0VmbCgpIHx8IGlzQW55V2luZG93cygpKSB7CiAgICAgIyBHdGssIEVGTCwgYW5kIFdpbmRv d3MgYnVpbGQgZXZlcnl0aGluZyBpbiBvbmUgc2hvdC4gTm8gbmVlZCB0byBidWlsZCBhbnl0aGlu ZyBoZXJlLgogICAgICRyZXN1bHQgPSAwOwo=