150121 2015-10-14 05:59:08 -0700 If a host object is only used as a variadic argument, its bindings header isn't properly included 2016-09-19 05:33:10 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 143211 1 adam.bergkvist nael.ouedp cdumez commit-queue eric.carlson ggaren nael.ouedp youennf oldest_to_newest 1133110 0 adam.bergkvist 2015-10-14 05:59:08 -0700 For example: in RTCPeerConnection.idl: [StrictTypeChecking, RaisesException] RTCRtpSender addTrack(MediaStreamTrack track, MediaStream... streams); If MediaStream is only mentioned at the line above (as a variadic arg), JSMediaStream.cpp won't be included in JSRTCPeerConnection.cpp. 1229971 1 288947 nael.ouedp 2016-09-15 03:32:09 -0700 Created attachment 288947 Patch 1229974 2 nael.ouedp 2016-09-15 03:44:30 -0700 I have not added new binding test in the uploaded patch since seems covered by TestObj.idl test. Is it necessary to add a specific test for this ? 1229982 3 adam.bergkvist 2016-09-15 04:31:38 -0700 Thanks for picking up this bug. There's a FIXME related to this bug at [1] where an extra include is used as a workaround. [1] https://trac.webkit.org/browser/trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.h#L41 1229988 4 nael.ouedp 2016-09-15 05:37:07 -0700 (In reply to comment #3) > Thanks for picking up this bug. > > There's a FIXME related to this bug at [1] where an extra include is used as > a workaround. > > [1] > https://trac.webkit.org/browser/trunk/Source/WebCore/Modules/mediastream/ > RTCPeerConnection.h#L41 Yes, I removed this workaround in the uploaded patch. 1229995 5 288947 youennf 2016-09-15 06:59:26 -0700 Comment on attachment 288947 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288947&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4010 > + AddVariadicToImplIncludes($type, $function->signature->extendedAttributes->{"Conditional"}); Can we write instead AddToImplIncludes(...) unless ...? That would remove the need for a dedicated AddVariadicToImplIncludes, which is not really about variadic so should probably be renamed. 1230018 6 288947 cdumez 2016-09-15 08:57:15 -0700 Comment on attachment 288947 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288947&action=review >> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4010 >> + AddVariadicToImplIncludes($type, $function->signature->extendedAttributes->{"Conditional"}); > > Can we write instead AddToImplIncludes(...) unless ...? > That would remove the need for a dedicated AddVariadicToImplIncludes, which is not really about variadic so should probably be renamed. I think there is already a AddIncludesForTypeInImpl() for this purpose. I also don't think we need a new subroutine that is specific to variadic. 1230054 7 nael.ouedp 2016-09-15 10:06:45 -0700 > Comment on attachment 288947 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=288947&action=review > > >> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4010 > >> + AddVariadicToImplIncludes($type, $function->signature->extendedAttributes->{"Conditional"}); > > > > Can we write instead AddToImplIncludes(...) unless ...? > > That would remove the need for a dedicated AddVariadicToImplIncludes, which is not really about variadic so should probably be renamed. > > I think there is already a AddIncludesForTypeInImpl() for this purpose. I > also don't think we need a new subroutine that is specific to variadic. Thanks for the reviews. Actually, I added a new function for variadic since AddIncludesForTypeInImpl() is not supporting conditional attributes. In addition, isCallback argument of AddIncludesForTypeInImpl() must be set to 1 to include the binding header even if the parameter is not a callback. So, is it OK to use AddToImplIncludes() as proposed by Youenn? 1230067 8 cdumez 2016-09-15 10:20:20 -0700 (In reply to comment #7) > > Comment on attachment 288947 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=288947&action=review > > > > >> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4010 > > >> + AddVariadicToImplIncludes($type, $function->signature->extendedAttributes->{"Conditional"}); > > > > > > Can we write instead AddToImplIncludes(...) unless ...? > > > That would remove the need for a dedicated AddVariadicToImplIncludes, which is not really about variadic so should probably be renamed. > > > > I think there is already a AddIncludesForTypeInImpl() for this purpose. I > > also don't think we need a new subroutine that is specific to variadic. > Thanks for the reviews. > > Actually, I added a new function for variadic since > AddIncludesForTypeInImpl() is not supporting conditional attributes. In > addition, isCallback argument of AddIncludesForTypeInImpl() must be set to 1 > to include the binding header even if the parameter is not a callback. > > So, is it OK to use AddToImplIncludes() as proposed by Youenn? Fine by me as long as it works. 1231050 9 289222 nael.ouedp 2016-09-19 03:32:38 -0700 Created attachment 289222 Patch 1231061 10 289222 commit-queue 2016-09-19 05:33:05 -0700 Comment on attachment 289222 Patch Clearing flags on attachment: 289222 Committed r206094: <http://trac.webkit.org/changeset/206094> 1231062 11 commit-queue 2016-09-19 05:33:10 -0700 All reviewed patches have been landed. Closing bug. 288947 2016-09-15 03:32:09 -0700 2016-09-19 03:32:31 -0700 Patch bug-150121-20160915122931.patch text/plain 3510 nael.ouedp U3VidmVyc2lvbiBSZXZpc2lvbjogMjA1OTY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2JiYWI2MWZhYmQxYmY4 NjFmYjNiNTRmZjgxNjllMzBlOThlNmJkZS4uZWJjMWMzZjkxMDNjYmM3OGVkZjRiZjhiZDM5ZjMz NWNiNzc1MTRiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTA5LTE1ICBOYWVs IE91ZWRyYW9nbyAgPG5hZWwub3VlZHJhb2dvQGNyZi5jYW5vbi5mcj4KKworICAgICAgICBJZiBh IGhvc3Qgb2JqZWN0IGlzIG9ubHkgdXNlZCBhcyBhIHZhcmlhZGljIGFyZ3VtZW50LCBpdHMgYmlu ZGluZ3MgaGVhZGVyIGlzbid0IHByb3Blcmx5IGluY2x1ZGVkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTAxMjEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb2RpZnkgSlMgYmluZGluZyBnZW5lcmF0b3Ig dG8gaW5jbHVkZSBiaW5kaW5nIGhlYWRlcnMgb2Ygb2JqZWN0cyBwYXNzZWQKKyAgICAgICAgYXMg dmFyaWFkaWMgYXJndW1lbnQuCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1Bl ZXJDb25uZWN0aW9uLmg6IFJlbW92ZSB3b3JrYXJvdW5kLgorICAgICAgICAqIGJpbmRpbmdzL3Nj cmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtOgorICAgICAgICAoQWRkVmFyaWFkaWNUb0ltcGxJbmNs dWRlcyk6CisgICAgICAgIChHZW5lcmF0ZVBhcmFtZXRlcnNDaGVjayk6CisgICAgICAgICogYmlu ZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdE9iai5jcHA6CisKIDIwMTYtMDktMTUgIEFsZWph bmRybyBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CiAKICAgICAgICAgRml4IGJ1aWxkIHdh cm5pbmdzIGluIHRoZSBtZWRpYXN0cmVhbSBjb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmggYi9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmgKaW5kZXggNGQ2MGFiMzIx MDYzNjdlNzU3ZmM1ZTQyNmZhZDMxZDM5Y2Q1MGEwOS4uNDJmYTM5MGVhNTRlYmQwZDFiODFhODM4 NGUyZDdkNDYyYjE2NTc5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv bWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24uaApAQCAtMzgsOCArMzgsNyBAQAogI2luY2x1 ZGUgIkFjdGl2ZURPTU9iamVjdC5oIgogI2luY2x1ZGUgIkRpY3Rpb25hcnkuaCIKICNpbmNsdWRl ICJFdmVudFRhcmdldC5oIgotLy8gRklYTUU6IFdvcmthcm91bmQgZm9yIGJpbmRpbmdzIGJ1ZyBo dHRwOi8vd2Via2l0Lm9yZy9iLzE1MDEyMQotI2luY2x1ZGUgIkpTTWVkaWFTdHJlYW0uaCIKKyNp bmNsdWRlICJNZWRpYVN0cmVhbS5oIgogI2luY2x1ZGUgIlBlZXJDb25uZWN0aW9uQmFja2VuZC5o IgogI2luY2x1ZGUgIlJUQ1J0cFRyYW5zY2VpdmVyLmgiCiAjaW5jbHVkZSAiU2NyaXB0V3JhcHBh YmxlLmgiCkBAIC00OCw3ICs0Nyw2IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotY2xhc3Mg TWVkaWFTdHJlYW07CiBjbGFzcyBNZWRpYVN0cmVhbVRyYWNrOwogY2xhc3MgUGVlckNvbm5lY3Rp b25CYWNrZW5kOwogY2xhc3MgUlRDQ29uZmlndXJhdGlvbjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KaW5kZXggM2IzYTUxNjdkMTMy YzA2OGEyMzJlN2M0NWIwYzQ4OWY1MzVmMjc1ZS4uNTdmMzI5ODU3OWNiZWYxMTlmNTBkMmZhMDNj MGVhMTU3MmM1MDM0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9Db2RlR2VuZXJhdG9ySlMucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9Db2RlR2VuZXJhdG9ySlMucG0KQEAgLTI1NCw2ICsyNTQsMTggQEAgc3ViIEFkZFRvSW1wbElu Y2x1ZGVzCiAgICAgfQogfQogCitzdWIgQWRkVmFyaWFkaWNUb0ltcGxJbmNsdWRlcworeworICAg IG15ICR0eXBlID0gc2hpZnQ7CisgICAgbXkgJGNvbmRpdGlvbmFsID0gc2hpZnQ7CisKKyAgICBy ZXR1cm4gaWYgJGNvZGVHZW5lcmF0b3ItPlNraXBJbmNsdWRlSGVhZGVyKCR0eXBlKTsKKworICAg IGlmICgkY29kZUdlbmVyYXRvci0+SXNXcmFwcGVyVHlwZSgkdHlwZSkpIHsKKyAgICAgICAgQWRk VG9JbXBsSW5jbHVkZXMoIkpTJHt0eXBlfS5oIiwgJGNvbmRpdGlvbmFsKTsKKyAgICB9Cit9CisK IHN1YiBJc1JlYWRvbmx5CiB7CiAgICAgbXkgJGF0dHJpYnV0ZSA9IHNoaWZ0OwpAQCAtMzk5NSw2 ICs0MDA3LDcgQEAgc3ViIEdlbmVyYXRlUGFyYW1ldGVyc0NoZWNrCiAgICAgICAgICAgICB9CiAg ICAgICAgICAgICAkdmFsdWUgPSAiV1RGTW92ZSgkbmFtZSkiOwogICAgICAgICB9IGVsc2lmICgk cGFyYW1ldGVyLT5pc1ZhcmlhZGljKSB7CisgICAgICAgICAgICBBZGRWYXJpYWRpY1RvSW1wbElu Y2x1ZGVzKCR0eXBlLCAkZnVuY3Rpb24tPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57 IkNvbmRpdGlvbmFsIn0pOwogICAgICAgICAgICAgbXkgKCR3cmFwcGVyVHlwZSwgJHdyYXBwZWRU eXBlKSA9IEdldFZhcmlhZGljVHlwZSgkaW50ZXJmYWNlLCAkdHlwZSk7CiAgICAgICAgICAgICBw dXNoKEAkb3V0cHV0QXJyYXksICIgICAgYXV0byAkbmFtZSA9IHRvQXJndW1lbnRzPFZhcmlhZGlj SGVscGVyPCR3cmFwcGVyVHlwZSwgJHdyYXBwZWRUeXBlPj4oKnN0YXRlLCAkYXJndW1lbnRJbmRl eCk7XG4iKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90 ZXN0L0pTL0pTVGVzdE9iai5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rl c3QvSlMvSlNUZXN0T2JqLmNwcAppbmRleCA4ODE0NjY2ZGM0OWQ0YzE3NWJlMzNmYjM1ODU0OWVm NjBhZjg3MDBiLi43ZmE4YTU4YmJiNzlmOTk3NjNhOTY1MDVlZWI3YjJhODI5MmRjNjMzIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0T2Jq LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0 T2JqLmNwcApAQCAtMzEsNiArMzEsNyBAQAogI2luY2x1ZGUgIkV4Y2VwdGlvbkNvZGUuaCIKICNp bmNsdWRlICJGcmFtZS5oIgogI2luY2x1ZGUgIkhUTUxOYW1lcy5oIgorI2luY2x1ZGUgIkpTQmxv Yi5oIgogI2luY2x1ZGUgIkpTRE9NQmluZGluZy5oIgogI2luY2x1ZGUgIkpTRE9NQ29uc3RydWN0 b3IuaCIKICNpbmNsdWRlICJKU0RPTUNvbnZlcnQuaCIK 289222 2016-09-19 03:32:38 -0700 2016-09-19 05:33:05 -0700 Patch bug-150121-20160919122953.patch text/plain 3243 nael.ouedp U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2MDg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGZiZWE3ZGU2M2E1NmM2 MjdhNTM1MThjNzNmZjliMGFjYjc0MGI5Ny4uMTNmYTJjNzcxMDU3ZDQzY2U2ZTQ3Njc2ZDIzYjAz N2VmOTYyYzU0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTA5LTE5ICBOYWVs IE91ZWRyYW9nbyAgPG5hZWwub3VlZHJhb2dvQGNyZi5jYW5vbi5mcj4KKworICAgICAgICBJZiBh IGhvc3Qgb2JqZWN0IGlzIG9ubHkgdXNlZCBhcyBhIHZhcmlhZGljIGFyZ3VtZW50LCBpdHMgYmlu ZGluZ3MgaGVhZGVyIGlzbid0IHByb3Blcmx5IGluY2x1ZGVkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTAxMjEKKworICAgICAgICBSZXZpZXdlZCBi eSBZb3Vlbm4gRmFibGV0LgorCisgICAgICAgIE1vZGlmeSBKUyBiaW5kaW5nIGdlbmVyYXRvciB0 byBpbmNsdWRlIGJpbmRpbmcgaGVhZGVycyBvZiBvYmplY3RzIHBhc3NlZAorICAgICAgICBhcyB2 YXJpYWRpYyBhcmd1bWVudC4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vUlRDUGVl ckNvbm5lY3Rpb24uaDogUmVtb3ZlIHdvcmthcm91bmQuCisgICAgICAgICogYmluZGluZ3Mvc2Ny aXB0cy9Db2RlR2VuZXJhdG9ySlMucG06CisgICAgICAgIChBZGRWYXJpYWRpY1RvSW1wbEluY2x1 ZGVzKToKKyAgICAgICAgKEdlbmVyYXRlUGFyYW1ldGVyc0NoZWNrKToKKyAgICAgICAgKiBiaW5k aW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0T2JqLmNwcDoKKwogMjAxNi0wOS0xOCAgQWxleCBD aHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlbW92ZSB1 bm5lY2Vzc2FyeSBTdHJpbmcgYWxsb2NhdGlvbnMgaW4gVVJMUGFyc2VyCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmggYi9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmgKaW5k ZXggNGQ2MGFiMzIxMDYzNjdlNzU3ZmM1ZTQyNmZhZDMxZDM5Y2Q1MGEwOS4uNDJmYTM5MGVhNTRl YmQwZDFiODFhODM4NGUyZDdkNDYyYjE2NTc5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24uaApAQCAtMzgsOCArMzgs NyBAQAogI2luY2x1ZGUgIkFjdGl2ZURPTU9iamVjdC5oIgogI2luY2x1ZGUgIkRpY3Rpb25hcnku aCIKICNpbmNsdWRlICJFdmVudFRhcmdldC5oIgotLy8gRklYTUU6IFdvcmthcm91bmQgZm9yIGJp bmRpbmdzIGJ1ZyBodHRwOi8vd2Via2l0Lm9yZy9iLzE1MDEyMQotI2luY2x1ZGUgIkpTTWVkaWFT dHJlYW0uaCIKKyNpbmNsdWRlICJNZWRpYVN0cmVhbS5oIgogI2luY2x1ZGUgIlBlZXJDb25uZWN0 aW9uQmFja2VuZC5oIgogI2luY2x1ZGUgIlJUQ1J0cFRyYW5zY2VpdmVyLmgiCiAjaW5jbHVkZSAi U2NyaXB0V3JhcHBhYmxlLmgiCkBAIC00OCw3ICs0Nyw2IEBACiAKIG5hbWVzcGFjZSBXZWJDb3Jl IHsKIAotY2xhc3MgTWVkaWFTdHJlYW07CiBjbGFzcyBNZWRpYVN0cmVhbVRyYWNrOwogY2xhc3Mg UGVlckNvbm5lY3Rpb25CYWNrZW5kOwogY2xhc3MgUlRDQ29uZmlndXJhdGlvbjsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KaW5kZXgg Y2I4MWNhMDU5MTYwYWUxMDU4ZmI1ODVjYjQ0Y2ZhNmU0ZGZhMjJhMy4uNjZjYTlkYTRjNDZlMzk0 MGM0MjM0MzliZGEyOGEyZDA1YzhmYWEzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KQEAgLTQwMDIsNiArNDAwMiw3IEBAIHN1 YiBHZW5lcmF0ZVBhcmFtZXRlcnNDaGVjawogICAgICAgICAgICAgfQogICAgICAgICAgICAgJHZh bHVlID0gIldURk1vdmUoJG5hbWUpIjsKICAgICAgICAgfSBlbHNpZiAoJHBhcmFtZXRlci0+aXNW YXJpYWRpYykgeworICAgICAgICAgICAgQWRkVG9JbXBsSW5jbHVkZXMoIkpTJHt0eXBlfS5oIiwg JGZ1bmN0aW9uLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDb25kaXRpb25hbCJ9 KSB1bmxlc3MgJGNvZGVHZW5lcmF0b3ItPlNraXBJbmNsdWRlSGVhZGVyKCR0eXBlKSBvciAhJGNv ZGVHZW5lcmF0b3ItPklzV3JhcHBlclR5cGUoJHR5cGUpOwogICAgICAgICAgICAgbXkgKCR3cmFw cGVyVHlwZSwgJHdyYXBwZWRUeXBlKSA9IEdldFZhcmlhZGljVHlwZSgkaW50ZXJmYWNlLCAkdHlw ZSk7CiAgICAgICAgICAgICBwdXNoKEAkb3V0cHV0QXJyYXksICIgICAgYXV0byAkbmFtZSA9IHRv QXJndW1lbnRzPFZhcmlhZGljSGVscGVyPCR3cmFwcGVyVHlwZSwgJHdyYXBwZWRUeXBlPj4oKnN0 YXRlLCAkYXJndW1lbnRJbmRleCk7XG4iKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdE9iai5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0T2JqLmNwcAppbmRleCAxOWI0NWFlOGNlMGQ2 NmE2NjlkOWI1MTcwZjIwYzE0OTQ2MTUxODJmLi40NWYzNmU0NmIyNGJmYjJmY2E4ZDZhYWVlNjU4 YmExOTRhZmE4ZTFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L3Rlc3QvSlMvSlNUZXN0T2JqLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3Jp cHRzL3Rlc3QvSlMvSlNUZXN0T2JqLmNwcApAQCAtMzEsNiArMzEsNyBAQAogI2luY2x1ZGUgIkV4 Y2VwdGlvbkNvZGUuaCIKICNpbmNsdWRlICJGcmFtZS5oIgogI2luY2x1ZGUgIkhUTUxOYW1lcy5o IgorI2luY2x1ZGUgIkpTQmxvYi5oIgogI2luY2x1ZGUgIkpTRE9NQmluZGluZy5oIgogI2luY2x1 ZGUgIkpTRE9NQ29uc3RydWN0b3IuaCIKICNpbmNsdWRlICJKU0RPTUNvbnZlcnQuaCIK