150115 2015-10-13 23:03:34 -0700 [ES6] Class method should not declare any variables to upper scope. 2015-10-14 22:31:23 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki ysuzuki commit-queue fpizlo ggaren keith_miller mark.lam saam oldest_to_newest 1133048 0 ysuzuki 2015-10-13 23:03:34 -0700 In the following case, class A { method() { } } the current implementation attempt to declare the variable `method` to the lexical scope for the class `A`'s body. 1133049 1 ysuzuki 2015-10-13 23:04:02 -0700 Copied from https://bugs.webkit.org/show_bug.cgi?id=150089 Current Class expression implementation declares method names as a variable. For example, class A { method() { } } In the above case, we declare a variable `method` in the current implementation. I guess this is the old draft behavior because I can't see any step in the current spec. http://www.ecma-international.org/ecma-262/6.0/#sec-runtime-semantics-definemethod As a result, if we evaluate the following, class A { 1() { } } We attempt to declare the variable `1`. We now wrap the class body with the class lexical scope. However, the lexical scope does not allow us to declare incorrect Identifier variable (like `1`). So assertion is fired. 1133052 2 263060 ysuzuki 2015-10-13 23:10:32 -0700 Created attachment 263060 Patch 1133137 3 263060 ggaren 2015-10-14 09:37:30 -0700 Comment on attachment 263060 Patch r=me 1133394 4 263060 commit-queue 2015-10-14 22:31:20 -0700 Comment on attachment 263060 Patch Clearing flags on attachment: 263060 Committed r191086: <http://trac.webkit.org/changeset/191086> 1133395 5 commit-queue 2015-10-14 22:31:23 -0700 All reviewed patches have been landed. Closing bug. 263060 2015-10-13 23:10:32 -0700 2015-10-14 22:31:20 -0700 Patch bug-150115-20151014150953.patch text/plain 3832 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxMDMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj NzFlNTlhM2Y4NThhZWFiODdmYzcxNThlNzY0N2Y1OWQxZTA5YzA0Li45YjRhMjE3NjE1MzViNTdi Njk1MGU4YjM0ZDg1ZGI1YTVjMTBmYTY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyOCBAQAogMjAxNS0xMC0xMyAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KIAorICAgICAgICBbRVM2XSBDbGFzcyBtZXRob2Qgc2hvdWxkIG5vdCBkZWNsYXJlIGFu eSB2YXJpYWJsZXMgdG8gdXBwZXIgc2NvcGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTAxMTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJbiB0aGUgY3VycmVudCBpbXBsZW1lbnRhdGlvbiwgY2xhc3Mg bWV0aG9kcyBhdHRlbXB0IHRvIGRlY2xhcmUgdmFyaWFibGVzIHRvIGFuIHVwcGVyIHNjb3BlIHdp dGggdGhlaXIgbWV0aG9kIG5hbWVzLgorICAgICAgICBCdXQgdGhpcyBpcyBub3Qgc3BlY2lmaWVk IGJlaGF2aW9yIGluIHRoZSBFUzYgc3BlYy4KKworICAgICAgICBBbmQgYXMgYSByZXN1bHQsIHBy ZXZpb3VzbHksIHdlIGF0dGVtcHRlZCB0byBkZWNsYXJlIHZhcmlhYmxlcyB3aXRoIGludmFsaWQg aWRlbnRpZmllcnMuCisgICAgICAgIEZvciBleGFtcGxlLCBgY2xhc3MgQSB7IDEoKSB7IH0gfWAg YXR0ZW1wdCB0byBkZWNsYXJlIGEgdmFyaWFibGUgd2l0aCBuYW1lIGAxYC4KKyAgICAgICAgVGhp cyAoZGVjbGFyaW5nIHZhcmlhYmxlcyB3aXRoIGluY29ycmVjdCBuYW1lcykgaXMgbm90IGFsbG93 ZWQgaW4gdGhlIGxleGljYWwgZW52aXJvbm1lbnQuCisgICAgICAgIEFuZCBpdCBmaXJlcyBhc3Nl cnRpb25zIGluIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTAwODku CisKKyAgICAgICAgKiBwYXJzZXIvUGFyc2VyLmNwcDoKKyAgICAgICAgKEpTQzo6UGFyc2VyPExl eGVyVHlwZT46OnBhcnNlQ2xhc3MpOiBEZWxldGVkLgorICAgICAgICAqIHRlc3RzL3N0cmVzcy9j bGFzcy1tZXRob2QtZG9lcy1ub3QtZGVjbGFyZS12YXJpYWJsZS10by11cHBlci1zY29wZS5qczog QWRkZWQuCisgICAgICAgIChzaG91bGRCZSk6CisgICAgICAgIChBLnByb3RvdHlwZS5tZXRob2Qp OgorICAgICAgICAoQS5zdGF0aWNNZXRob2QpOgorICAgICAgICAoQSk6CisKKzIwMTUtMTAtMTMg IFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CisKICAgICAgICAgW0VTNl0g Q2xhc3MgZXhwcmVzc2lvbiBzaG91bGQgaGF2ZSBsZXhpY2FsIGVudmlyb25tZW50IHRoYXQgaGFz IGl0c2VsZiBhcyBhbiBpbXV0YWJsZSBiaW5kaW5nCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTAwODkKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNl ci9QYXJzZXIuY3BwCmluZGV4IGY2MzgwNWY1ZTc0NWI4ZDU3MGQ3ZWQxZjI0MzVlMWVjNWUzZDA4 ZDMuLmQ4NGRiMTc2NTNmMjI2MTA1NzkzYmM5ZGRhYzNlMDQwMmFiZmE3YmUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5jcHAKQEAgLTIwMTcsNyArMjAxNyw2IEBAIHN0YXRp YyBjb25zdCBjaGFyKiBzdHJpbmdGb3JGdW5jdGlvbk1vZGUoU291cmNlUGFyc2VNb2RlIG1vZGUp CiAgICAgICAgICAgICBQYXJzZXJGdW5jdGlvbkluZm88VHJlZUJ1aWxkZXI+IG1ldGhvZEluZm87 CiAgICAgICAgICAgICBib29sIGlzQ29uc3RydWN0b3IgPSAhaXNTdGF0aWNNZXRob2QgJiYgKmlk ZW50ID09IHByb3BlcnR5TmFtZXMuY29uc3RydWN0b3I7CiAgICAgICAgICAgICBmYWlsSWZGYWxz ZSgocGFyc2VGdW5jdGlvbkluZm8oY29udGV4dCwgRnVuY3Rpb25Ob1JlcXVpcmVtZW50cywgU291 cmNlUGFyc2VNb2RlOjpNZXRob2RNb2RlLCBmYWxzZSwgaXNDb25zdHJ1Y3RvciA/IGNvbnN0cnVj dG9yS2luZCA6IENvbnN0cnVjdG9yS2luZDo6Tm9uZSwgU3VwZXJCaW5kaW5nOjpOZWVkZWQsIG1l dGhvZFN0YXJ0LCBtZXRob2RJbmZvLCBTdGFuZGFyZEZ1bmN0aW9uUGFyc2VUeXBlKSksICJDYW5u b3QgcGFyc2UgdGhpcyBtZXRob2QiKTsKLSAgICAgICAgICAgIGZhaWxJZlRydWUoIWNvbXB1dGVk UHJvcGVydHlOYW1lICYmIChkZWNsYXJlVmFyaWFibGUoaWRlbnQpICYgRGVjbGFyYXRpb25SZXN1 bHQ6OkludmFsaWRTdHJpY3RNb2RlKSwgIkNhbm5vdCBkZWNsYXJlIGEgbWV0aG9kIG5hbWVkICci LCBtZXRob2RJbmZvLm5hbWUtPmltcGwoKSwgIiciKTsKICAgICAgICAgICAgIG1ldGhvZEluZm8u bmFtZSA9IGlzQ29uc3RydWN0b3IgPyBjbGFzc05hbWUgOiBpZGVudDsKIAogICAgICAgICAgICAg VHJlZUV4cHJlc3Npb24gbWV0aG9kID0gY29udGV4dC5jcmVhdGVGdW5jdGlvbkV4cHIobWV0aG9k TG9jYXRpb24sIG1ldGhvZEluZm8pOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3Rlc3RzL3N0cmVzcy9jbGFzcy1tZXRob2QtZG9lcy1ub3QtZGVjbGFyZS12YXJpYWJsZS10by11 cHBlci1zY29wZS5qcyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvY2xhc3Mt bWV0aG9kLWRvZXMtbm90LWRlY2xhcmUtdmFyaWFibGUtdG8tdXBwZXItc2NvcGUuanMKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uNWZjNmExYmI5ZGRmYWM0ZmE2ZmUzOWY3ZGY1NjJiNzBkZDAxOTRhNAotLS0gL2Rldi9u dWxsCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvY2xhc3MtbWV0aG9k LWRvZXMtbm90LWRlY2xhcmUtdmFyaWFibGUtdG8tdXBwZXItc2NvcGUuanMKQEAgLTAsMCArMSwy OSBAQAorZnVuY3Rpb24gc2hvdWxkQmUoYWN0dWFsLCBleHBlY3RlZCkgeworICAgIGlmIChhY3R1 YWwgIT09IGV4cGVjdGVkKQorICAgICAgICB0aHJvdyBuZXcgRXJyb3IoJ2JhZCB2YWx1ZTogJyAr IGFjdHVhbCk7Cit9CisKKy8vIFRoaXMgaXMgdGhlIG1pbmltaXplZCB0ZXN0IGNhc2UgZm9yIHRo ZSBjcmFzaC4KKy8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTAx MTUKKyhmdW5jdGlvbiAoKSB7CisgICAgZXZhbCgiY2xhc3MgQSB7IHN0YXRpYyAxKCkgeyByZXR1 cm4gNDA1IH0gfTsiKTsKK30oKSk7CisKKyhmdW5jdGlvbiAoKSB7CisgICAgY2xhc3MgQSB7Cisg ICAgICAgIG1ldGhvZCgpIHsKKyAgICAgICAgICAgIHNob3VsZEJlKHR5cGVvZiBzdGF0aWNNZXRo b2QsICd1bmRlZmluZWQnKTsKKyAgICAgICAgfQorCisgICAgICAgIHN0YXRpYyBzdGF0aWNNZXRo b2QoKSB7CisgICAgICAgICAgICBzaG91bGRCZSh0eXBlb2YgbWV0aG9kLCAndW5kZWZpbmVkJyk7 CisgICAgICAgIH0KKyAgICB9CisKKyAgICBzaG91bGRCZSh0eXBlb2YgbWV0aG9kLCAndW5kZWZp bmVkJyk7CisgICAgc2hvdWxkQmUodHlwZW9mIHN0YXRpY01ldGhvZCwgJ3VuZGVmaW5lZCcpOwor CisgICAgbGV0IGEgPSBuZXcgQSgpOworICAgIGEubWV0aG9kKCk7CisgICAgQS5zdGF0aWNNZXRo b2QoKTsKK30oKSk7Cg==