150107 2015-10-13 16:48:30 -0700 User the correct notification strings for view service applications state change. 2015-10-13 17:27:17 -0700 1 1 1 Unclassified WebKit WebKit2 Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yongjun_zhang webkit-unassigned andersca barraclough commit-queue mitz sam yongjun_zhang oldest_to_newest 1132969 0 yongjun_zhang 2015-10-13 16:48:30 -0700 We should use the correct notification strings for view service app state changes. 1132971 1 yongjun_zhang 2015-10-13 16:49:00 -0700 rdar://problem/23020256 1132983 2 263041 yongjun_zhang 2015-10-13 17:11:40 -0700 Created attachment 263041 Patch. 1132986 3 commit-queue 2015-10-13 17:14:28 -0700 Attachment 263041 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:130: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/ApplicationStateTracker.mm:133: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1132992 4 barraclough 2015-10-13 17:27:17 -0700 Fixed in r191022 http://trac.webkit.org/changeset/191022 263041 2015-10-13 17:11:40 -0700 2015-10-13 17:23:10 -0700 Patch. svc_assertions.patch text/plain 2651 yongjun_zhang Y29tbWl0IGZhZmYzZTEzOGFkNDVjYzdhNTdiOWNkNDMwMDlhZDBlOWI0MWNlNzEKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBUdWUgT2N0IDEz IDE3OjA2OjQ0IDIwMTUgLTA3MDAKCiAgICBVc2UgdGhlIGNvcnJlY3Qgbm90aWZpY2F0aW9uIHN0 cmluZ3MgZm9yIHZpZXcgc2VydmljZSBhcHBsaWNhdGlvbnMgc3RhdGUgY2hhbmdlLgoKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZwppbmRleCBjMmY5YTE0Li5hYTgyOGExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFu Z2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIw MTUtMTAtMTMgIFlvbmdqdW4gWmhhbmcgIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KKworICAg ICAgICBVc2UgdGhlIGNvcnJlY3Qgbm90aWZpY2F0aW9uIHN0cmluZ3MgZm9yIHZpZXcgc2Vydmlj ZSBhcHBsaWNhdGlvbnMgc3RhdGUgY2hhbmdlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwMTA3CisKKyAgICAgICAgVXNlIHRoZSBjb3JyZWN0IG5v dGlmaWNhdGlvbiBuYW1lcyAiX1VJVmlld1NlcnZpY2VIb3N0RGlkRW50ZXJCYWNrZ3JvdW5kTm90 aWZpY2F0aW9uIiBhbmQKKyAgICAgICAgIl9VSVZpZXdTZXJ2aWNlSG9zdFdpbGxFbnRlckZvcmVn cm91bmROb3RpZmljYXRpb24iIHRvIGxpc3RlbiB0byB2aWV3IHNlcnZpY2UgYXBwbGljYXRpb24g c3RhdGUgY2hhbmdlcy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9BcHBsaWNhdGlvblN0YXRlVHJhY2tlci5tbToKKyAgICAgICAg KFdlYktpdDo6QXBwbGljYXRpb25TdGF0ZVRyYWNrZXI6OkFwcGxpY2F0aW9uU3RhdGVUcmFja2Vy KToKKwogMjAxNS0xMC0xMyAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29t PgogCiAgICAgICAgIFNwbGl0IFR5cGVzZXR0aW5nRmVhdHVyZXMgaW50byBrZXJuaW5nIGFuZCBs aWdhdHVyZXMgYm9vbHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BcHBs aWNhdGlvblN0YXRlVHJhY2tlci5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BcHBsaWNh dGlvblN0YXRlVHJhY2tlci5tbQppbmRleCBlMTMzNTU0Li44YmU1YmUyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQXBwbGljYXRpb25TdGF0ZVRyYWNrZXIubW0KKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FwcGxpY2F0aW9uU3RhdGVUcmFja2VyLm1tCkBAIC0x MjcsMTEgKzEyNywxMCBAQCBBcHBsaWNhdGlvblN0YXRlVHJhY2tlcjo6QXBwbGljYXRpb25TdGF0 ZVRyYWNrZXIoV0tDb250ZW50VmlldyAqdmlldywgU0VMIGRpZEVudAogICAgICAgICBtX2lzSW5C YWNrZ3JvdW5kID0gaXNCYWNrZ3JvdW5kU3RhdGUoW21fYXBwbGljYXRpb25TdGF0ZU1vbml0b3Ig bW9zdEVsZXZhdGVkQXBwbGljYXRpb25TdGF0ZUZvclBJRDphcHBsaWNhdGlvblBJRF0pOwogCiAg ICAgICAgIE5TTm90aWZpY2F0aW9uQ2VudGVyICpub3RpZmljYXRpb25DZW50ZXIgPSBbTlNOb3Rp ZmljYXRpb25DZW50ZXIgZGVmYXVsdENlbnRlcl07Ci0gICAgICAgIG1fZGlkRW50ZXJCYWNrZ3Jv dW5kT2JzZXJ2ZXIgPSBbbm90aWZpY2F0aW9uQ2VudGVyIGFkZE9ic2VydmVyRm9yTmFtZTpAIl9V SVZpZXdTZXJ2aWNlSG9zdERpZEVudGVyQmFja2dyb3VuZE5vdGlmaWNhdGlvbk5hbWUiIG9iamVj dDpzZXJ2aWNlVmlld0NvbnRyb2xsZXIgcXVldWU6bmlsIHVzaW5nQmxvY2s6W3RoaXNdKE5TTm90 aWZpY2F0aW9uICopIHsKKyAgICAgICAgbV9kaWRFbnRlckJhY2tncm91bmRPYnNlcnZlciA9IFtu b3RpZmljYXRpb25DZW50ZXIgYWRkT2JzZXJ2ZXJGb3JOYW1lOkAiX1VJVmlld1NlcnZpY2VIb3N0 RGlkRW50ZXJCYWNrZ3JvdW5kTm90aWZpY2F0aW9uIiBvYmplY3Q6c2VydmljZVZpZXdDb250cm9s bGVyIHF1ZXVlOm5pbCB1c2luZ0Jsb2NrOlt0aGlzXShOU05vdGlmaWNhdGlvbiAqKSB7CiAgICAg ICAgICAgICBhcHBsaWNhdGlvbkRpZEVudGVyQmFja2dyb3VuZCgpOwogICAgICAgICB9XTsKLQot ICAgICAgICBtX3dpbGxFbnRlckZvcmVncm91bmRPYnNlcnZlciA9IFtub3RpZmljYXRpb25DZW50 ZXIgYWRkT2JzZXJ2ZXJGb3JOYW1lOkAiX1VJVmlld1NlcnZpY2VIb3N0V2lsbEVudGVyRm9yZWdy b3VuZE5vdGlmaWNhdGlvbk5hbWUiIG9iamVjdDpzZXJ2aWNlVmlld0NvbnRyb2xsZXIgcXVldWU6 bmlsIHVzaW5nQmxvY2s6W3RoaXNdKE5TTm90aWZpY2F0aW9uICopIHsKKyAgICAgICAgbV93aWxs RW50ZXJGb3JlZ3JvdW5kT2JzZXJ2ZXIgPSBbbm90aWZpY2F0aW9uQ2VudGVyIGFkZE9ic2VydmVy Rm9yTmFtZTpAIl9VSVZpZXdTZXJ2aWNlSG9zdFdpbGxFbnRlckZvcmVncm91bmROb3RpZmljYXRp b24iIG9iamVjdDpzZXJ2aWNlVmlld0NvbnRyb2xsZXIgcXVldWU6bmlsIHVzaW5nQmxvY2s6W3Ro aXNdKE5TTm90aWZpY2F0aW9uICopIHsKICAgICAgICAgICAgIGFwcGxpY2F0aW9uV2lsbEVudGVy Rm9yZWdyb3VuZCgpOwogICAgICAgICB9XTsKIAo=