150103 2015-10-13 15:34:21 -0700 [Win] Generate Crash Traces 2015-10-13 17:16:10 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bfulgham bfulgham ap bfulgham commit-queue dbates glenn lforschler oldest_to_newest 1132937 0 bfulgham 2015-10-13 15:34:21 -0700 The test system has not been reliably generating crash traces on Windows. This seems to have started some time ago, and seems to be related to some bugs in the Python code as well as changes in the way MSVC deals with termination handlers. This patch updates the test infrastructure so that we get crash traces more reliably. 1132941 1 263030 bfulgham 2015-10-13 15:43:36 -0700 Created attachment 263030 Patch 1132968 2 263030 dbates 2015-10-13 16:43:45 -0700 Comment on attachment 263030 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263030&action=review > Tools/ChangeLog:19 > + (CrashLogs): Add another REGEX to handle a second crash trace syntax I Nit: REGEX => regex or regular expression > Tools/ChangeLog:21 > + (CrashLogs._find_newest_log_win): If the old REGEX doesn't match, try Ditto. > Tools/ChangeLog:22 > + the new one. The new REGEX finds a PID in HEX, so convert to integer. Nit: REGEX => regex or regular expression Nit: "in HEX" => "given as hexadecimal number" > Tools/Scripts/webkitpy/common/system/crashlogs.py:37 > + PID_LINE_REGEX2 = re.compile(r'Exit process \d+:(?P<pid>\w+), code') This is OK as-is. Maybe a better name for PID_LINE_REGEX2 would be EXIT_PROCESS_PID_REGEX? We may also want to consider coming up with a better name for PID_LINE_REGEX. Maybe GLOBAL_PID_REGEX? We may want to consider strengthening this regular expression to only accept ASCII hex digits for the PID instead of \w+. 1132972 3 263030 bfulgham 2015-10-13 16:51:37 -0700 Comment on attachment 263030 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263030&action=review >> Tools/ChangeLog:19 >> + (CrashLogs): Add another REGEX to handle a second crash trace syntax I > > Nit: REGEX => regex or regular expression Will fix. >> Tools/ChangeLog:21 >> + (CrashLogs._find_newest_log_win): If the old REGEX doesn't match, try > > Ditto. Will fix. >> Tools/ChangeLog:22 >> + the new one. The new REGEX finds a PID in HEX, so convert to integer. > > Nit: REGEX => regex or regular expression > Nit: "in HEX" => "given as hexadecimal number" Will fix. >> Tools/Scripts/webkitpy/common/system/crashlogs.py:37 >> + PID_LINE_REGEX2 = re.compile(r'Exit process \d+:(?P<pid>\w+), code') > > This is OK as-is. Maybe a better name for PID_LINE_REGEX2 would be EXIT_PROCESS_PID_REGEX? We may also want to consider coming up with a better name for PID_LINE_REGEX. Maybe GLOBAL_PID_REGEX? > > We may want to consider strengthening this regular expression to only accept ASCII hex digits for the PID instead of \w+. I agree about the name changes, and will do so. I'll use GLOBAL_PID_REGEX and EXIT_PROCESS_PID_REGEX. 1132988 4 bfulgham 2015-10-13 17:16:10 -0700 Committed r191018: <http://trac.webkit.org/changeset/191018> 263030 2015-10-13 15:43:36 -0700 2015-10-13 16:43:45 -0700 Patch bug-150103-20151013160020.patch text/plain 6265 bfulgham SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5MTAxMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDMzIEBACisyMDE1LTEwLTEzICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29t PgorCisgICAgICAgIFtXaW5dIEdlbmVyYXRlIENyYXNoIFRyYWNlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwMTAzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ugd2VyZSB1c2luZyBhbiBleGNlcHRp b24gZmlsdGVyIHRvIHRyeSB0byBlbWl0ICIjQ1JBU0hFRCIgdG8gc3RkZXJyCisgICAgICAgIHdo ZW4gYSB0ZXN0IHByb2dyYW0gY3Jhc2hlZC4gSG93ZXZlciwgdGhlIG1vZGVybiBQeXRob24gaW1w bGVtZW50YXRpb24KKyAgICAgICAgc2VlbXMgY2FwYWJsZSBvZiByZWNvZ25pemluZyBjcmFzaGVz IG9uIGl0cyBvd24uIEZ1cnRoZXJtb3JlLCByZWdpc3RlcmluZworICAgICAgICB0aGUgZXhjZXB0 aW9uIGhhbmRsZXIgd2FzIHByZXZlbnRpbmcgdGhlIEpJVCBkZWJ1Z2dlciAoTlRTRCkgZnJvbQor ICAgICAgICBhdXRvbWF0aWNhbGx5IGF0dGFjaGluZyB0byB0aGUgY3Jhc2hpbmcgcHJvZ3JhbSwg c28gd2Ugd2VyZSBub3QgZ2V0dGluZworICAgICAgICBjcmFzaCB0cmFjZXMuCisgICAgICAgIAor ICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVuZGVyVHJlZS5jcHA6CisgICAgICAg IChtYWluKTogRG9uJ3QgcmVnaXN0ZXIgYW4gZXhjZXB0aW9uIGZpbHRlci4KKyAgICAgICAgKGV4 Y2VwdGlvbkZpbHRlcik6IERlbGV0ZWQuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21t b24vc3lzdGVtL2NyYXNobG9ncy5weToKKyAgICAgICAgKENyYXNoTG9ncyk6IEFkZCBhbm90aGVy IFJFR0VYIHRvIGhhbmRsZSBhIHNlY29uZCBjcmFzaCB0cmFjZSBzeW50YXggSQorICAgICAgICBl bmNvdW50ZXJlZCBkdXJpbmcgdGVzdGluZy4KKyAgICAgICAgKENyYXNoTG9ncy5fZmluZF9uZXdl c3RfbG9nX3dpbik6IElmIHRoZSBvbGQgUkVHRVggZG9lc24ndCBtYXRjaCwgdHJ5CisgICAgICAg IHRoZSBuZXcgb25lLiBUaGUgbmV3IFJFR0VYIGZpbmRzIGEgUElEIGluIEhFWCwgc28gY29udmVy dCB0byBpbnRlZ2VyLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9kcml2ZXIucHk6 CisgICAgICAgIChEcml2ZXIuX2NoZWNrX2Zvcl9kcml2ZXJfY3Jhc2hfb3JfdW5yZXNwb25zaXZl bmVzcyk6IFdpbmRvd3Mgd2FzIG5vdCByZWNvZ25pemluZworICAgICAgICB0aGUgIiNDUkFTSEVE IiBzdGF0ZSBiZWNhdXNlIGl0IHdhcyBhcHBlbmRpbmcgJ1xyXG4nLCByYXRoZXIgdGhhbiBqdXN0 ICdccicuIEluc3RlYWQsCisgICAgICAgIGNoZWNrIGZvciAiI0NSQVNIRUQiIGFmdGVyIHN0cmlw cGluZyBvZmYgdGhlIEVPTCBjaGFyYWN0ZXJzLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkv cG9ydC93aW4ucHk6CisgICAgICAgIChXaW5Qb3J0LnNldHVwX2NyYXNoX2xvZ19zYXZpbmcpOiBQ dXQgYmFjayB0aGUgJy1lICVsZCcgZmxhZyBpbiB0aGUgZGVidWdnZXIKKyAgICAgICAgaW52b2Nh dGlvbi4gVGhpcyBpcyBhcHBhcmVudGx5IHVzZWQgdG8gc2lnbmFsIGFuIGV2ZW50IHdoZW4gdGhl IGRlYnVnZ2VyIGlzIGZpbmlzaGVkLgorCiAyMDE1LTEwLTEzICBBbGV4ZXkgUHJvc2t1cnlha292 ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIE1hYyBEZWJ1ZyBhbmQgMzItYml0IHF1ZXVlcyBz aG91bGQgYmUgc2VwYXJhdGUKSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9EdW1wUmVu ZGVyVHJlZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvd2luL0R1bXBS ZW5kZXJUcmVlLmNwcAkocmV2aXNpb24gMTkwODgxKQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUv d2luL0R1bXBSZW5kZXJUcmVlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTI5NywxMyArMTI5Nyw2 IEBAIFJldGFpblB0cjxDRlVSTENhY2hlUmVmPiBzaGFyZWRDRlVSTENhY2gKIH0KICNlbmRpZgog Ci1zdGF0aWMgTE9ORyBXSU5BUEkgZXhjZXB0aW9uRmlsdGVyKEVYQ0VQVElPTl9QT0lOVEVSUyop Ci17Ci0gICAgZnB1dHMoIiNDUkFTSEVEXG4iLCBzdGRlcnIpOwotICAgIGZmbHVzaChzdGRlcnIp OwotICAgIHJldHVybiBFWENFUFRJT05fQ09OVElOVUVfU0VBUkNIOwotfQotCiBzdGF0aWMgVmVj dG9yPGNvbnN0IGNoYXIqPiBpbml0aWFsaXplR2xvYmFsc0Zyb21Db21tYW5kTGluZU9wdGlvbnMo aW50IGFyZ2MsIGNvbnN0IGNoYXIqIGFyZ3ZbXSkKIHsKICAgICBWZWN0b3I8Y29uc3QgY2hhcio+ IHRlc3RzOwpAQCAtMTQxNCw4ICsxNDA3LDYgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNvbnN0IGNo YXIqIGFyZ3ZbXSkKICAgICAvLyBlcnJvciBtb2RlIGhlcmUgdG8gd29yayBhcm91bmQgQ3lnd2lu J3MgYmVoYXZpb3IuIFNlZSA8aHR0cDovL3dlYmtpdC5vcmcvYi81NTIyMj4uCiAgICAgOjpTZXRF cnJvck1vZGUoMCk7CiAKLSAgICA6OlNldFVuaGFuZGxlZEV4Y2VwdGlvbkZpbHRlcihleGNlcHRp b25GaWx0ZXIpOwotCiAgICAgbGVha0NoZWNraW5nID0gZmFsc2U7CiAKICAgICBfc2V0bW9kZSgx LCBfT19CSU5BUlkpOwpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVt L2NyYXNobG9ncy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1v bi9zeXN0ZW0vY3Jhc2hsb2dzLnB5CShyZXZpc2lvbiAxOTA4ODEpCisrKyBUb29scy9TY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vY3Jhc2hsb2dzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0x LDQgKzEsNSBAQAogIyBDb3B5cmlnaHQgKGMpIDIwMTEsIEdvb2dsZSBJbmMuIEFsbCByaWdodHMg cmVzZXJ2ZWQuCisjIENvcHlyaWdodCAoYykgMjAxNSwgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJl c2VydmVkLgogIwogIyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5 IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHBy b3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQpAQCAtMzMsNiArMzQsNyBA QCBpbXBvcnQgcmUKIGNsYXNzIENyYXNoTG9ncyhvYmplY3QpOgogCiAgICAgUElEX0xJTkVfUkVH RVggPSByZS5jb21waWxlKHInXHMrR2xvYmFsXHMrUElEOlxzK1xbKD9QPHBpZD5cZCspXF0nKQor ICAgIFBJRF9MSU5FX1JFR0VYMiA9IHJlLmNvbXBpbGUocidFeGl0IHByb2Nlc3MgXGQrOig/UDxw aWQ+XHcrKSwgY29kZScpCiAKICAgICBkZWYgX19pbml0X18oc2VsZiwgaG9zdCwgcmVzdWx0c19k aXJlY3Rvcnk9Tm9uZSk6CiAgICAgICAgIHNlbGYuX2hvc3QgPSBob3N0CkBAIC05MSw5ICs5Mywx NCBAQCBjbGFzcyBDcmFzaExvZ3Mob2JqZWN0KToKICAgICAgICAgICAgICAgICBpZiBub3QgbmV3 ZXJfdGhhbiBvciBzZWxmLl9ob3N0LmZpbGVzeXN0ZW0ubXRpbWUocGF0aCkgPiBuZXdlcl90aGFu OgogICAgICAgICAgICAgICAgICAgICBsb2dfZmlsZSA9IHNlbGYuX2hvc3QuZmlsZXN5c3RlbS5y ZWFkX2JpbmFyeV9maWxlKHBhdGgpLmRlY29kZSgnYXNjaWknLCAnaWdub3JlJykKICAgICAgICAg ICAgICAgICAgICAgbWF0Y2ggPSBzZWxmLlBJRF9MSU5FX1JFR0VYLnNlYXJjaChsb2dfZmlsZSkK KyAgICAgICAgICAgICAgICAgICAgaWYgbWF0Y2g6CisgICAgICAgICAgICAgICAgICAgICAgICBp ZiBpbnQobWF0Y2guZ3JvdXAoJ3BpZCcpKSA9PSBwaWQ6CisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgcmV0dXJuIGVycm9ycyArIGxvZ19maWxlCisgICAgICAgICAgICAgICAgICAgIG1hdGNo ID0gc2VsZi5QSURfTElORV9SRUdFWDIuc2VhcmNoKGxvZ19maWxlKQogICAgICAgICAgICAgICAg ICAgICBpZiBtYXRjaCBpcyBOb25lOgogICAgICAgICAgICAgICAgICAgICAgICAgY29udGludWUK LSAgICAgICAgICAgICAgICAgICAgaWYgaW50KG1hdGNoLmdyb3VwKCdwaWQnKSkgPT0gcGlkOgor ICAgICAgICAgICAgICAgICAgICAjIE5vdGU6IFRoaXMgb3V0cHV0IGNvbWVzIGZyb20gYSBwcm9n cmFtIHRoYXQgc2hvd3MgUElEIGluIGhleDoKKyAgICAgICAgICAgICAgICAgICAgaWYgaW50KG1h dGNoLmdyb3VwKCdwaWQnKSwgMTYpID09IHBpZDoKICAgICAgICAgICAgICAgICAgICAgICAgIHJl dHVybiBlcnJvcnMgKyBsb2dfZmlsZQogICAgICAgICAgICAgZXhjZXB0IElPRXJyb3IsIGU6CiAg ICAgICAgICAgICAgICAgcHJpbnQgIklPRXJyb3IgJXMiICUgc3RyKGUpCkluZGV4OiBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3BvcnQvZHJpdmVyLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvcG9ydC9kcml2ZXIucHkJKHJldmlzaW9uIDE5MDg4MSkKKysrIFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvcG9ydC9kcml2ZXIucHkJKHdvcmtpbmcgY29weSkKQEAgLTEsNCArMSw1 IEBACiAjIENvcHlyaWdodCAoQykgMjAxMSBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVk LgorIyBDb3B5cmlnaHQgKGMpIDIwMTUsIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4K ICMKICMgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywg d2l0aCBvciB3aXRob3V0CiAjIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0 aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKQEAgLTM5OSw3ICs0MDAsOCBAQCBjbGFz cyBEcml2ZXIob2JqZWN0KToKICAgICAgICAgICAgIHJldHVybiBUcnVlCiAKICAgICBkZWYgX2No ZWNrX2Zvcl9kcml2ZXJfY3Jhc2hfb3JfdW5yZXNwb25zaXZlbmVzcyhzZWxmLCBlcnJvcl9saW5l KToKLSAgICAgICAgaWYgZXJyb3JfbGluZSA9PSAiI0NSQVNIRURcbiI6CisgICAgICAgIGNyYXNo ZWRfY2hlY2sgPSBlcnJvcl9saW5lLnJzdHJpcCgnXHJcbicpCisgICAgICAgIGlmIGNyYXNoZWRf Y2hlY2sgPT0gIiNDUkFTSEVEIjoKICAgICAgICAgICAgIHNlbGYuX2NyYXNoZWRfcHJvY2Vzc19u YW1lID0gc2VsZi5fc2VydmVyX3Byb2Nlc3MubmFtZSgpCiAgICAgICAgICAgICBzZWxmLl9jcmFz aGVkX3BpZCA9IHNlbGYuX3NlcnZlcl9wcm9jZXNzLnBpZCgpCiAgICAgICAgICAgICByZXR1cm4g VHJ1ZQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3dpbi5weQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvd2luLnB5CShyZXZpc2lvbiAxOTA4ODEp CisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvd2luLnB5CSh3b3JraW5nIGNvcHkpCkBA IC0yNDUsNyArMjQ1LDcgQEAgY2xhc3MgV2luUG9ydChBcHBsZVBvcnQpOgogICAgICAgICBjb21t YW5kX2ZpbGUgPSBzZWxmLmNyZWF0ZV9kZWJ1Z2dlcl9jb21tYW5kX2ZpbGUoKQogICAgICAgICBp ZiBub3QgY29tbWFuZF9maWxlOgogICAgICAgICAgICAgcmV0dXJuIE5vbmUKLSAgICAgICAgZGVi dWdnZXJfb3B0aW9ucyA9ICciezB9IiAtcCAlbGQgLWcgLW5vaW8gLWxpbmVzIC1jZiAiezF9Iicu Zm9ybWF0KGN5Z3BhdGgobnRzZF9wYXRoKSwgY3lncGF0aChjb21tYW5kX2ZpbGUpKQorICAgICAg ICBkZWJ1Z2dlcl9vcHRpb25zID0gJyJ7MH0iIC1wICVsZCAtZSAlbGQgLWcgLW5vaW8gLWxpbmVz IC1jZiAiezF9IicuZm9ybWF0KGN5Z3BhdGgobnRzZF9wYXRoKSwgY3lncGF0aChjb21tYW5kX2Zp bGUpKQogICAgICAgICByZWdpc3RyeV9zZXR0aW5ncyA9IHsnRGVidWdnZXInOiBkZWJ1Z2dlcl9v cHRpb25zLCAnQXV0byc6ICIxIn0KICAgICAgICAgZm9yIGtleSBpbiByZWdpc3RyeV9zZXR0aW5n czoKICAgICAgICAgICAgIGZvciBhcmNoIGluIFsiLS13b3czMiIsICItLXdvdzY0Il06Cg==