150070 2015-10-12 18:17:36 -0700 ASSERT(m_motionManager) on emgn.com page 2015-10-13 14:49:45 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino oldest_to_newest 1132619 0 dino 2015-10-12 18:17:36 -0700 ASSERT(m_motionManager) on emgn.com page 1132621 1 dino 2015-10-12 18:21:19 -0700 <rdar://problem/18383732> 1132622 2 262949 dino 2015-10-12 18:22:49 -0700 Created attachment 262949 Patch 1132625 3 262949 simon.fraser 2015-10-12 18:25:01 -0700 Comment on attachment 262949 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262949&action=review > Source/WebCore/platform/ios/WebCoreMotionManager.mm:79 > + m_initialized = NO; No need for this; Objective-C ivars get initialized to 0 by default. 1132915 4 dino 2015-10-13 14:49:45 -0700 Committed r191007: <http://trac.webkit.org/changeset/191007> 262949 2015-10-12 18:22:49 -0700 2015-10-12 18:25:01 -0700 Patch bug-150070-20151013122212.patch text/plain 3967 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwODkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTExZGQ0YmIyMzgwZDE5 MTYwYzAyYjM3MjMxMTY3MzcxODU4NmQ1ZS4uMzJjOTVmMmE1MjdiMjM1MzQ2ZDRhNDU4ODlmY2Rm NTk4ZTUwMjQ0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDE1LTEwLTEyICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBBU1NFUlQobV9tb3Rpb25NYW5h Z2VyKSBvbiBlbWduLmNvbSBwYWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTAwNzAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE4MzgzNzMyPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHRoZSBX ZWJDb3JlTW90aW9uTWFuYWdlciBpbml0IG1ldGhvZCwgd2UgY2FsbAorICAgICAgICBpbnRvIGFu b3RoZXIgc2V0dXAgbWV0aG9kIG9uIHRoZSBtYWluIHRocmVhZC4KKyAgICAgICAgSG93ZXZlciwg aWYgYSBsaXN0ZW5lciB3YXMgYXR0YWNoZWQgYmVmb3JlIHRoYXQKKyAgICAgICAgcmFuLCB3ZSdk IEFTU0VSVC4gVGhpcyB3YXNuJ3QgYWN0dWFsbHkgY2F1c2luZyBhIGJ1ZworICAgICAgICBiZWNh dXNlIHRoZSBtYWluIHRocmVhZCBpbml0aWFsaXphdGlvbiB3b3VsZAorICAgICAgICBjaGVjayB0 aGUgbGlzdGVuZXJzIG9uY2UgaXQgZ290IGEgY2hhbmNlIHRvIHJ1bi4KKworICAgICAgICBUaGUg Zml4IGlzIHRvIG9ubHkgY2hlY2sgc3RhdHVzIHdoZW4gd2UndmUKKyAgICAgICAgYWN0dWFsbHkg aW5pdGlhbGl6ZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3MvV2ViQ29yZU1vdGlvbk1hbmFn ZXIuaDogTmV3IG1faW5pdGlhbGl6ZWQgYm9vbGVhbi4KKyAgICAgICAgKiBwbGF0Zm9ybS9pb3Mv V2ViQ29yZU1vdGlvbk1hbmFnZXIubW06IENoZWNrIG1faW5pdGlhbGl6ZWQgYmVmb3JlIGRvaW5n IHJlYWwgd29yay4KKyAgICAgICAgKC1bV2ViQ29yZU1vdGlvbk1hbmFnZXIgaW5pdF0pOgorICAg ICAgICAoLVtXZWJDb3JlTW90aW9uTWFuYWdlciBhZGRNb3Rpb25DbGllbnQ6XSk6CisgICAgICAg ICgtW1dlYkNvcmVNb3Rpb25NYW5hZ2VyIHJlbW92ZU1vdGlvbkNsaWVudDpdKToKKyAgICAgICAg KC1bV2ViQ29yZU1vdGlvbk1hbmFnZXIgYWRkT3JpZW50YXRpb25DbGllbnQ6XSk6CisgICAgICAg ICgtW1dlYkNvcmVNb3Rpb25NYW5hZ2VyIHJlbW92ZU9yaWVudGF0aW9uQ2xpZW50Ol0pOgorICAg ICAgICAoLVtXZWJDb3JlTW90aW9uTWFuYWdlciBpbml0aWFsaXplT25NYWluVGhyZWFkXSk6CisK IDIwMTUtMTAtMTIgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAog ICAgICAgICBSRUdSRVNTSU9OKHIxODIxOTIpOiBMaWdhdHVyZXMgZG8gbm90IGludGVyYWN0IGNv cnJlY3RseSB3aXRoIFNIWSBpbiBzb21lIGZvbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9pb3MvV2ViQ29yZU1vdGlvbk1hbmFnZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2lvcy9XZWJDb3JlTW90aW9uTWFuYWdlci5oCmluZGV4IDIwMDIxMzNiYmY2ODNkZDA0 MTJlMDIxYTBmZThmNDMzNDgyYTQ0YTAuLjliOWZhZWFmNTAzNmQzN2M2MDcyZmFkYzQ3ZTU4MWZh YWM2NTNiYTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJDb3Jl TW90aW9uTWFuYWdlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJDb3Jl TW90aW9uTWFuYWdlci5oCkBAIC00NSw2ICs0NSw3IEBAIGNvbnN0IGZsb2F0IGtNb3Rpb25VcGRh dGVJbnRlcnZhbCA9IDEuMGYgLyA2MC4wZjsKICAgICBOU1RpbWVyKiBtX3VwZGF0ZVRpbWVyOwog ICAgIEJPT0wgbV9neXJvQXZhaWxhYmxlOwogICAgIEJPT0wgbV9oZWFkaW5nQXZhaWxhYmxlOwor ICAgIEJPT0wgbV9pbml0aWFsaXplZDsKIH0KIAogKyAoV2ViQ29yZU1vdGlvbk1hbmFnZXIgKilz aGFyZWRNYW5hZ2VyOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dl YkNvcmVNb3Rpb25NYW5hZ2VyLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYkNv cmVNb3Rpb25NYW5hZ2VyLm1tCmluZGV4IDUxNDRlYWYyNzY3NjhjM2ZlMTM1MTVmNWQ3NDBmMzEw ZDY0MzhiZWYuLjE3ZTI3MDE4ZTUyM2YxMThjYTkxZmFlYTk2NTBkMTIzNTQzZmUxYzggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJDb3JlTW90aW9uTWFuYWdlci5t bQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViQ29yZU1vdGlvbk1hbmFnZXIu bW0KQEAgLTc1LDggKzc1LDExIEBAIHN0YXRpYyBjb25zdCBkb3VibGUga0dyYXZpdHkgPSA5Ljgw NjY1OwogLSAoaWQpaW5pdAogewogICAgIHNlbGYgPSBbc3VwZXIgaW5pdF07Ci0gICAgaWYgKHNl bGYpCisgICAgaWYgKHNlbGYpIHsKKyAgICAgICAgbV9pbml0aWFsaXplZCA9IE5POwogICAgICAg ICBbc2VsZiBwZXJmb3JtU2VsZWN0b3JPbk1haW5UaHJlYWQ6QHNlbGVjdG9yKGluaXRpYWxpemVP bk1haW5UaHJlYWQpIHdpdGhPYmplY3Q6bmlsIHdhaXRVbnRpbERvbmU6Tk9dOworICAgIH0KKwog ICAgIHJldHVybiBzZWxmOwogfQogCkBAIC0xMDMsMjUgKzEwNiwyOSBAQCBzdGF0aWMgY29uc3Qg ZG91YmxlIGtHcmF2aXR5ID0gOS44MDY2NTsKIC0gKHZvaWQpYWRkTW90aW9uQ2xpZW50OihXZWJD b3JlOjpEZXZpY2VNb3Rpb25DbGllbnRJT1MgKiljbGllbnQKIHsKICAgICBtX2RldmljZU1vdGlv bkNsaWVudHMuYWRkKGNsaWVudCk7Ci0gICAgW3NlbGYgY2hlY2tDbGllbnRTdGF0dXNdOworICAg IGlmIChtX2luaXRpYWxpemVkKQorICAgICAgICBbc2VsZiBjaGVja0NsaWVudFN0YXR1c107CiB9 CiAKIC0gKHZvaWQpcmVtb3ZlTW90aW9uQ2xpZW50OihXZWJDb3JlOjpEZXZpY2VNb3Rpb25DbGll bnRJT1MgKiljbGllbnQKIHsKICAgICBtX2RldmljZU1vdGlvbkNsaWVudHMucmVtb3ZlKGNsaWVu dCk7Ci0gICAgW3NlbGYgY2hlY2tDbGllbnRTdGF0dXNdOworICAgIGlmIChtX2luaXRpYWxpemVk KQorICAgICAgICBbc2VsZiBjaGVja0NsaWVudFN0YXR1c107CiB9CiAKIC0gKHZvaWQpYWRkT3Jp ZW50YXRpb25DbGllbnQ6KFdlYkNvcmU6OkRldmljZU9yaWVudGF0aW9uQ2xpZW50SU9TICopY2xp ZW50CiB7CiAgICAgbV9kZXZpY2VPcmllbnRhdGlvbkNsaWVudHMuYWRkKGNsaWVudCk7Ci0gICAg W3NlbGYgY2hlY2tDbGllbnRTdGF0dXNdOworICAgIGlmIChtX2luaXRpYWxpemVkKQorICAgICAg ICBbc2VsZiBjaGVja0NsaWVudFN0YXR1c107CiB9CiAKIC0gKHZvaWQpcmVtb3ZlT3JpZW50YXRp b25DbGllbnQ6KFdlYkNvcmU6OkRldmljZU9yaWVudGF0aW9uQ2xpZW50SU9TICopY2xpZW50CiB7 CiAgICAgbV9kZXZpY2VPcmllbnRhdGlvbkNsaWVudHMucmVtb3ZlKGNsaWVudCk7Ci0gICAgW3Nl bGYgY2hlY2tDbGllbnRTdGF0dXNdOworICAgIGlmIChtX2luaXRpYWxpemVkKQorICAgICAgICBb c2VsZiBjaGVja0NsaWVudFN0YXR1c107CiB9CiAKIC0gKEJPT0wpZ3lyb0F2YWlsYWJsZQpAQCAt MTUwLDYgKzE1Nyw4IEBAIHN0YXRpYyBjb25zdCBkb3VibGUga0dyYXZpdHkgPSA5LjgwNjY1Owog ICAgIG1fbG9jYXRpb25NYW5hZ2VyID0gW2FsbG9jQ0xMb2NhdGlvbk1hbmFnZXJJbnN0YW5jZSgp IGluaXRdOwogICAgIG1faGVhZGluZ0F2YWlsYWJsZSA9IFtnZXRDTExvY2F0aW9uTWFuYWdlckNs YXNzKCkgaGVhZGluZ0F2YWlsYWJsZV07CiAKKyAgICBtX2luaXRpYWxpemVkID0gWUVTOworCiAg ICAgW3NlbGYgY2hlY2tDbGllbnRTdGF0dXNdOwogfQogCg==