<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>150061</bug_id>
          
          <creation_ts>2015-10-12 16:05:40 -0700</creation_ts>
          <short_desc>Avoid useless copying of Key::HashType in loops in NetworkCache::Storage::synchronize()</short_desc>
          <delta_ts>2015-10-13 01:54:00 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
    
    <cc>kling</cc>
    
    <cc>koivisto</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1132554</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2015-10-12 16:05:40 -0700</bug_when>
    <thetext>Avoid useless copying of Key::HashType in loops in NetworkCache::Storage::synchronize(). Key::HashType is currently a SHA1::Digest, which is a std::array&lt;uint8_t, 20&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1132556</commentid>
    <comment_count>1</comment_count>
      <attachid>262937</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2015-10-12 16:06:37 -0700</bug_when>
    <thetext>Created attachment 262937
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1132734</commentid>
    <comment_count>2</comment_count>
      <attachid>262937</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-10-13 01:53:56 -0700</bug_when>
    <thetext>Comment on attachment 262937
Patch

Clearing flags on attachment: 262937

Committed r190930: &lt;http://trac.webkit.org/changeset/190930&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1132735</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-10-13 01:54:00 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>262937</attachid>
            <date>2015-10-12 16:06:37 -0700</date>
            <delta_ts>2015-10-13 01:53:56 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-150061-20151012160602.patch</filename>
            <type>text/plain</type>
            <size>2019</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwODU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjFhNzA3MWI2ZTdlYTNj
ODg3MTYyYmUyN2UxZWNkZmI1N2ZlNDlkYi4uNWYxZTkyNjk1MmVkMzMyODNjNTMxNTA1MDc4NDA4
ZDYzZDJkMWJjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTEwLTEyICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgdXNlbGVzcyBjb3B5
aW5nIG9mIEtleTo6SGFzaFR5cGUgaW4gbG9vcHMgaW4gTmV0d29ya0NhY2hlOjpTdG9yYWdlOjpz
eW5jaHJvbml6ZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0xNTAwNjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg
ICAgICBBdm9pZCB1c2VsZXNzIGNvcHlpbmcgb2YgS2V5OjpIYXNoVHlwZSBpbiBsb29wcyBpbiBO
ZXR3b3JrQ2FjaGU6OlN0b3JhZ2U6OnN5bmNocm9uaXplKCkuCisgICAgICAgIEtleTo6SGFzaFR5
cGUgaXMgY3VycmVudGx5IGEgU0hBMTo6RGlnZXN0LCB3aGljaCBpcyBhIHN0ZDo6YXJyYXk8dWlu
dDhfdCwgMjA+LgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hl
U3RvcmFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtDYWNoZTo6U3RvcmFnZTo6c3lu
Y2hyb25pemUpOgorCiAyMDE1LTEwLTEyICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Vi
a2l0Lm9yZz4KIAogICAgICAgICBbRUZMXSBCdW1wIFZlcnNpb24vWCBpbiB1c2VyIGFnZW50CmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3b3JrQ2Fj
aGVTdG9yYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdv
cmtDYWNoZVN0b3JhZ2UuY3BwCmluZGV4IDM4YzBlZjE3MTY3MTczMzY5YTNkZjNjZDY5NWM2NzY5
ZTlhZTljODMuLmZhNWJhN2RhMjA2ZmQwOTlhMzlmNDg5ZTg4Mjc0OTJhNDEwMTI1OTUgMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVN0
b3JhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdv
cmtDYWNoZVN0b3JhZ2UuY3BwCkBAIC0yNTksMTEgKzI1OSwxMSBAQCB2b2lkIFN0b3JhZ2U6OnN5
bmNocm9uaXplKCkKICAgICAgICAgICAgIGF1dG8gcmVjb3JkRmlsdGVyID0gc3RkOjp1bmlxdWVf
cHRyPENvbnRlbnRzRmlsdGVyPihyZWNvcmRGaWx0ZXJQdHIpOwogICAgICAgICAgICAgYXV0byBi
b2R5RmlsdGVyID0gc3RkOjp1bmlxdWVfcHRyPENvbnRlbnRzRmlsdGVyPihib2R5RmlsdGVyUHRy
KTsKIAotICAgICAgICAgICAgZm9yIChhdXRvIGhhc2ggOiBtX3JlY29yZEZpbHRlckhhc2hlc0Fk
ZGVkRHVyaW5nU3luY2hyb25pemF0aW9uKQorICAgICAgICAgICAgZm9yIChhdXRvJiBoYXNoIDog
bV9yZWNvcmRGaWx0ZXJIYXNoZXNBZGRlZER1cmluZ1N5bmNocm9uaXphdGlvbikKICAgICAgICAg
ICAgICAgICByZWNvcmRGaWx0ZXItPmFkZChoYXNoKTsKICAgICAgICAgICAgIG1fcmVjb3JkRmls
dGVySGFzaGVzQWRkZWREdXJpbmdTeW5jaHJvbml6YXRpb24uY2xlYXIoKTsKIAotICAgICAgICAg
ICAgZm9yIChhdXRvIGhhc2ggOiBtX2JvZHlGaWx0ZXJIYXNoZXNBZGRlZER1cmluZ1N5bmNocm9u
aXphdGlvbikKKyAgICAgICAgICAgIGZvciAoYXV0byYgaGFzaCA6IG1fYm9keUZpbHRlckhhc2hl
c0FkZGVkRHVyaW5nU3luY2hyb25pemF0aW9uKQogICAgICAgICAgICAgICAgIGJvZHlGaWx0ZXIt
PmFkZChoYXNoKTsKICAgICAgICAgICAgIG1fYm9keUZpbHRlckhhc2hlc0FkZGVkRHVyaW5nU3lu
Y2hyb25pemF0aW9uLmNsZWFyKCk7CiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>