150051 2015-10-12 15:05:17 -0700 [Font Features] Tiny cleanup regarding FontCascade::typesettingFeatures() 2015-12-04 15:22:29 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mmaxfield mmaxfield dino jonlee simon.fraser thorton webkit-bug-importer oldest_to_newest 1132500 0 mmaxfield 2015-10-12 15:05:17 -0700 [Font Features] Tiny cleanup regarding FontCascade::typesettingFeatures() 1132501 1 262925 mmaxfield 2015-10-12 15:06:23 -0700 Created attachment 262925 Patch 1132511 2 262925 simon.fraser 2015-10-12 15:24:10 -0700 Comment on attachment 262925 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262925&action=review > Source/WebCore/platform/graphics/FontCascade.cpp:610 > +#if !PLATFORM(COCOA) > + if (run.length() > 1 && typesettingFeatures()) > return Complex; > +#endif We have FontCascadeCocoa; can't this be done in that file, instead of having an #ifdef? 1132531 3 262925 mmaxfield 2015-10-12 15:39:54 -0700 Comment on attachment 262925 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262925&action=review >> Source/WebCore/platform/graphics/FontCascade.cpp:610 >> +#endif > > We have FontCascadeCocoa; can't this be done in that file, instead of having an #ifdef? I think in this case, it would be worse. This thing is so simple that adding another function with two implementations is worse than this tiny ifdef. 1132532 4 mmaxfield 2015-10-12 15:41:12 -0700 Committed r190895: <http://trac.webkit.org/changeset/190895> 1146431 5 webkit-bug-importer 2015-12-04 15:22:29 -0800 <rdar://problem/23768511> 262925 2015-10-12 15:06:23 -0700 2015-10-12 15:24:10 -0700 Patch bug-150051-20151012150547.patch text/plain 2706 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwODgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjQ0MjQ5YjkzZWQ0OGRm YjBmMjBiNjA5MDdiNjUxYjY5YjljMGI1Yy4uNDIzMGZhYjE1OTllMGU5YjQ0YTM3YmUyZWQzMWU3 MTQzYWY4YTgxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTEwLTEyICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgW0ZvbnQgRmVh dHVyZXNdIFRpbnkgY2xlYW51cCByZWdhcmRpbmcgRm9udENhc2NhZGU6OnR5cGVzZXR0aW5nRmVh dHVyZXMoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTUwMDUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhlcmUgYXJlIG5vIHR5cGVzZXR0aW5nIGZlYXR1cmVzIHdoaWNoIGFyZW4ndCBrZXJuaW5nIG5v ciBsaWdhdHVyZXMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2UgdGhlcmUgaXMgbm8g YmVoYXZpb3IgZGlmZmVyZW5jZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ZvbnRD YXNjYWRlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnRDYXNjYWRlOjpjb2RlUGF0aCk6Cisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvV2lkdGhJdGVyYXRvci5oOgorICAgICAgICAoV2Vi Q29yZTo6V2lkdGhJdGVyYXRvcjo6c3VwcG9ydHNUeXBlc2V0dGluZ0ZlYXR1cmVzKTogRGVsZXRl ZC4KKwogMjAxNS0xMC0xMiAgU2FpZCBBYm91LUhhbGxhd2EgIDxzYWJvdWhhbGxhd2FAYXBwbGUu Y29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjE4NDg5NSk6IGJvcmRlci1pbWFnZSBzaG91bGQg YWx3YXlzIHNsaWNlIHRoZSBTVkcgaW1hZ2UgdG8gbmluZSBwaWVjZXMgd2hlbiBkcmF3aW5nIGl0 IGluIHRoZSBjb250YWluZXIgZWxlbWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvRm9udENhc2NhZGUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvRm9udENhc2NhZGUuY3BwCmluZGV4IDQ2NWZhY2YxODY5YThhYzIxMmYzNTVlYTEz Yzk3MTAzNWU1Zjg2YjkuLmQ3MDc3YjQyNjJhNzllNjY2NDAyOTQ3Y2JiZGRiNzViMTdhMzQ5YmMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRDYXNjYWRl LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250Q2FzY2FkZS5j cHAKQEAgLTYwMyw5ICs2MDMsMTEgQEAgRm9udENhc2NhZGU6OkNvZGVQYXRoIEZvbnRDYXNjYWRl Ojpjb2RlUGF0aChjb25zdCBUZXh0UnVuJiBydW4pIGNvbnN0CiAgICAgLy8gRklYTUU6IFRoaXMg c2hvdWxkbid0IGJlIG5lY2Vzc2FyeSBiZWNhdXNlIEZvbnQ6OmFwcGx5VHJhbnNmb3JtcygpIHNo b3VsZCBwZXJmb3JtIGFsbCBuZWNlc3Nhcnkgc2hhcGluZy4KICAgICBpZiAobV9mb250RGVzY3Jp cHRpb24uZmVhdHVyZVNldHRpbmdzKCkuc2l6ZSgpID4gMCB8fCAhbV9mb250RGVzY3JpcHRpb24u dmFyaWFudFNldHRpbmdzKCkuaXNBbGxOb3JtYWwoKSkKICAgICAgICAgcmV0dXJuIENvbXBsZXg7 Ci0gICAgCi0gICAgaWYgKHJ1bi5sZW5ndGgoKSA+IDEgJiYgIVdpZHRoSXRlcmF0b3I6OnN1cHBv cnRzVHlwZXNldHRpbmdGZWF0dXJlcygqdGhpcykpCisKKyNpZiAhUExBVEZPUk0oQ09DT0EpCisg ICAgaWYgKHJ1bi5sZW5ndGgoKSA+IDEgJiYgdHlwZXNldHRpbmdGZWF0dXJlcygpKQogICAgICAg ICByZXR1cm4gQ29tcGxleDsKKyNlbmRpZgogCiAgICAgaWYgKCFydW4uY2hhcmFjdGVyU2NhbkZv ckNvZGVQYXRoKCkpCiAgICAgICAgIHJldHVybiBTaW1wbGU7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9XaWR0aEl0ZXJhdG9yLmggYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9XaWR0aEl0ZXJhdG9yLmgKaW5kZXggNjFkMzA0NzFjNjlkNjkw MGFiMGM0MjFkMDBiOTlmYzZmMGEwZWI5MC4uMmVkNGViMWViNDE5ZTQyZjJmYjAyZjc2YmIxMzAx Y2Y5NDJhMTA2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv V2lkdGhJdGVyYXRvci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1dp ZHRoSXRlcmF0b3IuaApAQCAtNjEsMTUgKzYxLDYgQEAgcHVibGljOgogICAgIFZlY3RvcjxTVkdH bHlwaDo6QXJhYmljRm9ybT4mIGFyYWJpY0Zvcm1zKCkgeyByZXR1cm4gbV9hcmFiaWNGb3Jtczsg fQogI2VuZGlmCiAKLSAgICBzdGF0aWMgYm9vbCBzdXBwb3J0c1R5cGVzZXR0aW5nRmVhdHVyZXMo Y29uc3QgRm9udENhc2NhZGUmIGZvbnQpCi0gICAgewotI2lmIFBMQVRGT1JNKENPQ09BKQotICAg ICAgICByZXR1cm4gIShmb250LnR5cGVzZXR0aW5nRmVhdHVyZXMoKSAmIH4oS2VybmluZyB8IExp Z2F0dXJlcykpOwotI2Vsc2UKLSAgICAgICAgcmV0dXJuICFmb250LnR5cGVzZXR0aW5nRmVhdHVy ZXMoKTsKLSNlbmRpZgotICAgIH0KLQogICAgIGNvbnN0IEZvbnRDYXNjYWRlKiBtX2ZvbnQ7CiAK ICAgICBjb25zdCBUZXh0UnVuJiBtX3J1bjsK