150045 2015-10-12 13:36:52 -0700 Simplify WeakBlock visit and reap phases 2015-10-13 17:10:48 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue ggaren kling oldest_to_newest 1132463 0 joepeck 2015-10-12 13:36:52 -0700 Simplify WeakBlock visit and reap phases. In marking, WeakBlocks are visited last after MarkedBlocks have been visited. Likewise reaping happens after marking. In both cases, all MarkedBlocks should be either Marked or Retired. We shouldn't encounter any that are Allocated. 1132465 1 262916 joepeck 2015-10-12 13:39:27 -0700 Created attachment 262916 [PATCH] Proposed Fix I've been running with this change without any problems. 1132470 2 262916 ggaren 2015-10-12 13:55:22 -0700 Comment on attachment 262916 [PATCH] Proposed Fix r=me 1132981 3 262916 commit-queue 2015-10-13 17:10:44 -0700 Comment on attachment 262916 [PATCH] Proposed Fix Clearing flags on attachment: 262916 Committed r191015: <http://trac.webkit.org/changeset/191015> 1132982 4 commit-queue 2015-10-13 17:10:48 -0700 All reviewed patches have been landed. Closing bug. 262916 2015-10-12 13:39:27 -0700 2015-10-13 17:10:44 -0700 [PATCH] Proposed Fix attempt-1.patch text/plain 3191 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDE2ZjE0YTkuLjExNzMyOWYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE1LTEwLTEyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgU2ltcGxpZnkgV2Vha0Jsb2NrIHZp c2l0IGFuZCByZWFwIHBoYXNlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTUwMDQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2Vha0Jsb2NrIHZpc2l0aW5nIGFuZCByZWFwaW5nIGJvdGggaGFwcGVuIGFm dGVyIE1hcmtlZEJsb2NrIG1hcmtpbmcuCisgICAgICAgIEFsbCB0aGUgTWFya2VkQmxvY2tzIHdl IGVuY291bnRlciBzaG91bGQgYmUgZWl0aGVyIE1hcmtlZCBvciBSZXRpcmVkLgorCisgICAgICAg ICogaGVhcC9NYXJrZWRCbG9jay5oOgorICAgICAgICAoSlNDOjpNYXJrZWRCbG9jazo6aXNNYXJr ZWRPclJldGlyZWQpOgorICAgICAgICAqIGhlYXAvV2Vha0Jsb2NrLmNwcDoKKyAgICAgICAgKEpT Qzo6V2Vha0Jsb2NrOjp2aXNpdCk6CisgICAgICAgIChKU0M6OldlYWtCbG9jazo6cmVhcCk6Cisg ICAgICAgICogaGVhcC9XZWFrQmxvY2suaDoKKworMjAxNS0xMC0xMiAgSm9zZXBoIFBlY29yYXJv ICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJlYmFzZWxp bmUgSW5zcGVjdG9yIGdlbmVyYXRvciB0ZXN0cyBhbmQgbWFrZSBiZXR0ZXIgdXNlIG9mIFJXSVBy b3RvY29sIGNvbnN0YW50CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNTAwNDQKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAv TWFya2VkQmxvY2suaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01hcmtlZEJsb2NrLmgK aW5kZXggYjU4MzNjMi4uYzFhMGRiYiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2hlYXAvTWFya2VkQmxvY2suaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJr ZWRCbG9jay5oCkBAIC0xNjQsNiArMTY0LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIHZv aWQgY2xlYXJOZXdseUFsbG9jYXRlZChjb25zdCB2b2lkKik7CiAKICAgICAgICAgYm9vbCBpc0Fs bG9jYXRlZCgpIGNvbnN0OworICAgICAgICBib29sIGlzTWFya2VkT3JSZXRpcmVkKCkgY29uc3Q7 CiAgICAgICAgIGJvb2wgbmVlZHNTd2VlcGluZygpIGNvbnN0OwogICAgICAgICB2b2lkIGRpZFJl dGlyZUJsb2NrKGNvbnN0IEZyZWVMaXN0Jik7CiAgICAgICAgIHZvaWQgd2lsbFJlbW92ZUJsb2Nr KCk7CkBAIC00NDgsNiArNDQ5LDExIEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICByZXR1cm4g bV9zdGF0ZSA9PSBBbGxvY2F0ZWQ7CiAgICAgfQogCisgICAgaW5saW5lIGJvb2wgTWFya2VkQmxv Y2s6OmlzTWFya2VkT3JSZXRpcmVkKCkgY29uc3QKKyAgICB7CisgICAgICAgIHJldHVybiBtX3N0 YXRlID09IE1hcmtlZCB8fCBtX3N0YXRlID09IFJldGlyZWQ7CisgICAgfQorCiB9IC8vIG5hbWVz cGFjZSBKU0MKIAogbmFtZXNwYWNlIFdURiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvaGVhcC9XZWFrQmxvY2suY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvV2Vh a0Jsb2NrLmNwcAppbmRleCA2M2Y2NTg1Li5lZjFkYWQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvaGVhcC9XZWFrQmxvY2suY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9oZWFwL1dlYWtCbG9jay5jcHAKQEAgLTEwMiw4ICsxMDIsOCBAQCB2b2lkIFdlYWtCbG9jazo6 dmlzaXQoSGVhcFJvb3RWaXNpdG9yJiBoZWFwUm9vdFZpc2l0b3IpCiAgICAgLy8gSWYgdGhpcyBX ZWFrQmxvY2sgZG9lc24ndCBiZWxvbmcgdG8gYSBNYXJrZWRCbG9jaywgd2Ugd29uJ3QgZXZlbiBi ZSBoZXJlLgogICAgIEFTU0VSVChtX21hcmtlZEJsb2NrKTsKIAotICAgIGlmIChtX21hcmtlZEJs b2NrLT5pc0FsbG9jYXRlZCgpKQotICAgICAgICByZXR1cm47CisgICAgLy8gV2Ugb25seSB2aXNp dCBhZnRlciBtYXJraW5nLgorICAgIEFTU0VSVChtX21hcmtlZEJsb2NrLT5pc01hcmtlZE9yUmV0 aXJlZCgpKTsKIAogICAgIFNsb3RWaXNpdG9yJiB2aXNpdG9yID0gaGVhcFJvb3RWaXNpdG9yLnZp c2l0b3IoKTsKIApAQCAtMTM2LDggKzEzNiw4IEBAIHZvaWQgV2Vha0Jsb2NrOjpyZWFwKCkKICAg ICAvLyBJZiB0aGlzIFdlYWtCbG9jayBkb2Vzbid0IGJlbG9uZyB0byBhIE1hcmtlZEJsb2NrLCB3 ZSB3b24ndCBldmVuIGJlIGhlcmUuCiAgICAgQVNTRVJUKG1fbWFya2VkQmxvY2spOwogCi0gICAg aWYgKG1fbWFya2VkQmxvY2stPmlzQWxsb2NhdGVkKCkpCi0gICAgICAgIHJldHVybjsKKyAgICAv LyBXZSBvbmx5IHJlYXAgYWZ0ZXIgbWFya2luZy4KKyAgICBBU1NFUlQobV9tYXJrZWRCbG9jay0+ aXNNYXJrZWRPclJldGlyZWQoKSk7CiAKICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHdlYWtJ bXBsQ291bnQoKTsgKytpKSB7CiAgICAgICAgIFdlYWtJbXBsKiB3ZWFrSW1wbCA9ICZ3ZWFrSW1w bHMoKVtpXTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL1dlYWtCbG9j ay5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvV2Vha0Jsb2NrLmgKaW5kZXggOWUxOTc4 My4uOTQ4MjYwNiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvV2Vha0Js b2NrLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvV2Vha0Jsb2NrLmgKQEAgLTcz LDcgKzczLDYgQEAgcHJpdmF0ZToKICAgICBzdGF0aWMgRnJlZUNlbGwqIGFzRnJlZUNlbGwoV2Vh a0ltcGwqKTsKIAogICAgIGV4cGxpY2l0IFdlYWtCbG9jayhNYXJrZWRCbG9jayYpOwotICAgIFdl YWtJbXBsKiBmaXJzdFdlYWtJbXBsKCk7CiAgICAgdm9pZCBmaW5hbGl6ZShXZWFrSW1wbCopOwog ICAgIFdlYWtJbXBsKiB3ZWFrSW1wbHMoKTsKICAgICBzaXplX3Qgd2Vha0ltcGxDb3VudCgpOwo=