150035 2015-10-12 11:03:13 -0700 [Curl] Increase limit of parallel network requests. 2015-10-12 14:22:39 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham commit-queue galpeter oldest_to_newest 1132362 0 peavo 2015-10-12 11:03:13 -0700 If the limit is low, other network requests will often be blocked until active requests finishes. This can affect performance in a negative way. 1132367 1 262902 peavo 2015-10-12 11:09:53 -0700 Created attachment 262902 Patch 1132389 2 262902 achristensen 2015-10-12 11:30:22 -0700 Comment on attachment 262902 Patch What if the limit is too big? Why is there a limit? 1132395 3 peavo 2015-10-12 11:38:12 -0700 (In reply to comment #2) > Comment on attachment 262902 [details] > Patch > > What if the limit is too big? Why is there a limit? Good point. It might be better to leave this decision to Curl, since it is probably handled well there. In that case, I dont't think a big limit would hurt :) 1132404 4 peavo 2015-10-12 11:56:39 -0700 It seems there already is a Curl option for this (with default 0, meaning infinite number of connections): http://curl.haxx.se/libcurl/c/CURLMOPT_MAX_TOTAL_CONNECTIONS.html Since Curl doesn't have a limit here, maybe we shouldn't either? If we limit the number of connections, I think the limit should be higher that it is now at least. Another problem with the limit is that it can effectively block all future network requests if the current connections are never closed (for some reason). 1132466 5 peavo 2015-10-12 13:42:24 -0700 Thanks for reviewing :) 1132485 6 262902 commit-queue 2015-10-12 14:22:36 -0700 Comment on attachment 262902 Patch Clearing flags on attachment: 262902 Committed r190887: <http://trac.webkit.org/changeset/190887> 1132486 7 commit-queue 2015-10-12 14:22:39 -0700 All reviewed patches have been landed. Closing bug. 262902 2015-10-12 11:09:53 -0700 2015-10-12 14:22:36 -0700 Patch bug-150035-20151012200859.patch text/plain 1333 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MDg2MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTEwLTEyICBQZXIgQXJu ZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbQ3VybF0gSW5jcmVhc2Ug bGltaXQgb2YgcGFyYWxsZWwgbmV0d29yayByZXF1ZXN0cy4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDAzNQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElmIHRoZSBsaW1pdCBpcyB0b28gbG93LCBvdGhl ciBuZXR3b3JrIHJlcXVlc3RzIHdpbGwgb2Z0ZW4gYmUgYmxvY2tlZCB1bnRpbAorICAgICAgICBh Y3RpdmUgcmVxdWVzdHMgZmluaXNoZXMuIFRoaXMgY2FuIGFmZmVjdCBwZXJmb3JtYW5jZSBpbiBh IG5lZ2F0aXZlIHdheS4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJj ZUhhbmRsZU1hbmFnZXIuY3BwOgorCiAyMDE1LTEwLTA5ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRl cnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgRG9uJ3QgYWxsb3cgcGx1Zy1pbnMgdG8gb3ZlcnJp ZGUgaW1hZ2UgdHlwZXMgZm9yIDxlbWJlZD4gZWxlbWVudHMKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRs ZU1hbmFnZXIuY3BwCShyZXZpc2lvbiAxOTA4NTUpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNzgsNyArNzgsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNvbnN0IGludCBzZWxlY3RU aW1lb3V0TVMgPSA1OwogY29uc3QgZG91YmxlIHBvbGxUaW1lU2Vjb25kcyA9IDAuMDU7Ci1jb25z dCBpbnQgbWF4UnVubmluZ0pvYnMgPSA1OworY29uc3QgaW50IG1heFJ1bm5pbmdKb2JzID0gMTI4 OwogCiBzdGF0aWMgY29uc3QgYm9vbCBpZ25vcmVTU0xFcnJvcnMgPSBnZXRlbnYoIldFQktJVF9J R05PUkVfU1NMX0VSUk9SUyIpOwogCg==