150032 2015-10-12 09:56:03 -0700 [GTK][Mac] ICU-related build fixes 2015-10-22 00:08:45 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 126492 1 pnormand pnormand bugs-noreply cgarcia darin philip.chimento oldest_to_newest 1132331 0 pnormand 2015-10-12 09:56:03 -0700 I had some link errors and not-found-headers issues related with ICU on Mac. 1132334 1 262894 pnormand 2015-10-12 10:01:58 -0700 Created attachment 262894 Patch 1132724 2 262894 cgarcia 2015-10-13 00:58:06 -0700 Comment on attachment 262894 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262894&action=review > Source/JavaScriptCore/PlatformGTK.cmake:51 > +if (CMAKE_SYSTEM_NAME MATCHES "Darwin") Why is this specific to darwin? > Source/WTF/wtf/PlatformGTK.cmake:26 > +if (CMAKE_SYSTEM_NAME MATCHES "Darwin") Ditto. 1132726 3 262894 pnormand 2015-10-13 01:03:17 -0700 Comment on attachment 262894 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262894&action=review >> Source/JavaScriptCore/PlatformGTK.cmake:51 >> +if (CMAKE_SYSTEM_NAME MATCHES "Darwin") > > Why is this specific to darwin? No idea. The wonders of CMake on Linux I suppose :) 1132732 4 cgarcia 2015-10-13 01:28:23 -0700 (In reply to comment #3) > Comment on attachment 262894 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=262894&action=review > > >> Source/JavaScriptCore/PlatformGTK.cmake:51 > >> +if (CMAKE_SYSTEM_NAME MATCHES "Darwin") > > > > Why is this specific to darwin? > > No idea. The wonders of CMake on Linux I suppose :) If that works for the other platforms, we could avoid conditionals that we don't even understand 1135213 5 263679 pnormand 2015-10-21 08:22:49 -0700 Created attachment 263679 patch 1135214 6 darin 2015-10-21 08:50:45 -0700 I’m just rubber stamping this; seems fine to me even though I’m not expert on how CMake works. 1135596 7 pnormand 2015-10-22 00:08:45 -0700 Committed r191442: <http://trac.webkit.org/changeset/191442> 262894 2015-10-12 10:01:58 -0700 2015-10-21 08:22:49 -0700 Patch bug-150032-20151012190122.patch text/plain 4057 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwNzgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl Y2JlZGQ3MWY3ZWFiYThiZjJhMTVhZWI0NDYyZjNmNDlkOGRlYmU2Li42MzhjOGI1NzhjM2U3YWE1 NGZhODFkOTc0NzMwZWZiNDMzYzZjNTc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNS0xMC0xMiAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxp YS5jb20+CisKKyAgICAgICAgW0dUS11bTWFjXSBJQ1UtcmVsYXRlZCBidWlsZCBmaXhlcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwMDMyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBQbGF0Zm9ybUdU Sy5jbWFrZTogQWRkIHJlZmVyZW5jZXMgdG8gSUNVIGluY2x1ZGUgZGlyZWN0b3JpZXMgYW5kIGxp YnJhcmllcy4KKwogMjAxNS0wNi0xOSAgUGhpbGlwIENoaW1lbnRvICA8cGhpbGlwLmNoaW1lbnRv QGdtYWlsLmNvbT4KIAogICAgICAgICB3ZWJraXQtZ3RrLTIuMy40IGZhaWxzIHRvIGxpbmsgSmF2 YVNjcmlwdENvcmUsIG1pc3Npbmcgc3ltYm9scyBhZGRfaGlzdG9yeSBhbmQgcmVhZGxpbmUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKaW5k ZXggMzU5MTZlZjA3NGNjZTljOTcwNGJjMTMxZjQ2ODg3NjdiZWIxNmI1NC4uZjQyMzMzZmI2NmY5 YjMzODk5ZDE2ZTdiYTBhOTIxYjNiMzdkMjg0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFu Z2VMb2cKKysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNS0x MC0xMiAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAg W0dUS11bTWFjXSBJQ1UtcmVsYXRlZCBidWlsZCBmaXhlcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwMDMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm1HVEsuY21ha2U6IEFkZCBy ZWZlcmVuY2VzIHRvIElDVSBpbmNsdWRlIGRpcmVjdG9yaWVzIGFuZCBsaWJyYXJpZXMuCisKIDIw MTUtMDYtMTkgIFBoaWxpcCBDaGltZW50byAgPHBoaWxpcC5jaGltZW50b0BnbWFpbC5jb20+CiAK ICAgICAgICAgW0dUS10gRml4IGNvbWJpbmF0aW9ucyBvZiBQTEFURk9STShHVEspIGFuZCBPUyhE QVJXSU4pCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvUGxhdGZvcm1HVEsuY21h a2UgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggNGFkMWMx YTAzODIxNzI4NjViNGZmNjhiY2U0Y2NjNGMyNTM2ZmY0Zi4uNzM5ZThjYmYxOWZlNjQ5ZTZjMDE0 ZDk1ZTc2ODczMDIwNTI3N2ZhOCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL1Bs YXRmb3JtR1RLLmNtYWtlCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9QbGF0Zm9ybUdUSy5j bWFrZQpAQCAtNDYsMyArNDYsMTQgQEAgbGlzdChBUFBFTkQgSmF2YVNjcmlwdENvcmVfTElCUkFS SUVTCiBsaXN0KEFQUEVORCBKYXZhU2NyaXB0Q29yZV9TWVNURU1fSU5DTFVERV9ESVJFQ1RPUklF UwogICAgICR7R0xJQl9JTkNMVURFX0RJUlN9CiApCisKKworaWYgKENNQUtFX1NZU1RFTV9OQU1F IE1BVENIRVMgIkRhcndpbiIpCisgICAgbGlzdChBUFBFTkQgSmF2YVNjcmlwdENvcmVfU1lTVEVN X0lOQ0xVREVfRElSRUNUT1JJRVMKKyAgICAgICAgJHtJQ1VfSU5DTFVERV9ESVJTfQorICAgICkK KyAgICBsaXN0KEFQUEVORCBKYXZhU2NyaXB0Q29yZV9MSUJSQVJJRVMKKyAgICAgICAgJHtJQ1Vf TElCUkFSSUVTfQorICAgICAgICAke0lDVV9JMThOX0xJQlJBUklFU30KKyAgICApCitlbmRpZiAo KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm1HVEsuY21ha2UgYi9Tb3VyY2Uv V1RGL3d0Zi9QbGF0Zm9ybUdUSy5jbWFrZQppbmRleCA4MzIyMGRjODZlZmUyOWUzM2NkNGI1MDc3 NjRmNTdiYWExMWU5YTYxLi5jZWIxYWI5ZGQ3MTI2YTZmOTk5YzViZDUxMmI2MGVmYmIyN2NlNTc4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUdUSy5jbWFrZQorKysgYi9Tb3Vy Y2UvV1RGL3d0Zi9QbGF0Zm9ybUdUSy5jbWFrZQpAQCAtMjIsMyArMjIsMTMgQEAgbGlzdChBUFBF TkQgV1RGX0xJQlJBUklFUwogbGlzdChBUFBFTkQgV1RGX1NZU1RFTV9JTkNMVURFX0RJUkVDVE9S SUVTCiAgICAgJHtHTElCX0lOQ0xVREVfRElSU30KICkKKworaWYgKENNQUtFX1NZU1RFTV9OQU1F IE1BVENIRVMgIkRhcndpbiIpCisgICAgbGlzdChBUFBFTkQgV1RGX1NZU1RFTV9JTkNMVURFX0RJ UkVDVE9SSUVTCisgICAgICAgICR7SUNVX0lOQ0xVREVfRElSU30KKyAgICApCisgICAgbGlzdChB UFBFTkQgV1RGX0xJQlJBUklFUworICAgICAgICAke0lDVV9MSUJSQVJJRVN9CisgICAgICAgICR7 SUNVX0kxOE5fTElCUkFSSUVTfQorICAgICkKK2VuZGlmICgpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv Y21ha2UvRmluZElDVS5jbWFrZSBiL1NvdXJjZS9jbWFrZS9GaW5kSUNVLmNtYWtlCmluZGV4IGI3 YmQzMGEwMWQ3MmVhOWI3ZWYwMjNjNzQ2NWUxZDhiOWI0MGM3M2IuLjRlOTMyODZmMzIyYTU4ODU3 N2ZjMjI5YTYxMDkwODhmNjEzYjBhYmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9GaW5kSUNV LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kSUNVLmNtYWtlCkBAIC00Niw5ICs0NiwxMiBA QCBpZiAoSUNVX0lOQ0xVREVfRElSIEFORCBJQ1VfTElCUkFSWSkKICAgICBzZXQoSUNVX1ZFUlNJ T04gIiR7SUNVX01BSk9SX1ZFUlNJT059LiR7SUNVX01JTk9SX1ZFUlNJT059IikKIAogICAgICMg TG9vayBmb3IgdGhlIElDVSBpbnRlcm5hdGlvbmFsaXphdGlvbiBsaWJyYXJpZXMKKyAgICBwa2df Y2hlY2tfbW9kdWxlcyhQQ19JQ1VfSTE4TiBpY3UtaTE4bikKICAgICBmaW5kX2xpYnJhcnkoCiAg ICAgICAgIElDVV9JMThOX0xJQlJBUlkKLSAgICAgICAgTkFNRVMgaWN1aW4gaWN1aTE4biBjeWdp Y3VpbiBjeWdpY3VpbjMyCisgICAgICAgIE5BTUVTIGljdWkxOG4gaWN1aW4gY3lnaWN1aW4gY3ln aWN1aW4zMgorICAgICAgICBISU5UUyAke1BDX0lDVV9JMThOX0xJQlJBUllfRElSU30KKyAgICAg ICAgICAgICAgJHtQQ19JQ1VfSTE4Tl9MSUJESVJ9CiAgICAgICAgIERPQyAiTGlicmFyaWVzIHRv IGxpbmsgYWdhaW5zdCBmb3IgSUNVIGludGVybmF0aW9uYWxpemF0aW9uIikKICAgICBtYXJrX2Fz X2FkdmFuY2VkKElDVV9JMThOX0xJQlJBUlkpCiAgICAgaWYgKElDVV9JMThOX0xJQlJBUlkpCmRp ZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggYjdiYjE1MzQzZDA0MTJlYWNm M2UxNjA0YzZhZTMyYmIwZjA0MWE1Zi4uYjkzYTg5MzAzOTRlZTExYmQxMmFhZDY1NjYxYTJiNjcy M2NiZWY4ZiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEyIEBACisyMDE1LTEwLTEyICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNv bT4KKworICAgICAgICBbR1RLXVtNYWNdIElDVS1yZWxhdGVkIGJ1aWxkIGZpeGVzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTAwMzIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9G aW5kSUNVLmNtYWtlOiBVc2UgcGtnLWNvbmZpZyB0byBoaW50IGF0IGljdS1pMThuJ3MgbGlicmFy eSBsb2NhdGlvbi4KKwogMjAxNS0wNi0xOSAgUGhpbGlwIENoaW1lbnRvICA8cGhpbGlwLmNoaW1l bnRvQGdtYWlsLmNvbT4KIAogICAgICAgICBbR1RLXSBVc2UgLS12ZXJzaW9uLXNjcmlwdCBvbmx5 IG9uIExpbnV4Cg== 263679 2015-10-21 08:22:49 -0700 2015-10-21 08:50:16 -0700 patch 0001-GTK-Mac-ICU-related-build-fixes.patch text/plain 1621 pnormand RnJvbSA3OWE1ZTRlZGRmYjYzMjgzZDRkOGVmODYxOTViZTU2ODkyYWY1YzQ0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBNb24sIDEyIE9jdCAyMDE1IDE4OjQ5OjQ1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g W0dUS11bTWFjXSBJQ1UtcmVsYXRlZCBidWlsZCBmaXhlcwoKLS0tCiBDaGFuZ2VMb2cgICAgICAg ICAgICAgICAgICB8IDkgKysrKysrKysrCiBTb3VyY2UvY21ha2UvRmluZElDVS5jbWFrZSB8IDUg KysrKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoK ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBiN2JiMTUzLi5iOTNhODkz IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTUtMTAtMTIgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisg ICAgICAgIFtHVEtdW01hY10gSUNVLXJlbGF0ZWQgYnVpbGQgZml4ZXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDAzMgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL0ZpbmRJQ1Uu Y21ha2U6IFVzZSBwa2ctY29uZmlnIHRvIGhpbnQgYXQgaWN1LWkxOG4ncyBsaWJyYXJ5IGxvY2F0 aW9uLgorCiAyMDE1LTA2LTE5ICBQaGlsaXAgQ2hpbWVudG8gIDxwaGlsaXAuY2hpbWVudG9AZ21h aWwuY29tPgogCiAgICAgICAgIFtHVEtdIFVzZSAtLXZlcnNpb24tc2NyaXB0IG9ubHkgb24gTGlu dXgKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9GaW5kSUNVLmNtYWtlIGIvU291cmNlL2NtYWtl L0ZpbmRJQ1UuY21ha2UKaW5kZXggYjdiZDMwYS4uNGU5MzI4NiAxMDA2NDQKLS0tIGEvU291cmNl L2NtYWtlL0ZpbmRJQ1UuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL0ZpbmRJQ1UuY21ha2UKQEAg LTQ2LDkgKzQ2LDEyIEBAIGlmIChJQ1VfSU5DTFVERV9ESVIgQU5EIElDVV9MSUJSQVJZKQogICAg IHNldChJQ1VfVkVSU0lPTiAiJHtJQ1VfTUFKT1JfVkVSU0lPTn0uJHtJQ1VfTUlOT1JfVkVSU0lP Tn0iKQogCiAgICAgIyBMb29rIGZvciB0aGUgSUNVIGludGVybmF0aW9uYWxpemF0aW9uIGxpYnJh cmllcworICAgIHBrZ19jaGVja19tb2R1bGVzKFBDX0lDVV9JMThOIGljdS1pMThuKQogICAgIGZp bmRfbGlicmFyeSgKICAgICAgICAgSUNVX0kxOE5fTElCUkFSWQotICAgICAgICBOQU1FUyBpY3Vp biBpY3VpMThuIGN5Z2ljdWluIGN5Z2ljdWluMzIKKyAgICAgICAgTkFNRVMgaWN1aTE4biBpY3Vp biBjeWdpY3VpbiBjeWdpY3VpbjMyCisgICAgICAgIEhJTlRTICR7UENfSUNVX0kxOE5fTElCUkFS WV9ESVJTfQorICAgICAgICAgICAgICAke1BDX0lDVV9JMThOX0xJQkRJUn0KICAgICAgICAgRE9D ICJMaWJyYXJpZXMgdG8gbGluayBhZ2FpbnN0IGZvciBJQ1UgaW50ZXJuYXRpb25hbGl6YXRpb24i KQogICAgIG1hcmtfYXNfYWR2YW5jZWQoSUNVX0kxOE5fTElCUkFSWSkKICAgICBpZiAoSUNVX0kx OE5fTElCUkFSWSkKLS0gCjEuOC4xLjMKCg==