150026 2015-10-12 04:57:52 -0700 [GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2 2015-10-12 05:37:44 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Linux RESOLVED FIXED Gtk P2 Normal --- 1 mario webkit-unassigned bugs-noreply cgarcia clopez gustavo mcatanzaro mrobinson ossy pnormand oldest_to_newest 1132297 0 mario 2015-10-12 04:57:52 -0700 As it was found out while working on bug 149749, I had quite some trouble running the layout tests on a recently installed development machine with "standard" Debian Testing (no packages from other sources), where I would get ~230 tests crashing due to some kind of problem in GStreamer, as you can check here: Description: https://bugs.webkit.org/show_bug.cgi?id=149749#c6 Results here: https://drive.google.com/file/d/0B6Gdj3EoWfFLRFNSejRIMlViY28/view?usp=sharing After some investigation today, I finally found the problem (and why it was so hard to find in the first place): The problem is that a newer versions of cpp (I have 5.2.1, while the bot has 4.9.2) produces a different output while processing the headers from libfaad2, causing gst-plugins-bad to be compiled without the FAAD2_MINOR_VERSION definition in config.h, which causes crashes and stack corruption on runtime. This problem has been reported already for Fedora 22 in the RH's bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1219320 Fortunately, this has been already fixed upstream in gst-plugins-bad: http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=1f738ca5b8711ca5532a326cd646312e60484863 I'm 100% sure that's the same issue I was seeing because I could double check myself that the output for f21 and f22 as mentioned in https://bugzilla.redhat.com/show_bug.cgi?id=1219320#c21 is exactly the same one that I'm getting in the bots (with help from aperezdc), with cpp 4.9.2, and my local Debian Testing machine, with cpp 5.2.1. Besides, I've applied the patch locally myself to the gst-plugins-bad from the internal jhbuild, recompiled it together with the WebKit libraries and binaries... and it worked! No more weird crashes around running the tests! So, I'll submit a new patch to backport that patch from upstream into gst-plugins-bad 1.4.4 from the jhbuild 1132299 1 262883 mario 2015-10-12 05:06:35 -0700 Created attachment 262883 Patch proposal See the proposed patch attached, please review. Thanks! 1132306 2 mario 2015-10-12 05:37:44 -0700 Committed r190854: <http://trac.webkit.org/changeset/190854> 262883 2015-10-12 05:06:35 -0700 2015-10-12 05:15:45 -0700 Patch proposal 0001-2015-10-12-Mario-Sanchez-Prada-mario-endlessm.com.patch text/plain 4328 mario RnJvbSBiY2E1MmFlM2Y4ZDYyZWVlMjg5ZDI5MjFjOTJjYTAyMTMzMjE5MDBhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtYXJpb0B3ZWJraXQub3Jn PgpEYXRlOiBNb24sIDEyIE9jdCAyMDE1IDEzOjAzOjUyICswMTAwClN1YmplY3Q6IFtQQVRDSF0g MjAxNS0xMC0xMiAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1hcmlvQGVuZGxlc3NtLmNvbT4KCiAg ICAgICAgW0dUS10gTWVkaWEgdGVzdHMgY3Jhc2hpbmcgd2l0aCBnc3QtcGx1Z2lucy1iYWQgMS40 LjQgYW5kIGNwcCA1LjIKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTUwMDI2CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAg ICBCYWNrcG9ydCB1cHN0cmVhbSBwYXRjaCBmcm9tIGdzdC1wbHVnaW5zLWJhZCBzbyB0aGF0IHRo ZSByaWdodCB2ZXJzaW9uCiAgICAgICAgb2YgRkFBRDIgY2FuIGJlIGZvdW5kIHdpdGggbmV3ZXIg dmVyc2lvbnMgb2YgY3BwLCBzbyB0aGF0IGdzdC1wbHVnaW5zLWJhZAogICAgICAgIGdldHMgY29t cGlsZWQgcHJvcGVybHksIGF2b2lkaW5nIGNyYXNoZXMgb24gcnVudGltZSB3aGlsZSBydW5uaW5n IHRlc3RzLgoKICAgICAgICAqIGd0ay9wYXRjaGVzL2dzdC1wbHVnaW5zLWJhZC1maXgtZmFhZDIt dmVyc2lvbi1jaGVjay5wYXRjaDogQWRkZWQuCiAgICAgICAgKiBndGsvamhidWlsZC5tb2R1bGVz OiBSZWZlcmVuY2VkIHRoZSBuZXdseSBhZGRlZCBwYXRjaCBmb3IgZ3N0LXBsdWdpbnMtYmFkLgot LS0KIFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwg MTQgKysrKysrKysrCiBUb29scy9ndGsvamhidWlsZC5tb2R1bGVzICAgICAgICAgICAgICAgICAg ICAgICAgICB8ICAxICsKIC4uLi9nc3QtcGx1Z2lucy1iYWQtZml4LWZhYWQyLXZlcnNpb24tY2hl Y2sucGF0Y2ggIHwgMzUgKysrKysrKysrKysrKysrKysrKysrKwogMyBmaWxlcyBjaGFuZ2VkLCA1 MCBpbnNlcnRpb25zKCspCiBjcmVhdGUgbW9kZSAxMDA2NDQgVG9vbHMvZ3RrL3BhdGNoZXMvZ3N0 LXBsdWdpbnMtYmFkLWZpeC1mYWFkMi12ZXJzaW9uLWNoZWNrLnBhdGNoCgpkaWZmIC0tZ2l0IGEv VG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDIwMDJhN2IuLjM2ZGVlYjAg MTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNS0xMC0xMiAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1hcmlvQGVuZGxl c3NtLmNvbT4KKworICAgICAgICBbR1RLXSBNZWRpYSB0ZXN0cyBjcmFzaGluZyB3aXRoIGdzdC1w bHVnaW5zLWJhZCAxLjQuNCBhbmQgY3BwIDUuMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwMDI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQmFja3BvcnQgdXBzdHJlYW0gcGF0Y2ggZnJvbSBnc3QtcGx1 Z2lucy1iYWQgc28gdGhhdCB0aGUgcmlnaHQgdmVyc2lvbgorICAgICAgICBvZiBGQUFEMiBjYW4g YmUgZm91bmQgd2l0aCBuZXdlciB2ZXJzaW9ucyBvZiBjcHAsIHNvIHRoYXQgZ3N0LXBsdWdpbnMt YmFkCisgICAgICAgIGdldHMgY29tcGlsZWQgcHJvcGVybHksIGF2b2lkaW5nIGNyYXNoZXMgb24g cnVudGltZSB3aGlsZSBydW5uaW5nIHRlc3RzLgorCisgICAgICAgICogZ3RrL3BhdGNoZXMvZ3N0 LXBsdWdpbnMtYmFkLWZpeC1mYWFkMi12ZXJzaW9uLWNoZWNrLnBhdGNoOiBBZGRlZC4KKyAgICAg ICAgKiBndGsvamhidWlsZC5tb2R1bGVzOiBSZWZlcmVuY2VkIHRoZSBuZXdseSBhZGRlZCBwYXRj aCBmb3IgZ3N0LXBsdWdpbnMtYmFkLgorCiAyMDE1LTEwLTA1ICBNeWxlcyBDLiBNYXhmaWVsZCAg PG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTigxODk2Njg/KTogaHR0 cC90ZXN0cy9ub3RpZmljYXRpb25zL2V2ZW50cy5odG1sIGZsYWtpbHkgYXNzZXJ0cyBvciB0aW1l cyBvdXQKZGlmZiAtLWdpdCBhL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMgYi9Ub29scy9ndGsv amhidWlsZC5tb2R1bGVzCmluZGV4IDk1NDE2OWEuLmJjODc0ZjYgMTAwNjQ0Ci0tLSBhL1Rvb2xz L2d0ay9qaGJ1aWxkLm1vZHVsZXMKKysrIGIvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcwpAQCAt MzI0LDYgKzMyNCw3IEBACiAgICAgICAgICAgICBoYXNoPSJzaGEyNTY6ZTQxYjM2MTA1YzBhMTNh MmNiMWZmOWY1NTk3MTRlODM5YjgyZGMzODQxNDg0Y2Q2NjQ3OTBmYjc5NDdlNTVjNyIKICAgICAg ICAgICAgIG1kNXN1bT0iOTcyYzZlMjJkZDJlNDRmY2YwYjA0YjlkODEwYTU2YmUiPgogICAgICAg PHBhdGNoIGZpbGU9ImdzdC1wbHVnaW5zLWJhZC1yZW1vdmUtZ251c3RlcC1zdXBwb3J0LnBhdGNo IiBzdHJpcD0iMSIvPgorICAgICAgPHBhdGNoIGZpbGU9ImdzdC1wbHVnaW5zLWJhZC1maXgtZmFh ZDItdmVyc2lvbi1jaGVjay5wYXRjaCIgc3RyaXA9IjEiLz4KICAgICA8L2JyYW5jaD4KICAgPC9h dXRvdG9vbHM+CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL2d0ay9wYXRjaGVzL2dzdC1wbHVnaW5zLWJh ZC1maXgtZmFhZDItdmVyc2lvbi1jaGVjay5wYXRjaCBiL1Rvb2xzL2d0ay9wYXRjaGVzL2dzdC1w bHVnaW5zLWJhZC1maXgtZmFhZDItdmVyc2lvbi1jaGVjay5wYXRjaApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwLi5jMDM3ZjFlCi0tLSAvZGV2L251bGwKKysrIGIvVG9vbHMvZ3Rr L3BhdGNoZXMvZ3N0LXBsdWdpbnMtYmFkLWZpeC1mYWFkMi12ZXJzaW9uLWNoZWNrLnBhdGNoCkBA IC0wLDAgKzEsMzUgQEAKK0Zyb20gMWY3MzhjYTViODcxMWNhNTUzMmEzMjZjZDY0NjMxMmU2MDQ4 NDg2MyBNb24gU2VwIDE3IDAwOjAwOjAwIDIwMDEKK0Zyb206IFdpbSBUYXltYW5zIDx3dGF5bWFu c0ByZWRoYXQuY29tPgorRGF0ZTogV2VkLCAxMyBNYXkgMjAxNSAxNjoyMzoyNiArMDIwMAorU3Vi amVjdDogW1BBVENIXSBmaXggZmFhZDIgdmVyc2lvbiBjaGVjaworCitPbiBmZWRvcmEgMjIsIHRo ZSBvdXRwdXQgb2YgY3BwIGluc2VydHMgZXh0cmEgZGVidWcgY29tbWVudHMsIHdoaWNoCittYWtl cyBvdXIgcmVnZXhwIGZvciB0aGUgZmFhZDIgdmVyc2lvbiBjaGVjayBmYWlsLiBUaGlzIGluIHR1 cm4gY2F1c2VzCitpdCB0byBjb21waWxlIHdpdGggdGhlIHdyb25nIGFyZ3VtZW50cyBwYXNzZWQg d2hpY2ggdGhlbiBjYXVzZXMgc3RhY2sKK2NvcnJ1cHRpb24gYW5kIGNyYXNoZXMuCisKK0ZpeCB0 aGlzIGJ5IG9ubHkgY2hlY2tpbmcgZm9yIHRoZSB2ZXJzaW9uICh3aGljaCBzaG91bGQgYmUgYnkg aXRzZWxmIG9uCithIHNpbmdsZSBsaW5lKS4gVGhpcyBpcyBwb3RlbnRpYWxseSBsZXNzIHNhZmUs IGl0IG1pZ2h0IGJlIHBvc3NpYmxlIHRoYXQKK2Egc2ltaWxhciBzdHJpbmcgd291bGQgYXBwZWFy IGluIGEgbGF0ZXIgdmVyc2lvbiBpbiB0aGUgaGVhZGVyIGZpbGUuCisKK0ZpeGVzIGh0dHBzOi8v YnVnemlsbGEuZ25vbWUub3JnL3Nob3dfYnVnLmNnaT9pZD03NDg1NzEKKy0tLQorIGNvbmZpZ3Vy ZS5hYyB8IDQgKystLQorIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRp b25zKC0pCisKK2RpZmYgLS1naXQgYS9jb25maWd1cmUuYWMgYi9jb25maWd1cmUuYWMKK2luZGV4 IGY1Y2UyOGMuLmQyOTUyNTMgMTAwNjQ0CistLS0gYS9jb25maWd1cmUuYWMKKysrKyBiL2NvbmZp Z3VyZS5hYworQEAgLTIwMDgsOSArMjAwOCw5IEBAIEFHX0dTVF9DSEVDS19GRUFUVVJFKEZBQUQs IFtBQUMgZGVjb2RlciBwbHVnLWluXSwgZmFhZCwgWworICAgICAgIEFDX01TR19DSEVDS0lORyhb Q2hlY2tpbmcgRkFBRDIgdmVyc2lvbiBpbiAkZmFhZF9oZHJdKQorICAgICAgIGZvciBtaW5vciBp biAxMCA5IDggNyA2IDUgMDsgZG8KKyAgICAgICAgIGlmIHRlc3QgeCRmYWFkMl9taW5vcl92ZXJz aW9uID0gIngiOyB0aGVuCistICAgICAgICAgIEFDX0VHUkVQX0NQUChbR1NUX0NIRUNLX0ZBQURf VkVSU0lPTiBcIjJcLiRtaW5vclwiXSwgWworKyAgICAgICAgICBBQ19FR1JFUF9DUFAoW1wiMlwu JG1pbm9yXCIkXSwgWworICAgICAgICAgICAgICAgI2luY2x1ZGUgPCRmYWFkX2hkcj4KKy0gICAg ICAgICAgICAgIEdTVF9DSEVDS19GQUFEX1ZFUlNJT04gRkFBRDJfVkVSU0lPTgorKyAgICAgICAg ICAgICAgRkFBRDJfVkVSU0lPTgorICAgICAgICAgICAgIF0sIFsKKyAgICAgICAgICAgICAgIGZh YWQyX21pbm9yX3ZlcnNpb249JG1pbm9yCisgICAgICAgICAgICAgXSkKLS0gCjIuNS4zCgo=