149982 2015-10-09 18:54:54 -0700 Check if start and end positions are still valid after updating them through VisibleSelection. 2015-10-09 19:54:30 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 138167 1 zalan zalan commit-queue rniwa oldest_to_newest 1132067 0 zalan 2015-10-09 18:54:54 -0700 They could end up being nullptr. 1132068 1 zalan 2015-10-09 18:57:02 -0700 LayoutTests/editing/execCommand/crash-137961.html crashes when https://bug-138167-attachments.webkit.org/attachment.cgi?id=262749 applied. see the stacktrace here: https://bugs.webkit.org/attachment.cgi?id=262728 1132070 2 262811 zalan 2015-10-09 19:03:31 -0700 Created attachment 262811 Patch 1132092 3 262811 commit-queue 2015-10-09 19:54:26 -0700 Comment on attachment 262811 Patch Clearing flags on attachment: 262811 Committed r190835: <http://trac.webkit.org/changeset/190835> 1132093 4 commit-queue 2015-10-09 19:54:30 -0700 All reviewed patches have been landed. Closing bug. 262811 2015-10-09 19:03:31 -0700 2015-10-09 19:54:26 -0700 Patch bug-149982-20151009190258.patch text/plain 3235 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwNjg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2MzOTg5ZjE5NGE5NDFk OTNiMDMyZTMxZDNjNWJlNTNiYmViMmY5YS4uNTEzNWI1NWFlODFmNTU2ZTM1NjU4YTlmYTA5ZDNk NGY0MGE1NTE5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTEwLTA5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgQ2hlY2sgaWYgc3RhcnQgYW5k IGVuZCBwb3NpdGlvbnMgYXJlIHN0aWxsIHZhbGlkIGFmdGVyIHVwZGF0aW5nIHRoZW0gdGhyb3Vn aCBWaXNpYmxlU2VsZWN0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTQ5OTgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGhpcyBwYXRjaCBpcyByZXF1aXJlZCB0byBiZSBhYmxlIHRvIGNsZWFuIHVw IGFub255bW91cyB0YWJsZXMgc3RydWN0dXJlLgorICAgICAgICBJbiBjZXJ0YWluIGVkZ2UgY2Fz ZXMsIHN0YXJ0L2VuZCBwb3NpdGlvbnMgY291bGQgYmVjb21lIG51bGxwdHIgYWZ0ZXIgdmFyaW91 cyB0ZXh0IHNwbGl0dGluZworICAgICAgICBvcGVyYXRpb25zLiAKKworICAgICAgICBDb3ZlcmVk IGJ5IGVkaXRpbmcvZXhlY0NvbW1hbmQvY3Jhc2gtMTM3OTYxLmh0bWwKKworICAgICAgICAqIGVk aXRpbmcvQXBwbHlTdHlsZUNvbW1hbmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXBwbHlTdHls ZUNvbW1hbmQ6OmFwcGx5UmVsYXRpdmVGb250U3R5bGVDaGFuZ2UpOgorICAgICAgICAoV2ViQ29y ZTo6QXBwbHlTdHlsZUNvbW1hbmQ6OmFwcGx5SW5saW5lU3R5bGUpOgorCiAyMDE1LTEwLTA3ICBa YWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmVuZGVyT2JqZWN0Ojpj b21wdXRlUmVjdEZvclJlcGFpbnQvY29tcHV0ZUZsb2F0UmVjdEZvclJlcGFpbnQgc2hvdWxkIHJl dHVybiB0aGUgY29tcHV0ZWQgcmVjdGFuZ2xlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv ZWRpdGluZy9BcHBseVN0eWxlQ29tbWFuZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0Fw cGx5U3R5bGVDb21tYW5kLmNwcAppbmRleCA1OTFmZDg1NGIyYTE3ZDJmYmYxZjhkYmMxYWJjZWMw YTgyZTI1ODBmLi42ZDNlYTYwZWJjZGFkZTRhNzEwMGZmM2UxYTAzMTkyMTRlZjEzNmZmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0FwcGx5U3R5bGVDb21tYW5kLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0FwcGx5U3R5bGVDb21tYW5kLmNwcApAQCAtMzM5LDEy ICszMzksMTggQEAgdm9pZCBBcHBseVN0eWxlQ29tbWFuZDo6YXBwbHlSZWxhdGl2ZUZvbnRTdHls ZUNoYW5nZShFZGl0aW5nU3R5bGUqIHN0eWxlKQogICAgICAgICBlbmQgPSBlbmRQb3NpdGlvbigp OwogICAgIH0KIAorICAgIGlmIChzdGFydC5pc051bGwoKSB8fCBlbmQuaXNOdWxsKCkpCisgICAg ICAgIHJldHVybjsKKwogICAgIGlmIChpc1ZhbGlkQ2FyZXRQb3NpdGlvbkluVGV4dE5vZGUoZW5k KSkgewogICAgICAgICBzcGxpdFRleHRBdEVuZChzdGFydCwgZW5kKTsKICAgICAgICAgc3RhcnQg PSBzdGFydFBvc2l0aW9uKCk7CiAgICAgICAgIGVuZCA9IGVuZFBvc2l0aW9uKCk7CiAgICAgfQog CisgICAgaWYgKHN0YXJ0LmlzTnVsbCgpIHx8IGVuZC5pc051bGwoKSkKKyAgICAgICAgcmV0dXJu OworCiAgICAgLy8gQ2FsY3VsYXRlIGxvb3AgZW5kIHBvaW50LgogICAgIC8vIElmIHRoZSBlbmQg bm9kZSBpcyBiZWZvcmUgdGhlIHN0YXJ0IG5vZGUgKGNhbiBvbmx5IGhhcHBlbiBpZiB0aGUgZW5k IG5vZGUgaXMKICAgICAvLyBhbiBhbmNlc3RvciBvZiB0aGUgc3RhcnQgbm9kZSksIHdlIGdhdGhl ciBub2RlcyB1cCB0byB0aGUgbmV4dCBzaWJsaW5nIG9mIHRoZSBlbmQgbm9kZQpAQCAtNTg2LDYg KzU5Miw5IEBAIHZvaWQgQXBwbHlTdHlsZUNvbW1hbmQ6OmFwcGx5SW5saW5lU3R5bGUoRWRpdGlu Z1N0eWxlKiBzdHlsZSkKICAgICAgICAgc3RhcnREdW1teVNwYW5BbmNlc3RvciA9IGR1bW15U3Bh bkFuY2VzdG9yRm9yTm9kZShzdGFydC5kZXByZWNhdGVkTm9kZSgpKTsKICAgICB9CiAKKyAgICBp ZiAoc3RhcnQuaXNOdWxsKCkgfHwgZW5kLmlzTnVsbCgpKQorICAgICAgICByZXR1cm47CisKICAg ICAvLyBzcGxpdCB0aGUgZW5kIG5vZGUgYW5kIGNvbnRhaW5pbmcgZWxlbWVudCBpZiB0aGUgc2Vs ZWN0aW9uIGVuZHMgaW5zaWRlIG9mIGl0CiAgICAgYm9vbCBzcGxpdEVuZCA9IGlzVmFsaWRDYXJl dFBvc2l0aW9uSW5UZXh0Tm9kZShlbmQpOwogICAgIGlmIChzcGxpdEVuZCkgewpAQCAtNTk4LDYg KzYwNyw5IEBAIHZvaWQgQXBwbHlTdHlsZUNvbW1hbmQ6OmFwcGx5SW5saW5lU3R5bGUoRWRpdGlu Z1N0eWxlKiBzdHlsZSkKICAgICAgICAgZW5kRHVtbXlTcGFuQW5jZXN0b3IgPSBkdW1teVNwYW5B bmNlc3RvckZvck5vZGUoZW5kLmRlcHJlY2F0ZWROb2RlKCkpOwogICAgIH0KIAorICAgIGlmIChz dGFydC5pc051bGwoKSB8fCBlbmQuaXNOdWxsKCkpCisgICAgICAgIHJldHVybjsKKwogICAgIC8v IFJlbW92ZSBzdHlsZSBmcm9tIHRoZSBzZWxlY3Rpb24uCiAgICAgLy8gVXNlIHRoZSB1cHN0cmVh bSBwb3NpdGlvbiBvZiB0aGUgc3RhcnQgZm9yIHJlbW92aW5nIHN0eWxlLgogICAgIC8vIFRoaXMg d2lsbCBlbnN1cmUgd2UgcmVtb3ZlIGFsbCB0cmFjZXMgb2YgdGhlIHJlbGV2YW50IHN0eWxlcyBm cm9tIHRoZSBzZWxlY3Rpb24KQEAgLTY1MCw2ICs2NjIsOSBAQCB2b2lkIEFwcGx5U3R5bGVDb21t YW5kOjphcHBseUlubGluZVN0eWxlKEVkaXRpbmdTdHlsZSogc3R5bGUpCiAgICAgICAgIGVuZCA9 IGVuZFBvc2l0aW9uKCk7CiAgICAgfQogCisgICAgaWYgKHN0YXJ0LmlzTnVsbCgpIHx8IGVuZC5p c051bGwoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgLy8gdXBkYXRlIGRvY3VtZW50IGxheW91 dCBvbmNlIGJlZm9yZSBydW5uaW5nIHRoZSByZXN0IG9mIHRoZSBmdW5jdGlvbgogICAgIC8vIHNv IHRoYXQgd2UgYXZvaWQgdGhlIGV4cGVuc2Ugb2YgdXBkYXRpbmcgYmVmb3JlIGVhY2ggYW5kIGV2 ZXJ5IGNhbGwKICAgICAvLyB0byBjaGVjayBhIGNvbXB1dGVkIHN0eWxlCg==