<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>149980</bug_id>
          
          <creation_ts>2015-10-09 17:26:30 -0700</creation_ts>
          <short_desc>VisitedValueCount GC Counter misses parallel SlotVisitors</short_desc>
          <delta_ts>2015-10-12 12:36:41 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Joseph Pecoraro">joepeck</reporter>
          <assigned_to name="Joseph Pecoraro">joepeck</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>ggaren</cc>
    
    <cc>kling</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1132056</commentid>
    <comment_count>0</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2015-10-09 17:26:30 -0700</bug_when>
    <thetext>VisitedValueCount GC Counter misses parallel SlotVisitors, it only counts the objects the main thread visits.

Not sure how useful this counter is (it is the only one), but lets correct its value.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1132057</commentid>
    <comment_count>1</comment_count>
      <attachid>262806</attachid>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2015-10-09 17:27:44 -0700</bug_when>
    <thetext>Created attachment 262806
[PATCH] Proposed Fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1132413</commentid>
    <comment_count>2</comment_count>
      <attachid>262806</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2015-10-12 12:05:34 -0700</bug_when>
    <thetext>Comment on attachment 262806
[PATCH] Proposed Fix

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1132438</commentid>
    <comment_count>3</comment_count>
      <attachid>262806</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-10-12 12:36:38 -0700</bug_when>
    <thetext>Comment on attachment 262806
[PATCH] Proposed Fix

Clearing flags on attachment: 262806

Committed r190881: &lt;http://trac.webkit.org/changeset/190881&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1132439</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2015-10-12 12:36:41 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>262806</attachid>
            <date>2015-10-09 17:27:44 -0700</date>
            <delta_ts>2015-10-12 12:36:38 -0700</delta_ts>
            <desc>[PATCH] Proposed Fix</desc>
            <filename>visit-counts.patch</filename>
            <type>text/plain</type>
            <size>1315</size>
            <attacher name="Joseph Pecoraro">joepeck</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDFhNjFiMmEuLmRhZGIyMTcgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD
b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE1LTEwLTA5ICBKb3NlcGggUGVjb3Jh
cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgVmlzaXRlZFZhbHVlQ291bnQgR0Mg
Q291bnRlciBtaXNzZXMgcGFyYWxsZWwgU2xvdFZpc2l0b3JzCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDk5ODAKKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGhlYXAvSGVhcC5jcHA6CisgICAgICAgIChK
U0M6OkhlYXA6OnVwZGF0ZU9iamVjdENvdW50cyk6CisgICAgICAgIEluY2x1ZGUgdGhyZWFkZWQg
c2xvdCB2aXNpdG9yJ3Mgb2JqZWN0IGNvdW50cyBpbiB0aGUgZGVidWdnaW5nIHZhbHVlLgorCisy
MDE1LTEwLTA5ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAg
ICAgUmVtb3ZlIHVudXNlZCBSZWN1cnNpdmVBbGxvY2F0aW9uU2NvcGUKICAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTk2NwogCmRpZmYgLS1naXQgYS9T
b3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9oZWFwL0hlYXAuY3BwCmluZGV4IDY4NTYyMDYuLjdkZjM3MjkgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9oZWFwL0hlYXAuY3BwCkBAIC04NTEsNyArODUxLDcgQEAgdm9pZCBIZWFwOjp2aXNpdFdlYWtI
YW5kbGVzKEhlYXBSb290VmlzaXRvciYgdmlzaXRvcikKIAogdm9pZCBIZWFwOjp1cGRhdGVPYmpl
Y3RDb3VudHMoZG91YmxlIGdjU3RhcnRUaW1lKQogewotICAgIEdDQ09VTlRFUihWaXNpdGVkVmFs
dWVDb3VudCwgbV9zbG90VmlzaXRvci52aXNpdENvdW50KCkpOworICAgIEdDQ09VTlRFUihWaXNp
dGVkVmFsdWVDb3VudCwgbV9zbG90VmlzaXRvci52aXNpdENvdW50KCkgKyB0aHJlYWRWaXNpdENv
dW50KCkpOwogCiAgICAgaWYgKE9wdGlvbnM6OmxvZ0dDKCkgPT0gR0NMb2dnaW5nOjpWZXJib3Nl
KSB7CiAgICAgICAgIHNpemVfdCB2aXNpdENvdW50ID0gbV9zbG90VmlzaXRvci52aXNpdENvdW50
KCk7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>