149962 2015-10-09 11:49:20 -0700 Modernize and cleanup an NSNumber constant 2015-10-09 16:20:32 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue oldest_to_newest 1131968 0 joepeck 2015-10-09 11:49:20 -0700 [NSNumber numberWithBool:true] is confusing as it normally takes a YES/NO. Either way it can be modernized to @YES. 1131969 1 262783 joepeck 2015-10-09 11:49:56 -0700 Created attachment 262783 [PATCH] Proposed Fix 1132040 2 262783 commit-queue 2015-10-09 16:20:29 -0700 Comment on attachment 262783 [PATCH] Proposed Fix Clearing flags on attachment: 262783 Committed r190831: <http://trac.webkit.org/changeset/190831> 1132041 3 commit-queue 2015-10-09 16:20:32 -0700 All reviewed patches have been landed. Closing bug. 262783 2015-10-09 11:49:56 -0700 2015-10-09 16:20:29 -0700 [PATCH] Proposed Fix modernize.patch text/plain 1291 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNWaXJ0dWFsTWFjaGluZS5t bSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNWaXJ0dWFsTWFjaGluZS5tbQppbmRleCA5 YWE5MmQ0Li5mZGY1ZDIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pT VmlydHVhbE1hY2hpbmUubW0KKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1ZpcnR1 YWxNYWNoaW5lLm1tCkBAIC0xNTYsNyArMTU2LDcgQEAgLSAoYm9vbClpc09sZEV4dGVybmFsT2Jq ZWN0OihpZClvYmplY3QKIC0gKHZvaWQpYWRkRXh0ZXJuYWxSZW1lbWJlcmVkT2JqZWN0OihpZClv YmplY3QKIHsKICAgICBBU1NFUlQoW3NlbGYgaXNPbGRFeHRlcm5hbE9iamVjdDpvYmplY3RdKTsK LSAgICBbbV9leHRlcm5hbFJlbWVtYmVyZWRTZXQgc2V0T2JqZWN0OltOU051bWJlciBudW1iZXJX aXRoQm9vbDp0cnVlXSBmb3JLZXk6b2JqZWN0XTsKKyAgICBbbV9leHRlcm5hbFJlbWVtYmVyZWRT ZXQgc2V0T2JqZWN0OkBZRVMgZm9yS2V5Om9iamVjdF07CiB9CiAKIC0gKHZvaWQpYWRkTWFuYWdl ZFJlZmVyZW5jZTooaWQpb2JqZWN0IHdpdGhPd25lcjooaWQpb3duZXIKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nCmluZGV4IGExMjY4NzQuLjRmOWFiNmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpA QCAtMSw1ICsxLDE1IEBACiAyMDE1LTEwLTA5ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0Bh cHBsZS5jb20+CiAKKyAgICAgICAgTW9kZXJuaXplIGFuZCBjbGVhbnVwIGFuIE5TTnVtYmVyIGNv bnN0YW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NDk5NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IEFQSS9KU1ZpcnR1YWxNYWNoaW5lLm1tOgorICAgICAgICAoLVtKU1ZpcnR1YWxNYWNoaW5lIGFk ZEV4dGVybmFsUmVtZW1iZXJlZE9iamVjdDpdKToKKworMjAxNS0xMC0wOSAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIE5vIG5lZWQgdG8ga2VlcCBzZXR0 aW5nIG5lZWRzVmlzaXQgZmxhZyBpbiBTbWFsbFN0cmluZ3MKICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTk2MQogCg==