149961 2015-10-09 11:45:35 -0700 No need to keep setting needsVisit flag in SmallStrings 2015-10-09 16:18:36 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck benjamin commit-queue ggaren oldest_to_newest 1131966 0 joepeck 2015-10-09 11:45:35 -0700 No need to keep setting needsVisit flag in SmallStrings. The strings are all setup before GC is enabled by the VM, and all in private functions. No need to keep updating the flag if it couldn't have changed. 1131967 1 262782 joepeck 2015-10-09 11:47:26 -0700 Created attachment 262782 [PATCH] Proposed Fix 1132036 2 262782 commit-queue 2015-10-09 16:18:33 -0700 Comment on attachment 262782 [PATCH] Proposed Fix Clearing flags on attachment: 262782 Committed r190829: <http://trac.webkit.org/changeset/190829> 1132037 3 commit-queue 2015-10-09 16:18:36 -0700 All reviewed patches have been landed. Closing bug. 262782 2015-10-09 11:47:26 -0700 2015-10-09 16:18:33 -0700 [PATCH] Proposed Fix smallstrings.patch text/plain 3140 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGZmNWIwNGEuLmExMjY4NzQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTEwLTA5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgTm8gbmVlZCB0byBrZWVwIHNldHRp bmcgbmVlZHNWaXNpdCBmbGFnIGluIFNtYWxsU3RyaW5ncworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5OTYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU21hbGxTdHJpbmdzIGFyZSBhbGwgaW5pdGlhbGl6 ZWQgYXQgb25jZSBwcml2YXRlbHkgYmVmb3JlIHRoZSBWTQorICAgICAgICBlbmFibGVzIEdhcmJh Z2UgQ29sbGVjdGlvbi4gVGhlcmUgaXMgbm8gbmVlZCB0byBrZWVwIHVwZGF0aW5nCisgICAgICAg IHRoaXMgZmxhZywgYXMgaXQgY291bGRuJ3QgaGF2ZSBjaGFuZ2VkLgorCisgICAgICAgICogcnVu dGltZS9TbWFsbFN0cmluZ3MuY3BwOgorICAgICAgICAoSlNDOjpTbWFsbFN0cmluZ3M6OmNyZWF0 ZUVtcHR5U3RyaW5nKToKKyAgICAgICAgKEpTQzo6U21hbGxTdHJpbmdzOjpjcmVhdGVTaW5nbGVD aGFyYWN0ZXJTdHJpbmcpOgorICAgICAgICAoSlNDOjpTbWFsbFN0cmluZ3M6OmluaXRpYWxpemUp OgorICAgICAgICAqIHJ1bnRpbWUvU21hbGxTdHJpbmdzLmg6CisKIDIwMTUtMTAtMDggIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIGJ1 aWxkIGZpeC4gTWlzc2luZyBmb3J3YXJkIGRlY2xhcmF0aW9uLgpkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU21hbGxTdHJpbmdzLmNwcCBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL1NtYWxsU3RyaW5ncy5jcHAKaW5kZXggOWM2YTQzYS4uNzYzMTZiNyAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU21hbGxTdHJpbmdzLmNw cAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TbWFsbFN0cmluZ3MuY3BwCkBA IC0xMDksNyArMTA5LDcgQEAgdm9pZCBTbWFsbFN0cmluZ3M6OmNyZWF0ZUVtcHR5U3RyaW5nKFZN KiB2bSkKIHsKICAgICBBU1NFUlQoIW1fZW1wdHlTdHJpbmcpOwogICAgIG1fZW1wdHlTdHJpbmcg PSBKU1N0cmluZzo6Y3JlYXRlSGFzT3RoZXJPd25lcigqdm0sIFN0cmluZ0ltcGw6OmVtcHR5KCkp OwotICAgIG1fbmVlZHNUb0JlVmlzaXRlZCA9IHRydWU7CisgICAgQVNTRVJUKG1fbmVlZHNUb0Jl VmlzaXRlZCk7CiB9CiAKIHZvaWQgU21hbGxTdHJpbmdzOjpjcmVhdGVTaW5nbGVDaGFyYWN0ZXJT dHJpbmcoVk0qIHZtLCB1bnNpZ25lZCBjaGFyIGNoYXJhY3RlcikKQEAgLTExOCw3ICsxMTgsNyBA QCB2b2lkIFNtYWxsU3RyaW5nczo6Y3JlYXRlU2luZ2xlQ2hhcmFjdGVyU3RyaW5nKFZNKiB2bSwg dW5zaWduZWQgY2hhciBjaGFyYWN0ZXIpCiAgICAgICAgIG1fc3RvcmFnZSA9IHN0ZDo6bWFrZV91 bmlxdWU8U21hbGxTdHJpbmdzU3RvcmFnZT4oKTsKICAgICBBU1NFUlQoIW1fc2luZ2xlQ2hhcmFj dGVyU3RyaW5nc1tjaGFyYWN0ZXJdKTsKICAgICBtX3NpbmdsZUNoYXJhY3RlclN0cmluZ3NbY2hh cmFjdGVyXSA9IEpTU3RyaW5nOjpjcmVhdGVIYXNPdGhlck93bmVyKCp2bSwgUGFzc1JlZlB0cjxT dHJpbmdJbXBsPihtX3N0b3JhZ2UtPnJlcChjaGFyYWN0ZXIpKSk7Ci0gICAgbV9uZWVkc1RvQmVW aXNpdGVkID0gdHJ1ZTsKKyAgICBBU1NFUlQobV9uZWVkc1RvQmVWaXNpdGVkKTsKIH0KIAogU3Ry aW5nSW1wbCogU21hbGxTdHJpbmdzOjpzaW5nbGVDaGFyYWN0ZXJTdHJpbmdSZXAodW5zaWduZWQg Y2hhciBjaGFyYWN0ZXIpCkBAIC0xMzEsNyArMTMxLDcgQEAgU3RyaW5nSW1wbCogU21hbGxTdHJp bmdzOjpzaW5nbGVDaGFyYWN0ZXJTdHJpbmdSZXAodW5zaWduZWQgY2hhciBjaGFyYWN0ZXIpCiB2 b2lkIFNtYWxsU3RyaW5nczo6aW5pdGlhbGl6ZShWTSogdm0sIEpTU3RyaW5nKiYgc3RyaW5nLCBj b25zdCBjaGFyKiB2YWx1ZSkKIHsKICAgICBzdHJpbmcgPSBKU1N0cmluZzo6Y3JlYXRlKCp2bSwg SWRlbnRpZmllcjo6ZnJvbVN0cmluZyh2bSwgdmFsdWUpLmltcGwoKSk7Ci0gICAgbV9uZWVkc1Rv QmVWaXNpdGVkID0gdHJ1ZTsKKyAgICBBU1NFUlQobV9uZWVkc1RvQmVWaXNpdGVkKTsKIH0KIAog fSAvLyBuYW1lc3BhY2UgSlNDCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9TbWFsbFN0cmluZ3MuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1NtYWxs U3RyaW5ncy5oCmluZGV4IDkwOWJhZTEuLjc0ZjZlMjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL1NtYWxsU3RyaW5ncy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL1NtYWxsU3RyaW5ncy5oCkBAIC00OCw3ICs0OCw2IEBAIGNsYXNzIFN0cmlu Z0ltcGw7CiAKIG5hbWVzcGFjZSBKU0MgewogCi1jbGFzcyBIZWFwUm9vdFZpc2l0b3I7CiBjbGFz cyBWTTsKIGNsYXNzIEpTU3RyaW5nOwogY2xhc3MgU21hbGxTdHJpbmdzU3RvcmFnZTsKQEAgLTEy Myw4ICsxMjIsOCBAQCBwdWJsaWM6CiBwcml2YXRlOgogICAgIHN0YXRpYyBjb25zdCB1bnNpZ25l ZCBzaW5nbGVDaGFyYWN0ZXJTdHJpbmdDb3VudCA9IG1heFNpbmdsZUNoYXJhY3RlclN0cmluZyAr IDE7CiAKLSAgICBKU19FWFBPUlRfUFJJVkFURSB2b2lkIGNyZWF0ZUVtcHR5U3RyaW5nKFZNKik7 Ci0gICAgSlNfRVhQT1JUX1BSSVZBVEUgdm9pZCBjcmVhdGVTaW5nbGVDaGFyYWN0ZXJTdHJpbmco Vk0qLCB1bnNpZ25lZCBjaGFyKTsKKyAgICB2b2lkIGNyZWF0ZUVtcHR5U3RyaW5nKFZNKik7Cisg ICAgdm9pZCBjcmVhdGVTaW5nbGVDaGFyYWN0ZXJTdHJpbmcoVk0qLCB1bnNpZ25lZCBjaGFyKTsK IAogICAgIHZvaWQgaW5pdGlhbGl6ZShWTSosIEpTU3RyaW5nKiYsIGNvbnN0IGNoYXIqIHZhbHVl KTsKIAo=