149955 2015-10-09 08:27:26 -0700 Fix the !ENABLE(STREAM_API) build after r190794 2015-10-09 10:09:05 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 149751 1 ossy ossy bburg calvaris commit-queue darin youennf oldest_to_newest 1131915 0 ossy 2015-10-09 08:27:26 -0700 http://trac.webkit.org/changeset/190794 broke the !ENABLE(STREAM_API) build: In file included from ../../Source/WebCore/bindings/js/JSDOMWindowBase.h:25:0, from DerivedSources/WebCore/JSDOMWindow.h:25, from ../../Source/WebCore/bindings/js/JSDOMGlobalObject.cpp:31: ../../Source/WebCore/bindings/js/WebCoreJSBuiltinInternals.h:39:34: error: unused parameter ‘visitor’ [-Werror=unused-parameter] void visit(JSC::SlotVisitor& visitor) { ^ ../../Source/WebCore/bindings/js/WebCoreJSBuiltinInternals.h:44:36: error: unused parameter ‘globalObject’ [-Werror=unused-parameter] void init(JSC::JSGlobalObject& globalObject) { ^ cc1plus: all warnings being treated as errors 1131916 1 262774 ossy 2015-10-09 08:28:43 -0700 Created attachment 262774 Patch 1131917 2 youennf 2015-10-09 08:32:15 -0700 Thanks for fixing it. LGTM. 1131941 3 262774 commit-queue 2015-10-09 10:08:58 -0700 Comment on attachment 262774 Patch Clearing flags on attachment: 262774 Committed r190804: <http://trac.webkit.org/changeset/190804> 1131942 4 commit-queue 2015-10-09 10:09:05 -0700 All reviewed patches have been landed. Closing bug. 262774 2015-10-09 08:28:43 -0700 2015-10-09 10:08:58 -0700 Patch bug-149955-20151009172810.patch text/plain 1619 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwNzk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWMxNzJiZDA5MTUxZTc2 NDkxOTgxMjg2MDZlMzJiMGZiYWUwMmEzOS4uODBmY2FkNjA5MWEwNThjOTMxNmQwZWYzNzdjZDc5 NWFkMDU0NmI2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTEwLTA5ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSAhRU5B QkxFKFNUUkVBTV9BUEkpIGJ1aWxkIGFmdGVyIHIxOTA3OTQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTk1NQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYmluZGluZ3MvanMvV2ViQ29yZUpTQnVpbHRp bkludGVybmFscy5oOgorICAgICAgICAoV2ViQ29yZTo6SlNCdWlsdGluSW50ZXJuYWxGdW5jdGlv bnM6OnZpc2l0KToKKyAgICAgICAgKFdlYkNvcmU6OkpTQnVpbHRpbkludGVybmFsRnVuY3Rpb25z Ojppbml0KToKKwogMjAxNS0xMC0wOSAgWGFiaWVyIFJvZHJpZ3VleiBDYWx2YXIgIDxjYWx2YXJp c0BpZ2FsaWEuY29tPiBhbmQgWW91ZW5uIEZhYmxldCAgPHlvdWVubi5mYWJsZXRAY3JmLmNhbm9u LmZyPgogCiAgICAgICAgIFJlZmFjdG9yIFdlYkNvcmUgSlMgYnVpbHRpbnMgdG8gcHJlcGFyZSBm b3IgYXV0b21hdGljIGdlbmVyYXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL2pzL1dlYkNvcmVKU0J1aWx0aW5JbnRlcm5hbHMuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL2pzL1dlYkNvcmVKU0J1aWx0aW5JbnRlcm5hbHMuaAppbmRleCBkZjYzNzkzNzdmMDk5MTMx ZmM0YmI4OWM3ZDRjZTczZjliMjZkNWJjLi4wZmQ5ZTA5Y2ZhMDhjNjhkOWE5OTIwMzRiYjBkMTM2 ZDBhZjQ4MTc1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9XZWJDb3Jl SlNCdWlsdGluSW50ZXJuYWxzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvV2Vi Q29yZUpTQnVpbHRpbkludGVybmFscy5oCkBAIC0zOSwxMSArMzksMTUgQEAgZXhwbGljaXQgSlNC dWlsdGluSW50ZXJuYWxGdW5jdGlvbnMoSlNDOjpWTSYgdikKICAgICB2b2lkIHZpc2l0KEpTQzo6 U2xvdFZpc2l0b3ImIHZpc2l0b3IpIHsKICNpZiBFTkFCTEUoU1RSRUFNU19BUEkpCiAgICAgICAg IG1fcmVhZGFibGVTdHJlYW1JbnRlcm5hbHNGdW5jdGlvbnMudmlzaXQodmlzaXRvcik7CisjZWxz ZQorICAgICAgICBVTlVTRURfUEFSQU0odmlzaXRvcik7CiAjZW5kaWYKICAgICB9CiAgICAgdm9p ZCBpbml0KEpTQzo6SlNHbG9iYWxPYmplY3QmIGdsb2JhbE9iamVjdCkgewogI2lmIEVOQUJMRShT VFJFQU1TX0FQSSkKICAgICAgICAgbV9yZWFkYWJsZVN0cmVhbUludGVybmFsc0Z1bmN0aW9ucy5p bml0KGdsb2JhbE9iamVjdCk7CisjZWxzZQorICAgICAgICBVTlVTRURfUEFSQU0oZ2xvYmFsT2Jq ZWN0KTsKICNlbmRpZgogICAgIH0KIAo=