149949 2015-10-09 02:01:53 -0700 Fix webkitpy tests after r190779 2015-10-09 02:08:14 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 149944 1 ossy ossy commit-queue dewei_zhu glenn lforschler ossy rniwa oldest_to_newest 1131864 0 ossy 2015-10-09 02:01:53 -0700 https://trac.webkit.org/changeset/190779 broke 6 webkitpy tests. 1131866 1 ossy 2015-10-09 02:04:43 -0700 benchmark_results_unittest.BenchmarkResultsTest.test_format_values_with_no_error erred: Traceback (most recent call last): File "/home/webkit/WebKit/Tools/Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py", line 101, in test_format_values_with_no_error self.assertEqual(BenchmarkResults._format_values('Time', [1, 1, 1]), '1.00ms stdev=0.0%') TypeError: _format_values() takes exactly 4 arguments (3 given) [5/1442] webkitpy.benchmark_runner.benchmark_results_unittest.BenchmarkResultsTest.test_format_values_with_small_error erred: Traceback (most recent call last): File "/home/webkit/WebKit/Tools/Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py", line 74, in test_format_values_with_small_error self.assertEqual(BenchmarkResults._format_values('Runs', [1.1, 1.2, 1.3]), '1.20/s stdev=8.3%') TypeError: _format_values() takes exactly 4 arguments (3 given) [8/1442] webkitpy.benchmark_runner.benchmark_results_unittest.BenchmarkResultsTest.test_format_values_with_large_error erred: Traceback (most recent call last): File "/home/webkit/WebKit/Tools/Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py", line 59, in test_format_values_with_large_error self.assertEqual(BenchmarkResults._format_values('Runs', [1, 2, 3]), '2.0/s stdev=50.0%') TypeError: _format_values() takes exactly 4 arguments (3 given) [9/1442] webkitpy.benchmark_runner.benchmark_results_unittest.BenchmarkResultsTest.test_format erred: Traceback (most recent call last): File "/home/webkit/WebKit/Tools/Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py", line 38, in test_format self.assertEqual(result.format(), 'SomeTest:Time: 2.0ms stdev=50.0%\n') TypeError: format() takes exactly 2 arguments (1 given) [10/1442] webkitpy.benchmark_runner.benchmark_results_unittest.BenchmarkResultsTest.test_format_values_with_small_difference erred: Traceback (most recent call last): File "/home/webkit/WebKit/Tools/Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py", line 104, in test_format_values_with_small_difference self.assertEqual(BenchmarkResults._format_values('Time', [5, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4]), TypeError: _format_values() takes exactly 4 arguments (3 given) [11/1442] webkitpy.benchmark_runner.benchmark_results_unittest.BenchmarkResultsTest.test_format_values_with_time erred: Traceback (most recent call last): File "/home/webkit/WebKit/Tools/Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py", line 89, in test_format_values_with_time self.assertEqual(BenchmarkResults._format_values('Time', [1, 2, 3]), '2.0ms stdev=50.0%') TypeError: _format_values() takes exactly 4 arguments (3 given) 1131867 2 262757 ossy 2015-10-09 02:05:56 -0700 Created attachment 262757 Patch 1131868 3 rniwa 2015-10-09 02:06:40 -0700 Thanks for the fix! 1131869 4 262757 ossy 2015-10-09 02:08:07 -0700 Comment on attachment 262757 Patch Clearing flags on attachment: 262757 Committed r190782: <http://trac.webkit.org/changeset/190782> 1131870 5 ossy 2015-10-09 02:08:14 -0700 All reviewed patches have been landed. Closing bug. 262757 2015-10-09 02:05:56 -0700 2015-10-09 02:08:07 -0700 Patch bug-149949-20151009020522.patch text/plain 1701 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwNzgxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTg1NWNiOGUwM2E3YzA5ZDNlMmViZjRkZDIxNDM3Mjk1 M2I4NjJhYS4uZTY3MDdjM2E1YWJlYmFiNjdmMDMwYmExMjAzYWE3MDk4NDYyMDQ4MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE1LTEwLTA5ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgRml4IHdlYmtpdHB5IHRlc3RzIGFmdGVyIHIxOTA3NzkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTk0OQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9iZW5j aG1hcmtfcnVubmVyL2JlbmNobWFya19yZXN1bHRzLnB5OgorICAgICAgICAoQmVuY2htYXJrUmVz dWx0cy5mb3JtYXQpOgorICAgICAgICAoQmVuY2htYXJrUmVzdWx0cy5fZm9ybWF0X3ZhbHVlcyk6 CisKIDIwMTUtMTAtMDggIERld2VpIFpodSAgPGRld2VpX3podUBhcHBsZS5jb20+CiAKICAgICAg ICAgRXh0ZW5kIHJ1bi1iZW5jaG1hcmsgc2NyaXB0IHRvIHN1cHBvcnQgaHVtYW4tcmVhZGFibGUg cmVzdWx0cyBjb252ZXJzaW9uLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9i ZW5jaG1hcmtfcnVubmVyL2JlbmNobWFya19yZXN1bHRzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9iZW5jaG1hcmtfcnVubmVyL2JlbmNobWFya19yZXN1bHRzLnB5CmluZGV4IGE4NjY3Njcx NDUwNjc4Yzk1NTM4NmY3MTI5MTk2OTg2ZGE5NzlmMTEuLjAxOGU1YjQ0NmI2ZDE3NTk2NzRjYTdj MWY4ZDg5MmFlZTU3ZTU5NzMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvYmVu Y2htYXJrX3J1bm5lci9iZW5jaG1hcmtfcmVzdWx0cy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2JlbmNobWFya19ydW5uZXIvYmVuY2htYXJrX3Jlc3VsdHMucHkKQEAgLTQ4LDcgKzQ4 LDcgQEAgY2xhc3MgQmVuY2htYXJrUmVzdWx0cyhvYmplY3QpOgogICAgICAgICBzZWxmLl9saW50 X3Jlc3VsdHMocmVzdWx0cykKICAgICAgICAgc2VsZi5fcmVzdWx0cyA9IHNlbGYuX2FnZ3JlZ2F0 ZV9yZXN1bHRzKHJlc3VsdHMpCiAKLSAgICBkZWYgZm9ybWF0KHNlbGYsIHNjYWxlX3VuaXQpOgor ICAgIGRlZiBmb3JtYXQoc2VsZiwgc2NhbGVfdW5pdD1UcnVlKToKICAgICAgICAgcmV0dXJuIHNl bGYuX2Zvcm1hdF90ZXN0cyhzZWxmLl9yZXN1bHRzLCBzY2FsZV91bml0KQogCiAgICAgQGNsYXNz bWV0aG9kCkBAIC03Nyw3ICs3Nyw3IEBAIGNsYXNzIEJlbmNobWFya1Jlc3VsdHMob2JqZWN0KToK ICAgICAgICAgcmV0dXJuIG91dHB1dAogCiAgICAgQGNsYXNzbWV0aG9kCi0gICAgZGVmIF9mb3Jt YXRfdmFsdWVzKGNscywgbWV0cmljX25hbWUsIHZhbHVlcywgc2NhbGVfdW5pdCk6CisgICAgZGVm IF9mb3JtYXRfdmFsdWVzKGNscywgbWV0cmljX25hbWUsIHZhbHVlcywgc2NhbGVfdW5pdD1UcnVl KToKICAgICAgICAgdmFsdWVzID0gbWFwKGZsb2F0LCB2YWx1ZXMpCiAgICAgICAgIHRvdGFsID0g c3VtKHZhbHVlcykKICAgICAgICAgbWVhbiA9IHRvdGFsIC8gbGVuKHZhbHVlcykK