149943 2015-10-08 20:42:03 -0700 Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK 2015-10-08 21:02:29 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build iPhone / iPad iOS 9.0 RESOLVED FIXED P2 Normal --- 149913 1 dbates dbates ap ddkilzer lforschler oldest_to_newest 1131812 0 dbates 2015-10-08 20:42:03 -0700 Following the patch for bug #149913 we can teach build-webkit to install the iOS LLVM binaries/headers that are included in WebKitLibraries when building for device with the public iOS SDK. 1131813 1 262739 dbates 2015-10-08 20:45:05 -0700 Created attachment 262739 Patch 1131814 2 262739 mitz 2015-10-08 20:50:42 -0700 Comment on attachment 262739 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262739&action=review > Tools/Scripts/build-webkit:198 > + if (my $hasInternalSDK = (xcodeSDK() || "") eq "iphoneos.internal") { I don’t think you need to check for undefined xcodeSDK() here 1131815 3 dbates 2015-10-08 20:51:45 -0700 (In reply to comment #2) > Comment on attachment 262739 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=262739&action=review > > > Tools/Scripts/build-webkit:198 > > + if (my $hasInternalSDK = (xcodeSDK() || "") eq "iphoneos.internal") { > > I don’t think you need to check for undefined xcodeSDK() here You're right! This line should read: if (my $hasInternalSDK = xcodeSDK() eq "iphoneos.internal") { Will change before landing. 1131816 4 dbates 2015-10-08 21:02:29 -0700 Committed r190775: <http://trac.webkit.org/changeset/190775> 262739 2015-10-08 20:45:05 -0700 2015-10-08 20:50:42 -0700 Patch bug-149943-20151008204432.patch text/plain 2256 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwNzY0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWVlMmYzOGE5NzM3YjllY2FkYTliOWI4OWU5YzAyZDcw MDgwNTk1Ni4uZWM0NWY0MDVlOTM2NDdlNDBiYjlhZmJmN2Q2ZjA5MWIzNDdiZmZlZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3 IEBACiAyMDE1LTEwLTA4ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAorICAg ICAgICBUZWFjaCBidWlsZC13ZWJraXQgdG8gaW5zdGFsbCBMTFZNIGJpbmFyaWVzIGZvciBpT1Mg d2hlbiBidWlsZGluZyBmb3IgZGV2aWNlIHdpdGggdGhlIHB1YmxpYyBpT1MgU0RLCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDk5NDMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGb2xsb3dpbmcgdGhlIGFk ZGl0aW9uIG9mIHRoZSBMTFZNIGJpbmFyaWVzIGZvciBpT1MgaW4gY2hhbmdlc2V0IHIxOTA3NTkg KGJ1ZyAjMTQ5OTEzKSB3ZSBzaG91bGQKKyAgICAgICAgdGVhY2ggYnVpbGQtd2Via2l0IHRvIGlu c3RhbGwgdGhlbSB3aGVuIGJ1aWxkaW5nIGZvciBpT1MgZGV2aWNlIHVzaW5nIHRoZSBwdWJsaWMg aU9TIFNESy4gCisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDoKKworMjAxNS0xMC0w OCAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CisKICAgICAgICAgQWRkIExMVk0g YmluYXJpZXMgZm9yIGlPUyA5IGRldmljZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5OTEzCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvYnVp bGQtd2Via2l0IGIvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKaW5kZXggZDg2YmM1ODgwODY1 MjRkZTU5YWMyMjQ1NDI3ZWQ4ZjEyNGNkZjI0Yy4uZDI2Nzg4NDVkM2Q0NDBiOTc1OGJlMjhjNTVi MzVmMzViYzczZmY1YSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKKysr IGIvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKQEAgLTE5MywxMiArMTkzLDE2IEBAIGlmIChp c0FwcGxlTWFjV2ViS2l0KCkpIHsKICAgICAgICAgcHJpbnQoam9pbigiICIsIEBjb3B5TGlicmFy aWVzQXJncykgLiAiXG4iKTsKICAgICAgICAgKHN5c3RlbShAY29weUxpYnJhcmllc0FyZ3MpID09 IDApIG9yIGRpZTsKICAgICB9IGVsc2UgewotICAgICAgICBteSBAY29weUxpYnJhcmllc0FyZ3Mg PSAoCi0gICAgICAgICAgICAicGVybCIsICJUb29scy9TY3JpcHRzL2NvcHktd2Via2l0bGlicmFy aWVzLXRvLXByb2R1Y3QtZGlyZWN0b3J5IiwKLSAgICAgICAgICAgICItLXNkayIsIHhjb2RlU0RL KCksICItLXdrc2kiLCAiLS1sbHZtIiwgIi0tcHJlZmVyLXN5c3RlbS1sbHZtIiwKLSAgICAgICAg ICAgICItLWxsdm0tc3ViZGlyZWN0b3J5IiwgImludGVybmFsLWxsdm0iLCBwcm9kdWN0RGlyKCks Ci0gICAgICAgICAgICAiLS1sbHZtLXByZWZpeCIsICIvdXNyL2xvY2FsIgotICAgICAgICApOwor ICAgICAgICBteSBAY29weUxpYnJhcmllc0FyZ3MgPSAoInBlcmwiLCAiVG9vbHMvU2NyaXB0cy9j b3B5LXdlYmtpdGxpYnJhcmllcy10by1wcm9kdWN0LWRpcmVjdG9yeSIsICItLXNkayIsIHhjb2Rl U0RLKCksICItLXdrc2kiKTsKKyAgICAgICAgcHVzaCBAY29weUxpYnJhcmllc0FyZ3MsICItLWxs dm0iIGlmIHdpbGxVc2VJT1NEZXZpY2VTREtXaGVuQnVpbGRpbmcoKTsKKyAgICAgICAgaWYgKG15 ICRoYXNJbnRlcm5hbFNESyA9ICh4Y29kZVNESygpIHx8ICIiKSBlcSAiaXBob25lb3MuaW50ZXJu YWwiKSB7CisgICAgICAgICAgICBwdXNoIEBjb3B5TGlicmFyaWVzQXJncywgKAorICAgICAgICAg ICAgICAgICItLXByZWZlci1zeXN0ZW0tbGx2bSIsCisgICAgICAgICAgICAgICAgIi0tbGx2bS1z dWJkaXJlY3RvcnkiLCAiaW50ZXJuYWwtbGx2bSIsCisgICAgICAgICAgICAgICAgIi0tbGx2bS1w cmVmaXgiLCAiL3Vzci9sb2NhbCIsCisgICAgICAgICAgICApOworICAgICAgICB9CisgICAgICAg IHB1c2ggQGNvcHlMaWJyYXJpZXNBcmdzLCBwcm9kdWN0RGlyKCk7CiAgICAgICAgIHByaW50KGpv aW4oIiAiLCBAY29weUxpYnJhcmllc0FyZ3MpIC4gIlxuIik7CiAgICAgICAgIChzeXN0ZW0oQGNv cHlMaWJyYXJpZXNBcmdzKSA9PSAwKSBvciBkaWU7CiAK