149928 2015-10-08 10:23:43 -0700 Update Inspector to only work with Legacy IDB (for now) 2015-10-08 10:36:17 -0700 1 1 1 Unclassified WebKit WebCore Misc. Safari 9 Unspecified Unspecified RESOLVED FIXED P2 Normal --- 149117 1 beidson webkit-unassigned alecflett commit-queue jsbell oldest_to_newest 1131679 0 beidson 2015-10-08 10:23:43 -0700 Update Inspector to only work with Legacy IDB (for now) Modern IDB (https://bugs.webkit.org/show_bug.cgi?id=149117) doesn't work exactly the same way as the inspector expects, but all of the required functionality isn't in place yet, so it'll be easiest to just disable it in the inspector for now. 1131681 1 262700 beidson 2015-10-08 10:28:29 -0700 Created attachment 262700 Patch v1 1131685 2 beidson 2015-10-08 10:36:17 -0700 https://trac.webkit.org/changeset/190731 262700 2015-10-08 10:28:29 -0700 2015-10-08 10:34:23 -0700 Patch v1 patch text/plain 4790 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1ZGI2NjI4Li42ZGEzMmZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTUtMTAtMDggIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIFVwZGF0ZSBJbnNwZWN0b3IgdG8gb25seSB3b3JrIHdpdGggTGVnYWN5IElEQiAoZm9yIG5v dykuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDk5 MjguCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBN b2R1bGVzL2luZGV4ZWRkYi9JREJBbnkuaDoKKyAgICAgICAgKFdlYkNvcmU6OklEQkFueTo6aXNM ZWdhY3kpOgorICAgICAgICAKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9sZWdhY3kvTGVn YWN5QW55Lmg6CisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckluZGV4ZWREQkFnZW50LmNw cDoKKwogMjAxNS0xMC0wOCAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAg ICAgICAgQ3Jhc2hUcmFjZXI6IFtVU0VSXSBjb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQgYXQg 4oCmQ29yZTo6U2VsZWN0b3JDaGVja2VyOjpjaGVja1Njcm9sbGJhclBzZXVkb0NsYXNzIGNvbnN0 ICsgMjE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJB bnkuaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkFueS5oCmluZGV4IDEz OGRlNDcuLjViOGJkYjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhl ZGRiL0lEQkFueS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkFu eS5oCkBAIC02OCw2ICs2OCwxMCBAQCBwdWJsaWM6CiAgICAgICAgIEtleVBhdGgsCiAgICAgfTsK IAorICAgIC8vIEZJWE1FOiBUaGlzIGlzIGEgdGVtcG9yYXJ5IGhhY2sgdG8gYWxsb3cgY2FzdHMg aW4gV2ViSW5zcGVjdG9yIGNvZGUgd2hpbGUgTW9kZXJuIElEQiBhbmQgTGVnYWN5IElEQiBsaXZl IHNpZGUtYnktc2lkZS4KKyAgICAvLyBJdCBzaG91bGQgYmUgcmVtb3ZlZCB3aGVuIHRoZSBsZWdh Y3kgaW1wbGVtZW50YXRpb24gaXMgcmVtb3ZlZCBhcyBwYXJ0IG9mIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDkxMTcKKyAgICB2aXJ0dWFsIGJvb2wgaXNMZWdhY3ko KSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQorCiAgICAgdmlydHVhbCBUeXBlIHR5cGUoKSBjb25z dCA9IDA7CiAgICAgdmlydHVhbCBSZWZQdHI8RE9NU3RyaW5nTGlzdD4gZG9tU3RyaW5nTGlzdCgp ID0gMDsKICAgICB2aXJ0dWFsIFJlZlB0cjxJREJDdXJzb3I+IGlkYkN1cnNvcigpID0gMDsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL2xlZ2FjeS9MZWdhY3lB bnkuaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL2xlZ2FjeS9MZWdhY3lBbnku aAppbmRleCBjNDNhZTk3Li40M2RjMTVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL2luZGV4ZWRkYi9sZWdhY3kvTGVnYWN5QW55LmgKKysrIGIvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9pbmRleGVkZGIvbGVnYWN5L0xlZ2FjeUFueS5oCkBAIC04NCw2ICs4NCwxMCBAQCBwdWJs aWM6CiAgICAgfQogICAgIH5MZWdhY3lBbnkoKTsKIAorICAgIC8vIEZJWE1FOiBUaGlzIGlzIGEg dGVtcG9yYXJ5IGhhY2sgdG8gYWxsb3cgY2FzdHMgaW4gV2ViSW5zcGVjdG9yIGNvZGUgd2hpbGUg TW9kZXJuIElEQiBhbmQgTGVnYWN5IElEQiBsaXZlIHNpZGUtYnktc2lkZS4KKyAgICAvLyBJdCBz aG91bGQgYmUgcmVtb3ZlZCB3aGVuIHRoZSBsZWdhY3kgaW1wbGVtZW50YXRpb24gaXMgcmVtb3Zl ZCBhcyBwYXJ0IG9mIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDkx MTcKKyAgICB2aXJ0dWFsIGJvb2wgaXNMZWdhY3koKSBjb25zdCBvdmVycmlkZSBmaW5hbCB7IHJl dHVybiB0cnVlOyB9CisKICAgICB2aXJ0dWFsIFR5cGUgdHlwZSgpIGNvbnN0IG92ZXJyaWRlIGZp bmFsIHsgcmV0dXJuIG1fdHlwZTsgfQogICAgIC8vIFVzZSB0eXBlKCkgdG8gZmlndXJlIG91dCB3 aGljaCBvbmUgb2YgdGhlc2UgeW91J3JlIGFsbG93ZWQgdG8gY2FsbC4KICAgICB2aXJ0dWFsIFJl ZlB0cjxET01TdHJpbmdMaXN0PiBkb21TdHJpbmdMaXN0KCkgb3ZlcnJpZGUgZmluYWw7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9ySW5kZXhlZERCQWdlbnQu Y3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckluZGV4ZWREQkFnZW50LmNw cAppbmRleCA2OTA5ZjRiLi45OWQ2MjhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvSW5zcGVjdG9ySW5kZXhlZERCQWdlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9JbnNwZWN0b3JJbmRleGVkREJBZ2VudC5jcHAKQEAgLTYxLDYgKzYxLDcgQEAKICNp bmNsdWRlICJJREJUcmFuc2FjdGlvbi5oIgogI2luY2x1ZGUgIkluc3BlY3RvclBhZ2VBZ2VudC5o IgogI2luY2x1ZGUgIkluc3RydW1lbnRpbmdBZ2VudHMuaCIKKyNpbmNsdWRlICJMZWdhY3lEYXRh YmFzZS5oIgogI2luY2x1ZGUgIlNlY3VyaXR5T3JpZ2luLmgiCiAjaW5jbHVkZSA8aW5zcGVjdG9y L0luamVjdGVkU2NyaXB0Lmg+CiAjaW5jbHVkZSA8aW5zcGVjdG9yL0luamVjdGVkU2NyaXB0TWFu YWdlci5oPgpAQCAtMTQ5LDcgKzE1MCw3IEBAIHB1YmxpYzoKICAgICAgICAgOiBtX2NvbnRleHQo Y29udGV4dCkgeyB9CiAgICAgdmlydHVhbCB+RXhlY3V0YWJsZVdpdGhEYXRhYmFzZSgpIHsgfTsK ICAgICB2b2lkIHN0YXJ0KElEQkZhY3RvcnkqLCBTZWN1cml0eU9yaWdpbiosIGNvbnN0IFN0cmlu ZyYgZGF0YWJhc2VOYW1lKTsKLSAgICB2aXJ0dWFsIHZvaWQgZXhlY3V0ZShSZWZQdHI8SURCRGF0 YWJhc2U+JiYpID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgZXhlY3V0ZShSZWZQdHI8TGVnYWN5RGF0 YWJhc2U+JiYpID0gMDsKICAgICB2aXJ0dWFsIFJlcXVlc3RDYWxsYmFjayYgcmVxdWVzdENhbGxi YWNrKCkgPSAwOwogICAgIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQoKSB7IHJldHVy biBtX2NvbnRleHQ7IH07CiBwcml2YXRlOgpAQCAtMTg4LDggKzE4OSwxMiBAQCBwdWJsaWM6CiAg ICAgICAgICAgICBtX2V4ZWN1dGFibGVXaXRoRGF0YWJhc2UtPnJlcXVlc3RDYWxsYmFjaygpLnNl bmRGYWlsdXJlKCJVbmV4cGVjdGVkIHJlc3VsdCB0eXBlLiIpOwogICAgICAgICAgICAgcmV0dXJu OwogICAgICAgICB9CisgICAgICAgIGlmICghcmVxdWVzdFJlc3VsdC0+aXNMZWdhY3koKSkgewor ICAgICAgICAgICAgbV9leGVjdXRhYmxlV2l0aERhdGFiYXNlLT5yZXF1ZXN0Q2FsbGJhY2soKS5z ZW5kRmFpbHVyZSgiT25seSBMZWdhY3kgSURCIGlzIHN1cHBvcnRlZCByaWdodCBub3cuIik7Cisg ICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KIAotICAgICAgICBSZWZQdHI8SURCRGF0YWJh c2U+IGlkYkRhdGFiYXNlID0gcmVxdWVzdFJlc3VsdC0+aWRiRGF0YWJhc2UoKTsKKyAgICAgICAg UmVmUHRyPExlZ2FjeURhdGFiYXNlPiBpZGJEYXRhYmFzZSA9IGFkb3B0UmVmKHN0YXRpY19jYXN0 PExlZ2FjeURhdGFiYXNlKj4ocmVxdWVzdFJlc3VsdC0+aWRiRGF0YWJhc2UoKS5sZWFrUmVmKCkp KTsKICAgICAgICAgbV9leGVjdXRhYmxlV2l0aERhdGFiYXNlLT5leGVjdXRlKFdURjo6bW92ZShp ZGJEYXRhYmFzZSkpOwogICAgICAgICBJREJQZW5kaW5nVHJhbnNhY3Rpb25Nb25pdG9yOjpkZWFj dGl2YXRlTmV3VHJhbnNhY3Rpb25zKCk7CiAgICAgICAgIGlkYkRhdGFiYXNlLT5jbG9zZSgpOwpA QCAtMjgzLDcgKzI4OCw3IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgfkRhdGFiYXNlTG9hZGVy KCkgeyB9CiAKLSAgICB2aXJ0dWFsIHZvaWQgZXhlY3V0ZShSZWZQdHI8SURCRGF0YWJhc2U+JiYg ZGF0YWJhc2UpIG92ZXJyaWRlCisgICAgdmlydHVhbCB2b2lkIGV4ZWN1dGUoUmVmUHRyPExlZ2Fj eURhdGFiYXNlPiYmIGRhdGFiYXNlKSBvdmVycmlkZQogICAgIHsKICAgICAgICAgaWYgKCFyZXF1 ZXN0Q2FsbGJhY2soKS5pc0FjdGl2ZSgpKQogICAgICAgICAgICAgcmV0dXJuOwpAQCAtNTEyLDcg KzUxNyw3IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgfkRhdGFMb2FkZXIoKSB7IH0KIAotICAg IHZpcnR1YWwgdm9pZCBleGVjdXRlKFJlZlB0cjxJREJEYXRhYmFzZT4mJiBkYXRhYmFzZSkgb3Zl cnJpZGUKKyAgICB2aXJ0dWFsIHZvaWQgZXhlY3V0ZShSZWZQdHI8TGVnYWN5RGF0YWJhc2U+JiYg ZGF0YWJhc2UpIG92ZXJyaWRlCiAgICAgewogICAgICAgICBpZiAoIXJlcXVlc3RDYWxsYmFjaygp LmlzQWN0aXZlKCkpCiAgICAgICAgICAgICByZXR1cm47CkBAIC03MjgsNyArNzMzLDcgQEAgcHVi bGljOgogICAgIHsKICAgICB9CiAKLSAgICB2aXJ0dWFsIHZvaWQgZXhlY3V0ZShSZWZQdHI8SURC RGF0YWJhc2U+JiYgZGF0YWJhc2UpIG92ZXJyaWRlCisgICAgdmlydHVhbCB2b2lkIGV4ZWN1dGUo UmVmUHRyPExlZ2FjeURhdGFiYXNlPiYmIGRhdGFiYXNlKSBvdmVycmlkZQogICAgIHsKICAgICAg ICAgaWYgKCFyZXF1ZXN0Q2FsbGJhY2soKS5pc0FjdGl2ZSgpKQogICAgICAgICAgICAgcmV0dXJu Owo=