149926 2015-10-08 09:48:27 -0700 [css-grid] Remove unneeded calls to compute(Content)LogicalWidth(Height) 2015-10-09 05:48:26 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 svillar svillar commit-queue darin dino esprehn+autocc glenn jfernandez kling koivisto kondapallykalyan rego oldest_to_newest 1131666 0 svillar 2015-10-08 09:48:27 -0700 [css-grid] Remove unneeded calls to compute(Content)LogicalWidth(Height) 1131667 1 262697 svillar 2015-10-08 09:53:56 -0700 Created attachment 262697 Patch 1131887 2 svillar 2015-10-09 05:48:26 -0700 Committed r190783: <http://trac.webkit.org/changeset/190783> 262697 2015-10-08 09:53:56 -0700 2015-10-08 14:56:08 -0700 Patch bug-149926-20151008185322.patch text/plain 7592 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwNjY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDBlY2E2YzA0ZmZmOTAx YTBkNWVlYmMzNzIyNmQzNzZhZGVlZGNlNy4uNDE4N2ZkMmEyZjU4OWFjYTY5YjJjMDUxMmE3ODY1 MGE3NzAyNTdhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDE1LTEwLTA4ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZ3Jp ZF0gUmVtb3ZlIHVubmVlZGVkIGNhbGxzIHRvIGNvbXB1dGUoQ29udGVudClMb2dpY2FsV2lkdGgo SGVpZ2h0KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQ5OTI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SW4gb3JkZXIgdG8gcmVzb2x2ZSBhIExlbmd0aCB0byBhIExheW91dFVuaXQgd2UgbmVlZCB0bwor ICAgICAgICBwcm92aWRlIGEgbWF4aW11bSB2YWx1ZSBzbyB0aGF0IGkuZS4gcGVyY2VudGFnZXMg YXJlIGNvcnJlY3RseQorICAgICAgICBjb21wdXRlZC4gVGhhdCBtYXhpbXVtIHZhbHVlIHdhcyBj b21wdXRlTG9naWNhbFdpZHRoKCkgZm9yCisgICAgICAgIGNvbHVtbnMgYW5kIGNvbXB1dGVDb250 ZW50TG9naWNhbEhlaWdodCgpIGZvciByb3dzLiBXZSB3ZXJlCisgICAgICAgIGNhbGxpbmcgaXQg Zm9yIGV2ZXJ5IHNpbmdsZSB0cmFjayB3aXRoIGEgZGVmaW5pdGUgc2l6ZSBpbnN0ZWFkCisgICAg ICAgIG9mIGNvbXB1dGluZyBpdCBvbmNlIGFuZCByZXVzaW5nIGl0IG11bHRpcGxlIHRpbWVzLgor CisgICAgICAgIFRoaXMgYnJpbmdzIHNvbWUgbmljZSBwZXJmb3JtYW5jZSBpbXByb3ZlbWVudHM6 CisgICAgICAgIC0gMi45JSAgaW4gL0xheW91dC9maXhlZC1ncmlkLWxvdHMtb2YtZGF0YQorICAg ICAgICAtIDIuOTUlIGluIC9MYXlvdXQvZml4ZWQtZ3JpZC1sb3RzLW9mLXN0cmV0Y2hlZC1kYXRh CisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHJlcXVpcmVkIGFzIHRoZXJlIGlzIG5vIGNoYW5nZSBp biBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyR3JpZDo6Y29tcHV0ZVVzZWRCcmVhZHRoT2ZHcmlkVHJh Y2tzKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckdyaWQ6OmNvbXB1dGVVc2VkQnJlYWR0aE9m TWluTGVuZ3RoKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckdyaWQ6OmNvbXB1dGVVc2VkQnJl YWR0aE9mTWF4TGVuZ3RoKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckdyaWQ6OnRyYWNrc0Fy ZVdpZGVyVGhhbk1pblRyYWNrQnJlYWR0aCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckdy aWQuaDoKKwogMjAxNS0xMC0wNiAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNv bT4KIAogICAgICAgICB3aWxsLWNoYW5nZSBzaG91bGQgdHJpZ2dlciBzdGFja2luZyBjb250ZXh0 IGJhc2VkIHB1cmVseSBvbiBwcm9wZXJ0aWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyR3JpZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy R3JpZC5jcHAKaW5kZXggMzFjMGQwMGYyMWI5M2FjNDQ1OWM2M2YwMzkyOTY2ODBmZDIxYjczNi4u MTU3NjNhN2IyNDFkZmNjN2NmNDhjMTg1NjJlNjQ0Yzg0ZWJlZDIxMCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJHcmlkLmNwcApAQCAtMzg3LDYgKzM4Nyw3IEBAIHZvaWQgUmVuZGVy R3JpZDo6Y29tcHV0ZVVzZWRCcmVhZHRoT2ZHcmlkVHJhY2tzKEdyaWRUcmFja1NpemluZ0RpcmVj dGlvbiBkaXJlY3RpCiAgICAgVmVjdG9yPHVuc2lnbmVkPiBmbGV4aWJsZVNpemVkVHJhY2tzSW5k ZXg7CiAgICAgc2l6aW5nRGF0YS5jb250ZW50U2l6ZWRUcmFja3NJbmRleC5zaHJpbmsoMCk7CiAK KyAgICBjb25zdCBMYXlvdXRVbml0IG1heFNpemUgPSBkaXJlY3Rpb24gPT0gRm9yQ29sdW1ucyA/ IGNvbnRlbnRMb2dpY2FsV2lkdGgoKSA6IGNvbXB1dGVDb250ZW50TG9naWNhbEhlaWdodChNYWlu T3JQcmVmZXJyZWRTaXplLCBzdHlsZSgpLmxvZ2ljYWxIZWlnaHQoKSwgTnVsbG9wdCkudmFsdWVP cigwKTsKICAgICAvLyAxLiBJbml0aWFsaXplIHBlciBHcmlkIHRyYWNrIHZhcmlhYmxlcy4KICAg ICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgdHJhY2tzLnNpemUoKTsgKytpKSB7CiAgICAgICAg IEdyaWRUcmFjayYgdHJhY2sgPSB0cmFja3NbaV07CkBAIC0zOTQsOCArMzk1LDggQEAgdm9pZCBS ZW5kZXJHcmlkOjpjb21wdXRlVXNlZEJyZWFkdGhPZkdyaWRUcmFja3MoR3JpZFRyYWNrU2l6aW5n RGlyZWN0aW9uIGRpcmVjdGkKICAgICAgICAgY29uc3QgR3JpZExlbmd0aCYgbWluVHJhY2tCcmVh ZHRoID0gdHJhY2tTaXplLm1pblRyYWNrQnJlYWR0aCgpOwogICAgICAgICBjb25zdCBHcmlkTGVu Z3RoJiBtYXhUcmFja0JyZWFkdGggPSB0cmFja1NpemUubWF4VHJhY2tCcmVhZHRoKCk7CiAKLSAg ICAgICAgdHJhY2suc2V0QmFzZVNpemUoY29tcHV0ZVVzZWRCcmVhZHRoT2ZNaW5MZW5ndGgoZGly ZWN0aW9uLCBtaW5UcmFja0JyZWFkdGgpKTsKLSAgICAgICAgdHJhY2suc2V0R3Jvd3RoTGltaXQo Y29tcHV0ZVVzZWRCcmVhZHRoT2ZNYXhMZW5ndGgoZGlyZWN0aW9uLCBtYXhUcmFja0JyZWFkdGgs IHRyYWNrLmJhc2VTaXplKCkpKTsKKyAgICAgICAgdHJhY2suc2V0QmFzZVNpemUoY29tcHV0ZVVz ZWRCcmVhZHRoT2ZNaW5MZW5ndGgobWluVHJhY2tCcmVhZHRoLCBtYXhTaXplKSk7CisgICAgICAg IHRyYWNrLnNldEdyb3d0aExpbWl0KGNvbXB1dGVVc2VkQnJlYWR0aE9mTWF4TGVuZ3RoKG1heFRy YWNrQnJlYWR0aCwgdHJhY2suYmFzZVNpemUoKSwgbWF4U2l6ZSkpOwogICAgICAgICB0cmFjay5z ZXRJbmZpbml0ZWx5R3Jvd2FibGUoZmFsc2UpOwogCiAgICAgICAgIGlmICh0cmFja1NpemUuaXND b250ZW50U2l6ZWQoKSkKQEAgLTQ3MSw0MyArNDcyLDMyIEBAIHZvaWQgUmVuZGVyR3JpZDo6Y29t cHV0ZVVzZWRCcmVhZHRoT2ZHcmlkVHJhY2tzKEdyaWRUcmFja1NpemluZ0RpcmVjdGlvbiBkaXJl Y3RpCiAgICAgfQogfQogCi1MYXlvdXRVbml0IFJlbmRlckdyaWQ6OmNvbXB1dGVVc2VkQnJlYWR0 aE9mTWluTGVuZ3RoKEdyaWRUcmFja1NpemluZ0RpcmVjdGlvbiBkaXJlY3Rpb24sIGNvbnN0IEdy aWRMZW5ndGgmIGdyaWRMZW5ndGgpIGNvbnN0CitMYXlvdXRVbml0IFJlbmRlckdyaWQ6OmNvbXB1 dGVVc2VkQnJlYWR0aE9mTWluTGVuZ3RoKGNvbnN0IEdyaWRMZW5ndGgmIGdyaWRMZW5ndGgsIExh eW91dFVuaXQgbWF4U2l6ZSkgY29uc3QKIHsKICAgICBpZiAoZ3JpZExlbmd0aC5pc0ZsZXgoKSkK ICAgICAgICAgcmV0dXJuIDA7CiAKICAgICBjb25zdCBMZW5ndGgmIHRyYWNrTGVuZ3RoID0gZ3Jp ZExlbmd0aC5sZW5ndGgoKTsKICAgICBpZiAodHJhY2tMZW5ndGguaXNTcGVjaWZpZWQoKSkKLSAg ICAgICAgcmV0dXJuIGNvbXB1dGVVc2VkQnJlYWR0aE9mU3BlY2lmaWVkTGVuZ3RoKGRpcmVjdGlv biwgdHJhY2tMZW5ndGgpOworICAgICAgICByZXR1cm4gdmFsdWVGb3JMZW5ndGgodHJhY2tMZW5n dGgsIG1heFNpemUpOwogCiAgICAgQVNTRVJUKHRyYWNrTGVuZ3RoLmlzTWluQ29udGVudCgpIHx8 IHRyYWNrTGVuZ3RoLmlzQXV0bygpIHx8IHRyYWNrTGVuZ3RoLmlzTWF4Q29udGVudCgpKTsKICAg ICByZXR1cm4gMDsKIH0KIAotTGF5b3V0VW5pdCBSZW5kZXJHcmlkOjpjb21wdXRlVXNlZEJyZWFk dGhPZk1heExlbmd0aChHcmlkVHJhY2tTaXppbmdEaXJlY3Rpb24gZGlyZWN0aW9uLCBjb25zdCBH cmlkTGVuZ3RoJiBncmlkTGVuZ3RoLCBMYXlvdXRVbml0IHVzZWRCcmVhZHRoKSBjb25zdAorTGF5 b3V0VW5pdCBSZW5kZXJHcmlkOjpjb21wdXRlVXNlZEJyZWFkdGhPZk1heExlbmd0aChjb25zdCBH cmlkTGVuZ3RoJiBncmlkTGVuZ3RoLCBMYXlvdXRVbml0IHVzZWRCcmVhZHRoLCBMYXlvdXRVbml0 IG1heFNpemUpIGNvbnN0CiB7CiAgICAgaWYgKGdyaWRMZW5ndGguaXNGbGV4KCkpCiAgICAgICAg IHJldHVybiB1c2VkQnJlYWR0aDsKIAogICAgIGNvbnN0IExlbmd0aCYgdHJhY2tMZW5ndGggPSBn cmlkTGVuZ3RoLmxlbmd0aCgpOwotICAgIGlmICh0cmFja0xlbmd0aC5pc1NwZWNpZmllZCgpKSB7 Ci0gICAgICAgIExheW91dFVuaXQgY29tcHV0ZWRCcmVhZHRoID0gY29tcHV0ZVVzZWRCcmVhZHRo T2ZTcGVjaWZpZWRMZW5ndGgoZGlyZWN0aW9uLCB0cmFja0xlbmd0aCk7Ci0gICAgICAgIEFTU0VS VChjb21wdXRlZEJyZWFkdGggIT0gaW5maW5pdHkpOwotICAgICAgICByZXR1cm4gY29tcHV0ZWRC cmVhZHRoOwotICAgIH0KKyAgICBpZiAodHJhY2tMZW5ndGguaXNTcGVjaWZpZWQoKSkKKyAgICAg ICAgcmV0dXJuIHZhbHVlRm9yTGVuZ3RoKHRyYWNrTGVuZ3RoLCBtYXhTaXplKTsKIAogICAgIEFT U0VSVCh0cmFja0xlbmd0aC5pc01pbkNvbnRlbnQoKSB8fCB0cmFja0xlbmd0aC5pc0F1dG8oKSB8 fCB0cmFja0xlbmd0aC5pc01heENvbnRlbnQoKSk7CiAgICAgcmV0dXJuIGluZmluaXR5OwogfQog Ci1MYXlvdXRVbml0IFJlbmRlckdyaWQ6OmNvbXB1dGVVc2VkQnJlYWR0aE9mU3BlY2lmaWVkTGVu Z3RoKEdyaWRUcmFja1NpemluZ0RpcmVjdGlvbiBkaXJlY3Rpb24sIGNvbnN0IExlbmd0aCYgdHJh Y2tMZW5ndGgpIGNvbnN0Ci17Ci0gICAgQVNTRVJUKHRyYWNrTGVuZ3RoLmlzU3BlY2lmaWVkKCkp OwotICAgIGlmIChkaXJlY3Rpb24gPT0gRm9yQ29sdW1ucykKLSAgICAgICAgcmV0dXJuIHZhbHVl Rm9yTGVuZ3RoKHRyYWNrTGVuZ3RoLCBjb250ZW50TG9naWNhbFdpZHRoKCkpOwotICAgIHJldHVy biB2YWx1ZUZvckxlbmd0aCh0cmFja0xlbmd0aCwgY29tcHV0ZUNvbnRlbnRMb2dpY2FsSGVpZ2h0 KE1haW5PclByZWZlcnJlZFNpemUsIHN0eWxlKCkubG9naWNhbEhlaWdodCgpLCBOdWxsb3B0KS52 YWx1ZU9yKDApKTsKLX0KLQogZG91YmxlIFJlbmRlckdyaWQ6OmNvbXB1dGVGbGV4RmFjdG9yVW5p dFNpemUoY29uc3QgVmVjdG9yPEdyaWRUcmFjaz4mIHRyYWNrcywgR3JpZFRyYWNrU2l6aW5nRGly ZWN0aW9uIGRpcmVjdGlvbiwgZG91YmxlIGZsZXhGYWN0b3JTdW0sIExheW91dFVuaXQgbGVmdE92 ZXJTcGFjZSwgY29uc3QgVmVjdG9yPHVuc2lnbmVkLCA4PiYgZmxleGlibGVUcmFja3NJbmRleGVz LCBzdGQ6OnVuaXF1ZV9wdHI8VHJhY2tJbmRleFNldD4gdHJhY2tzVG9UcmVhdEFzSW5mbGV4aWJs ZSkgY29uc3QKIHsKICAgICAvLyBXZSB3YW50IHRvIGF2b2lkIHRoZSBlZmZlY3Qgb2YgZmxleCBm YWN0b3JzIHN1bSBiZWxvdyAxIG1ha2luZyB0aGUgZmFjdG9yIHVuaXQgc2l6ZSB0byBncm93IGV4 cG9uZW50aWFsbHkuCkBAIC0xMDAyLDEwICs5OTIsMTEgQEAgdm9pZCBSZW5kZXJHcmlkOjpkaXN0 cmlidXRlU3BhY2VUb1RyYWNrcyhWZWN0b3I8R3JpZFRyYWNrKj4mIHRyYWNrcywgY29uc3QgVmVj dG8KICNpZm5kZWYgTkRFQlVHCiBib29sIFJlbmRlckdyaWQ6OnRyYWNrc0FyZVdpZGVyVGhhbk1p blRyYWNrQnJlYWR0aChHcmlkVHJhY2tTaXppbmdEaXJlY3Rpb24gZGlyZWN0aW9uLCBjb25zdCBW ZWN0b3I8R3JpZFRyYWNrPiYgdHJhY2tzKQogeworICAgIGNvbnN0IExheW91dFVuaXQgbWF4U2l6 ZSA9IGRpcmVjdGlvbiA9PSBGb3JDb2x1bW5zID8gY29udGVudExvZ2ljYWxXaWR0aCgpIDogY29t cHV0ZUNvbnRlbnRMb2dpY2FsSGVpZ2h0KE1haW5PclByZWZlcnJlZFNpemUsIHN0eWxlKCkubG9n aWNhbEhlaWdodCgpLCBOdWxsb3B0KS52YWx1ZU9yKDApOwogICAgIGZvciAodW5zaWduZWQgaSA9 IDA7IGkgPCB0cmFja3Muc2l6ZSgpOyArK2kpIHsKICAgICAgICAgY29uc3QgR3JpZFRyYWNrU2l6 ZSYgdHJhY2tTaXplID0gZ3JpZFRyYWNrU2l6ZShkaXJlY3Rpb24sIGkpOwogICAgICAgICBjb25z dCBHcmlkTGVuZ3RoJiBtaW5UcmFja0JyZWFkdGggPSB0cmFja1NpemUubWluVHJhY2tCcmVhZHRo KCk7Ci0gICAgICAgIGlmIChjb21wdXRlVXNlZEJyZWFkdGhPZk1pbkxlbmd0aChkaXJlY3Rpb24s IG1pblRyYWNrQnJlYWR0aCkgPiB0cmFja3NbaV0uYmFzZVNpemUoKSkKKyAgICAgICAgaWYgKGNv bXB1dGVVc2VkQnJlYWR0aE9mTWluTGVuZ3RoKG1pblRyYWNrQnJlYWR0aCwgbWF4U2l6ZSkgPiB0 cmFja3NbaV0uYmFzZVNpemUoKSkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAg ICAgcmV0dXJuIHRydWU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyR3JpZC5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckdyaWQuaAppbmRleCA1 ZDNjZWZkMzE2N2Y5YTgwZTU3N2E1MDhlYzlhMjBkMjM5NWIwYjc5Li5jZWUxMDczZTlmN2ZhYzkw OWE0YzQzNGI5NzdlNjZhMjY4ZDM2NzEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyR3JpZC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJH cmlkLmgKQEAgLTcxLDkgKzcxLDggQEAgcHJpdmF0ZToKICAgICBjbGFzcyBHcmlkU2l6aW5nRGF0 YTsKICAgICB2b2lkIGNvbXB1dGVVc2VkQnJlYWR0aE9mR3JpZFRyYWNrcyhHcmlkVHJhY2tTaXpp bmdEaXJlY3Rpb24sIEdyaWRTaXppbmdEYXRhJiwgTGF5b3V0VW5pdCYgYXZhaWxhYmxlTG9naWNh bFNwYWNlKTsKICAgICBib29sIGdyaWRFbGVtZW50SXNTaHJpbmtUb0ZpdCgpOwotICAgIExheW91 dFVuaXQgY29tcHV0ZVVzZWRCcmVhZHRoT2ZNaW5MZW5ndGgoR3JpZFRyYWNrU2l6aW5nRGlyZWN0 aW9uLCBjb25zdCBHcmlkTGVuZ3RoJikgY29uc3Q7Ci0gICAgTGF5b3V0VW5pdCBjb21wdXRlVXNl ZEJyZWFkdGhPZk1heExlbmd0aChHcmlkVHJhY2tTaXppbmdEaXJlY3Rpb24sIGNvbnN0IEdyaWRM ZW5ndGgmLCBMYXlvdXRVbml0IHVzZWRCcmVhZHRoKSBjb25zdDsKLSAgICBMYXlvdXRVbml0IGNv bXB1dGVVc2VkQnJlYWR0aE9mU3BlY2lmaWVkTGVuZ3RoKEdyaWRUcmFja1NpemluZ0RpcmVjdGlv biwgY29uc3QgTGVuZ3RoJikgY29uc3Q7CisgICAgTGF5b3V0VW5pdCBjb21wdXRlVXNlZEJyZWFk dGhPZk1pbkxlbmd0aChjb25zdCBHcmlkTGVuZ3RoJiwgTGF5b3V0VW5pdCBtYXhTaXplKSBjb25z dDsKKyAgICBMYXlvdXRVbml0IGNvbXB1dGVVc2VkQnJlYWR0aE9mTWF4TGVuZ3RoKGNvbnN0IEdy aWRMZW5ndGgmLCBMYXlvdXRVbml0IHVzZWRCcmVhZHRoLCBMYXlvdXRVbml0IG1heFNpemUpIGNv bnN0OwogICAgIHZvaWQgcmVzb2x2ZUNvbnRlbnRCYXNlZFRyYWNrU2l6aW5nRnVuY3Rpb25zKEdy aWRUcmFja1NpemluZ0RpcmVjdGlvbiwgR3JpZFNpemluZ0RhdGEmKTsKIAogICAgIHZvaWQgZW5z dXJlR3JpZFNpemUodW5zaWduZWQgbWF4aW11bVJvd0luZGV4LCB1bnNpZ25lZCBtYXhpbXVtQ29s dW1uSW5kZXgpOwo=