149919 2015-10-08 02:37:24 -0700 Fix the WASM build on Linux 2015-10-08 08:21:29 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 146064 1 ossy ossy commit-queue ggaren mark.lam msaboff ossy saam sukolsak oldest_to_newest 1131576 0 ossy 2015-10-08 02:37:24 -0700 build error #1 --------------- ../../Source/JavaScriptCore/inspector/ScriptCallStackFactory.cpp: In member function 'JSC::StackVisitor::Status Inspector::CreateScriptCallStackFunctor::operator()(JSC::StackVisitor&)': ../../Source/JavaScriptCore/inspector/ScriptCallStackFactory.cpp:70:37: error: invalid use of incomplete type 'class JSC::CodeBlock' In file included from ../../Source/JavaScriptCore/interpreter/JSStack.h:33:0, from ../../Source/JavaScriptCore/interpreter/CallFrame.h:27, from ../../Source/JavaScriptCore/inspector/ScriptCallStackFactory.cpp:36: ../../Source/JavaScriptCore/interpreter/Register.h:38:11: error: forward declaration of 'class JSC::CodeBlock' -----> fix: CodeBlock.h should be included build error #2 --------------- In file included from ../../Source/JavaScriptCore/wasm/WASMFunctionParser.cpp:34:0: ../../Source/JavaScriptCore/wasm/WASMFunctionLLVMIRGenerator.h:37:12: error: 'JSC::FTL::LBasicBlock' has not been declared ../../Source/JavaScriptCore/wasm/WASMFunctionLLVMIRGenerator.h:38:12: error: 'JSC::FTL::LValue' has not been declared ../../Source/JavaScriptCore/wasm/WASMFunctionLLVMIRGenerator.h:42:13: error: 'LValue' does not name a type ... [SNIP] ... -----> fix: These symbols are FTL specific, we should add an ENABLE(FTL_JIT) guard for the whole file. build error #3 --------------- In file included from ../../Source/JavaScriptCore/wasm/WASMFunctionParser.cpp:33:0: ../../Source/JavaScriptCore/wasm/WASMFunctionCompiler.h: In function 'size_t JSC::sizeOfMemoryType(JSC::WASMMemoryType)': ../../Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:97:1: error: control reaches end of non-void function [-Werror=return-type] -----> fix: We need an unreachable return to make GCC happy. build error #4 --------------- Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/JSWASMModule.cpp.o:JSWASMModule.cpp:function JSC::JSWASMModule::visitChildren(JSC::JSCell*, JSC::SlotVisitor&): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSCell*)' Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/JSWASMModule.cpp.o:JSWASMModule.cpp:function JSC::JSWASMModule::visitChildren(JSC::JSCell*, JSC::SlotVisitor&): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSCell*)' Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/wasm/JSWASMModule.cpp.o:JSWASMModule.cpp:function JSC::JSWASMModule::visitChildren(JSC::JSCell*, JSC::SlotVisitor&): error: undefined reference to 'JSC::JSValue::JSValue(JSC::JSCell*)' collect2: error: ld returned 1 exit status -----> fix: We should include JSCJSValueInlines.h too. 1131577 1 262682 ossy 2015-10-08 02:39:02 -0700 Created attachment 262682 Patch 1131579 2 sukolsak 2015-10-08 02:44:14 -0700 It looks good to me. 1131617 3 262682 mark.lam 2015-10-08 07:36:36 -0700 Comment on attachment 262682 Patch r=me 1131628 4 262682 commit-queue 2015-10-08 08:21:24 -0700 Comment on attachment 262682 Patch Clearing flags on attachment: 262682 Committed r190722: <http://trac.webkit.org/changeset/190722> 1131629 5 commit-queue 2015-10-08 08:21:29 -0700 All reviewed patches have been landed. Closing bug. 262682 2015-10-08 02:39:02 -0700 2015-10-08 08:21:24 -0700 Patch bug-149919-20151008023829.patch text/plain 2939 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwNjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk NzllMTU4YzZiZjhjYmY4ZWJhZDk5OTA0YzFiNDdjZTRjM2VjNjA2Li40Njk4OTJmMTZmNzM4NDgy MDczZTU0ZmI1NmFlNWEzZGU2NWM0ZTAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNS0xMC0wOCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIEZpeCB0aGUgV0FTTSBidWlsZCBvbiBMaW51eAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5OTE5CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvU2NyaXB0Q2Fs bFN0YWNrRmFjdG9yeS5jcHA6CisgICAgICAgICogd2FzbS9KU1dBU01Nb2R1bGUuY3BwOgorICAg ICAgICAqIHdhc20vV0FTTUZ1bmN0aW9uQ29tcGlsZXIuaDoKKyAgICAgICAgKEpTQzo6c2l6ZU9m TWVtb3J5VHlwZSk6CisgICAgICAgICogd2FzbS9XQVNNRnVuY3Rpb25MTFZNSVJHZW5lcmF0b3Iu aDoKKwogMjAxNS0xMC0wNyAgU3Vrb2xzYWsgU2Frc2h1d29uZyAgPHN1a29sc2FrQGdtYWlsLmNv bT4KIAogICAgICAgICBBZGQgYW4gTExWTSBJUiBnZW5lcmF0b3IgZm9yIFdlYkFzc2VtYmx5CmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL1NjcmlwdENhbGxTdGFj a0ZhY3RvcnkuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9TY3JpcHRDYWxs U3RhY2tGYWN0b3J5LmNwcAppbmRleCBmZDcxMjc0YTM1NjE0YjJmMDc1ZjU3NWFhMTViMTliMWIy N2ZjYjlkLi4zNjI1MDljODVmNjhhYzk1N2Y3ZDJmNmIxMjNkNjBjMWQwNjBhZTQ4IDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL1NjcmlwdENhbGxTdGFja0ZhY3Rv cnkuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvU2NyaXB0Q2FsbFN0 YWNrRmFjdG9yeS5jcHAKQEAgLTM0LDYgKzM0LDcgQEAKICNpbmNsdWRlICJTY3JpcHRDYWxsU3Rh Y2tGYWN0b3J5LmgiCiAKICNpbmNsdWRlICJDYWxsRnJhbWUuaCIKKyNpbmNsdWRlICJDb2RlQmxv Y2suaCIKICNpbmNsdWRlICJFeGNlcHRpb24uaCIKICNpbmNsdWRlICJKU0NKU1ZhbHVlLmgiCiAj aW5jbHVkZSAiSlNDSW5saW5lcy5oIgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3dhc20vSlNXQVNNTW9kdWxlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL0pTV0FT TU1vZHVsZS5jcHAKaW5kZXggODE4MWEzZWYxMzU1ZGU2MzFjMTA4ZDgxYjAyZWFmNmUxMTgwZTli ZS4uYzdlYTRhNmVkM2QwNDkxYTk5ODFhODhlZmM5YzNiMmFlOWE4NmNmNSAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vSlNXQVNNTW9kdWxlLmNwcAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvd2FzbS9KU1dBU01Nb2R1bGUuY3BwCkBAIC0yOSw2ICsyOSw3IEBACiAj aWYgRU5BQkxFKFdFQkFTU0VNQkxZKQogCiAjaW5jbHVkZSAiSlNBcnJheUJ1ZmZlci5oIgorI2lu Y2x1ZGUgIkpTQ0pTVmFsdWVJbmxpbmVzLmgiCiAjaW5jbHVkZSAiSlNDZWxsSW5saW5lcy5oIgog I2luY2x1ZGUgIkpTRnVuY3Rpb24uaCIKICNpbmNsdWRlICJTbG90VmlzaXRvcklubGluZXMuaCIK ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dBU01GdW5jdGlvbkNvbXBp bGVyLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XQVNNRnVuY3Rpb25Db21waWxlci5o CmluZGV4IGIxZDYyZTRhNmMwMWFiZWM5ZGZhOTVlNjllZmI4MWJlMDFmYTA5MGYuLmRkZTE5NTcw MjVjOTZlZTJmY2ZlMWRjZWJlNmJmMjJhMjg4ODBlMmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS93YXNtL1dBU01GdW5jdGlvbkNvbXBpbGVyLmgKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3dhc20vV0FTTUZ1bmN0aW9uQ29tcGlsZXIuaApAQCAtOTQsNiArOTQsOCBAQCBz dGF0aWMgc2l6ZV90IHNpemVPZk1lbW9yeVR5cGUoV0FTTU1lbW9yeVR5cGUgbWVtb3J5VHlwZSkK ICAgICBkZWZhdWx0OgogICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICB9CisgICAg UkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICByZXR1cm4gMDsKIH0KIAogY2xhc3Mg V0FTTUZ1bmN0aW9uQ29tcGlsZXIgOiBwcml2YXRlIENDYWxsSGVscGVycyB7CmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XQVNNRnVuY3Rpb25MTFZNSVJHZW5lcmF0b3Iu aCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dBU01GdW5jdGlvbkxMVk1JUkdlbmVyYXRv ci5oCmluZGV4IDI0NTVmYzZkZTg3MTIwOGMxMDU5NzdkOTZhNmJjZjA0OTYzMTllNzEuLjdkZDkw Y2JjNWUyODA5NDMyODNkNjMwZmFkOGJlYTlkZmRhZmFiMzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS93YXNtL1dBU01GdW5jdGlvbkxMVk1JUkdlbmVyYXRvci5oCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dBU01GdW5jdGlvbkxMVk1JUkdlbmVyYXRvci5oCkBA IC0yNiw3ICsyNiw3IEBACiAjaWZuZGVmIFdBU01GdW5jdGlvbkxMVk1JUkdlbmVyYXRvcl9oCiAj ZGVmaW5lIFdBU01GdW5jdGlvbkxMVk1JUkdlbmVyYXRvcl9oCiAKLSNpZiBFTkFCTEUoV0VCQVNT RU1CTFkpCisjaWYgRU5BQkxFKFdFQkFTU0VNQkxZKSAmJiBFTkFCTEUoRlRMX0pJVCkKIAogI2lu Y2x1ZGUgIkZUTEFiYnJldmlhdGVkVHlwZXMuaCIKIAo=