149905 2015-10-07 16:45:15 -0700 Allow custom revisions to be specified in A/B testing 2015-10-07 17:17:48 -0700 1 1 1 Unclassified WebKit WebKit Website WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa cdumez dewei_zhu jond slewis timothy oldest_to_newest 1131470 0 rniwa 2015-10-07 16:45:15 -0700 Cleanup my monkey patch for the internal website and commit it. 1131472 1 262656 rniwa 2015-10-07 16:52:50 -0700 Created attachment 262656 Adds the feature 1131477 2 262656 cdumez 2015-10-07 17:04:46 -0700 Comment on attachment 262656 Adds the feature rs=me 1131482 3 rniwa 2015-10-07 17:17:48 -0700 Committed r190696: <http://trac.webkit.org/changeset/190696> 262656 2015-10-07 16:52:50 -0700 2015-10-07 17:04:46 -0700 Adds the feature bug-149905-20151007165219.patch text/plain 7982 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMTkwNjk1KQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI0IEBACisyMDE1LTEwLTA3ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIEFsbG93IGN1c3RvbSByZXZpc2lvbnMgdG8gYmUgc3BlY2lmaWVkIGluIEEvQiB0 ZXN0aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NDk5MDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB bGxvdyBjdXN0b20gcmV2aXNpb24gbnVtYmVyIG9uIGVhY2ggInJlcG9zaXRvcnkiIHdoZW4gY3Jl YXRpbmcgYSB0ZXN0IGdyb3VwLgorCisgICAgICAgICogcHVibGljL3YyL2FwcC5jc3M6CisgICAg ICAgIChmb3JtIC5hbmFseXNpcy1ncm91cCBbbmFtZT1jdXN0b21WYWx1ZV0pOiBBZGRlZC4KKwor ICAgICAgICAqIHB1YmxpYy92Mi9hcHAuanM6CisgICAgICAgIChBcHAuQW5hbHlzaXNUYXNrQ29u dHJvbGxlci5fY3JlYXRlQ29uZmlndXJhdGlvbik6IEFkZGVkICJDdXN0b20iIGFzIGEgcmV2aXNp b24gb3B0aW9uLgorICAgICAgICBBbHNvIGFkZGVkIHBvaW50IGxhYmVscyBzdWNoIGFzIChwb2lu dCAzKSBvbiAiTm9uZSIgZm9yIHdoZW4gc29tZSBwb2ludHMgYXJlIG1pc3NpbmcgcmV2aXNpb24g aW5mby4KKyAgICAgICAgKEFwcC5BbmFseXNpc1Rhc2tDb250cm9sbGVyLl9sYWJlbEZvclBvaW50 cyk6IEV4dHJhY3RlZCBmcm9tIF9jcmVhdGVDb25maWd1cmF0aW9uLgorICAgICAgICAoQXBwLkFu YWx5c2lzVGFza0NvbnRyb2xsZXIuYWN0aW9ucy5jcmVhdGVUZXN0R3JvdXApOiBSZXNwZWN0IHRo ZSBjdXN0b20gcmV2aXNpb24gbnVtYmVyIHdoZW4gY3VzdG9tCisgICAgICAgIHJldmlzaW9uIG9w dGlvbiBpcyBzZWxlY3RlZC4KKworICAgICAgICAqIHB1YmxpYy92Mi9pbmRleC5odG1sOiBBZGRl ZCBhIHRleHQgZmllbGQgZm9yIHNwZWNpZnlpbmcgYSBjdXN0b20gcmV2aXNpb24gbnVtYmVyLgor CiAyMDE1LTEwLTA3ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAg IE1ha2UgdGhlIHNpdGUgbmFtZSBjb25maWd1cmFibGUgaW4gcGVyZiBkYXNoYm9hcmQKSW5kZXg6 IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjIvYXBwLmNzcwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YyL2FwcC5jc3MJKHJldmlzaW9uIDE5 MDY4MykKKysrIFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjIvYXBwLmNzcwkod29y a2luZyBjb3B5KQpAQCAtNDM3LDYgKzQzNywxMCBAQCBmb3JtIC5hbmFseXNpcy1ncm91cCA+ICog ewogICAgIG1hcmdpbjogMC41cmVtOwogfQogCitmb3JtIC5hbmFseXNpcy1ncm91cCBbbmFtZT1j dXN0b21WYWx1ZV0geworICAgIGRpc3BsYXk6IGJsb2NrOworfQorCiAjYW5hbHlzaXMtdGFza3Ms CiAuYW5hbHlzaXMtZ3JvdXAgdGFibGUgewogICAgIGJvcmRlcjogc29saWQgMHB4ICM5OTk7Cklu ZGV4OiBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YyL2FwcC5qcwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YyL2FwcC5qcwkocmV2aXNpb24g MTkwNjgzKQorKysgV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92Mi9hcHAuanMJKHdv cmtpbmcgY29weSkKQEAgLTEzOTEsMTIgKzEzOTEsMTQgQEAgQXBwLkFuYWx5c2lzVGFza0NvbnRy b2xsZXIgPSBFbWJlci5Db250cgogICAgIF9jcmVhdGVDb25maWd1cmF0aW9uOiBmdW5jdGlvbihy ZXBvc2l0b3J5LCBjb21taXRzLCBhbmFseXNpc1BvaW50cykgewogICAgICAgICB2YXIgcmVwb3Np dG9yeUlkID0gcmVwb3NpdG9yeS5nZXQoJ2lkJyk7CiAKLSAgICAgICAgdmFyIG9wdGlvbnMgPSBb e2xhYmVsOiAnTm9uZSd9XTsKICAgICAgICAgdmFyIHJldmlzaW9uVG9Qb2ludHMgPSB7fTsKKyAg ICAgICAgdmFyIG1pc3NpbmdQb2ludHMgPSBbXTsKICAgICAgICAgYW5hbHlzaXNQb2ludHMuZm9y RWFjaChmdW5jdGlvbiAocG9pbnQsIHBvaW50SW5kZXgpIHsKICAgICAgICAgICAgIHZhciByZXZp c2lvbiA9IHBvaW50Lm1lYXN1cmVtZW50LnJldmlzaW9uRm9yUmVwb3NpdG9yeShyZXBvc2l0b3J5 SWQpOwotICAgICAgICAgICAgaWYgKCFyZXZpc2lvbikKKyAgICAgICAgICAgIGlmICghcmV2aXNp b24pIHsKKyAgICAgICAgICAgICAgICBtaXNzaW5nUG9pbnRzLnB1c2gocG9pbnRJbmRleCk7CiAg ICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgfQogICAgICAgICAgICAgaWYgKCFy ZXZpc2lvblRvUG9pbnRzW3JldmlzaW9uXSkKICAgICAgICAgICAgICAgICByZXZpc2lvblRvUG9p bnRzW3JldmlzaW9uXSA9IFtdOwogICAgICAgICAgICAgcmV2aXNpb25Ub1BvaW50c1tyZXZpc2lv bl0ucHVzaChwb2ludEluZGV4KTsKQEAgLTE0MDgsMTUgKzE0MTAsMzEgQEAgQXBwLkFuYWx5c2lz VGFza0NvbnRyb2xsZXIgPSBFbWJlci5Db250cgogICAgICAgICAgICAgICAgIGNvbW1pdHMucHVz aCh7cmV2aXNpb246IHJldmlzaW9ufSk7CiAgICAgICAgIH0KIAorICAgICAgICB2YXIgb3B0aW9u cyA9IFt7bGFiZWw6ICdOb25lJ30sIHtsYWJlbDogJ0N1c3RvbScsIGlzQ3VzdG9tOiB0cnVlfV07 CisgICAgICAgIGlmIChtaXNzaW5nUG9pbnRzLmxlbmd0aCkgeworICAgICAgICAgICAgb3B0aW9u c1swXS5sYWJlbCArPSAnICcgKyB0aGlzLl9sYWJlbEZvclBvaW50cyhtaXNzaW5nUG9pbnRzKTsK KyAgICAgICAgICAgIG9wdGlvbnNbMF0ucG9pbnRzID0gbWlzc2luZ1BvaW50czsKKyAgICAgICAg fQorCiAgICAgICAgIGZvciAodmFyIGNvbW1pdCBvZiBjb21taXRzKSB7CiAgICAgICAgICAgICB2 YXIgcmV2aXNpb24gPSBjb21taXQucmV2aXNpb247Ci0gICAgICAgICAgICB2YXIgbGFiZWwgPSBN ZWFzdXJlbWVudC5mb3JtYXRSZXZpc2lvblJhbmdlKHJldmlzaW9uKS5sYWJlbDsKICAgICAgICAg ICAgIHZhciBwb2ludHMgPSByZXZpc2lvblRvUG9pbnRzW3JldmlzaW9uXTsKLSAgICAgICAgICAg IGlmIChwb2ludHMpIHsKLSAgICAgICAgICAgICAgICB2YXIgc2VyaWFsaXplZFBvaW50cyA9IHRo aXMuX3NlcmlhbGl6ZU51bWJlcnNTa2lwcGluZ0NvbnNlY3V0aXZlRW50cmllcyhyZXZpc2lvblRv UG9pbnRzW3JldmlzaW9uXSk7Ci0gICAgICAgICAgICAgICAgbGFiZWwgKz0gJyAnICsgWycoJywg cG9pbnRzLmxlbmd0aCA+IDEgPyAncG9pbnRzJyA6ICdwb2ludCcsIHNlcmlhbGl6ZWRQb2ludHMs ICcpJ10uam9pbignICcpOwotICAgICAgICAgICAgfQotICAgICAgICAgICAgb3B0aW9ucy5wdXNo KHt2YWx1ZTogcmV2aXNpb24sIGxhYmVsOiBsYWJlbH0pOworICAgICAgICAgICAgdmFyIGxhYmVs ID0gTWVhc3VyZW1lbnQuZm9ybWF0UmV2aXNpb25SYW5nZShyZXZpc2lvbikubGFiZWw7CisgICAg ICAgICAgICBpZiAocG9pbnRzKQorICAgICAgICAgICAgICAgIGxhYmVsICs9ICcgJyArIHRoaXMu X2xhYmVsRm9yUG9pbnRzKHBvaW50cyk7CisgICAgICAgICAgICBvcHRpb25zLnB1c2goe3ZhbHVl OiByZXZpc2lvbiwgbGFiZWw6IGxhYmVsLCBwb2ludHM6IHBvaW50c30pOworICAgICAgICB9CisK KyAgICAgICAgdmFyIGZpcnN0T3B0aW9uID0gbnVsbDsKKyAgICAgICAgdmFyIGxhc3RPcHRpb24g PSBudWxsOworICAgICAgICBmb3IgKHZhciBvcHRpb24gb2Ygb3B0aW9ucykgeworICAgICAgICAg ICAgdmFyIHBvaW50cyA9IG9wdGlvbi5wb2ludHM7CisgICAgICAgICAgICBpZiAoIXBvaW50cykK KyAgICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgICAgIGlmIChwb2ludHMuaW5kZXhP ZigwKSA+PSAwKQorICAgICAgICAgICAgICAgIGZpcnN0T3B0aW9uID0gb3B0aW9uOworICAgICAg ICAgICAgaWYgKHBvaW50cy5pbmRleE9mKGFuYWx5c2lzUG9pbnRzLmxlbmd0aCAtIDEpID49IDAp CisgICAgICAgICAgICAgICAgbGFzdE9wdGlvbiA9IG9wdGlvbjsKICAgICAgICAgfQogCiAgICAg ICAgIHJldHVybiBFbWJlci5PYmplY3QuY3JlYXRlKHsKQEAgLTE0MjUsMTIgKzE0NDMsMTcgQEAg QXBwLkFuYWx5c2lzVGFza0NvbnRyb2xsZXIgPSBFbWJlci5Db250cgogICAgICAgICAgICAgc2V0 czogWwogICAgICAgICAgICAgICAgIEVtYmVyLk9iamVjdC5jcmVhdGUoe25hbWU6ICdBWycgKyBy ZXBvc2l0b3J5SWQgKyAnXScsCiAgICAgICAgICAgICAgICAgICAgIG9wdGlvbnM6IG9wdGlvbnMs Ci0gICAgICAgICAgICAgICAgICAgIHNlbGVjdGlvbjogb3B0aW9uc1sxXX0pLAorICAgICAgICAg ICAgICAgICAgICBzZWxlY3Rpb246IGZpcnN0T3B0aW9ufSksCiAgICAgICAgICAgICAgICAgRW1i ZXIuT2JqZWN0LmNyZWF0ZSh7bmFtZTogJ0JbJyArIHJlcG9zaXRvcnlJZCArICddJywKICAgICAg ICAgICAgICAgICAgICAgb3B0aW9uczogb3B0aW9ucywKLSAgICAgICAgICAgICAgICAgICAgc2Vs ZWN0aW9uOiBvcHRpb25zW29wdGlvbnMubGVuZ3RoIC0gMV19KSwKKyAgICAgICAgICAgICAgICAg ICAgc2VsZWN0aW9uOiBsYXN0T3B0aW9ufSksCiAgICAgICAgICAgICBdfSk7CiAgICAgfSwKKyAg ICBfbGFiZWxGb3JQb2ludHM6IGZ1bmN0aW9uIChwb2ludHMpCisgICAgeworICAgICAgICB2YXIg c2VyaWFsaXplZFBvaW50cyA9IHRoaXMuX3NlcmlhbGl6ZU51bWJlcnNTa2lwcGluZ0NvbnNlY3V0 aXZlRW50cmllcyhwb2ludHMpOworICAgICAgICByZXR1cm4gWycoJywgcG9pbnRzLmxlbmd0aCA+ IDEgPyAncG9pbnRzJyA6ICdwb2ludCcsIHNlcmlhbGl6ZWRQb2ludHMsICcpJ10uam9pbignICcp OworICAgIH0sCiAgICAgX3NlcmlhbGl6ZU51bWJlcnNTa2lwcGluZ0NvbnNlY3V0aXZlRW50cmll czogZnVuY3Rpb24gKG51bWJlcnMpIHsKICAgICAgICAgdmFyIHJlc3VsdCA9IG51bWJlcnNbMF07 CiAgICAgICAgIGZvciAodmFyIGkgPSAxOyBpIDwgbnVtYmVycy5sZW5ndGg7IGkrKykgewpAQCAt MTQ5NSwxNCArMTUxOCwyMCBAQCBBcHAuQW5hbHlzaXNUYXNrQ29udHJvbGxlciA9IEVtYmVyLkNv bnRyCiAgICAgICAgICAgICB2YXIgcm9vdENvbmZpZ3VyYXRpb25zID0gdGhpcy5nZXQoJ3Jvb3RD b25maWd1cmF0aW9ucycpLnRvQXJyYXkoKTsKICAgICAgICAgICAgIGZvciAodmFyIHJvb3Qgb2Yg cm9vdENvbmZpZ3VyYXRpb25zKSB7CiAgICAgICAgICAgICAgICAgdmFyIHNldHMgPSByb290Lmdl dCgnc2V0cycpOwotICAgICAgICAgICAgICAgIHZhciBoYXNTZWxlY3Rpb24gPSBmdW5jdGlvbiAo aXRlbSkgeyByZXR1cm4gaXRlbS5nZXQoJ3NlbGVjdGlvbicpICYmIGl0ZW0uZ2V0KCdzZWxlY3Rp b24nKS52YWx1ZTsgfTsKKyAgICAgICAgICAgICAgICB2YXIgaGFzU2VsZWN0aW9uID0gZnVuY3Rp b24gKGl0ZW0pIHsKKyAgICAgICAgICAgICAgICAgICAgdmFyIHNlbGVjdGlvbiA9IGl0ZW0uZ2V0 KCdzZWxlY3Rpb24nKTsKKyAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHNlbGVjdGlvbi52YWx1 ZSB8fCAoc2VsZWN0aW9uLmlzQ3VzdG9tICYmIGl0ZW0uZ2V0KCdjdXN0b21WYWx1ZScpKTsKKyAg ICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgaWYgKCFzZXRzLmFueShoYXNTZWxlY3Rp b24pKQogICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgICAgICAgICBpZiAo IXNldHMuZXZlcnkoaGFzU2VsZWN0aW9uKSkgewogICAgICAgICAgICAgICAgICAgICBhbGVydCgn T25seSBzb21lIGNvbmZpZ3VyYXRpb24gc3BlY2lmaWVzICcgKyByb290LmdldCgnbmFtZScpKTsK ICAgICAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgICAgIH0KLSAgICAgICAg ICAgICAgICByb290c1tyb290LmdldCgnbmFtZScpXSA9IHNldHMubWFwKGZ1bmN0aW9uIChpdGVt KSB7IHJldHVybiBpdGVtLmdldCgnc2VsZWN0aW9uJykudmFsdWU7IH0pOyAgICAgICAgICAgICAg ICAKKyAgICAgICAgICAgICAgICByb290c1tyb290LmdldCgnbmFtZScpXSA9IHNldHMubWFwKGZ1 bmN0aW9uIChpdGVtKSB7CisgICAgICAgICAgICAgICAgICAgIHZhciBzZWxlY3Rpb24gPSBpdGVt LmdldCgnc2VsZWN0aW9uJyk7CisgICAgICAgICAgICAgICAgICAgIHJldHVybiBzZWxlY3Rpb24u aXNDdXN0b20gPyBpdGVtLmdldCgnY3VzdG9tVmFsdWUnKSA6IHNlbGVjdGlvbi52YWx1ZTsKKyAg ICAgICAgICAgICAgICB9KTsKICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgQXBwLlRlc3RH cm91cC5jcmVhdGUoYW5hbHlzaXNUYXNrLCBuYW1lLCByb290cywgcmVwZXRpdGlvbkNvdW50KS50 aGVuKGZ1bmN0aW9uICgpIHsKSW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMv djIvaW5kZXguaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVi bGljL3YyL2luZGV4Lmh0bWwJKHJldmlzaW9uIDE5MDY4NykKKysrIFdlYnNpdGVzL3BlcmYud2Vi a2l0Lm9yZy9wdWJsaWMvdjIvaW5kZXguaHRtbAkod29ya2luZyBjb3B5KQpAQCAtNzI2LDkgKzcy NiwxNCBAQAogICAgICAgICAgICAgICAgICAgICAgICAgICAgIDx0cj4KICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgPHRoPnt7bmFtZX19PC90aD4KICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAge3sjZWFjaCBzZXRzfX0KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIDx0ZD57e3ZpZXcgRW1iZXIuU2VsZWN0IG5hbWU9bmFtZSBjb250ZW50PW9wdGlvbnMK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBvcHRpb25WYWx1ZVBhdGg9 ImNvbnRlbnQudmFsdWUiIG9wdGlvbkxhYmVsUGF0aD0iY29udGVudC5sYWJlbCIKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzZWxlY3Rpb249c2VsZWN0aW9ufX08L3Rk PgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPHRkPgorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHt7dmlldyBFbWJlci5TZWxlY3QgbmFtZT1uYW1l IGNvbnRlbnQ9b3B0aW9ucworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBvcHRpb25WYWx1ZVBhdGg9ImNvbnRlbnQudmFsdWUiIG9wdGlvbkxhYmVsUGF0aD0iY29u dGVudC5sYWJlbCIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg c2VsZWN0aW9uPXNlbGVjdGlvbn19CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAge3sjaWYgc2VsZWN0aW9uLmlzQ3VzdG9tfX0KKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAge3tpbnB1dCBuYW1lPSJjdXN0b21WYWx1ZSIgdHlwZT10ZXh0 IHZhbHVlPWN1c3RvbVZhbHVlfX0KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB7ey9pZn19CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPC90 ZD4KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAge3svZWFjaH19CiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgPC90cj4KICAgICAgICAgICAgICAgICAgICAgICAgIHt7L2VhY2h9 fQo=