149894 2015-10-07 13:52:57 -0700 Make the site name configurable in perf dashboard 2016-02-16 13:53:58 -0800 1 1 1 Unclassified WebKit Perf Dashboard WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa cdumez dewei_zhu jond kling koivisto rniwa timothy oldest_to_newest 1131403 0 rniwa 2015-10-07 13:52:57 -0700 Right now, we have to modify HTML files to change the app name. We should make it configurable through config.json. 1131409 1 262640 rniwa 2015-10-07 14:01:04 -0700 Created attachment 262640 Fixes the bug 1131410 2 262640 cdumez 2015-10-07 14:05:15 -0700 Comment on attachment 262640 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=262640&action=review r=me with comments. > Websites/perf.webkit.org/public/index.html:1224 > + document.querySelector('h1 a').textContent = manifest.siteTitle; May be nicer / more robust to have an id for the <a> element. > Websites/perf.webkit.org/public/index.html:1237 > +<h1><a href="/"></a></h1> I would keep "Perf Monitor" in there (similarly to what you did for the title), just for readability, even though it does not matter in practice. 1131422 3 rniwa 2015-10-07 14:23:43 -0700 Thanks for the reviews! 1131423 4 rniwa 2015-10-07 14:25:21 -0700 Committed r190687: <http://trac.webkit.org/changeset/190687> 262640 2015-10-07 14:01:04 -0700 2015-10-07 14:05:15 -0700 Fixes the bug bug-149894-20151007140035.patch text/plain 5292 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMTkwNjgzKQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIxIEBACisyMDE1LTEwLTA3ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIE1ha2UgdGhlIHNpdGUgbmFtZSBjb25maWd1cmFibGUgaW4gcGVyZiBkYXNoYm9h cmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTg5 NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVk ICJzaXRlVGl0bGUiIGFzIGEgbmV3IGNvbmZpZ3VyYXRpb24ga2V5IHRvIHNwZWNpZnkgdGhlIHNp dGUgbmFtZS4KKworICAgICAgICAqIHB1YmxpYy9pbmNsdWRlL2RiLnBocDoKKyAgICAgICAgKGNv bmZpZyk6IE5vdyB0YWtlcyB0aGUgZGVmYXVsdCB2YWx1ZSBhcyBhbiBhcmd1bWVudC4KKyAgICAg ICAgKiBwdWJsaWMvaW5jbHVkZS9tYW5pZmVzdC5waHA6CisgICAgICAgIChNYW5pZmVzdEdlbmVy YXRvcjo6Z2VuZXJhdGUpOiBJbmNsdWRlIHNpdGVUaXRsZSBpbiB0aGUgbWFuaWZlc3QuCisgICAg ICAgICogcHVibGljL2luZGV4Lmh0bWw6IFVwZGF0ZSB0aGUgdGl0bGUgYW5kIHRoZSBoZWFkaW5n IHdoZW4gdGhlIG1hbmlmZXN0IGlzIGxvYWRlZC4KKyAgICAgICAgKiBwdWJsaWMvdjIvaW5kZXgu aHRtbDogVXNlIEFwcC5NYW5pZmVzdC5zaXRlVGl0bGUgYXMgdGhlIGhlYWRpbmcuIGRvY3VtZW50 LnRpdGxlIG5lZWRzIHRvIGJlIHVwZGF0ZWQgbWFudWFsbHkuCisgICAgICAgICogcHVibGljL3Yy L21hbmlmZXN0LmpzOiAKKyAgICAgICAgKEFwcC5NZXRyaWNTZXJpYWxpemVyLm5vcm1hbGl6ZVBh eWxvYWQpOiBVcGRhdGUgZG9jdW1lbnQudGl0bGUgYW5kIEFwcC5NYW5pZmVzdC5zaXRlVGl0bGUu CisKIDIwMTUtMTAtMDcgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgUGVyZiBkYXNoYm9hcmQgZG9lc24ndCBzaG93IGFuYWx5c2lzIHRhc2tzIGFuY2hvcmVkIGF0 IG91dGxpZXJzCkluZGV4OiBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL2luZGV4Lmh0 bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy9pbmRleC5o dG1sCShyZXZpc2lvbiAxOTA2ODMpCisrKyBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGlj L2luZGV4Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTEsNyArMSw3IEBACiA8IURPQ1RZUEUgaHRt bD4KIDxodG1sPgogPGhlYWQ+Ci08dGl0bGU+V2ViS2l0IFBlcmYgTW9uaXRvcjwvdGl0bGU+Cis8 dGl0bGU+UGVyZiBNb25pdG9yIGlzIExvYWRpbmcuLi48L3RpdGxlPgogPHNjcmlwdCBzcmM9Impz L2pxdWVyeS5qcyIgZGVmZXI+PC9zY3JpcHQ+CiA8c2NyaXB0IHNyYz0ianMvanF1ZXJ5LmZsb3Qu anMiIGRlZmVyPjwvc2NyaXB0PgogPHNjcmlwdCBzcmM9ImpzL2pxdWVyeS5mbG90LmNyb3NzaGFp ci5qcyIgZGVmZXI+PC9zY3JpcHQ+CkBAIC0xMjIwLDYgKzEyMjAsOSBAQCBmdW5jdGlvbiBpbml0 KCkgewogICAgICAgICBidWlsZGVycyA9IG1hbmlmZXN0LmJ1aWxkZXJzOwogICAgICAgICBidWdU cmFja2VycyA9IG1hbmlmZXN0LmJ1Z1RyYWNrZXJzOwogCisgICAgICAgIGRvY3VtZW50LnRpdGxl ID0gbWFuaWZlc3Quc2l0ZVRpdGxlOworICAgICAgICBkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCdo MSBhJykudGV4dENvbnRlbnQgPSBtYW5pZmVzdC5zaXRlVGl0bGU7CisKICAgICAgICAgc2V0TW9k ZShVUkxTdGF0ZS5nZXQoJ21vZGUnLCAnZGFzaGJvYXJkJykpOwogICAgIH0pOwogfQpAQCAtMTIz MSw3ICsxMjM0LDcgQEAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoJ0RPTUNvbnRlbnRMb2FkZQog PGJvZHk+CiAKIDxoZWFkZXIgaWQ9InRpdGxlIj4KLTxoMT48YSBocmVmPSIvIj5XZWJLaXQgUGVy ZiBNb25pdG9yPC9hPjwvaDE+Cis8aDE+PGEgaHJlZj0iLyI+PC9hPjwvaDE+CiA8dWw+CiAgICAg PGxpIGlkPSJudW1iZXJPZkRheXNQaWNrZXIiPjxpbnB1dCBpZD0ibnVtYmVyT2ZEYXlzIiB0eXBl PSJyYW5nZSIgbWluPSIxIiBtYXg9IjUuOSIgc3RlcD0iMC4wMDEiIHZhbHVlPSIyLjMiPjxzcGFu IGNsYXNzPSJvdXRwdXQiPjwvc3Bhbj48L2xpPgogICAgIDxsaT48YSBocmVmPSJqYXZhc2NyaXB0 OnNldE1vZGUoJ2Rhc2hib2FyZCcpOyI+RGFzaGJvYXJkPC9hPjwvbGk+CkluZGV4OiBXZWJzaXRl cy9wZXJmLndlYmtpdC5vcmcvcHVibGljL2luY2x1ZGUvZGIucGhwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvaW5jbHVkZS9kYi5waHAJKHJldmlzaW9uIDE5 MDY4MykKKysrIFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvaW5jbHVkZS9kYi5waHAJ KHdvcmtpbmcgY29weSkKQEAgLTI5LDExICsyOSwxMSBAQCAkX2NvbmZpZyA9IE5VTEw7CiAKIGRl ZmluZSgnQ09ORklHX0RJUicsIGRpcm5hbWUoX19GSUxFX18pIC4gJy8uLi8uLi8nKTsKIAotZnVu Y3Rpb24gY29uZmlnKCRrZXkpIHsKK2Z1bmN0aW9uIGNvbmZpZygka2V5LCAkZGVmYXVsdCA9IE5V TEwpIHsKICAgICBnbG9iYWwgJF9jb25maWc7CiAgICAgaWYgKCEkX2NvbmZpZykKICAgICAgICAg JF9jb25maWcgPSBqc29uX2RlY29kZShmaWxlX2dldF9jb250ZW50cyhDT05GSUdfRElSIC4gJ2Nv bmZpZy5qc29uJyksIHRydWUpOwotICAgIHJldHVybiAkX2NvbmZpZ1ska2V5XTsKKyAgICByZXR1 cm4gYXJyYXlfZ2V0KCRfY29uZmlnLCAka2V5LCAkZGVmYXVsdCk7CiB9CiAKIGZ1bmN0aW9uIGNv bmZpZ19wYXRoKCRrZXksICRwYXRoKSB7CkluZGV4OiBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcv cHVibGljL2luY2x1ZGUvbWFuaWZlc3QucGhwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNpdGVzL3BlcmYu d2Via2l0Lm9yZy9wdWJsaWMvaW5jbHVkZS9tYW5pZmVzdC5waHAJKHJldmlzaW9uIDE5MDY4MykK KysrIFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvaW5jbHVkZS9tYW5pZmVzdC5waHAJ KHdvcmtpbmcgY29weSkKQEAgLTI3LDYgKzI3LDcgQEAgY2xhc3MgTWFuaWZlc3RHZW5lcmF0b3Ig ewogICAgICAgICAgICAgJHJvdyA9ICRyb3dbJ2NvbW1pdF9yZXBvc2l0b3J5J107CiAKICAgICAg ICAgJHRoaXMtPm1hbmlmZXN0ID0gYXJyYXkoCisgICAgICAgICAgICAnc2l0ZVRpdGxlJyA9PiBj b25maWcoJ3NpdGVUaXRsZScsICdQZXJmb3JtYW5jZSBEYXNoYm9hcmQnKSwKICAgICAgICAgICAg ICd0ZXN0cycgPT4gKG9iamVjdCkkdGhpcy0+dGVzdHMoKSwKICAgICAgICAgICAgICdtZXRyaWNz JyA9PiAob2JqZWN0KSR0aGlzLT5tZXRyaWNzKCksCiAgICAgICAgICAgICAnYWxsJyA9PiAob2Jq ZWN0KSR0aGlzLT5wbGF0Zm9ybXMoJGNvbmZpZ190YWJsZSwgJHBsYXRmb3JtX3RhYmxlLCBmYWxz ZSksCkluZGV4OiBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YyL2luZGV4Lmh0bWwK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92Mi9pbmRleC5o dG1sCShyZXZpc2lvbiAxOTA2ODMpCisrKyBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGlj L3YyL2luZGV4Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTIsNyArMiw3IEBACiA8aHRtbD4KIDxo ZWFkPgogICAgIDxtZXRhIGNoYXJzZXQ9InV0Zi04Ij4KLSAgICA8dGl0bGU+V2ViS2l0IFBlcmZv cm1hbmNlIE1vbml0b3IgKEJldGEpPC90aXRsZT4KKyAgICA8dGl0bGU+UGVyZm9ybWFuY2UgRGFz aGJvYXJkIGlzIExvYWRpbmcuLi48L3RpdGxlPgogCiAgICAgPGxpbmsgcmVsPSJwcmVmZXRjaCIg aHJlZj0iLi4vZGF0YS9tYW5pZmVzdC5qc29uIj4KICAgICA8c2NyaXB0IHR5cGU9ImFwcGxpY2F0 aW9uL2pzb24iIHNyYz0iLi4vZGF0YS9tYW5pZmVzdC5qc29uIj48L3NjcmlwdD4KQEAgLTQ4Niw3 ICs0ODYsNyBAQAogCiAgICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L3gtaGFuZGxlYmFycyIgZGF0YS10 ZW1wbGF0ZS1uYW1lPSJuYXZiYXIiPgogICAgICAgICA8bmF2IGlkPSJuYXZpZ2F0aW9uIiByb2xl PSJuYXZpZ2F0aW9uIj4KLSAgICAgICAgICAgIDxoMT48YSBocmVmPSIjIj5XZWJLaXQgUGVyZiBN b25pdG9yPC9hPjwvaDE+CisgICAgICAgICAgICA8aDE+PGEgaHJlZj0iIyI+e3tBcHAuTWFuaWZl c3Quc2l0ZVRpdGxlfX08L2E+PC9oMT4KICAgICAgICAgICAgIDx1bD4KICAgICAgICAgICAgICAg ICB7eyNlYWNoIEFwcC5NYW5pZmVzdC5kYXNoYm9hcmRzfX0KICAgICAgICAgICAgICAgICAgICAg e3sjaWYgbmFtZX19CkluZGV4OiBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YyL21h bmlmZXN0LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMv djIvbWFuaWZlc3QuanMJKHJldmlzaW9uIDE5MDY4MykKKysrIFdlYnNpdGVzL3BlcmYud2Via2l0 Lm9yZy9wdWJsaWMvdjIvbWFuaWZlc3QuanMJKHdvcmtpbmcgY29weSkKQEAgLTIxNCw2ICsyMTQs MTIgQEAgQXBwLk1ldHJpY1NlcmlhbGl6ZXIgPSBBcHAuUGxhdGZvcm1TZXJpYQogICAgICAgICAg ICAgaWQrKzsKICAgICAgICAgfQogCisgICAgICAgIHZhciBzaXRlVGl0bGUgPSBwYXlsb2FkWydz aXRlVGl0bGUnXTsKKyAgICAgICAgaWYgKHNpdGVUaXRsZSkgeworICAgICAgICAgICAgQXBwLk1h bmlmZXN0LnNldCgnc2l0ZVRpdGxlJywgc2l0ZVRpdGxlKTsKKyAgICAgICAgICAgIGRvY3VtZW50 LnRpdGxlID0gc2l0ZVRpdGxlOworICAgICAgICB9CisKICAgICAgICAgcmV0dXJuIHJlc3VsdHM7 CiAgICAgfSwKICAgICBfbm9ybWFsaXplSWRNYXA6IGZ1bmN0aW9uIChpZE1hcCkK