149868 2015-10-06 20:17:33 -0700 Format string issue in WebResourceLoadScheduler.cpp 2015-10-08 08:27:41 -0700 1 1 1 Unclassified WebKit WebKit Misc. Other PC Linux RESOLVED FIXED P2 Minor --- 1 mcatanzaro mcatanzaro commit-queue mcatanzaro ossy oldest_to_newest 1131213 0 mcatanzaro 2015-10-06 20:17:33 -0700 [978/1606] Building CXX object Source/...Network/WebResourceLoadScheduler.cpp.o In file included from ../../Source/WTF/wtf/StdLibExtras.h:32:0, from ../../Source/WTF/wtf/FastMalloc.h:26, from ../../Source/WebKit2/config.h:44, from ../../Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp:26: ../../Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp: In member function ‘void WebKit::WebResourceLoadScheduler::scheduleLoad(WebCore::ResourceLoader*, WebCore::CachedResource*, bool)’: ../../Source/WTF/wtf/Assertions.h:349:105: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 4 has type ‘WebCore::ResourceLoadPriority’ [-Wformat=] #define LOG(channel, ...) WTFLog(&JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, channel), __VA_ARGS__) ^ ../../Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp:158:5: note: in expansion of macro ‘LOG’ LOG(NetworkScheduling, "(WebProcess) WebResourceLoadScheduler::scheduleLoad, url '%s' will be scheduled with the NetworkProcess with priority %u", resourceLoader->url().string().utf8().data(), resourceLoader->request().priority()); ^ 1131223 1 262577 mcatanzaro 2015-10-06 21:25:39 -0700 Created attachment 262577 Patch 1131632 2 262577 commit-queue 2015-10-08 08:27:38 -0700 Comment on attachment 262577 Patch Clearing flags on attachment: 262577 Committed r190724: <http://trac.webkit.org/changeset/190724> 1131633 3 commit-queue 2015-10-08 08:27:41 -0700 All reviewed patches have been landed. Closing bug. 262577 2015-10-06 21:25:39 -0700 2015-10-08 08:27:38 -0700 Patch bug-149868-20151006232508.patch text/plain 2091 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwNjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWE1M2FlYzcxYjFkMTE3 MzQ2NWRmOWIwZjBlNzZiNjY1YWU1MjM0OC4uYmE3MzI2YmU2MWM5ZGNiYzQzMTQyNTAxY2U1YjY3 MzA0YmNjYjhhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE1LTEwLTA2ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAorICAgICAgICBGb3JtYXQg c3RyaW5nIGlzc3VlIGluIFdlYlJlc291cmNlTG9hZFNjaGVkdWxlci5jcHAKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTg2OAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhc3QgZW51bXMgdG8gaW50cyBi ZWZvcmUgcHJpbnRpbmcgdGhlbSB0byBwbGFjYXRlIEdDQydzIC1XZm9ybWF0LgorCisgICAgICAg ICogV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlJlc291cmNlTG9hZFNjaGVkdWxlci5jcHA6CisgICAg ICAgIChXZWJLaXQ6OldlYlJlc291cmNlTG9hZFNjaGVkdWxlcjo6c2NoZWR1bGVMb2FkKToKKwor MjAxNS0xMC0wNiAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CisK ICAgICAgICAgW0dUS10gQWRkIGF1dG9jbGVhbnVwcwogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5NTg4CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvTmV0d29yay9XZWJSZXNvdXJjZUxvYWRTY2hlZHVsZXIuY3BwIGIvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlJlc291cmNlTG9hZFNjaGVkdWxlci5j cHAKaW5kZXggMDliZDk0YjQwYzA0NTMyMTVjNWU0MzIyYThhYzJkOWExYWMzODkwNy4uNmUzYWYz MDQxODlmNWY4NWQ5OTRkZTA4NTY5ZTJlNWY3NmM1OTg4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlJlc291cmNlTG9hZFNjaGVkdWxlci5jcHAKKysr IGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlJlc291cmNlTG9hZFNjaGVk dWxlci5jcHAKQEAgLTE1NSw3ICsxNTUsNyBAQCB2b2lkIFdlYlJlc291cmNlTG9hZFNjaGVkdWxl cjo6c2NoZWR1bGVMb2FkKFJlc291cmNlTG9hZGVyKiByZXNvdXJjZUxvYWRlciwgQ2FjaAogICAg IH0KICNlbmRpZgogCi0gICAgTE9HKE5ldHdvcmtTY2hlZHVsaW5nLCAiKFdlYlByb2Nlc3MpIFdl YlJlc291cmNlTG9hZFNjaGVkdWxlcjo6c2NoZWR1bGVMb2FkLCB1cmwgJyVzJyB3aWxsIGJlIHNj aGVkdWxlZCB3aXRoIHRoZSBOZXR3b3JrUHJvY2VzcyB3aXRoIHByaW9yaXR5ICV1IiwgcmVzb3Vy Y2VMb2FkZXItPnVybCgpLnN0cmluZygpLnV0ZjgoKS5kYXRhKCksIHJlc291cmNlTG9hZGVyLT5y ZXF1ZXN0KCkucHJpb3JpdHkoKSk7CisgICAgTE9HKE5ldHdvcmtTY2hlZHVsaW5nLCAiKFdlYlBy b2Nlc3MpIFdlYlJlc291cmNlTG9hZFNjaGVkdWxlcjo6c2NoZWR1bGVMb2FkLCB1cmwgJyVzJyB3 aWxsIGJlIHNjaGVkdWxlZCB3aXRoIHRoZSBOZXR3b3JrUHJvY2VzcyB3aXRoIHByaW9yaXR5ICVk IiwgcmVzb3VyY2VMb2FkZXItPnVybCgpLnN0cmluZygpLnV0ZjgoKS5kYXRhKCksIHN0YXRpY19j YXN0PGludD4ocmVzb3VyY2VMb2FkZXItPnJlcXVlc3QoKS5wcmlvcml0eSgpKSk7CiAKICAgICBD b250ZW50U25pZmZpbmdQb2xpY3kgY29udGVudFNuaWZmaW5nUG9saWN5ID0gcmVzb3VyY2VMb2Fk ZXItPnNob3VsZFNuaWZmQ29udGVudCgpID8gU25pZmZDb250ZW50IDogRG9Ob3RTbmlmZkNvbnRl bnQ7CiAgICAgU3RvcmVkQ3JlZGVudGlhbHMgYWxsb3dTdG9yZWRDcmVkZW50aWFscyA9IHJlc291 cmNlTG9hZGVyLT5zaG91bGRVc2VDcmVkZW50aWFsU3RvcmFnZSgpID8gQWxsb3dTdG9yZWRDcmVk ZW50aWFscyA6IERvTm90QWxsb3dTdG9yZWRDcmVkZW50aWFsczsK