149866 2015-10-06 19:38:40 -0700 Format string issues in LegacyRequest.cpp 2015-10-08 08:28:28 -0700 1 1 1 Unclassified WebKit WebCore Misc. Other PC Linux RESOLVED FIXED P2 Minor --- 1 mcatanzaro mcatanzaro alecflett beidson commit-queue jsbell mcatanzaro ossy oldest_to_newest 1131203 0 mcatanzaro 2015-10-06 19:38:40 -0700 Probably need to static_cast<int>(m_readyState) [1669/5846] Building CXX object Source...s/indexeddb/legacy/LegacyRequest.cpp.o In file included from ../../Source/WTF/wtf/StdLibExtras.h:32:0, from ../../Source/WTF/wtf/FastMalloc.h:26, from ../../Source/WebCore/config.h:75, from ../../Source/WebCore/Modules/indexeddb/legacy/LegacyRequest.cpp:29: ../../Source/WebCore/Modules/indexeddb/legacy/LegacyRequest.cpp: In member function ‘virtual bool WebCore::LegacyRequest::dispatchEvent(WTF::PassRefPtr<WebCore::Event>)’: ../../Source/WTF/wtf/Assertions.h:278:110: warning: format ‘%d’ expects argument of type ‘int’, but argument 7 has type ‘WebCore::IDBRequestReadyState’ [-Wformat=] WTFReportAssertionFailureWithMessage(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, #assertion, __VA_ARGS__); \ ^ ../../Source/WebCore/Modules/indexeddb/legacy/LegacyRequest.cpp:478:5: note: in expansion of macro ‘ASSERT_WITH_MESSAGE’ ASSERT_WITH_MESSAGE(m_readyState < IDBRequestReadyState::Done, "When dispatching event %s, m_readyState < DONE(%d), was %d", event->type().string().utf8().data(), IDBRequestReadyState::Done, m_readyState); ^ ../../Source/WTF/wtf/Assertions.h:278:110: warning: format ‘%d’ expects argument of type ‘int’, but argument 8 has type ‘WebCore::IDBRequestReadyState’ [-Wformat=] WTFReportAssertionFailureWithMessage(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, #assertion, __VA_ARGS__); \ ^ ../../Source/WebCore/Modules/indexeddb/legacy/LegacyRequest.cpp:478:5: note: in expansion of macro ‘ASSERT_WITH_MESSAGE’ ASSERT_WITH_MESSAGE(m_readyState < IDBRequestReadyState::Done, "When dispatching event %s, m_readyState < DONE(%d), was %d", event->type().string().utf8().data(), IDBRequestReadyState::Done, m_readyState); ^ ../../Source/WebCore/Modules/indexeddb/legacy/LegacyRequest.cpp: In member function ‘void WebCore::LegacyRequest::enqueueEvent(WTF::PassRefPtr<WebCore::Event>)’: ../../Source/WTF/wtf/Assertions.h:278:110: warning: format ‘%d’ expects argument of type ‘int’, but argument 7 has type ‘WebCore::IDBRequestReadyState’ [-Wformat=] WTFReportAssertionFailureWithMessage(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, #assertion, __VA_ARGS__); \ ^ ../../Source/WebCore/Modules/indexeddb/legacy/LegacyRequest.cpp:575:5: note: in expansion of macro ‘ASSERT_WITH_MESSAGE’ ASSERT_WITH_MESSAGE(m_readyState == IDBRequestReadyState::Pending || m_didFireUpgradeNeededEvent, "When queueing event %s, m_readyState was %d", event->type().string().utf8().data(), m_readyState); ^ 1131222 1 262576 mcatanzaro 2015-10-06 21:19:25 -0700 Created attachment 262576 Patch 1131634 2 262576 commit-queue 2015-10-08 08:28:24 -0700 Comment on attachment 262576 Patch Clearing flags on attachment: 262576 Committed r190725: <http://trac.webkit.org/changeset/190725> 1131635 3 commit-queue 2015-10-08 08:28:28 -0700 All reviewed patches have been landed. Closing bug. 262576 2015-10-06 21:19:25 -0700 2015-10-08 08:28:24 -0700 Patch bug-149866-20151006231853.patch text/plain 2528 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwNjYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDAzODA0ODRkZGQyZjk3 MDNlOTY1ZjI3YmI4MTdkNTVlZWI4NGE5MS4uM2Q0NjVjMWZjMTliZGM3Yjg4MjY2YWUyY2NlM2Vi OWYwMWE5MjI1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE1LTEwLTA2ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAorICAgICAgICBGb3JtYXQg c3RyaW5nIGlzc3VlcyBpbiBMZWdhY3lSZXF1ZXN0LmNwcAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5ODY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2FzdCBlbnVtcyB0byBpbnRzIGJlZm9yZSBwcmlu dGluZyB0aGVtIHRvIHBsYWNhdGUgR0NDJ3MgLVdmb3JtYXQuCisKKyAgICAgICAgKiBNb2R1bGVz L2luZGV4ZWRkYi9sZWdhY3kvTGVnYWN5UmVxdWVzdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpM ZWdhY3lSZXF1ZXN0OjpkaXNwYXRjaEV2ZW50KToKKyAgICAgICAgKFdlYkNvcmU6OkxlZ2FjeVJl cXVlc3Q6OmVucXVldWVFdmVudCk6CisKKzIwMTUtMTAtMDYgIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCiAgICAgICAgIFtHVEtdIEFkZCBhdXRvY2xlYW51cHMK ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTU4OAog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9sZWdhY3kvTGVn YWN5UmVxdWVzdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9sZWdhY3kv TGVnYWN5UmVxdWVzdC5jcHAKaW5kZXggZDM2YmUzNjgyNDk1MGIwYzc4NGNiNzMzNTI3MGU2YjU3 ZWVmZTk1Yi4uYTNjMjAyMGIwMDBiNzM0ZWQ2Y2E3YTMzZWUzOTZlZDg4YThlZTUxYyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvbGVnYWN5L0xlZ2FjeVJlcXVl c3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL2xlZ2FjeS9MZWdh Y3lSZXF1ZXN0LmNwcApAQCAtNDc1LDcgKzQ3NSw3IEBAIGJvb2wgTGVnYWN5UmVxdWVzdDo6ZGlz cGF0Y2hFdmVudChQYXNzUmVmUHRyPEV2ZW50PiBldmVudCkKICAgICBBU1NFUlQobV9lbnF1ZXVl ZEV2ZW50cy5zaXplKCkpOwogICAgIEFTU0VSVChzY3JpcHRFeGVjdXRpb25Db250ZXh0KCkpOwog ICAgIEFTU0VSVChldmVudC0+dGFyZ2V0KCkgPT0gdGhpcyk7Ci0gICAgQVNTRVJUX1dJVEhfTUVT U0FHRShtX3JlYWR5U3RhdGUgPCBJREJSZXF1ZXN0UmVhZHlTdGF0ZTo6RG9uZSwgIldoZW4gZGlz cGF0Y2hpbmcgZXZlbnQgJXMsIG1fcmVhZHlTdGF0ZSA8IERPTkUoJWQpLCB3YXMgJWQiLCBldmVu dC0+dHlwZSgpLnN0cmluZygpLnV0ZjgoKS5kYXRhKCksIElEQlJlcXVlc3RSZWFkeVN0YXRlOjpE b25lLCBtX3JlYWR5U3RhdGUpOworICAgIEFTU0VSVF9XSVRIX01FU1NBR0UobV9yZWFkeVN0YXRl IDwgSURCUmVxdWVzdFJlYWR5U3RhdGU6OkRvbmUsICJXaGVuIGRpc3BhdGNoaW5nIGV2ZW50ICVz LCBtX3JlYWR5U3RhdGUgPCBET05FKCVkKSwgd2FzICVkIiwgZXZlbnQtPnR5cGUoKS5zdHJpbmco KS51dGY4KCkuZGF0YSgpLCBzdGF0aWNfY2FzdDxpbnQ+KElEQlJlcXVlc3RSZWFkeVN0YXRlOjpE b25lKSwgc3RhdGljX2Nhc3Q8aW50PihtX3JlYWR5U3RhdGUpKTsKIAogICAgIERPTVJlcXVlc3RT dGF0ZTo6U2NvcGUgc2NvcGUobV9yZXF1ZXN0U3RhdGUpOwogCkBAIC01NzIsNyArNTcyLDcgQEAg dm9pZCBMZWdhY3lSZXF1ZXN0OjplbnF1ZXVlRXZlbnQoUGFzc1JlZlB0cjxFdmVudD4gZXZlbnQp CiAgICAgaWYgKG1fY29udGV4dFN0b3BwZWQgfHwgIXNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSkK ICAgICAgICAgcmV0dXJuOwogCi0gICAgQVNTRVJUX1dJVEhfTUVTU0FHRShtX3JlYWR5U3RhdGUg PT0gSURCUmVxdWVzdFJlYWR5U3RhdGU6OlBlbmRpbmcgfHwgbV9kaWRGaXJlVXBncmFkZU5lZWRl ZEV2ZW50LCAiV2hlbiBxdWV1ZWluZyBldmVudCAlcywgbV9yZWFkeVN0YXRlIHdhcyAlZCIsIGV2 ZW50LT50eXBlKCkuc3RyaW5nKCkudXRmOCgpLmRhdGEoKSwgbV9yZWFkeVN0YXRlKTsKKyAgICBB U1NFUlRfV0lUSF9NRVNTQUdFKG1fcmVhZHlTdGF0ZSA9PSBJREJSZXF1ZXN0UmVhZHlTdGF0ZTo6 UGVuZGluZyB8fCBtX2RpZEZpcmVVcGdyYWRlTmVlZGVkRXZlbnQsICJXaGVuIHF1ZXVlaW5nIGV2 ZW50ICVzLCBtX3JlYWR5U3RhdGUgd2FzICVkIiwgZXZlbnQtPnR5cGUoKS5zdHJpbmcoKS51dGY4 KCkuZGF0YSgpLCBzdGF0aWNfY2FzdDxpbnQ+KG1fcmVhZHlTdGF0ZSkpOwogCiAgICAgZXZlbnQt PnNldFRhcmdldCh0aGlzKTsKIAo=