149813 2015-10-05 11:23:22 -0700 [Win] Clean up annoying compiler warnings 2016-05-10 07:34:55 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build PC All RESOLVED FIXED P2 Normal --- 1 bfulgham webkit-unassigned bfulgham commit-queue ggaren keith_miller mark.lam msaboff ossy peavo saam oldest_to_newest 1130674 0 bfulgham 2015-10-05 11:23:22 -0700 The Windows build log is cluttered with build warnings that make it difficult to find real problems during the build. Could you please correct these warnings so we can get a meaningful build log? [53/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\runtime\Error.cpp.obj c:\projects\webkit\opensource\source\javascriptcore\runtime\error.cpp(170) : warning C4701: potentially uninitialized local variable 'stackFrame' used c:\projects\webkit\opensource\source\javascriptcore\runtime\error.cpp(170) : warning C4703: potentially uninitialized local pointer variable 'stackFrame' used [61/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\runtime\ErrorInstance.cpp.obj c:\projects\webkit\opensource\source\javascriptcore\runtime\errorinstance.cpp(160) : warning C4701: potentially uninitialized local variable 'stackFrame' used c:\projects\webkit\opensource\source\javascriptcore\runtime\errorinstance.cpp(160) : warning C4703: potentially uninitialized local pointer variable 'stackFrame' used [177/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\runtime\RegExpPrototype.cpp.obj c:\projects\webkit\opensource\source\javascriptcore\runtime\regexpprototype.cpp(148) : warning C4700: uninitialized local variable 'string' used [216/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\runtime\VM.cpp.obj ..\..\Source\JavaScriptCore\runtime\VM.cpp(338): warning C4312: 'reinterpret_cast': conversion from 'unsigned int' to 'JSC::Interpreter *' of greater size [306/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\bytecode\PropertyCondition.cpp.obj c:\projects\webkit\opensource\source\javascriptcore\bytecode\propertycondition.cpp(256) : warning C4701: potentially uninitialized local variable 'set' used c:\projects\webkit\opensource\source\javascriptcore\bytecode\propertycondition.cpp(256) : warning C4703: potentially uninitialized local pointer variable 'set' used [434/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\dfg\DFGObjectAllocationSinkingPhase.cpp.obj c:\projects\webkit\opensource\source\javascriptcore\dfg\dfgobjectallocationsinkingphase.cpp(1400) : warning C4701: potentially uninitialized local variable 'bestAllocation' used c:\projects\webkit\opensource\source\javascriptcore\dfg\dfgobjectallocationsinkingphase.cpp(1400) : warning C4703: potentially uninitialized local pointer variable 'bestAllocation' used [451/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\dfg\DFGSpeculativeJIT64.cpp.obj c:\projects\webkit\opensource\source\javascriptcore\dfg\dfgspeculativejit64.cpp(823) : warning C4701: potentially uninitialized local variable 'calleeGPR' used [456/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\dfg\DFGSpeculativeJIT.cpp.obj c:\projects\webkit\opensource\source\javascriptcore\dfg\dfgspeculativejit.cpp(4744) : warning C4701: potentially uninitialized local variable 'thisValueGPR' used [548/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\jit\JITCall.cpp.obj c:\projects\webkit\opensource\source\javascriptcore\jit\jitcall.cpp(189) : warning C4701: potentially uninitialized local variable 'info' used c:\projects\webkit\opensource\source\javascriptcore\jit\jitcall.cpp(189) : warning C4703: potentially uninitialized local pointer variable 'info' used [551/1109] Building CXX object Source\JavaScriptCore\CMakeFiles\JavaScriptCore.dir\parser\Parser.cpp.obj c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1745) : warning C4701: potentially uninitialized local variable 'startColumn' used c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1766) : warning C4701: potentially uninitialized local variable 'parametersStart' used c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1766) : warning C4701: potentially uninitialized local variable 'functionBodyType' used c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1745) : warning C4701: potentially uninitialized local variable 'startColumn' used c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1766) : warning C4701: potentially uninitialized local variable 'parametersStart' used c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1766) : warning C4701: potentially uninitialized local variable 'functionBodyType' used c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1745) : warning C4701: potentially uninitialized local variable 'startColumn' used c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1766) : warning C4701: potentially uninitialized local variable 'parametersStart' used c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1766) : warning C4701: potentially uninitialized local variable 'functionBodyType' used c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1745) : warning C4701: potentially uninitialized local variable 'startColumn' used c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1766) : warning C4701: potentially uninitialized local variable 'parametersStart' used c:\projects\webkit\opensource\source\javascriptcore\parser\parser.cpp(1766) : warning C4701: potentially uninitialized local variable 'functionBodyType' used [597/1109] Building CXX object Source\JavaScriptCore\shell\CMakeFiles\jscLib.dir\__\jsc.cpp.obj ..\..\Source\JavaScriptCore\jsc.cpp(1332): warning C4646: function declared with __declspec(noreturn) has non-void return type 1189328 1 277893 peavo 2016-05-01 23:29:53 -0700 Created attachment 277893 Patch 1189331 2 277893 achristensen 2016-05-02 00:11:34 -0700 Comment on attachment 277893 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=277893&action=review > Source/JavaScriptCore/runtime/RegExpPrototype.cpp:178 > + string[0] = 0; This adds an unnecessary operation in the common case where no error happens. Could we add this only if we are returning early? > Source/JavaScriptCore/runtime/SamplingProfiler.cpp:678 > - return -1; > + return UINT_MAX; We typically use std::numeric_limits<unsigned>::max() 1189513 3 peavo 2016-05-02 14:22:33 -0700 Thanks for reviewing :) 1189516 4 peavo 2016-05-02 14:25:06 -0700 Committed r200338: <http://trac.webkit.org/changeset/200338> 277893 2016-05-01 23:29:53 -0700 2016-05-02 00:11:34 -0700 Patch bug-149813-20160502083027.patch text/plain 9612 peavo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAwMzE4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM1IEBA CisyMDE2LTA1LTAxICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAg ICAgICBbV2luXSBDbGVhbiB1cCBhbm5veWluZyBjb21waWxlciB3YXJuaW5ncworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5ODEzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBieXRlY29kZS9Qcm9wZXJ0 eUNvbmRpdGlvbi5jcHA6CisgICAgICAgIChKU0M6OlByb3BlcnR5Q29uZGl0aW9uOjppc1dhdGNo YWJsZVdoZW5WYWxpZCk6CisgICAgICAgICogZGZnL0RGR09iamVjdEFsbG9jYXRpb25TaW5raW5n UGhhc2UuY3BwOgorICAgICAgICAqIGRmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcDoKKyAg ICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6ZW1pdENhbGwpOgorICAgICAgICAqIGlu c3BlY3Rvci9JbnNwZWN0b3JCYWNrZW5kRGlzcGF0Y2hlci5jcHA6CisgICAgICAgIChJbnNwZWN0 b3I6OkJhY2tlbmREaXNwYXRjaGVyOjpzZW5kUGVuZGluZ0Vycm9ycyk6CisgICAgICAgICogaml0 L0pJVENhbGwzMl82NC5jcHA6CisgICAgICAgIChKU0M6OkpJVDo6Y29tcGlsZU9wQ2FsbCk6Cisg ICAgICAgICogcGFyc2VyL1BhcnNlci5jcHA6CisgICAgICAgIChKU0M6OlBhcnNlcjxMZXhlclR5 cGU+OjpwYXJzZUFzc2lnbm1lbnRFeHByZXNzaW9uKToKKyAgICAgICAgKiBydW50aW1lL0Nsb25l ZEFyZ3VtZW50cy5jcHA6CisgICAgICAgIChKU0M6OkNsb25lZEFyZ3VtZW50czo6Y3JlYXRlV2l0 aElubGluZUZyYW1lKToKKyAgICAgICAgKiBydW50aW1lL0Vycm9yLmNwcDoKKyAgICAgICAgKEpT Qzo6YWRkRXJyb3JJbmZvQW5kR2V0Qnl0ZWNvZGVPZmZzZXQpOgorICAgICAgICAqIHJ1bnRpbWUv SW50bE51bWJlckZvcm1hdC5jcHA6CisgICAgICAgIChKU0M6OkludGxOdW1iZXJGb3JtYXQ6Omlu aXRpYWxpemVOdW1iZXJGb3JtYXQpOgorICAgICAgICAqIHJ1bnRpbWUvSlNPYmplY3QuY3BwOgor ICAgICAgICAoSlNDOjpKU09iamVjdDo6aGVhcFNuYXBzaG90KToKKyAgICAgICAgKEpTQzo6Y2Fs bFRvUHJpbWl0aXZlRnVuY3Rpb24pOgorICAgICAgICAqIHJ1bnRpbWUvUmVnRXhwUHJvdG90eXBl LmNwcDoKKyAgICAgICAgKEpTQzo6ZmxhZ3NTdHJpbmcpOgorICAgICAgICAqIHJ1bnRpbWUvU2Ft cGxpbmdQcm9maWxlci5jcHA6CisgICAgICAgIChKU0M6OlNhbXBsaW5nUHJvZmlsZXI6OlN0YWNr RnJhbWU6OmZ1bmN0aW9uU3RhcnRDb2x1bW4pOgorCiAyMDE2LTA0LTMwICBLb25zdGFudGluIFRv a2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KIAogICAgICAgICBHdWFyZCBPYmpDLXNwZWNpZmlj IGNvZGUgaW4gSGVhcC5jcHAgd2l0aCBVU0UoRk9VTkRBVElPTikKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ieXRlY29kZS9Qcm9wZXJ0eUNvbmRpdGlvbi5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1Byb3BlcnR5Q29uZGl0aW9uLmNwcAkocmV2 aXNpb24gMjAwMjM2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1Byb3BlcnR5 Q29uZGl0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjU0LDcgKzI1NCw3IEBAIGJvb2wgUHJv cGVydHlDb25kaXRpb246OmlzV2F0Y2hhYmxlV2hlblYKICAgICAgICAgLy8gc2hvdWxkbid0IGhh dmUgYSBUT0NUT1UgcmFjZSBlaXRoZXIuCiAgICAgICAgIFJFTEVBU0VfQVNTRVJUKG9mZnNldCAh PSBpbnZhbGlkT2Zmc2V0KTsKICAgICAgICAgCi0gICAgICAgIFdhdGNocG9pbnRTZXQqIHNldDsK KyAgICAgICAgV2F0Y2hwb2ludFNldCogc2V0ID0gbnVsbHB0cjsKICAgICAgICAgc3dpdGNoIChl ZmZvcnQpIHsKICAgICAgICAgY2FzZSBNYWtlTm9DaGFuZ2VzOgogICAgICAgICAgICAgc2V0ID0g c3RydWN0dXJlLT5wcm9wZXJ0eVJlcGxhY2VtZW50V2F0Y2hwb2ludFNldChvZmZzZXQpOwpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPYmplY3RBbGxvY2F0aW9uU2lua2luZ1Bo YXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09iamVj dEFsbG9jYXRpb25TaW5raW5nUGhhc2UuY3BwCShyZXZpc2lvbiAyMDAyMzYpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR09iamVjdEFsbG9jYXRpb25TaW5raW5nUGhhc2UuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xMzcxLDcgKzEzNzEsNyBAQCBwcml2YXRlOgogICAgICAgICAgICAg Ly8gZmlyc3QuCiAgICAgICAgICAgICBpZiAobWF0ZXJpYWxpemVkLmlzRW1wdHkoKSkgewogICAg ICAgICAgICAgICAgIHVpbnQ2NF90IG1heEV2YWx1YXRpb24gPSAwOwotICAgICAgICAgICAgICAg IEFsbG9jYXRpb24qIGJlc3RBbGxvY2F0aW9uOworICAgICAgICAgICAgICAgIEFsbG9jYXRpb24q IGJlc3RBbGxvY2F0aW9uID0gbnVsbHB0cjsKICAgICAgICAgICAgICAgICBmb3IgKGF1dG8mIGVu dHJ5IDogZXNjYXBlZXMpIHsKICAgICAgICAgICAgICAgICAgICAgaWYgKCFmb3JNYXRlcmlhbGl6 YXRpb24uZmluZChlbnRyeS5rZXkpLT52YWx1ZS5pc0VtcHR5KCkpCiAgICAgICAgICAgICAgICAg ICAgICAgICBjb250aW51ZTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3Bl Y3VsYXRpdmVKSVQzMl82NC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcAkocmV2aXNpb24gMjAwMjM2KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDMyXzY0LmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNzE2LDggKzcxNiw4IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmVtaXRDYWxs KE5vZGUqIG5vZGUKICAgICB9CiAKICAgICBFZGdlIGNhbGxlZUVkZ2UgPSBtX2ppdC5ncmFwaCgp LmNoaWxkKG5vZGUsIDApOwotICAgIEdQUlJlZyBjYWxsZWVUYWdHUFI7Ci0gICAgR1BSUmVnIGNh bGxlZVBheWxvYWRHUFI7CisgICAgR1BSUmVnIGNhbGxlZVRhZ0dQUiA9IEludmFsaWRHUFJSZWc7 CisgICAgR1BSUmVnIGNhbGxlZVBheWxvYWRHUFIgPSBJbnZhbGlkR1BSUmVnOwogICAgIENhbGxG cmFtZVNodWZmbGVEYXRhIHNodWZmbGVEYXRhOwogICAgIAogICAgIC8vIEdvdHRhIGxvYWQgdGhl IGFyZ3VtZW50cyBzb21laG93LiBWYXJhcmdzIGlzIHRyaWNraWVyLgpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JCYWNrZW5kRGlzcGF0Y2hlci5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JCYWNr ZW5kRGlzcGF0Y2hlci5jcHAJKHJldmlzaW9uIDIwMDIzNikKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQmFja2VuZERpc3BhdGNoZXIuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0yMTIsNyArMjEyLDcgQEAgdm9pZCBCYWNrZW5kRGlzcGF0Y2hlcjo6c2VuZFBlbmRp bmdFcnJvcgogICAgIC8vIFRvIGNvbnN0cnVjdCB0aGUgZXJyb3Igb2JqZWN0LCBvbmx5IHVzZSB0 aGUgbGFzdCBlcnJvcidzIGNvZGUgYW5kIG1lc3NhZ2UuCiAgICAgLy8gUGVyIEpTT04tUlBDIDIu MCwgU2VjdGlvbiA1LjEsIHRoZSAnZGF0YScgbWVtYmVyIG1heSBjb250YWluIG5lc3RlZCBlcnJv cnMsCiAgICAgLy8gYnV0IG9ubHkgb25lIHRvcC1sZXZlbCBFcnJvciBvYmplY3Qgc2hvdWxkIGJl IHNlbnQgcGVyIHJlcXVlc3QuCi0gICAgQ29tbW9uRXJyb3JDb2RlIGVycm9yQ29kZTsKKyAgICBD b21tb25FcnJvckNvZGUgZXJyb3JDb2RlID0gSW50ZXJuYWxFcnJvcjsKICAgICBTdHJpbmcgZXJy b3JNZXNzYWdlOwogICAgIFJlZjxJbnNwZWN0b3JBcnJheT4gcGF5bG9hZCA9IEluc3BlY3RvckFy cmF5OjpjcmVhdGUoKTsKICAgICAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklU Q2FsbDMyXzY0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJ VENhbGwzMl82NC5jcHAJKHJldmlzaW9uIDIwMDIzNikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9qaXQvSklUQ2FsbDMyXzY0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjI2LDcgKzIyNiw3IEBA IHZvaWQgSklUOjpjb21waWxlT3BDYWxsKE9wY29kZUlEIG9wY29kZUkKICAgICAgICAgLSBDYWxs ZXIgaW5pdGlhbGl6ZXMgUmV0dXJuUEM7IENvZGVCbG9jay4KICAgICAgICAgLSBDYWxsZXIgcmVz dG9yZXMgY2FsbEZyYW1lUmVnaXN0ZXIgYWZ0ZXIgcmV0dXJuLgogICAgICovCi0gICAgQ2FsbExp bmtJbmZvKiBpbmZvOworICAgIENhbGxMaW5rSW5mbyogaW5mbyA9IG51bGxwdHI7CiAgICAgaWYg KG9wY29kZUlEICE9IG9wX2NhbGxfZXZhbCkKICAgICAgICAgaW5mbyA9IG1fY29kZUJsb2NrLT5h ZGRDYWxsTGlua0luZm8oKTsKICAgICBpZiAob3Bjb2RlSUQgPT0gb3BfY2FsbF92YXJhcmdzIHx8 IG9wY29kZUlEID09IG9wX2NvbnN0cnVjdF92YXJhcmdzIHx8IG9wY29kZUlEID09IG9wX3RhaWxf Y2FsbF92YXJhcmdzKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNw cAkocmV2aXNpb24gMjAwMjM2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJz ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMDYwLDcgKzMwNjAsNyBAQCB0ZW1wbGF0ZSA8dHlw ZW5hbWUgVHJlZUJ1aWxkZXI+IFRyZWVFeHByCiAgICAgYm9vbCB3YXNPcGVuUGFyZW4gPSBtYXRj aChPUEVOUEFSRU4pOwogICAgIGJvb2wgaXNWYWxpZEFycm93RnVuY3Rpb25TdGFydCA9IG1hdGNo KE9QRU5QQVJFTikgfHwgbWF0Y2goSURFTlQpOwogICAgIFNhdmVQb2ludCBzYXZlUG9pbnQgPSBj cmVhdGVTYXZlUG9pbnQoKTsKLSAgICBzaXplX3QgdXNlZFZhcmlhYmxlc1NpemU7CisgICAgc2l6 ZV90IHVzZWRWYXJpYWJsZXNTaXplID0gMDsKICAgICBpZiAod2FzT3BlblBhcmVuKSB7CiAgICAg ICAgIHVzZWRWYXJpYWJsZXNTaXplID0gY3VycmVudFNjb3BlKCktPmN1cnJlbnRVc2VkVmFyaWFi bGVzU2l6ZSgpOwogICAgICAgICBjdXJyZW50U2NvcGUoKS0+cHVzaFVzZWRWYXJpYWJsZVNldCgp OwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ2xvbmVkQXJndW1lbnRzLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9DbG9uZWRBcmd1 bWVudHMuY3BwCShyZXZpc2lvbiAyMDAyMzYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9DbG9uZWRBcmd1bWVudHMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04Myw3ICs4Myw3IEBA IENsb25lZEFyZ3VtZW50cyogQ2xvbmVkQXJndW1lbnRzOjpjcmVhdGUKICAgICBlbHNlCiAgICAg ICAgIGNhbGxlZSA9IGpzQ2FzdDxKU0Z1bmN0aW9uKj4odGFyZ2V0RnJhbWUtPmNhbGxlZSgpKTsK IAotICAgIENsb25lZEFyZ3VtZW50cyogcmVzdWx0OworICAgIENsb25lZEFyZ3VtZW50cyogcmVz dWx0ID0gbnVsbHB0cjsKICAgICAKICAgICB1bnNpZ25lZCBsZW5ndGggPSAwOyAvLyBJbml0aWFs aXplIGJlY2F1c2UgVkMgbmVlZHMgaXQuCiAgICAgc3dpdGNoIChtb2RlKSB7CkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FcnJvci5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvRXJyb3IuY3BwCShyZXZpc2lvbiAyMDAyMzYpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FcnJvci5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTE1MCw3ICsxNTAsNyBAQCBib29sIGFkZEVycm9ySW5mb0FuZEdldEJ5dGVjb2RlT2Zmc2V0KEV4 CiAKICAgICAgICAgQVNTRVJUKGV4ZWMgPT0gdm0udG9wQ2FsbEZyYW1lIHx8IGV4ZWMgPT0gZXhl Yy0+bGV4aWNhbEdsb2JhbE9iamVjdCgpLT5nbG9iYWxFeGVjKCkgfHwgZXhlYyA9PSBleGVjLT52 bUVudHJ5R2xvYmFsT2JqZWN0KCktPmdsb2JhbEV4ZWMoKSk7CiAKLSAgICAgICAgU3RhY2tGcmFt ZSogc3RhY2tGcmFtZTsKKyAgICAgICAgU3RhY2tGcmFtZSogc3RhY2tGcmFtZSA9IG51bGxwdHI7 CiAgICAgICAgIGZvciAodW5zaWduZWQgaSA9IDAgOyBpIDwgc3RhY2tUcmFjZS5zaXplKCk7ICsr aSkgewogICAgICAgICAgICAgc3RhY2tGcmFtZSA9ICZzdGFja1RyYWNlLmF0KGkpOwogICAgICAg ICAgICAgaWYgKHN0YWNrRnJhbWUtPmJ5dGVjb2RlT2Zmc2V0KQpJbmRleDogU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvSW50bE51bWJlckZvcm1hdC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSW50bE51bWJlckZvcm1hdC5jcHAJKHJldmlzaW9u IDIwMDIzNikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0ludGxOdW1iZXJGb3Jt YXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMzUsNyArMjM1LDcgQEAgdm9pZCBJbnRsTnVtYmVy Rm9ybWF0Ojppbml0aWFsaXplTnVtYmVyRgogICAgICAgICB9CiAgICAgfQogCi0gICAgdW5zaWdu ZWQgY3VycmVuY3lEaWdpdHM7CisgICAgdW5zaWduZWQgY3VycmVuY3lEaWdpdHMgPSAwOwogICAg IGlmIChtX3N0eWxlID09IFN0eWxlOjpDdXJyZW5jeSkgewogICAgICAgICAvLyAyMi4gSWYgcyBp cyAiY3VycmVuY3kiIGFuZCBjIGlzIHVuZGVmaW5lZCwgdGhyb3cgYSBUeXBlRXJyb3IgZXhjZXB0 aW9uLgogICAgICAgICBpZiAoY3VycmVuY3kuaXNOdWxsKCkpIHsKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAJKHJldmlzaW9uIDIwMDIzNikKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpA QCAtMjUyLDcgKzI1Miw3IEBAIHZvaWQgSlNPYmplY3Q6OmhlYXBTbmFwc2hvdChKU0NlbGwqIGNl bGwKIAogICAgIEJ1dHRlcmZseSogYnV0dGVyZmx5ID0gdGhpc09iamVjdC0+bV9idXR0ZXJmbHku Z2V0KCk7CiAgICAgaWYgKGJ1dHRlcmZseSkgewotICAgICAgICBXcml0ZUJhcnJpZXI8VW5rbm93 bj4qIGRhdGE7CisgICAgICAgIFdyaXRlQmFycmllcjxVbmtub3duPiogZGF0YSA9IG51bGxwdHI7 CiAgICAgICAgIHVpbnQzMl90IGNvdW50ID0gMDsKIAogICAgICAgICBzd2l0Y2ggKHRoaXNPYmpl Y3QtPmluZGV4aW5nVHlwZSgpKSB7CkBAIC0xNTk1LDcgKzE1OTUsNyBAQCBzdGF0aWMgQUxXQVlT X0lOTElORSBKU1ZhbHVlIGNhbGxUb1ByaW1pCiAKICAgICBNYXJrZWRBcmd1bWVudEJ1ZmZlciBj YWxsQXJnczsKICAgICBpZiAobW9kZSA9PSBUeXBlSGludE1vZGU6OlRha2VzSGludCkgewotICAg ICAgICBKU1N0cmluZyogaGludFN0cmluZzsKKyAgICAgICAgSlNTdHJpbmcqIGhpbnRTdHJpbmcg PSBudWxscHRyOwogICAgICAgICBzd2l0Y2ggKGhpbnQpIHsKICAgICAgICAgY2FzZSBOb1ByZWZl cmVuY2U6CiAgICAgICAgICAgICBoaW50U3RyaW5nID0gZXhlYy0+dm0oKS5zbWFsbFN0cmluZ3Mu ZGVmYXVsdFN0cmluZygpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVn RXhwUHJvdG90eXBlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9SZWdFeHBQcm90b3R5cGUuY3BwCShyZXZpc2lvbiAyMDAyMzYpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHBQcm90b3R5cGUuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xNzUsNiArMTc1LDcgQEAgdHlwZWRlZiBzdGQ6OmFycmF5PGNoYXIsIDUgKyAxPiBGbGFnc1N0 cgogc3RhdGljIGlubGluZSBGbGFnc1N0cmluZyBmbGFnc1N0cmluZyhFeGVjU3RhdGUqIGV4ZWMs IEpTT2JqZWN0KiByZWdleHApCiB7CiAgICAgRmxhZ3NTdHJpbmcgc3RyaW5nOworICAgIHN0cmlu Z1swXSA9IDA7CiAKICAgICBWTSYgdm0gPSBleGVjLT52bSgpOwogCkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9TYW1wbGluZ1Byb2ZpbGVyLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TYW1wbGluZ1Byb2ZpbGVyLmNwcAkocmV2aXNp b24gMjAwMjM2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU2FtcGxpbmdQcm9m aWxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY3NSwxMCArNjc1LDEwIEBAIGludCBTYW1wbGlu Z1Byb2ZpbGVyOjpTdGFja0ZyYW1lOjpmdW5jdGkKIHVuc2lnbmVkIFNhbXBsaW5nUHJvZmlsZXI6 OlN0YWNrRnJhbWU6OmZ1bmN0aW9uU3RhcnRDb2x1bW4oKQogewogICAgIGlmIChmcmFtZVR5cGUg PT0gRnJhbWVUeXBlOjpVbmtub3duIHx8IGZyYW1lVHlwZSA9PSBGcmFtZVR5cGU6Okhvc3QpCi0g ICAgICAgIHJldHVybiAtMTsKKyAgICAgICAgcmV0dXJuIFVJTlRfTUFYOwogCiAgICAgaWYgKGV4 ZWN1dGFibGUtPmlzSG9zdEZ1bmN0aW9uKCkpCi0gICAgICAgIHJldHVybiAtMTsKKyAgICAgICAg cmV0dXJuIFVJTlRfTUFYOwogCiAgICAgcmV0dXJuIHN0YXRpY19jYXN0PFNjcmlwdEV4ZWN1dGFi bGUqPihleGVjdXRhYmxlKS0+c3RhcnRDb2x1bW4oKTsKIH0K