149791 2015-10-03 20:10:47 -0700 Bot watcher's dashboard builders should turn yellow when svn fails 2015-10-04 09:57:40 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue lforschler oldest_to_newest 1130479 0 ap 2015-10-03 20:10:47 -0700 Currently, builders turn red when svn fails. But we already know that it's not a productive step. 1130480 1 262388 ap 2015-10-03 20:12:26 -0700 Created attachment 262388 proposed fix 1130511 2 262388 commit-queue 2015-10-04 09:57:37 -0700 Comment on attachment 262388 proposed fix Clearing flags on attachment: 262388 Committed r190548: <http://trac.webkit.org/changeset/190548> 1130512 3 commit-queue 2015-10-04 09:57:40 -0700 All reviewed patches have been landed. Closing bug. 262388 2015-10-03 20:12:26 -0700 2015-10-04 09:57:37 -0700 proposed fix dashboard2.txt text/plain 1976 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5MDU0NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE1LTEwLTAzICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIEJvdCB3YXRjaGVyJ3MgZGFzaGJvYXJkIGJ1aWxkZXJzIHNob3VsZCB0dXJu IHllbGxvdyB3aGVuIHN2biBmYWlscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTQ5NzkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZp Zy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdEJ1aWxkZXJRdWV1ZVZpZXcu anM6CisgICAgICAgIChCdWlsZGJvdEJ1aWxkZXJRdWV1ZVZpZXcucHJvdG90eXBlLmFwcGVuZEJ1 aWxkZXJRdWV1ZVN0YXR1cyk6CisgICAgICAgIChCdWlsZGJvdEJ1aWxkZXJRdWV1ZVZpZXcucHJv dG90eXBlLnVwZGF0ZSk6CisKIDIwMTUtMTAtMDIgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBw bGUuY29tPgogCiAgICAgICAgIEFkZCBpT1MgOSBTaW11bGF0b3IgYnVpbGRlcnMgYW5kIHRlc3Rl cnMgdG8gV2ViS2l0IEJvdCBXYXRjaGVyJ3MgRGFzaGJvYXJkCkluZGV4OiBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQv U2NyaXB0cy9CdWlsZGJvdEJ1aWxkZXJRdWV1ZVZpZXcuanMKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFz aGJvYXJkL1NjcmlwdHMvQnVpbGRib3RCdWlsZGVyUXVldWVWaWV3LmpzCShyZXZpc2lvbiAxOTA1 NDIpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9w dWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdEJ1aWxkZXJRdWV1ZVZpZXcuanMJ KHdvcmtpbmcgY29weSkKQEAgLTc1LDcgKzc1LDcgQEAgQnVpbGRib3RCdWlsZGVyUXVldWVWaWV3 LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgICAgICAmJiBtb3N0UmVjZW50RmluaXNoZWRJdGVy YXRpb24gJiYgbW9zdFJlY2VudEZpbmlzaGVkSXRlcmF0aW9uLmxvYWRlZCkgewogICAgICAgICAg ICAgICAgIGNvbnNvbGUuYXNzZXJ0KCFtb3N0UmVjZW50RmluaXNoZWRJdGVyYXRpb24uc3VjY2Vz c2Z1bCk7CiAgICAgICAgICAgICAgICAgdmFyIG1lc3NhZ2UgPSB0aGlzLnJldmlzaW9uQ29udGVu dEZvckl0ZXJhdGlvbihtb3N0UmVjZW50RmluaXNoZWRJdGVyYXRpb24sIG1vc3RSZWNlbnRGaW5p c2hlZEl0ZXJhdGlvbi5wcm9kdWN0aXZlID8gbW9zdFJlY2VudFN1Y2Nlc3NmdWxJdGVyYXRpb24g OiBudWxsKTsKLSAgICAgICAgICAgICAgICBpZiAobW9zdFJlY2VudEZpbmlzaGVkSXRlcmF0aW9u LmZhaWxlZCkgeworICAgICAgICAgICAgICAgIGlmIChtb3N0UmVjZW50RmluaXNoZWRJdGVyYXRp b24uZmFpbGVkICYmIG1vc3RSZWNlbnRGaW5pc2hlZEl0ZXJhdGlvbi5wcm9kdWN0aXZlKSB7CiAg ICAgICAgICAgICAgICAgICAgIC8vIEFzc3VtZSBpdCB3YXMgYSBidWlsZCBzdGVwIHRoYXQgZmFp bGVkLCBhbmQgbGluayBkaXJlY3RseSB0byBvdXRwdXQuCiAgICAgICAgICAgICAgICAgICAgIHZh ciB1cmwgPSBtb3N0UmVjZW50RmluaXNoZWRJdGVyYXRpb24uZmFpbHVyZUxvZ1VSTCgiYnVpbGQg bG9nIik7CiAgICAgICAgICAgICAgICAgICAgIGlmICghdXJsKQo=