149726 2015-10-01 15:18:55 -0700 Web Inspector: Do not immediately create all ProfileNodeTreeElements when showing JavaScript and Events timeline 2015-10-01 16:34:40 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1130051 0 joepeck 2015-10-01 15:18:55 -0700 * SUMMARY Do not immediately create all ProfileNodeTreeElements when showing JavaScript and Events timeline. When switching to JavaScript and Events timeline we accidentally create ProfileNodeDataGrid / ProfileNodeTreeElements for every single profile node. Some samples this can be > 500000 tree elements. This causes significant performance impact on tasks like sorting and filtering. 1130052 1 webkit-bug-importer 2015-10-01 15:19:24 -0700 <rdar://problem/22941804> 1130056 2 262288 joepeck 2015-10-01 15:28:11 -0700 Created attachment 262288 [PATCH] Proposed Fix This brings Script & Events to a usable level of performance as long as you don't have a text filter. 1. Switching to the timeline doesn't create 500000+ tree elements 2. Sorting the timeline doesn't need to update 500000+ tree elements However, this does mean the first time you do a text filter we have abysmal performance, as we create these tree elements at that time and walk all of them, maybe expand portions, and calculate ProfileNode times. I think that is a reasonable step forward at the moment and we will work to improve that next. 1130068 3 262288 timothy 2015-10-01 15:46:56 -0700 Comment on attachment 262288 [PATCH] Proposed Fix Nice! 1130084 4 262288 commit-queue 2015-10-01 16:34:36 -0700 Comment on attachment 262288 [PATCH] Proposed Fix Clearing flags on attachment: 262288 Committed r190437: <http://trac.webkit.org/changeset/190437> 1130085 5 commit-queue 2015-10-01 16:34:40 -0700 All reviewed patches have been landed. Closing bug. 262288 2015-10-01 15:28:11 -0700 2015-10-01 16:34:36 -0700 [PATCH] Proposed Fix filter-1.patch text/plain 3760 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDdlZmU1OWIuLmE1Yjk3MDQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTEwLTAxICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRG8gbm90 IGltbWVkaWF0ZWx5IGNyZWF0ZSBhbGwgUHJvZmlsZU5vZGVUcmVlRWxlbWVudHMgd2hlbiBzaG93 aW5nIEphdmFTY3JpcHQgYW5kIEV2ZW50cyB0aW1lbGluZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5NzI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL05hdmlnYXRp b25TaWRlYmFyUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTmF2aWdhdGlvblNpZGVi YXJQYW5lbC5wcm90b3R5cGUuc2hvdWxkRmlsdGVyUG9wdWxhdGUpOgorICAgICAgICAoV2ViSW5z cGVjdG9yLk5hdmlnYXRpb25TaWRlYmFyUGFuZWwucHJvdG90eXBlLl91cGRhdGVGaWx0ZXIpOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLk5hdmlnYXRpb25TaWRlYmFyUGFuZWwucHJvdG90eXBlLl90 cmVlRWxlbWVudEFkZGVkT3JDaGFuZ2VkKToKKyAgICAgICAgV2Ugd2VyZSBwb3B1bGF0aW5nIGR1 cmluZyBmaWx0ZXJpbmcgaWYgdGhlcmUgd2VyZSBhbnkgY3VzdG9tIGZpbHRlcnMuCisgICAgICAg IEhvd2V2ZXIgdGhlIFRpbWVsaW5lU2lkZWJhclBhbmVsIGhhcyBjdXN0b20gZmlsdGVycyAoYmFz ZWQgb24gdGltZSBhbmQgdHlwZSkKKyAgICAgICAgYnV0IHRob3NlIGRvbid0IG5lZWQgdG8gdHJp Z2dlciBwb3B1bGF0aW9uLiBEZWxheSBwb3B1bGF0aW9uIHVudGlsIGl0CisgICAgICAgIHdvdWxk IGFjdHVhbGx5IGJlIG5lZWRlZCAobGlrZSBhIHRleHQgc2VhcmNoKS4KKworICAgICAgICAqIFVz ZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVTaWRlYmFyUGFuZWwuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuVGltZWxpbmVTaWRlYmFyUGFuZWwucHJvdG90eXBlLnNob3VsZEZpbHRlclBvcHVs YXRlKToKKyAgICAgICAgRG8gbm90IHBvcHVsYXRlIG9uIGZpbHRlciB2aWEgdGhpcyBjdXN0b20g ZmlsdGVycy4KKwogMjAxNS0wOS0zMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJlZHVjZSBgZGVsZXRlYCBpbiBUaW1lbGlu ZSByZWxhdGVkIGNsYXNzZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL05hdmlnYXRpb25TaWRlYmFyUGFuZWwuanMgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzCmlu ZGV4IDk1YzFjMmIuLjY5YWUyNjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL05hdmlnYXRpb25TaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmF2aWdhdGlvblNpZGViYXJQYW5l bC5qcwpAQCAtMjkyLDYgKzI5MiwxMiBAQCBXZWJJbnNwZWN0b3IuTmF2aWdhdGlvblNpZGViYXJQ YW5lbCA9IGNsYXNzIE5hdmlnYXRpb25TaWRlYmFyUGFuZWwgZXh0ZW5kcyBXZWJJbgogICAgICAg ICB0aGlzLl91cGRhdGVGaWx0ZXIoKTsKICAgICB9CiAKKyAgICBzaG91bGRGaWx0ZXJQb3B1bGF0 ZSgpCisgICAgeworICAgICAgICAvLyBPdmVycmlkZW4gYnkgc3ViY2xhc3NlcyBpZiBuZWVkZWQu CisgICAgICAgIHJldHVybiB0aGlzLmhhc0N1c3RvbUZpbHRlcnMoKTsKKyAgICB9CisKICAgICBo YXNDdXN0b21GaWx0ZXJzKCkKICAgICB7CiAgICAgICAgIC8vIEltcGxlbWVudGVkIGJ5IHN1YmNs YXNzZXMgaWYgbmVlZGVkLgpAQCAtNTI1LDcgKzUzMSw3IEBAIFdlYkluc3BlY3Rvci5OYXZpZ2F0 aW9uU2lkZWJhclBhbmVsID0gY2xhc3MgTmF2aWdhdGlvblNpZGViYXJQYW5lbCBleHRlbmRzIFdl YkluCiAKICAgICAgICAgLy8gRG9uJ3QgcG9wdWxhdGUgaWYgd2UgZG9uJ3QgaGF2ZSBhbnkgYWN0 aXZlIGZpbHRlcnMuCiAgICAgICAgIC8vIFdlIG9ubHkgbmVlZCB0byBwb3B1bGF0ZSB3aGVuIGEg ZmlsdGVyIG5lZWRzIHRvIHJldmVhbC4KLSAgICAgICAgdmFyIGRvbnRQb3B1bGF0ZSA9ICF0aGlz Ll9maWx0ZXJCYXIuaGFzQWN0aXZlRmlsdGVycygpICYmICF0aGlzLmhhc0N1c3RvbUZpbHRlcnMo KTsKKyAgICAgICAgdmFyIGRvbnRQb3B1bGF0ZSA9ICF0aGlzLl9maWx0ZXJCYXIuaGFzQWN0aXZl RmlsdGVycygpICYmICF0aGlzLnNob3VsZEZpbHRlclBvcHVsYXRlKCk7CiAKICAgICAgICAgLy8g VXBkYXRlIHRoZSB3aG9sZSB0cmVlLgogICAgICAgICB2YXIgY3VycmVudFRyZWVFbGVtZW50ID0g dGhpcy5fY29udGVudFRyZWVPdXRsaW5lLmNoaWxkcmVuWzBdOwpAQCAtNTU0LDcgKzU2MCw3IEBA IFdlYkluc3BlY3Rvci5OYXZpZ2F0aW9uU2lkZWJhclBhbmVsID0gY2xhc3MgTmF2aWdhdGlvblNp ZGViYXJQYW5lbCBleHRlbmRzIFdlYkluCiAgICAgewogICAgICAgICAvLyBEb24ndCBwb3B1bGF0 ZSBpZiB3ZSBkb24ndCBoYXZlIGFueSBhY3RpdmUgZmlsdGVycy4KICAgICAgICAgLy8gV2Ugb25s eSBuZWVkIHRvIHBvcHVsYXRlIHdoZW4gYSBmaWx0ZXIgbmVlZHMgdG8gcmV2ZWFsLgotICAgICAg ICB2YXIgZG9udFBvcHVsYXRlID0gIXRoaXMuX2ZpbHRlckJhci5oYXNBY3RpdmVGaWx0ZXJzKCkg JiYgIXRoaXMuaGFzQ3VzdG9tRmlsdGVycygpOworICAgICAgICB2YXIgZG9udFBvcHVsYXRlID0g IXRoaXMuX2ZpbHRlckJhci5oYXNBY3RpdmVGaWx0ZXJzKCkgJiYgIXRoaXMuc2hvdWxkRmlsdGVy UG9wdWxhdGUoKTsKIAogICAgICAgICAvLyBBcHBseSB0aGUgZmlsdGVycyB0byB0aGUgdHJlZSBl bGVtZW50IGFuZCBpdHMgZGVzY2VuZGFudHMuCiAgICAgICAgIHZhciBjdXJyZW50VHJlZUVsZW1l bnQgPSB0cmVlRWxlbWVudDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVTaWRlYmFyUGFuZWwuanMKaW5kZXgg ZjU2ZTBiYi4uNDUxYjdlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvVGltZWxpbmVTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVTaWRlYmFyUGFuZWwuanMKQEAg LTM5OSw2ICszOTksMTEgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lU2lkZWJhclBhbmVsID0gY2xh c3MgVGltZWxpbmVTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXZWJJbnNwZWMKICAgICAgICAgdGhpcy5f ZGlzcGxheWVkQ29udGVudFZpZXcuZmlsdGVyRGlkQ2hhbmdlKCk7CiAgICAgfQogCisgICAgc2hv dWxkRmlsdGVyUG9wdWxhdGUoKQorICAgIHsKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0K KwogICAgIGhhc0N1c3RvbUZpbHRlcnMoKQogICAgIHsKICAgICAgICAgcmV0dXJuIHRydWU7Cg==