149724 2015-10-01 14:37:03 -0700 Convert focused-input-should-assist-on-touch.html into an automated test 2015-10-01 21:27:57 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wenson_hsieh webkit-unassigned enrica lforschler simon.fraser oldest_to_newest 1130044 0 wenson_hsieh 2015-10-01 14:37:03 -0700 Now that WKTR supports touch events on iOS, rewrite one of the manual tests added for https://bugs.webkit.org/show_bug.cgi?id=147836 as an automated test. 1130046 1 262285 wenson_hsieh 2015-10-01 14:48:59 -0700 Created attachment 262285 Patch 1130093 2 262285 simon.fraser 2015-10-01 17:02:10 -0700 Comment on attachment 262285 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262285&action=review > LayoutTests/fast/events/ios/focused-input-should-assist-on-touch.html:3 > + <meta name="viewport" content="initial-scale=1.0"> If you want this to work, you need to add the <!-- webkit-test-runner [ useFlexibleViewport=true ] --> comment on the first line. 1130094 3 262285 wenson_hsieh 2015-10-01 17:03:11 -0700 Comment on attachment 262285 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=262285&action=review >> LayoutTests/fast/events/ios/focused-input-should-assist-on-touch.html:3 >> + <meta name="viewport" content="initial-scale=1.0"> > > If you want this to work, you need to add the <!-- webkit-test-runner [ useFlexibleViewport=true ] --> comment on the first line. Got it -- thanks! 1130155 4 wenson_hsieh 2015-10-01 21:27:57 -0700 Committed r190451: <http://trac.webkit.org/changeset/190451> 262285 2015-10-01 14:48:59 -0700 2015-10-01 17:02:10 -0700 Patch bug-149724-20151001144833.patch text/plain 5385 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMTkwNDA4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzdhZGU0NDYyMDk2YmIwYWUzOWUx NGVmNTQ1Mjk5NGIxOGI3YWZiZC4uNzM0NzRkMmM4YzQ2YTIzODYyOWMxZWZiYmIyZGQ4MDM4NWFj NWRiYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE1LTEwLTAxICBXZW5zb24gSHNpZWggIDx3 ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCisgICAgICAgIENvbnZlcnQgZm9jdXNlZC1pbnB1dC1z aG91bGQtYXNzaXN0LW9uLXRvdWNoLmh0bWwgaW50byBhbiBhdXRvbWF0ZWQgdGVzdAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5NzI0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdHMgdGhhdCBhbiBp bnB1dCB0aGF0IGZvY3VzZXMgaXRzZWxmIG9uIHRvdWNoIGFuZCB0aGVuIHByZXZlbnRzIGRlZmF1 bHQgaXMKKyAgICAgICAgYWJsZSB0byB0cmlnZ2VyIG5vZGUgYXNzaXN0YW5jZSwgZXZlbiB3aGVu IGl0IGlzIGFscmVhZHkgZm9jdXNlZCBiZWZvcmUgdGhlCisgICAgICAgIHVzZXIgZ2VzdHVyZS4K KworICAgICAgICAqIGZhc3QvZXZlbnRzL2lvcy9mb2N1c2VkLWlucHV0LXNob3VsZC1hc3Npc3Qt b24tdG91Y2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2V2ZW50cy9pb3Mv Zm9jdXNlZC1pbnB1dC1zaG91bGQtYXNzaXN0LW9uLXRvdWNoLmh0bWw6IEFkZGVkLgorCisyMDE1 LTEwLTAxICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCiAgICAgICAg IEltcGxlbWVudCBrZXlib2FyZCBldmVudCBzZW5kaW5nIGZvciBpT1MgaW4gV2ViS2l0VGVzdFJ1 bm5lcgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5 Njc2CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2lvcy9mb2N1c2VkLWlu cHV0LXNob3VsZC1hc3Npc3Qtb24tdG91Y2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFz dC9ldmVudHMvaW9zL2ZvY3VzZWQtaW5wdXQtc2hvdWxkLWFzc2lzdC1vbi10b3VjaC1leHBlY3Rl ZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uZmE5MmMzMmVhNWNhZGFlNzYyMGI0MWZjYTIwMWUzYmI2MDE4ZjBm ZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2lvcy9mb2N1c2Vk LWlucHV0LXNob3VsZC1hc3Npc3Qtb24tdG91Y2gtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMiBA QAorCitTdWNjZXNzZnVsbHkgc2hvd2VkIGtleWJvYXJkLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZmFzdC9ldmVudHMvaW9zL2ZvY3VzZWQtaW5wdXQtc2hvdWxkLWFzc2lzdC1vbi10b3VjaC5o dG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvaW9zL2ZvY3VzZWQtaW5wdXQtc2hvdWxkLWFz c2lzdC1vbi10b3VjaC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmU4YTdkYjgwMDRhNzYwZGFkNWQ4YmUxMTNk YTUwZDg1ZjE3MjhiM2EKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50 cy9pb3MvZm9jdXNlZC1pbnB1dC1zaG91bGQtYXNzaXN0LW9uLXRvdWNoLmh0bWwKQEAgLTAsMCAr MSw2MCBAQAorPGh0bWw+Cis8aGVhZD4KKyAgICA8bWV0YSBuYW1lPSJ2aWV3cG9ydCIgY29udGVu dD0iaW5pdGlhbC1zY2FsZT0xLjAiPgorICAgIDxzY3JpcHQgaWQ9InVpLXNjcmlwdCIgdHlwZT0i dGV4dC9wbGFpbiI+CisgICAgICAgIChmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIHVpQ29udHJv bGxlci5kaWRTaG93S2V5Ym9hcmRDYWxsYmFjayA9IGZ1bmN0aW9uKCkgeworICAgICAgICAgICAg ICAgIHVpQ29udHJvbGxlci51aVNjcmlwdENvbXBsZXRlKCJTdWNjZXNzZnVsbHkgc2hvd2VkIGtl eWJvYXJkLiIpOworICAgICAgICAgICAgfQorICAgICAgICAgICAgdWlDb250cm9sbGVyLnNpbmds ZVRhcEF0UG9pbnQoNTAsIDI1LCBmdW5jdGlvbigpIHsgfSk7CisgICAgICAgIH0pKCk7CisgICAg PC9zY3JpcHQ+CisKKyAgICA8c2NyaXB0PgorICAgICAgICBpZiAod2luZG93LnRlc3RSdW5uZXIp IHsKKyAgICAgICAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworICAgICAgICAgICAgdGVz dFJ1bm5lci53YWl0VW50aWxEb25lKCk7CisgICAgICAgIH0KKworICAgICAgICBmdW5jdGlvbiBn ZXRVSVNjcmlwdCgpCisgICAgICAgIHsKKyAgICAgICAgICAgIHJldHVybiBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgidWktc2NyaXB0IikudGV4dDsKKyAgICAgICAgfQorCisgICAgICAgIGZ1bmN0 aW9uIGhhbmRsZVRvdWNoRXZlbnQoZXZlbnQpCisgICAgICAgIHsKKyAgICAgICAgICAgIGV2ZW50 LnRhcmdldC5mb2N1cygpOworICAgICAgICAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKKyAg ICAgICAgfQorCisgICAgICAgIGZ1bmN0aW9uIHJ1blRlc3QoKQorICAgICAgICB7CisgICAgICAg ICAgICBpZiAod2luZG93LnRlc3RSdW5uZXIgJiYgdGVzdFJ1bm5lci5ydW5VSVNjcmlwdCkKKyAg ICAgICAgICAgICAgICB0ZXN0UnVubmVyLnJ1blVJU2NyaXB0KGdldFVJU2NyaXB0KCksIGZ1bmN0 aW9uKHJlc3VsdCkgeworICAgICAgICAgICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgiY29uc29sZSIpLnRleHRDb250ZW50ID0gcmVzdWx0OworICAgICAgICAgICAgICAgICAgICB0 ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsKKyAgICAgICAgICAgICAgICB9KTsKKyAgICAgICAgICAg IGVsc2UKKyAgICAgICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29uc29sZSIp LnRleHRDb250ZW50ID0gIlRoaXMgdGVzdHMgdGhhdCBhIG5vZGUgY2FuIGJlIGFzc2lzdGVkIHdo ZW4gZm9jdXNlZCBkdWUgdG8gYSB0b3VjaCBldmVudCwgZXZlbiB3aGVuIHRoZSBmb2N1cyBkb2Vz IG5vdCBjaGFuZ2UuIFRhcHBpbmcgdGhlIGJlbG93IGlucHV0IHNob3VsZCBzaG93IHRoZSBrZXli b2FyZC4gQmVzdCBydW4gdXNpbmcgV0tUUi4iCisgICAgICAgIH0KKyAgICA8L3NjcmlwdD4KKwor ICAgIDxzdHlsZT4KKyAgICAgICAgaW5wdXQ6Zm9jdXMgeworICAgICAgICAgICAgb3V0bGluZTog bm9uZTsKKyAgICAgICAgICAgIGJvcmRlcjogMXB4IHNvbGlkICM0RDkwRkU7CisgICAgICAgIH0K KworICAgICAgICBpbnB1dCB7CisgICAgICAgICAgICB3aWR0aDogMTAwcHg7CisgICAgICAgICAg ICBoZWlnaHQ6IDUwcHg7CisgICAgICAgIH0KKyAgICA8L3N0eWxlPgorCis8L2hlYWQ+CisKKzxi b2R5IHN0eWxlPSJtYXJnaW46IDA7IiBvbmxvYWQ9InJ1blRlc3QoKSI+CisgICAgPGlucHV0IGF1 dG9mb2N1cyBvbnRvdWNoc3RhcnQ9ImhhbmRsZVRvdWNoRXZlbnQoZXZlbnQpIj48L2lucHV0Pgor ICAgIDxkaXYgaWQ9ImNvbnNvbGUiPkZhaWxlZCB0byBzaG93IGtleWJvYXJkLjwvZGl2PgorPC9i b2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDI0 MzJkOTVjNWEzZDg3OTA2ZjhjYTRlYzEyNWNjZTM4YmFiYTI4MzIuLjdiMGIyNTYwOTJiNWU3Y2U1 MmJiNTk5MjQ0OGY3NmRiNzQ1NjJiZjAgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxNS0xMC0wMSAgV2Vuc29uIEhzaWVoICA8d2Vuc29u X2hzaWVoQGFwcGxlLmNvbT4KKworICAgICAgICBDb252ZXJ0IGZvY3VzZWQtaW5wdXQtc2hvdWxk LWFzc2lzdC1vbi10b3VjaC5odG1sIGludG8gYW4gYXV0b21hdGVkIHRlc3QKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTcyNAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBhIG1hbnVhbCB0ZXN0 IHRoYXQgY2FuIG5vdyBiZSByZXdyaXR0ZW4gYXMgYW4gYXV0b21hdGVkIHRlc3QuCisKKyAgICAg ICAgKiBNYW51YWxUZXN0cy9pb3MvZm9jdXNlZC1pbnB1dC1zaG91bGQtYXNzaXN0LW9uLXRvdWNo Lmh0bWw6IFJlbW92ZWQuCisKIDIwMTUtMDktMzAgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBh cHBsZS5jb20+CiAKICAgICAgICAgW1dpbl0gVW5yZXZpZXdlZCBidWlsZCBmaXggYWZ0ZXIgQ01h a2UgY29udmVyc2lvbi4KZGlmZiAtLWdpdCBhL01hbnVhbFRlc3RzL2lvcy9mb2N1c2VkLWlucHV0 LXNob3VsZC1hc3Npc3Qtb24tdG91Y2guaHRtbCBiL01hbnVhbFRlc3RzL2lvcy9mb2N1c2VkLWlu cHV0LXNob3VsZC1hc3Npc3Qtb24tdG91Y2guaHRtbApkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggNDIzOGNmM2Y4MzgzYjAxNzRhODc3NWU0MGUwMTA1ZWM3ZTMwMzY0Zi4uMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9NYW51YWxUZXN0cy9pb3MvZm9j dXNlZC1pbnB1dC1zaG91bGQtYXNzaXN0LW9uLXRvdWNoLmh0bWwKKysrIC9kZXYvbnVsbApAQCAt MSwyNSArMCwwIEBACi08aHRtbD4KLTxoZWFkPgotICAgIDxtZXRhIG5hbWU9InZpZXdwb3J0IiBj b250ZW50PSJ3aWR0aD1kZXZpY2Utd2lkdGgsIGluaXRpYWwtc2NhbGU9MSI+Ci0gICAgPHNjcmlw dD4KLSAgICAgICAgZnVuY3Rpb24gaGFuZGxlVG91Y2hFdmVudChldmVudCkgewotICAgICAgICAg ICAgZXZlbnQudGFyZ2V0LmZvY3VzKCk7Ci0gICAgICAgICAgICBldmVudC5wcmV2ZW50RGVmYXVs dCgpOwotICAgICAgICB9Ci0gICAgPC9zY3JpcHQ+Ci0KLSAgICA8c3R5bGU+Ci0gICAgICAgIGlu cHV0OmZvY3VzIHsKLSAgICAgICAgICAgIG91dGxpbmU6IG5vbmU7Ci0gICAgICAgICAgICBib3Jk ZXI6IDFweCBzb2xpZCAjNEQ5MEZFOwotICAgICAgICB9Ci0gICAgPC9zdHlsZT4KLQotPC9oZWFk PgotCi08Ym9keSBzdHlsZT0ibWFyZ2luOiAwOyI+Ci0gICAgPHA+VGhpcyB0ZXN0cyBjaGVja3Mg dGhhdCBhIG5vZGUgY2FuIGJlIGFzc2lzdGVkIHdoZW4gZm9jdXNlZCBkdWUgdG8gYSB0b3VjaCBl dmVudCwgZXZlbiB3aGVuIHRoZSBmb2N1cyBkb2VzIG5vdCBjaGFuZ2UuPC9wPgotICAgIDxwPlRh cHBpbmcgdGhlIGJlbG93IGlucHV0IHNob3VsZCBzaG93IHRoZSBrZXlib2FyZC48L3A+Ci0gICAg PGlucHV0IGF1dG9mb2N1cyBvbnRvdWNoc3RhcnQ9ImhhbmRsZVRvdWNoRXZlbnQoZXZlbnQpOyI+ PC9pbnB1dD4KLTwvYm9keT4KLTwvaHRtbD4K