14972 2007-08-15 07:46:48 -0700 Moving cursor down in contentEditable section fails if styled line-height:1em 2007-08-25 05:32:51 -0700 1 1 1 Unclassified WebKit HTML Editing 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED HasReduction, InRadar P2 Normal --- 1 ben webkit-unassigned bdakin ben hyatt mitz oldest_to_newest 2262 0 ben 2007-08-15 07:46:48 -0700 In r25065 and below, moving the cursor down in a contentEditable section doesn't work properly if the paragraph has CSS style line-height:1em;. See attached; to reproduce, click in editable area, press the down arrow key. 2260 1 15979 ben 2007-08-15 07:47:38 -0700 Created attachment 15979 html file illustrating problem 2251 2 ddkilzer 2007-08-15 09:34:56 -0700 Confirmed with a local debug build of WebKit r25066 with Safari 3 Public Beta v. 3.0.3 (522.12.1) on Mac OS X 10.4.10 (8R218). This also reproduces on Safari 2.0.4 (419.3) with its original WebKit on 10.4.10, so it's not a regression. Also note the "lip" at the bottom of the <iframe> which bleeds through contents of the iframe! That looks like a different bug, although it's also present on Safari 2.0.4 as well. 2226 3 15984 mitz 2007-08-15 12:31:07 -0700 Created attachment 15984 Change RenderText hit testing to prefer the lower of two overlapping lines No layout test regressions, but it is perhaps worth mentioning that a more local fix is possible by patching nextLinePosition() to pass a lower y coordinate to positionForCoordinates(). 1694 4 15984 hyatt 2007-08-22 13:52:05 -0700 Comment on attachment 15984 Change RenderText hit testing to prefer the lower of two overlapping lines r=me 1495 5 mrowe 2007-08-25 05:32:07 -0700 Landed in r25235. 1496 6 mrowe 2007-08-25 05:32:48 -0700 <rdar://problem/5437710> 15979 2007-08-15 07:47:38 -0700 2007-08-15 07:47:38 -0700 html file illustrating problem safaricontenteditable.html text/html 2538 ben PGh0bWw+CjxoZWFkPjx0aXRsZT5Db250ZW50ZWRpdGFibGUgYnVnPC90aXRsZT4KPGJvZHkgb25s b2FkPSJsb2FkaWZyYW1lKCk7Ij4KCjxkaXYgaWQ9ImlmcmFtZWNvbnRhaW5lciIgc3R5bGU9Indp ZHRoOjUxMnB4O2hlaWdodDoyNTZweDtib3JkZXI6MXB4IHNvbGlkIGJsYWNrOyI+CjwvZGl2Pgo8 c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CmZ1bmN0aW9uIGxvYWRpZnJhbWUoKQp7CiAg dmFyIGlmcmFtZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2lmcmFtZScpOwogIGlmcmFtZS5p ZCA9ICdpZnJhbWVpZCc7CiAgaWZyYW1lLnN0eWxlLndpZHRoID0gJzEwMCUnOwogIGlmcmFtZS5z dHlsZS5oZWlnaHQgPSAnMTI4cHgnOwogIGlmcmFtZS5zdHlsZS5ib3JkZXIgPSAnMXB4IHNvbGlk ICM5OTknOwogIGlmcmFtZS5zY3JvbGxpbmcgPSAnbm8nOwogIGlmcmFtZS5mcmFtZUJvcmRlciA9 ICcwJzsKICBpZnJhbWUuYm9yZGVyID0gJzAnOwoJdmFyIGMgPSBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgnaWZyYW1lY29udGFpbmVyJyk7CgljLmFwcGVuZENoaWxkKGlmcmFtZSk7CglpZnJhbWUu c3R5bGUuaGVpZ2h0ID0gYy5vZmZzZXRIZWlnaHQrJ3B4JzsKCQoJdmFyIGQgPSBpZnJhbWUuY29u dGVudFdpbmRvdy5kb2N1bWVudDsKCWQub3BlbigpOwoJLyogUkVNT1ZFIGxpbmUtaGVpZ2h0OjFl bSBGUk9NIExJTkUgQkVMT1cgQU5EIERPV04gQVJST1cgV09SS1MgKi8KCWQud3JpdGUoJzwhRE9D VFlQRSBIVE1MIFBVQkxJQyAiLS8vVzNDLy9EVEQgSFRNTCA0LjAxLy9FTiIgImh0dHA6Ly93d3cu dzMub3JnL1RSL2h0bWw0L3N0cmljdC5kdGQiPjxodG1sPjxoZWFkPjxzdHlsZT5we2xpbmUtaGVp Z2h0OjFlbTt9PC9zdHlsZT48L2hlYWQ+PGJvZHk+Jyk7CglkLndyaXRlKCc8aDE+VGVzdCBkb3du IGFycm93PC9oMT4nKTsKCWQud3JpdGUoJzxwPlN1c3BlbmRpc3NlIHZpdGFlIGlwc3VtIGV1IHNl bSByaG9uY3VzIHBvcnRhLiBOdW5jIHB1cnVzIHBlZGUsIGxhb3JlZXQgYSwgcmhvbmN1cyB1dCwg dmVuZW5hdGlzIGEsIGZlbGlzLiBEb25lYyBub251bW15LiBQcmFlc2VudCB2aXRhZSBsYWN1cy4g QWxpcXVhbSBhdWN0b3IgZWdlc3RhcyBzZW0uIFByYWVzZW50IG5lYyBxdWFtLiBJbiB2aXZlcnJh IHJpc3VzIHNpdCBhbWV0IGxlY3R1cy4gQ3VtIHNvY2lpcyBuYXRvcXVlIHBlbmF0aWJ1cyBldCBt YWduaXMgZGlzIHBhcnR1cmllbnQgbW9udGVzLCBuYXNjZXR1ciByaWRpY3VsdXMgbXVzLiBWaXZh bXVzIGEgdHVycGlzIGFjIGlwc3VtIGVsZW1lbnR1bSBzY2VsZXJpc3F1ZS4gTnVsbGFtIHZpdmVy cmEgZW5pbSBldSBvcmNpLiBFdGlhbSBhbGlxdWFtIGNvbnNlcXVhdCB0b3J0b3IuIE5hbSBwZWxs ZW50ZXNxdWUgbm9udW1teSB0b3J0b3IuIER1aXMgdml2ZXJyYSwgbnVsbGEgcXVpcyBjb25kaW1l bnR1bSBtYXR0aXMsIHF1YW0gYW50ZSBub251bW15IHF1YW0sIHZpdGFlIGxvYm9ydGlzIHVybmEg ZGlhbSBxdWlzIG5lcXVlLiBQZWxsZW50ZXNxdWUgZXQgZHVpIGEgYXVndWUgYWxpcXVhbSBzZW1w ZXIuIFN1c3BlbmRpc3NlIHVsdHJpY2llcyBwZWRlIGEgcHVydXMuIERvbmVjIGxpYmVybyBsaWJl cm8sIGltcGVyZGlldCBzaXQgYW1ldCwgc29sbGljaXR1ZGluIGV1LCBtYXR0aXMgaWFjdWxpcywg bG9yZW0uPC9wPicpOwoJZC53cml0ZSgnPHA+U3VzcGVuZGlzc2Ugdml0YWUgaXBzdW0gZXUgc2Vt IHJob25jdXMgcG9ydGEuIE51bmMgcHVydXMgcGVkZSwgbGFvcmVldCBhLCByaG9uY3VzIHV0LCB2 ZW5lbmF0aXMgYSwgZmVsaXMuIERvbmVjIG5vbnVtbXkuIFByYWVzZW50IHZpdGFlIGxhY3VzLiBB bGlxdWFtIGF1Y3RvciBlZ2VzdGFzIHNlbS4gUHJhZXNlbnQgbmVjIHF1YW0uIEluIHZpdmVycmEg cmlzdXMgc2l0IGFtZXQgbGVjdHVzLiBDdW0gc29jaWlzIG5hdG9xdWUgcGVuYXRpYnVzIGV0IG1h Z25pcyBkaXMgcGFydHVyaWVudCBtb250ZXMsIG5hc2NldHVyIHJpZGljdWx1cyBtdXMuIFZpdmFt dXMgYSB0dXJwaXMgYWMgaXBzdW0gZWxlbWVudHVtIHNjZWxlcmlzcXVlLiBOdWxsYW0gdml2ZXJy YSBlbmltIGV1IG9yY2kuIEV0aWFtIGFsaXF1YW0gY29uc2VxdWF0IHRvcnRvci4gTmFtIHBlbGxl bnRlc3F1ZSBub251bW15IHRvcnRvci4gRHVpcyB2aXZlcnJhLCBudWxsYSBxdWlzIGNvbmRpbWVu dHVtIG1hdHRpcywgcXVhbSBhbnRlIG5vbnVtbXkgcXVhbSwgdml0YWUgbG9ib3J0aXMgdXJuYSBk aWFtIHF1aXMgbmVxdWUuIFBlbGxlbnRlc3F1ZSBldCBkdWkgYSBhdWd1ZSBhbGlxdWFtIHNlbXBl ci4gU3VzcGVuZGlzc2UgdWx0cmljaWVzIHBlZGUgYSBwdXJ1cy4gRG9uZWMgbGliZXJvIGxpYmVy bywgaW1wZXJkaWV0IHNpdCBhbWV0LCBzb2xsaWNpdHVkaW4gZXUsIG1hdHRpcyBpYWN1bGlzLCBs b3JlbS48L3A+Jyk7CglkLndyaXRlKCc8L2JvZHk+PC9odG1sPicpOwoJZC5jbG9zZSgpOwoJCglp ZnJhbWUuY29udGVudFdpbmRvdy5kb2N1bWVudC5ib2R5LmNvbnRlbnRFZGl0YWJsZSA9IHRydWU7 Cn0KCjwvc2NyaXB0Pgo8L2JvZHk+CjwvaHRtbD4K 15984 2007-08-15 12:31:07 -0700 2007-08-22 13:52:05 -0700 Change RenderText hit testing to prefer the lower of two overlapping lines 14972_r1.patch text/plain 4192 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTA5NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDctMDgtMTUgIE1pdHogUGV0dGVsICA8bWl0ekB3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4 IGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTcyCisgICAgICAgICAg TW92aW5nIGN1cnNvciBkb3duIGluIGNvbnRlbnRFZGl0YWJsZSBzZWN0aW9uIGZhaWxzIGlmIHN0 eWxlZCBsaW5lLWhlaWdodDoxZW0KKworICAgICAgICBUZXN0OiBlZGl0aW5nL3NlbGVjdGlvbi9t b3ZlLWJ5LWxpbmUtMDAzLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUZXh0LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRleHQ6OnBvc2l0aW9uRm9yQ29vcmRpbmF0ZXMp OiBDaGFuZ2VkIGhpdCB0ZXN0aW5nIHNvIHRoYXQgZWFjaAorICAgICAgICBsaW5lIGlzIHRlc3Rl ZCBmb3IgaGl0cyBiZXR3ZWVuIGl0cyBvdmVyZmxvdyB0b3AgYW5kIHRoZSBuZXh0IGxpbmUncyBv dmVyZmxvdyB0b3AuCisgICAgICAgIFRoaXMgbWF0Y2hlcyBSZW5kZXJCbG9jazo6cG9zaXRpb25G b3JDb29yZGluYXRlcy4KKwogMjAwNy0wOC0xNSAgRGF2aWQgSGFycmlzb24gIDxoYXJyaXNvbkBh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW50dGkgS29pdmlzdG8uCkluZGV4OiBX ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUZXh0LmNwcAkocmV2aXNpb24gMjUwOTApCisrKyBXZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJUZXh0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjY1LDcgKzI2NSw4IEBAIFZp c2libGVQb3NpdGlvbiBSZW5kZXJUZXh0Ojpwb3NpdGlvbkZvckMKICAgICBJbmxpbmVUZXh0Qm94 KiBsYXN0Qm94QWJvdmUgPSAwOwogICAgIGZvciAoSW5saW5lVGV4dEJveCogYm94ID0gZmlyc3RU ZXh0Qm94KCk7IGJveDsgYm94ID0gYm94LT5uZXh0VGV4dEJveCgpKSB7CiAgICAgICAgIGlmICh5 ID49IGJveC0+cm9vdCgpLT50b3BPdmVyZmxvdygpKSB7Ci0gICAgICAgICAgICBpZiAoeSA8IGJv eC0+cm9vdCgpLT5ib3R0b21PdmVyZmxvdygpKSB7CisgICAgICAgICAgICBpbnQgYm90dG9tID0g Ym94LT5yb290KCktPm5leHRSb290Qm94KCkgPyBib3gtPnJvb3QoKS0+bmV4dFJvb3RCb3goKS0+ dG9wT3ZlcmZsb3coKSA6IGJveC0+cm9vdCgpLT5ib3R0b21PdmVyZmxvdygpOworICAgICAgICAg ICAgaWYgKHkgPCBib3R0b20pIHsKICAgICAgICAgICAgICAgICBvZmZzZXQgPSBib3gtPm9mZnNl dEZvclBvc2l0aW9uKHgpOwogCiAgICAgICAgICAgICAgICAgaWYgKHggPT0gYm94LT5tX3gpCklu ZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNTA5NykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDA3LTA4LTE1ICBNaXR6IFBldHRlbCAgPG1pdHpA d2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAtIHRlc3QgZm9yIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0 OTcyCisgICAgICAgICAgTW92aW5nIGN1cnNvciBkb3duIGluIGNvbnRlbnRFZGl0YWJsZSBzZWN0 aW9uIGZhaWxzIGlmIHN0eWxlZCBsaW5lLWhlaWdodDoxZW0KKworICAgICAgICAqIGVkaXRpbmcv c2VsZWN0aW9uL21vdmUtYnktbGluZS0wMDMtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAg KiBlZGl0aW5nL3NlbGVjdGlvbi9tb3ZlLWJ5LWxpbmUtMDAzLmh0bWw6IEFkZGVkLgorCiAyMDA3 LTA4LTE0ICBLZXZpbiBNY0N1bGxvdWdoICA8a21jY3VsbG91Z2hAYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEFkYW0uCkluZGV4OiBMYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlv bi9tb3ZlLWJ5LWxpbmUtMDAzLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9lZGl0aW5nL3NlbGVjdGlvbi9tb3ZlLWJ5LWxpbmUtMDAzLWV4cGVjdGVkLnR4dAkocmV2aXNp b24gMCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL21vdmUtYnktbGluZS0wMDMt ZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDUgQEAKK1Rlc3QgZm9yIGh0dHA6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0OTcyIE1vdmluZyBjdXJzb3IgZG93 biBpbiBjb250ZW50RWRpdGFibGUgc2VjdGlvbiBmYWlscyBpZiBzdHlsZWQgbGluZS1oZWlnaHQ6 MWVtLgorCitQQVNTCisKK1ByZXNzaW5nIHRoZSBkb3duIGFycm93IHdoZW4gdGhlIGNhcmV0IGlz IG9uIHRoaXMgbGluZSBzaG91bGQgbW92ZSBpdCB0byB0aGlzIGxpbmUuIApJbmRleDogTGF5b3V0 VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vbW92ZS1ieS1saW5lLTAwMy5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL21vdmUtYnktbGluZS0wMDMuaHRtbAko cmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL21vdmUtYnktbGlu ZS0wMDMuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzMCBAQAorPGh0bWw+Cis8aGVhZD4K KyAgICA8c2NyaXB0IHNyYz0uLi9lZGl0aW5nLmpzIGxhbmd1YWdlPSJKYXZhU2NyaXB0IiB0eXBl PSJ0ZXh0L0phdmFTY3JpcHQiID48L3NjcmlwdD4KKyAgICA8c2NyaXB0PgorICAgICAgICBmdW5j dGlvbiB0ZXN0KCkKKyAgICAgICAgeworICAgICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0 Q29udHJvbGxlcikKKyAgICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNU ZXh0KCk7CisKKyAgICAgICAgICAgIHZhciB0YXJnZXQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgidGFyZ2V0Iik7CisgICAgICAgICAgICBnZXRTZWxlY3Rpb24oKS5zZXRCYXNlQW5kRXh0ZW50 KHRhcmdldC5maXJzdENoaWxkLCAwLCB0YXJnZXQuZnJzdENoaWxkLCAwKTsKKyAgICAgICAgICAg IG1vdmVTZWxlY3Rpb25Gb3J3YXJkQnlMaW5lQ29tbWFuZCgpOworCisgICAgICAgICAgICBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0IikuaW5uZXJUZXh0ID0gZ2V0U2VsZWN0aW9uKCku YmFzZU9mZnNldCA9PSA2MyA/ICJQQVNTIiA6ICJGQUlMIjsKKyAgICAgICAgfQorICAgIDwvc2Ny aXB0PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJ0ZXN0KCkiPgorICAgIDxwPgorICAgICAgICBU ZXN0IGZvciA8aT48YSBocmVmPSJodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNDk3MiI+aHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ5NzI8L2E+ CisgICAgICAgIE1vdmluZyBjdXJzb3IgZG93biBpbiBjb250ZW50RWRpdGFibGUgc2VjdGlvbiBm YWlscyBpZiBzdHlsZWQgbGluZS1oZWlnaHQ6MWVtPC9pPi4KKyAgICA8L3A+CisgICAgPHAgaWQ9 InJlc3VsdCI+CisgICAgICAgIFRlc3QgZGlkIG5vdCBydW4KKyAgICA8L3A+CisgICAgPHAgY29u dGVudGVkaXRhYmxlPSJ0cnVlIiBpZD0idGFyZ2V0IiBzdHlsZT0id2hpdGUtc3BhY2U6IHByZS1s aW5lOyBsaW5lLWhlaWdodDogMWVtOyI+UHJlc3NpbmcgdGhlIGRvd24gYXJyb3cgd2hlbiB0aGUg Y2FyZXQgaXMgb24gdGhpcyBsaW5lCisgICAgICAgIHNob3VsZCBtb3ZlIGl0IHRvIHRoaXMgbGlu ZS4KKyAgICA8L3A+Cis8L2JvZHk+Cis8L2h0bWw+Cg==