149715 2015-10-01 10:55:15 -0700 built-product-archive assumes 32-bit Windows build 2018-04-17 16:10:11 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build PC All RESOLVED DUPLICATE 184715 PlatformOnly P2 Normal --- 1 dbates webkit-unassigned achristensen bfulgham lforschler ross.kirsling oldest_to_newest 1129977 0 dbates 2015-10-01 10:55:15 -0700 In attempting to fix the Windows build breakage (*) following the patch for bug #149695, I noticed that built-product-archive hardcoded the assumption that we build 32-bit Windows. In particular, it looks for the built products to be in the subdirectory bin32 of the top-level WebKit build directory. We should make use of the configuration-specific build directory returned by the script webkit-build-directory (as we do for other ports) instead of hardcoding the path to the subdirectory bin32 for Windows. (*) Windows build fix committed in <http://trac.webkit.org/changeset/190411>. 1130020 1 bfulgham 2015-10-01 13:28:58 -0700 I think this is complicated by the fact that Windows creates 32-bit and 64-bit subdirectories, which other platforms don't do. Maybe I should add another flag to "webkit-build-directory" to return the active configuration (32-bit or 64-bit), or to return the full path to the binaries (perhaps only to be used under Windows)? 1415320 2 ross.kirsling 2018-04-17 16:10:11 -0700 *** This bug has been marked as a duplicate of bug 184715 ***