149711 2015-10-01 09:48:06 -0700 [Mac] Make run-api-tests work with System Integrity Protection 2016-11-12 00:05:37 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=164667 InRadar P2 Normal --- 1 ap ap andersca dbates lforschler mitz oldest_to_newest 1129949 0 ap 2015-10-01 09:48:06 -0700 We need to pass DYLD environment variables via arch explicitly, because it's a system binary, and gets these stripped. <rdar://problem/22928202> 1129955 1 262266 ap 2015-10-01 09:52:45 -0700 Created attachment 262266 proposed fix 1129961 2 262266 mitz 2015-10-01 10:05:17 -0700 Comment on attachment 262266 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=262266&action=review > Tools/Scripts/run-api-tests:357 > + push @arguments, "-e"; > + push @arguments, "$key=$ENV{$key}"; I am sure there are all sorts of fun ways to write this subroutine (filter and map a hash). This way seems fine, but can’t you push both elements in a single statement? push @arguments, "-e", "$key=$ENV{$key}"; 1129963 3 ap 2015-10-01 10:17:19 -0700 Committed <http://trac.webkit.org/r190412>. 262266 2015-10-01 09:52:45 -0700 2015-10-01 10:05:17 -0700 proposed fix SIP_api_tests.txt text/plain 2413 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5MDQxMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE1LTEwLTAxICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFtNYWNdIE1ha2UgcnVuLWFwaS10ZXN0cyB3b3JrIHdpdGggU3lzdGVtIElu dGVncml0eSBQcm90ZWN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNDk3MTEKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMjI5MjgyMDIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvcnVu LWFwaS10ZXN0czoKKyAgICAgICAgKHJ1blRlc3QpOgorICAgICAgICAoYXJjaENvbW1hbmRMaW5l QXJndW1lbnRzRm9yUmVzdHJpY3RlZEVudmlyb25tZW50VmFyaWFibGVzKToKKwogMjAxNS0xMC0w MSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtFRkxd IEZpeCB0aGUgb3BlbndlYnJ0YyBhbmQgZ3N0LXBsdWdpbnMtb3BlbndlYnJ0YyBidWlsZCB3aXRo IGNsYW5nCkluZGV4OiBUb29scy9TY3JpcHRzL3J1bi1hcGktdGVzdHMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g VG9vbHMvU2NyaXB0cy9ydW4tYXBpLXRlc3RzCShyZXZpc2lvbiAxOTAzMDkpCisrKyBUb29scy9T Y3JpcHRzL3J1bi1hcGktdGVzdHMJKHdvcmtpbmcgY29weSkKQEAgLTQwLDYgKzQwLDcgQEAgc3Vi IGxpc3RBbGxUZXN0cygpOwogc3ViIHJ1blRlc3QoJCQpOwogc3ViIHJ1blRlc3RzQnlTdWl0ZShc QCk7CiBzdWIgcHJlcGFyZUVudmlyb25tZW50Rm9yUnVubmluZ1Rlc3RUb29sKCk7CitzdWIgYXJj aENvbW1hbmRMaW5lQXJndW1lbnRzRm9yUmVzdHJpY3RlZEVudmlyb25tZW50VmFyaWFibGVzKCk7 CiBzdWIgdGVzdFRvb2xQYXRocygpOwogCiAjIERlZmluZWQgaW4gVkNTVXRpbHMuCkBAIC0xOTYs NyArMTk3LDcgQEAgc3ViIHJ1blRlc3QoJCQpCiAgICAgICAgIGlmIChpc0lPU1dlYktpdCgpKSB7 CiAgICAgICAgICAgICAkcGlkID0gb3BlbjMoJGNoaWxkSW4sICRjaGlsZE91dCwgJGNoaWxkRXJy LCBxdyh4Y3J1biAtc2RrIGlwaG9uZXNpbXVsYXRvciBzaW0gLS1lbnZpcm9ubWVudD1tZXJnZSks IEBjb21tb25Bcmd1bWVudHMpIG9yIGRpZSAiRmFpbGVkIHRvIHJ1biB0ZXN0OiAkdGVzdC4iOwog ICAgICAgICB9IGVsc2lmIChpc0FwcGxlTWFjV2ViS2l0KCkgJiYgYXJjaGl0ZWN0dXJlKCkpIHsK LSAgICAgICAgICAgICRwaWQgPSBvcGVuMygkY2hpbGRJbiwgJGNoaWxkT3V0LCAkY2hpbGRFcnIs ICJhcmNoIiwgIi0iIC4gYXJjaGl0ZWN0dXJlKCksIEBjb21tb25Bcmd1bWVudHMpIG9yIGRpZSAi RmFpbGVkIHRvIHJ1biB0ZXN0OiAkdGVzdC4iOworICAgICAgICAgICAgJHBpZCA9IG9wZW4zKCRj aGlsZEluLCAkY2hpbGRPdXQsICRjaGlsZEVyciwgImFyY2giLCAiLSIgLiBhcmNoaXRlY3R1cmUo KSwgYXJjaENvbW1hbmRMaW5lQXJndW1lbnRzRm9yUmVzdHJpY3RlZEVudmlyb25tZW50VmFyaWFi bGVzKCksIEBjb21tb25Bcmd1bWVudHMpIG9yIGRpZSAiRmFpbGVkIHRvIHJ1biB0ZXN0OiAkdGVz dC4iOwogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgJHBpZCA9IG9wZW4zKCRjaGlsZElu LCAkY2hpbGRPdXQsICRjaGlsZEVyciwgQGNvbW1vbkFyZ3VtZW50cykgb3IgZGllICJGYWlsZWQg dG8gcnVuIHRlc3Q6ICR0ZXN0LiI7CiAgICAgICAgIH0KQEAgLTM0Nyw2ICszNDgsMTggQEAgc3Vi IHByZXBhcmVFbnZpcm9ubWVudEZvclJ1bm5pbmdUZXN0VG9vbAogICAgIHNldHVwTWFjV2ViS2l0 RW52aXJvbm1lbnQocHJvZHVjdERpcigpKTsKIH0KIAorc3ViIGFyY2hDb21tYW5kTGluZUFyZ3Vt ZW50c0ZvclJlc3RyaWN0ZWRFbnZpcm9ubWVudFZhcmlhYmxlcygpCit7CisgICAgbXkgQGFyZ3Vt ZW50cyA9ICgpOworICAgIGZvcmVhY2ggbXkgJGtleSAoa2V5cyglRU5WKSkgeworICAgICAgICBp ZiAoJGtleSA9fiAvXkRZTERfLykgeworICAgICAgICAgICAgcHVzaCBAYXJndW1lbnRzLCAiLWUi OworICAgICAgICAgICAgcHVzaCBAYXJndW1lbnRzLCAiJGtleT0kRU5WeyRrZXl9IjsKKyAgICAg ICAgfQorICAgIH0KKyAgICByZXR1cm4gQGFyZ3VtZW50czsKK30KKwogc3ViIHRlc3RUb29sUGF0 aHMoKQogewogICAgIG15ICRwYXRoID0gRmlsZTo6U3BlYy0+Y2F0ZmlsZShwcm9kdWN0RGlyKCks ICJUZXN0V2ViS2l0QVBJIik7Cg==